134246 2014-06-24 03:09:41 -0700 REGRESSION(r170235): Remove incorrect ifdef guard 2014-06-24 10:48:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 133844 1 evab.u-szeged webkit-unassigned bunhere cdumez commit-queue enrica gyuyoung.kim ossy sergio oldest_to_newest 1017906 0 evab.u-szeged 2014-06-24 03:09:41 -0700 Removr unnecessary #if guard which remained in the code while removing PAGE_VISIBILITY_API compile guard. > Source/WebKit/mac/WebView/WebView.mm:4328 > #if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) > if (_private->page) > return kit(_private->page->visibilityState()); > #endif 1017907 1 233692 evab.u-szeged 2014-06-24 03:12:46 -0700 Created attachment 233692 Patch 1017909 2 ossy 2014-06-24 03:23:44 -0700 (In reply to comment #1) > Created an attachment (id=233692) [details] > Patch https://bugs.webkit.org/show_bug.cgi?id=133844#c4 > -#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) > +#if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) I agree, this guard is really unnecessary, "true || FOO" is always true. 1017910 3 233692 ossy 2014-06-24 03:24:15 -0700 Comment on attachment 233692 Patch LGTM, r=me. Thanks for the quick fix. 1017912 4 233692 commit-queue 2014-06-24 04:03:07 -0700 Comment on attachment 233692 Patch Clearing flags on attachment: 233692 Committed r170358: <http://trac.webkit.org/changeset/170358> 1017913 5 commit-queue 2014-06-24 04:03:13 -0700 All reviewed patches have been landed. Closing bug. 1017994 6 enrica 2014-06-24 10:21:27 -0700 This breaks the build for all the platforms that do not enable HIDDEN_PAGE_DOM_TIMER_THROTTLING. You removed the #ifdef but you left it around the kit function on line 521. 1017998 7 ossy 2014-06-24 10:35:57 -0700 (In reply to comment #6) > This breaks the build for all the platforms that do not enable HIDDEN_PAGE_DOM_TIMER_THROTTLING. > You removed the #ifdef but you left it around the kit function on line 521. In this case the original guarding was incorrect. This call was guarded with "#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)". But now there isn't PAGE_VISIBILITY_API guard, so we need this kit call unconditionally. Should we remove guards around kit function core? 1018006 8 ossy 2014-06-24 10:48:14 -0700 Thanks for the fix landed in https://trac.webkit.org/changeset/170372 . 233692 2014-06-24 03:12:46 -0700 2014-06-24 04:03:07 -0700 Patch bug-134246-20140624121224.patch text/plain 1232 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggMTBkZTNhMzZi YTA1ZTAwNGIxYzljNDg5OTYyZTY1YjkzZjRjMDcyMi4uNzMxNzk1N2NkNzIwZDBhMzAzOTg0YzA2 NzkzMjgzYjAxNjViZTM2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0 LTA2LTI0ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5j b20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTcwMjM1KTogUmVtb3ZlIGluY29ycmVjdCBpZmRl ZiBndWFyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM0MjQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgtW1dlYlZpZXcgX3Zpc2liaWxpdHlTdGF0 ZV0pOgorCiAyMDE0LTA2LTIzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ CiAKICAgICAgICAgRml4IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2Vi Vmlldy9XZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCmlu ZGV4IGNmN2MwMmY1ZTBmMjU2ZjZiYjA2YzM3NmFiN2FmNjYwNjFiN2M5OGUuLmQ2ZTMzYTYxY2Ix ZGQ5MGM0YjVlMTg1NDk0MDc5YjMyMjhhOTlkMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv bWFjL1dlYlZpZXcvV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dl YlZpZXcubW0KQEAgLTQzMjUsMTAgKzQzMjUsOCBAQCBzdGF0aWMgVmVjdG9yPFN0cmluZz4gdG9T dHJpbmdWZWN0b3IoTlNBcnJheSogcGF0dGVybnMpCiAKIC0gKFdlYlBhZ2VWaXNpYmlsaXR5U3Rh dGUpX3Zpc2liaWxpdHlTdGF0ZQogewotI2lmIEVOQUJMRShISURERU5fUEFHRV9ET01fVElNRVJf VEhST1RUTElORykKICAgICBpZiAoX3ByaXZhdGUtPnBhZ2UpCiAgICAgICAgIHJldHVybiBraXQo X3ByaXZhdGUtPnBhZ2UtPnZpc2liaWxpdHlTdGF0ZSgpKTsKLSNlbmRpZgogICAgIHJldHVybiBX ZWJQYWdlVmlzaWJpbGl0eVN0YXRlVmlzaWJsZTsKIH0KIAo=