<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>13424</bug_id>
          
          <creation_ts>2007-04-20 17:27:30 -0700</creation_ts>
          <short_desc>firstLineStyle and verticalPositionHint are too slow</short_desc>
          <delta_ts>2007-04-20 17:44:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>13351</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Dave Hyatt">hyatt</reporter>
          <assigned_to name="Dave Hyatt">hyatt</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>13679</commentid>
    <comment_count>0</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2007-04-20 17:27:30 -0700</bug_when>
    <thetext>These functions should do no work in the common case where a document has no first line style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13680</commentid>
    <comment_count>1</comment_count>
      <attachid>14117</attachid>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2007-04-20 17:35:55 -0700</bug_when>
    <thetext>Created attachment 14117
33% improvement on tag nesting PLT</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13681</commentid>
    <comment_count>2</comment_count>
      <attachid>14117</attachid>
    <who name="Beth Dakin">bdakin</who>
    <bug_when>2007-04-20 17:40:56 -0700</bug_when>
    <thetext>Comment on attachment 14117
33% improvement on tag nesting PLT

r=me!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13682</commentid>
    <comment_count>3</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2007-04-20 17:44:17 -0700</bug_when>
    <thetext>Fixed.
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>14117</attachid>
            <date>2007-04-20 17:35:55 -0700</date>
            <delta_ts>2007-04-20 17:40:56 -0700</delta_ts>
            <desc>33% improvement on tag nesting PLT</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>4558</size>
            <attacher name="Dave Hyatt">hyatt</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTc5
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDctMDQt
MjAgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIEJ1ZyAxMzQyNCwg
Zmlyc3RMaW5lU3R5bGUgYW5kIHZlcnRpY2FsUG9zaXRpb25IaW50IHRvZ2V0aGVyIHRha2UKKyAg
ICAgICAgMzMlIG9mIHRoZSB0aW1lIG9uIHRoZSBuZXcgdGFnIG5lc3RpbmcgUExULiAgRG9uJ3Qg
d2FzdGUgdGltZSBldmVuCisgICAgICAgIGxvb2tpbmcgZm9yIGZpcnN0LWxpbmUgc3R5bGVzIGlm
IG5vIHN0eWxlc2hlZXQgdXNlZCB0aGVtLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogY3NzL0NTU0dyYW1tYXIueToKKyAgICAgICAgKiBkb20vRG9j
dW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OkRvY3VtZW50KToKKyAgICAg
ICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp1c2VzRmly
c3RMaW5lUnVsZXMpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldFVzZXNGaXJzdExp
bmVSdWxlcyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnZlcnRpY2FsUG9zaXRpb25IaW50KToKKyAgICAgICAg
KFdlYkNvcmU6OlJlbmRlck9iamVjdDo6Zmlyc3RMaW5lU3R5bGUpOgorCiAyMDA3LTA0LTIwICBQ
ZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi
eSBPbGl2ZXIuCkluZGV4OiBjc3MvQ1NTR3JhbW1hci55Cj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNzcy9DU1NH
cmFtbWFyLnkJKHJldmlzaW9uIDIwOTQzKQorKysgY3NzL0NTU0dyYW1tYXIueQkod29ya2luZyBj
b3B5KQpAQCAtODUxLDYgKzg1MSwxMCBAQCBwc2V1ZG86CiAgICAgICAgICAgICBEb2N1bWVudCog
ZG9jID0gcC0+ZG9jdW1lbnQoKTsKICAgICAgICAgICAgIGlmIChkb2MpCiAgICAgICAgICAgICAg
ICAgZG9jLT5zZXRVc2VzU2libGluZ1J1bGVzKHRydWUpOworICAgICAgICB9IGVsc2UgaWYgKHR5
cGUgPT0gQ1NTU2VsZWN0b3I6OlBzZXVkb0ZpcnN0TGluZSkgeworICAgICAgICAgICAgQ1NTUGFy
c2VyKiBwID0gc3RhdGljX2Nhc3Q8Q1NTUGFyc2VyKj4ocGFyc2VyKTsKKyAgICAgICAgICAgIGlm
IChEb2N1bWVudCogZG9jID0gcC0+ZG9jdW1lbnQoKSkKKyAgICAgICAgICAgICAgICBkb2MtPnNl
dFVzZXNGaXJzdExpbmVSdWxlcyh0cnVlKTsKICAgICAgICAgfQogICAgIH0KICAgICB8ICc6JyAn
OicgSURFTlQgewpAQCAtODU4LDggKzg2MiwxNCBAQCBwc2V1ZG86CiAgICAgICAgICQkLT5tX21h
dGNoID0gQ1NTU2VsZWN0b3I6OlBzZXVkb0VsZW1lbnQ7CiAgICAgICAgICQzLmxvd2VyKCk7CiAg
ICAgICAgICQkLT5tX3ZhbHVlID0gYXRvbWljU3RyaW5nKCQzKTsKLSAgICAgICAgaWYgKCQkLT5w
c2V1ZG9UeXBlKCkgPT0gQ1NTU2VsZWN0b3I6OlBzZXVkb1Vua25vd24pCisgICAgICAgIENTU1Nl
bGVjdG9yOjpQc2V1ZG9UeXBlIHR5cGUgPSAkJC0+cHNldWRvVHlwZSgpOworICAgICAgICBpZiAo
dHlwZSA9PSBDU1NTZWxlY3Rvcjo6UHNldWRvVW5rbm93bikKICAgICAgICAgICAgICQkID0gMDsK
KyAgICAgICAgZWxzZSBpZiAodHlwZSA9PSBDU1NTZWxlY3Rvcjo6UHNldWRvRmlyc3RMaW5lKSB7
CisgICAgICAgICAgICBDU1NQYXJzZXIqIHAgPSBzdGF0aWNfY2FzdDxDU1NQYXJzZXIqPihwYXJz
ZXIpOworICAgICAgICAgICAgaWYgKERvY3VtZW50KiBkb2MgPSBwLT5kb2N1bWVudCgpKQorICAg
ICAgICAgICAgICAgIGRvYy0+c2V0VXNlc0ZpcnN0TGluZVJ1bGVzKHRydWUpOworICAgICAgICB9
CiAgICAgfQogICAgIC8vIHVzZWQgYnkgOmxhbmcKICAgICB8ICc6JyBGVU5DVElPTiBJREVOVCAn
KScgewpJbmRleDogZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBkb20vRG9jdW1lbnQu
Y3BwCShyZXZpc2lvbiAyMDk0MykKKysrIGRvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkK
QEAgLTMyNSw2ICszMjUsNyBAQCBEb2N1bWVudDo6RG9jdW1lbnQoRE9NSW1wbGVtZW50YXRpb24q
IGltCiAgICAgbV9jbG9zZUFmdGVyU3R5bGVSZWNhbGMgPSBmYWxzZTsKICAgICBtX3VzZXNEZXNj
ZW5kYW50UnVsZXMgPSBmYWxzZTsKICAgICBtX3VzZXNTaWJsaW5nUnVsZXMgPSBmYWxzZTsKKyAg
ICBtX3VzZXNGaXJzdExpbmVSdWxlcyA9IGZhbHNlOwogCiAgICAgbV9zdHlsZVNlbGVjdG9yID0g
bmV3IENTU1N0eWxlU2VsZWN0b3IodGhpcywgbV91c2Vyc2hlZXQsIG1fc3R5bGVTaGVldHMuZ2V0
KCksICFpbkNvbXBhdE1vZGUoKSk7CiAgICAgbV9wZW5kaW5nU3R5bGVzaGVldHMgPSAwOwpJbmRl
eDogZG9tL0RvY3VtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZG9tL0RvY3VtZW50LmgJKHJldmlzaW9u
IDIwOTQzKQorKysgZG9tL0RvY3VtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTI4MCw2ICsyODAs
OCBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRVc2VzRGVzY2VuZGFudFJ1bGVzKGJvb2wgYikgeyBt
X3VzZXNEZXNjZW5kYW50UnVsZXMgPSBiOyB9CiAgICAgYm9vbCB1c2VzU2libGluZ1J1bGVzKCkg
Y29uc3QgeyByZXR1cm4gbV91c2VzU2libGluZ1J1bGVzOyB9CiAgICAgdm9pZCBzZXRVc2VzU2li
bGluZ1J1bGVzKGJvb2wgYikgeyBtX3VzZXNTaWJsaW5nUnVsZXMgPSBiOyB9CisgICAgYm9vbCB1
c2VzRmlyc3RMaW5lUnVsZXMoKSBjb25zdCB7IHJldHVybiBtX3VzZXNGaXJzdExpbmVSdWxlczsg
fQorICAgIHZvaWQgc2V0VXNlc0ZpcnN0TGluZVJ1bGVzKGJvb2wgYikgeyBtX3VzZXNGaXJzdExp
bmVSdWxlcyA9IGI7IH0KIAogICAgIC8vIE1hY2hpbmVyeSBmb3Igc2F2aW5nIGFuZCByZXN0b3Jp
bmcgc3RhdGUgd2hlbiB5b3UgbGVhdmUgYW5kIHRoZW4gZ28gYmFjayB0byBhIHBhZ2UuCiAgICAg
dm9pZCByZWdpc3RlckZvcm1FbGVtZW50V2l0aFN0YXRlKEhUTUxHZW5lcmljRm9ybUVsZW1lbnQq
IGUpIHsgbV9mb3JtRWxlbWVudHNXaXRoU3RhdGUuYWRkKGUpOyB9CkBAIC03MDMsNyArNzA1LDgg
QEAgcHJvdGVjdGVkOgogICAgIGJvb2wgbV9jbG9zZUFmdGVyU3R5bGVSZWNhbGM7CiAgICAgYm9v
bCBtX3VzZXNEZXNjZW5kYW50UnVsZXM7CiAgICAgYm9vbCBtX3VzZXNTaWJsaW5nUnVsZXM7Ci0g
ICAgCisgICAgYm9vbCBtX3VzZXNGaXJzdExpbmVSdWxlczsKKwogICAgIFN0cmluZyBtX3RpdGxl
OwogICAgIGJvb2wgbV90aXRsZVNldEV4cGxpY2l0bHk7CiAgICAgUmVmUHRyPEVsZW1lbnQ+IG1f
dGl0bGVFbGVtZW50OwpJbmRleDogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDIwOTQzKQorKysgcmVu
ZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2MTMsNiArMjYxMyw4
IEBAIGJvb2wgUmVuZGVyT2JqZWN0Ojpub2RlQXRQb2ludChjb25zdCBIaXQKIAogc2hvcnQgUmVu
ZGVyT2JqZWN0Ojp2ZXJ0aWNhbFBvc2l0aW9uSGludChib29sIGZpcnN0TGluZSkgY29uc3QKIHsK
KyAgICBpZiAoZmlyc3RMaW5lKSAvLyBXZSdyZSBvbmx5IHJlYWxseSBhIGZpcnN0LWxpbmUgc3R5
bGUgaWYgdGhlIGRvY3VtZW50IGFjdHVhbGx5IHVzZXMgZmlyc3QtbGluZSBydWxlcy4KKyAgICAg
ICAgZmlyc3RMaW5lID0gZG9jdW1lbnQoKS0+dXNlc0ZpcnN0TGluZVJ1bGVzKCk7CiAgICAgc2hv
cnQgdnBvcyA9IG1fdmVydGljYWxQb3NpdGlvbjsKICAgICBpZiAobV92ZXJ0aWNhbFBvc2l0aW9u
ID09IFBvc2l0aW9uVW5kZWZpbmVkIHx8IGZpcnN0TGluZSkgewogICAgICAgICB2cG9zID0gZ2V0
VmVydGljYWxQb3NpdGlvbihmaXJzdExpbmUpOwpAQCAtMjc3Nyw2ICsyNzc5LDkgQEAgdm9pZCBS
ZW5kZXJPYmplY3Q6OmRlbGV0ZUxpbmVCb3hXcmFwcGVyKAogCiBSZW5kZXJTdHlsZSogUmVuZGVy
T2JqZWN0OjpmaXJzdExpbmVTdHlsZSgpIGNvbnN0CiB7CisgICAgaWYgKCFkb2N1bWVudCgpLT51
c2VzRmlyc3RMaW5lUnVsZXMoKSkKKyAgICAgICAgcmV0dXJuIG1fc3R5bGU7CisKICAgICBSZW5k
ZXJTdHlsZSogcyA9IG1fc3R5bGU7CiAgICAgY29uc3QgUmVuZGVyT2JqZWN0KiBvYmogPSBpc1Rl
eHQoKSA/IHBhcmVudCgpIDogdGhpczsKICAgICBpZiAob2JqLT5pc0Jsb2NrRmxvdygpKSB7Cg==
</data>
<flag name="review"
          id="5715"
          type_id="1"
          status="+"
          setter="bdakin"
    />
          </attachment>
      

    </bug>

</bugzilla>