134228 2014-06-23 17:03:45 -0700 Implement WebPageProxy::windowAndViewFramesChanged 2014-06-23 18:39:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED INVALID P2 Normal --- 1 mhock mhock benjamin bfulgham ian thorton oldest_to_newest 1017769 0 mhock 2014-06-23 17:03:45 -0700 Implement WebPageProxy::windowAndViewFramesChanged. 1017773 1 233656 mhock 2014-06-23 17:12:50 -0700 Created attachment 233656 patch 1017779 2 233656 thorton 2014-06-23 17:23:55 -0700 Comment on attachment 233656 patch View in context: https://bugs.webkit.org/attachment.cgi?id=233656&action=review > Source/WebKit2/UIProcess/ios/WKContentView.mm:260 > + [self.window addObserver:self forKeyPath:@"frame" options:NSKeyValueObservingOptionNew | NSKeyValueObservingOptionInitial context:nullptr]; I don't think this works, did you test this? 1017781 3 233656 benjamin 2014-06-23 17:27:14 -0700 Comment on attachment 233656 patch lgtm. What was the initial size bug? 1017782 4 233656 benjamin 2014-06-23 17:28:29 -0700 Comment on attachment 233656 patch View in context: https://bugs.webkit.org/attachment.cgi?id=233656&action=review > Source/WebKit2/UIProcess/ios/WKContentView.mm:253 > + // All observations are for bounds changes. > + _page->windowAndViewFramesChanged(self.window.bounds, self.window.bounds.origin); It would be best to assert the keyPath. You may want to call self.window.bounds only once since obj-c dispatch is not cheap. 1017785 5 ian 2014-06-23 17:32:02 -0700 Why do web pages care about the window frame? Could we give them the WKWebView size instead? 1017791 6 benjamin 2014-06-23 17:57:03 -0700 (In reply to comment #5) > Why do web pages care about the window frame? Could we give them the WKWebView size instead? There is no clear specification of what window.outerWidth/height should be on mobile. This matches the usage. One of the problem with reporting WKWebView's size is that some people use outerWidth/height to detect the screen orientation. 233656 2014-06-23 17:12:50 -0700 2014-06-23 17:28:29 -0700 patch windowchanged.01.diff text/plain 3774 mhock ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhNmRhYjY5Li4wMTExYTk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDYtMjMgIE1hcnRpbiBIb2NrICA8bWhvY2tAYXBwbGUuY29tPgorCisgICAgICAg IFtpT1NdIEltcGxlbWVudCBXZWJQYWdlUHJveHk6OndpbmRvd0FuZFZpZXdGcmFtZXNDaGFuZ2Vk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MjI4 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzA2MDE4Mz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll dy5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyB3aWxsTW92ZVRvV2luZG93Ol0pOgorICAg ICAgICAoLVtXS0NvbnRlbnRWaWV3IG9ic2VydmVWYWx1ZUZvcktleVBhdGg6b2ZPYmplY3Q6Y2hh bmdlOmNvbnRleHQ6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgZGlkTW92ZVRvV2luZG93 XSk6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW06CisgICAgICAg IChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6d2luZG93QW5kVmlld0ZyYW1lc0NoYW5nZWQpOgorCiAy MDE0LTA2LTIzICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAog ICAgICAgICBbV0syXSBVc2UgdGhlIHBhZ2UgYmFja2dyb3VuZCBjb2xvciBpbnN0ZWFkIG9mIHdo aXRlIHdoZW4gc3dpcGUgc25hcHNob3RzIHdlcmUgcHVyZ2VkICgxMzQyMTgpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0gYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0KaW5kZXggY2RlYzQ1Yy4uM2Ew Y2FlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5t bQpAQCAtMjM5LDE3ICsyMzksMjYgQEAgcHJpdmF0ZToKICAgICBOU05vdGlmaWNhdGlvbkNlbnRl ciAqZGVmYXVsdENlbnRlciA9IFtOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXTsK ICAgICBVSVdpbmRvdyAqd2luZG93ID0gc2VsZi53aW5kb3c7CiAKLSAgICBpZiAod2luZG93KQor ICAgIGlmICh3aW5kb3cpIHsKICAgICAgICAgW2RlZmF1bHRDZW50ZXIgcmVtb3ZlT2JzZXJ2ZXI6 c2VsZiBuYW1lOlVJV2luZG93RGlkTW92ZVRvU2NyZWVuTm90aWZpY2F0aW9uIG9iamVjdDp3aW5k b3ddOwotCisgICAgICAgIFt3aW5kb3cgcmVtb3ZlT2JzZXJ2ZXI6c2VsZiBmb3JLZXlQYXRoOkAi ZnJhbWUiXTsKKyAgICB9CiAgICAgaWYgKG5ld1dpbmRvdykKICAgICAgICAgW2RlZmF1bHRDZW50 ZXIgYWRkT2JzZXJ2ZXI6c2VsZiBzZWxlY3RvcjpAc2VsZWN0b3IoX3dpbmRvd0RpZE1vdmVUb1Nj cmVlbk5vdGlmaWNhdGlvbjopIG5hbWU6VUlXaW5kb3dEaWRNb3ZlVG9TY3JlZW5Ob3RpZmljYXRp b24gb2JqZWN0Om5ld1dpbmRvd107CiB9CiAKKy0gKHZvaWQpb2JzZXJ2ZVZhbHVlRm9yS2V5UGF0 aDooTlNTdHJpbmcgKilrZXlQYXRoIG9mT2JqZWN0OihpZClvYmplY3QgY2hhbmdlOihOU0RpY3Rp b25hcnkgKiljaGFuZ2UgY29udGV4dDoodm9pZCAqKWNvbnRleHQKK3sKKyAgICAvLyBBbGwgb2Jz ZXJ2YXRpb25zIGFyZSBmb3IgYm91bmRzIGNoYW5nZXMuCisgICAgX3BhZ2UtPndpbmRvd0FuZFZp ZXdGcmFtZXNDaGFuZ2VkKHNlbGYud2luZG93LmJvdW5kcywgc2VsZi53aW5kb3cuYm91bmRzLm9y aWdpbik7Cit9CisKIC0gKHZvaWQpZGlkTW92ZVRvV2luZG93CiB7Ci0gICAgaWYgKHNlbGYud2lu ZG93KQorICAgIGlmIChzZWxmLndpbmRvdykgewogICAgICAgICBbc2VsZiBfdXBkYXRlRm9yU2Ny ZWVuOnNlbGYud2luZG93LnNjcmVlbl07CisgICAgICAgIFtzZWxmLndpbmRvdyBhZGRPYnNlcnZl cjpzZWxmIGZvcktleVBhdGg6QCJmcmFtZSIgb3B0aW9uczpOU0tleVZhbHVlT2JzZXJ2aW5nT3B0 aW9uTmV3IHwgTlNLZXlWYWx1ZU9ic2VydmluZ09wdGlvbkluaXRpYWwgY29udGV4dDpudWxscHRy XTsKKyAgICB9CiAgICAgX3BhZ2UtPnZpZXdTdGF0ZURpZENoYW5nZShWaWV3U3RhdGU6OkFsbEZs YWdzKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJQ YWdlUHJveHlJT1MubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94 eUlPUy5tbQppbmRleCAxOTFlYjMxLi5jOGYzNzhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5tbQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBD b3B5cmlnaHQgKEMpIDIwMTIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29w eXJpZ2h0IChDKSAyMDEyLCAyMDE0IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAq CiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3 aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0 aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMTAzLDkgKzEwMywxNiBAQCB2b2lkIFdl YlBhZ2VQcm94eTo6c2VhcmNoVGhlV2ViKGNvbnN0IFN0cmluZyYpCiAgICAgbm90SW1wbGVtZW50 ZWQoKTsKIH0KIAotdm9pZCBXZWJQYWdlUHJveHk6OndpbmRvd0FuZFZpZXdGcmFtZXNDaGFuZ2Vk KGNvbnN0IEZsb2F0UmVjdCYsIGNvbnN0IEZsb2F0UG9pbnQmKQordm9pZCBXZWJQYWdlUHJveHk6 OndpbmRvd0FuZFZpZXdGcmFtZXNDaGFuZ2VkKGNvbnN0IEZsb2F0UmVjdCYgdmlld0ZyYW1lSW5X aW5kb3dDb29yZGluYXRlcywgY29uc3QgRmxvYXRQb2ludCYgYWNjZXNzaWJpbGl0eVZpZXdDb29y ZGluYXRlcykKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlmICghaXNWYWxpZCgpKQor ICAgICAgICByZXR1cm47CisKKyAgICAvLyBJbiBjYXNlIHRoZSBVSSBjbGllbnQgb3ZlcnJpZGVz IGdldFdpbmRvd0ZyYW1lKCksIHdlIGNhbGwgaXQgaGVyZSB0byBtYWtlIHN1cmUgd2Ugc2VuZCB0 aGUgYXBwcm9wcmlhdGUgd2luZG93IGZyYW1lLgorICAgIEZsb2F0UmVjdCB3aW5kb3dGcmFtZUlu U2NyZWVuQ29vcmRpbmF0ZXMgPSBtX3VpQ2xpZW50LT53aW5kb3dGcmFtZSh0aGlzKTsKKyAgICBG bG9hdFJlY3Qgd2luZG93RnJhbWVJblVuZmxpcHBlZFNjcmVlbkNvb3JkaW5hdGVzID0gd2luZG93 RnJhbWVJblNjcmVlbkNvb3JkaW5hdGVzOworCisgICAgcHJvY2VzcygpLnNlbmQoTWVzc2FnZXM6 OldlYlBhZ2U6OldpbmRvd0FuZFZpZXdGcmFtZXNDaGFuZ2VkKHdpbmRvd0ZyYW1lSW5TY3JlZW5D b29yZGluYXRlcywgd2luZG93RnJhbWVJblVuZmxpcHBlZFNjcmVlbkNvb3JkaW5hdGVzLCB2aWV3 RnJhbWVJbldpbmRvd0Nvb3JkaW5hdGVzLCBhY2Nlc3NpYmlsaXR5Vmlld0Nvb3JkaW5hdGVzKSwg bV9wYWdlSUQpOwogfQogCiBTdHJpbmcgV2ViUGFnZVByb3h5OjpzdHJpbmdTZWxlY3Rpb25Gb3JQ YXN0ZWJvYXJkKCkK