134219 2014-06-23 15:52:15 -0700 [iOS][WK2] REGRESSION (r169324): Page jumps to top when you type into a text field 2014-06-23 21:13:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 dbates dbates benjamin enrica simon.fraser oldest_to_newest 1017724 0 dbates 2014-06-23 15:52:15 -0700 Following the patch for bug #133262, typing into a text field may cause a noticeable jump to the top of the page when the height of the content is equal to the heigh of the visual rectangle. 1017725 1 dbates 2014-06-23 15:52:43 -0700 <rdar://problem/17279113> 1017735 2 233645 dbates 2014-06-23 16:01:11 -0700 Created attachment 233645 Patch I'm not an expert in our scrolling logic. I'm open to suggestions. 1017738 3 dbates 2014-06-23 16:09:15 -0700 For completeness, you can observe this regression in a ToT iOS WebKit build as follows: 1. Visit <http://www.twitter.com> and click Sign in. 2. Tap on the Username field to focus it. 3. Tap the > arrow above the keyboard to move the focus to the Password field. 4. Type an arbitrary character, say 'a', into the Password field. Notice that the scroll view noticeably jumps to the top of the page. Compare this to the behavior in iOS 7.1.1 (11D201). 1017759 4 233645 benjamin 2014-06-23 16:36:32 -0700 Comment on attachment 233645 Patch That makes sense, the VisibleContentRect updates definitely drives the scroll position. 1017831 5 233645 dbates 2014-06-23 21:13:24 -0700 Comment on attachment 233645 Patch Clearing flags on attachment: 233645 Committed r170344: <http://trac.webkit.org/changeset/170344> 1017832 6 dbates 2014-06-23 21:13:29 -0700 All reviewed patches have been landed. Closing bug. 233645 2014-06-23 16:01:11 -0700 2014-06-23 21:13:24 -0700 Patch Bug134219.patch text/plain 3627 dbates RnJvbSAyZjQ4YzQxNWU1YTkzMTU1YmQ4YTMwMDEyMTI5YTRkNDU4ZjJlN2NjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pZWwgQmF0ZXMgPGRiYXRlc0B3ZWJraXQub3JnPgpEYXRl OiBNb24sIDIzIEp1biAyMDE0IDE1OjU3OjU5IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gW2lPU11b V0syXSBSRUdSRVNTSU9OIChyMTY5MzI0KTogUGFnZSBqdW1wcyB0byB0b3Agd2hlbiB5b3UKIHR5 cGUgaW50byBhIHRleHQgZmllbGQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNDIxOQogPHJkYXI6Ly9wcm9ibGVtLzE3Mjc5MTEzPgoKUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCgpGaXhlcyBhbiBpc3N1ZSB3aGVyZSB0eXBpbmcgaW50byBhIHRleHQgZmllbGQg bWF5IGNhdXNlIGEgbm90aWNlYWJsZSBqdW1wIHRvIHRoZSB0b3Agb2YKdGhlIHBhZ2UuCgpDdXJy ZW50bHkgd2hlbiB1cGRhdGluZyB0aGUgdmlzdWFsIGNvbnRlbnQgcmVjdGFuZ2xlcyB3ZSBhbHdh eXMgY29uc3RyYWluIHRoZSBzY3JvbGwgb2Zmc2V0CihzX3gsIHNfeSkgc3VjaCB0aGF0IDAgPD0g c194IDw9ICJjb250ZW50IHdpZHRoIiAtICJ2aXNpYmxlIHdpZHRoIiBhbmQgMCA8PSBzX3kgPD0g ImNvbnRlbnQgaGVpZ2h0IiAtICJ2aXNpYmxlIGhlaWdodCIuCkhvd2V2ZXIgdGhlIFVJUHJvY2Vz cyBtYXkgd2FudCB0byBzY3JvbGwgdGhlIHBhZ2UgYnkgYW4gb2Zmc2V0IG91dHNpZGUgb2YgdGhp cyByYW5nZSB0bwpjcmVhdGUgYSB2aXN1YWxseSBwbGVhc2luZyByZXN1bHQuIEluIHBhcnRpY3Vs YXIsIG9uIGlPUyB3ZSBtYXkgc2Nyb2xsIHRoZSBwYWdlIHNsaWdodGx5Cm91dHNpZGUgb2YgdGhp cyByYW5nZSAoZS5nLiBzX3kgPiAwID0gImNvbnRlbnQgaGVpZ2h0IiAtICJ2aXNpYmxlIGhlaWdo dCIpIHdoZW4gYSBmb3JtCmNvbnRyb2wgaXMgZm9jdXNlZCBzbyBhcyB0byBiZSBjb25zaXN0ZW50 IHdpdGggcGxhdGZvcm0gY29udmVudGlvbi4KCiogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQ YWdlSU9TLm1tOgooV2ViS2l0OjpXZWJQYWdlOjp1cGRhdGVWaXNpYmxlQ29udGVudFJlY3RzKTog VGVtcG9yYXJpbHkgZGlzYWJsZSBjb250ZW50IGVkZ2UgY29uc3RyYWludCB3aGVuCnVwZGF0aW5n IHNjcm9sbCBvZmZzZXQuCi0tLQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAyMiArKysrKysrKysrKysrKysrKysrKysrCiAuLi4vV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gICB8ICAyICsrCiAyIGZpbGVzIGNo YW5nZWQsIDI0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmQ0MTM2Ny4uYzFiNjQ1OCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTA2LTIzICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXVtXSzJdIFJFR1JFU1NJT04gKHIxNjkz MjQpOiBQYWdlIGp1bXBzIHRvIHRvcCB3aGVuIHlvdSB0eXBlIGludG8gYSB0ZXh0IGZpZWxkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQyMTkKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3Mjc5MTEzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIGFuIGlzc3VlIHdoZXJlIHR5cGluZyBpbnRv IGEgdGV4dCBmaWVsZCBtYXkgY2F1c2UgYSBub3RpY2VhYmxlIGp1bXAgdG8gdGhlIHRvcCBvZgor ICAgICAgICB0aGUgcGFnZS4KKworICAgICAgICBDdXJyZW50bHkgd2hlbiB1cGRhdGluZyB0aGUg dmlzdWFsIGNvbnRlbnQgcmVjdGFuZ2xlcyB3ZSBhbHdheXMgY29uc3RyYWluIHRoZSBzY3JvbGwg b2Zmc2V0CisgICAgICAgIChzX3gsIHNfeSkgc3VjaCB0aGF0IDAgPD0gc194IDw9ICJjb250ZW50 IHdpZHRoIiAtICJ2aXNpYmxlIHdpZHRoIiBhbmQgMCA8PSBzX3kgPD0gImNvbnRlbnQgaGVpZ2h0 IiAtICJ2aXNpYmxlIGhlaWdodCIuCisgICAgICAgIEhvd2V2ZXIgdGhlIFVJUHJvY2VzcyBtYXkg d2FudCB0byBzY3JvbGwgdGhlIHBhZ2UgYnkgYW4gb2Zmc2V0IG91dHNpZGUgb2YgdGhpcyByYW5n ZSB0bworICAgICAgICBjcmVhdGUgYSB2aXN1YWxseSBwbGVhc2luZyByZXN1bHQuIEluIHBhcnRp Y3VsYXIsIG9uIGlPUyB3ZSBtYXkgc2Nyb2xsIHRoZSBwYWdlIHNsaWdodGx5CisgICAgICAgIG91 dHNpZGUgb2YgdGhpcyByYW5nZSAoZS5nLiBzX3kgPiAwID0gImNvbnRlbnQgaGVpZ2h0IiAtICJ2 aXNpYmxlIGhlaWdodCIpIHdoZW4gYSBmb3JtCisgICAgICAgIGNvbnRyb2wgaXMgZm9jdXNlZCBz byBhcyB0byBiZSBjb25zaXN0ZW50IHdpdGggcGxhdGZvcm0gY29udmVudGlvbi4KKworICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZTo6dXBkYXRlVmlzaWJsZUNvbnRlbnRSZWN0cyk6IFRlbXBvcmFyaWx5IGRpc2Fi bGUgY29udGVudCBlZGdlIGNvbnN0cmFpbnQgd2hlbgorICAgICAgICB1cGRhdGluZyBzY3JvbGwg b2Zmc2V0LgorCiAyMDE0LTA2LTE3ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBTa2lwIGZhaWxpbmcgRUZMIEFQSSB0ZXN0cwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdl SU9TLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9T Lm1tCmluZGV4IDdlMjIyZjEuLjZjYmJhYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTIzNTksNyArMjM1OSw5IEBA IHZvaWQgV2ViUGFnZTo6dXBkYXRlVmlzaWJsZUNvbnRlbnRSZWN0cyhjb25zdCBWaXNpYmxlQ29u dGVudFJlY3RVcGRhdGVJbmZvJiB2aXNpCiAgICAgaWYgKCF2aXNpYmxlQ29udGVudFJlY3RVcGRh dGVJbmZvLmlzQ2hhbmdpbmdPYnNjdXJlZEluc2V0c0ludGVyYWN0aXZlbHkoKSkKICAgICAgICAg ZnJhbWVWaWV3LnNldEN1c3RvbVNpemVGb3JSZXNpemVFdmVudChleHBhbmRlZEludFNpemUodmlz aWJsZUNvbnRlbnRSZWN0VXBkYXRlSW5mby51bm9ic2N1cmVkUmVjdEluU2Nyb2xsVmlld0Nvb3Jk aW5hdGVzKCkuc2l6ZSgpKSk7CiAKKyAgICBmcmFtZVZpZXcuc2V0Q29uc3RyYWluc1Njcm9sbGlu Z1RvQ29udGVudEVkZ2UoZmFsc2UpOwogICAgIGZyYW1lVmlldy5zZXRTY3JvbGxPZmZzZXQoc2Ny b2xsUG9zaXRpb24pOworICAgIGZyYW1lVmlldy5zZXRDb25zdHJhaW5zU2Nyb2xsaW5nVG9Db250 ZW50RWRnZSh0cnVlKTsKIH0KIAogdm9pZCBXZWJQYWdlOjp3aWxsU3RhcnRVc2VyVHJpZ2dlcmVk Wm9vbWluZygpCi0tIAoxLjkuMyAoQXBwbGUgR2l0LTUwKQoK