134215 2014-06-23 14:38:16 -0700 Policy delegate methods should use CompletionHandlerCallChecker 2014-06-23 14:40:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1017696 0 andersca 2014-06-23 14:38:16 -0700 Policy delegate methods should use CompletionHandlerCallChecker 1017698 1 233637 andersca 2014-06-23 14:38:57 -0700 Created attachment 233637 Patch 1017699 2 commit-queue 2014-06-23 14:40:23 -0700 Attachment 233637 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:309: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:371: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1017700 3 andersca 2014-06-23 14:40:30 -0700 Committed r170322: <http://trac.webkit.org/changeset/170322> 233637 2014-06-23 14:38:57 -0700 2014-06-23 14:39:58 -0700 Patch bug-134215-20140623143836.patch text/plain 3138 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzM1NTk3YzAwYTU0NGE5 ZWZmNWE3NjQ0NWU1NTdkMTNjYzZiYWNjZi4uMTI5Yjg2NzE5NzYwMTkwNzk0MGExYjg5MzBmMDA1 NDZhZDI1MDM3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE0LTA2LTIzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUG9saWN5IGRlbGVn YXRlIG1ldGhvZHMgc2hvdWxkIHVzZSBDb21wbGV0aW9uSGFuZGxlckNhbGxDaGVja2VyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQyMTUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9D b2NvYS9OYXZpZ2F0aW9uU3RhdGUubW06CisgICAgICAgIChXZWJLaXQ6Ok5hdmlnYXRpb25TdGF0 ZTo6UG9saWN5Q2xpZW50OjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKToKKyAgICAg ICAgKFdlYktpdDo6TmF2aWdhdGlvblN0YXRlOjpQb2xpY3lDbGllbnQ6OmRlY2lkZVBvbGljeUZv clJlc3BvbnNlKToKKworMjAxNC0wNi0yMyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgorCiAgICAgICAgIERvbid0IHVzZSB0aGUgV0sgcHJlZml4IGZvciBpbnRlcm5hbCBD KysgdHlwZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNDIxNAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2 aWdhdGlvblN0YXRlLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRp b25TdGF0ZS5tbQppbmRleCA5ZjJmMjUxZTYzYjVlMDQzODM0ZDFhOThhMDk3NWZjMjUwYzZmYzU0 Li5hYTRlNDU2ZWZlOTNkZDIyYTNmOGEzYjA3ZGVkMzkzZmMyODlkZmYyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0KQEAgLTMwNSw3 ICszMDUsMTAgQEAgdm9pZCBOYXZpZ2F0aW9uU3RhdGU6OlBvbGljeUNsaWVudDo6ZGVjaWRlUG9s aWN5Rm9yTmF2aWdhdGlvbkFjdGlvbihXZWJQYWdlUHJveHkKICAgICBbbmF2aWdhdGlvbkFjdGlv biBzZXRSZXF1ZXN0OnJlcXVlc3QubnNVUkxSZXF1ZXN0KFdlYkNvcmU6OkRvTm90VXBkYXRlSFRU UEJvZHkpXTsKICAgICBbbmF2aWdhdGlvbkFjdGlvbiBfc2V0T3JpZ2luYWxVUkw6b3JpZ2luYWxS ZXF1ZXN0LnVybCgpXTsKIAotICAgIFtuYXZpZ2F0aW9uRGVsZWdhdGUgd2ViVmlldzptX25hdmln YXRpb25TdGF0ZS5tX3dlYlZpZXcgZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbjpuYXZp Z2F0aW9uQWN0aW9uLmdldCgpIGRlY2lzaW9uSGFuZGxlcjpbbGlzdGVuZXJdKFdLTmF2aWdhdGlv bkFjdGlvblBvbGljeSBhY3Rpb25Qb2xpY3kpIHsKKyAgICBSZWZQdHI8Q29tcGxldGlvbkhhbmRs ZXJDYWxsQ2hlY2tlcj4gY2hlY2tlciA9IENvbXBsZXRpb25IYW5kbGVyQ2FsbENoZWNrZXI6OmNy ZWF0ZShuYXZpZ2F0aW9uRGVsZWdhdGUuZ2V0KCksIEBzZWxlY3Rvcih3ZWJWaWV3OmRlY2lkZVBv bGljeUZvck5hdmlnYXRpb25BY3Rpb246ZGVjaXNpb25IYW5kbGVyOikpOworICAgIFtuYXZpZ2F0 aW9uRGVsZWdhdGUgd2ViVmlldzptX25hdmlnYXRpb25TdGF0ZS5tX3dlYlZpZXcgZGVjaWRlUG9s aWN5Rm9yTmF2aWdhdGlvbkFjdGlvbjpuYXZpZ2F0aW9uQWN0aW9uLmdldCgpIGRlY2lzaW9uSGFu ZGxlcjpbbGlzdGVuZXIsIGNoZWNrZXJdKFdLTmF2aWdhdGlvbkFjdGlvblBvbGljeSBhY3Rpb25Q b2xpY3kpIHsKKyAgICAgICAgY2hlY2tlci0+ZGlkQ2FsbENvbXBsZXRpb25IYW5kbGVyKCk7CisK ICAgICAgICAgc3dpdGNoIChhY3Rpb25Qb2xpY3kpIHsKICAgICAgICAgY2FzZSBXS05hdmlnYXRp b25BY3Rpb25Qb2xpY3lBbGxvdzoKICAgICAgICAgICAgIGxpc3RlbmVyLT51c2UoKTsKQEAgLTM2 NCw3ICszNjcsMTAgQEAgdm9pZCBOYXZpZ2F0aW9uU3RhdGU6OlBvbGljeUNsaWVudDo6ZGVjaWRl UG9saWN5Rm9yUmVzcG9uc2UoV2ViUGFnZVByb3h5KiwgV2ViRnIKICAgICBbbmF2aWdhdGlvblJl c3BvbnNlIHNldFJlc3BvbnNlOnJlc291cmNlUmVzcG9uc2UubnNVUkxSZXNwb25zZSgpXTsKICAg ICBbbmF2aWdhdGlvblJlc3BvbnNlIHNldENhblNob3dNSU1FVHlwZTpjYW5TaG93TUlNRVR5cGVd OwogCi0gICAgW25hdmlnYXRpb25EZWxlZ2F0ZSB3ZWJWaWV3Om1fbmF2aWdhdGlvblN0YXRlLm1f d2ViVmlldyBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uUmVzcG9uc2U6bmF2aWdhdGlvblJlc3Bv bnNlLmdldCgpIGRlY2lzaW9uSGFuZGxlcjpbbGlzdGVuZXJdKFdLTmF2aWdhdGlvblJlc3BvbnNl UG9saWN5IHJlc3BvbnNlUG9saWN5KSB7CisgICAgUmVmUHRyPENvbXBsZXRpb25IYW5kbGVyQ2Fs bENoZWNrZXI+IGNoZWNrZXIgPSBDb21wbGV0aW9uSGFuZGxlckNhbGxDaGVja2VyOjpjcmVhdGUo bmF2aWdhdGlvbkRlbGVnYXRlLmdldCgpLCBAc2VsZWN0b3Iod2ViVmlldzpkZWNpZGVQb2xpY3lG b3JOYXZpZ2F0aW9uUmVzcG9uc2U6ZGVjaXNpb25IYW5kbGVyOikpOworICAgIFtuYXZpZ2F0aW9u RGVsZWdhdGUgd2ViVmlldzptX25hdmlnYXRpb25TdGF0ZS5tX3dlYlZpZXcgZGVjaWRlUG9saWN5 Rm9yTmF2aWdhdGlvblJlc3BvbnNlOm5hdmlnYXRpb25SZXNwb25zZS5nZXQoKSBkZWNpc2lvbkhh bmRsZXI6W2xpc3RlbmVyLCBjaGVja2VyXShXS05hdmlnYXRpb25SZXNwb25zZVBvbGljeSByZXNw b25zZVBvbGljeSkgeworICAgICAgICBjaGVja2VyLT5kaWRDYWxsQ29tcGxldGlvbkhhbmRsZXIo KTsKKwogICAgICAgICBzd2l0Y2ggKHJlc3BvbnNlUG9saWN5KSB7CiAgICAgICAgIGNhc2UgV0tO YXZpZ2F0aW9uUmVzcG9uc2VQb2xpY3lBbGxvdzoKICAgICAgICAgICAgIGxpc3RlbmVyLT51c2Uo KTsK