134210 2014-06-23 13:30:49 -0700 [iOS][wk2] Don't use view snapshots if the destination layer is a different size 2014-06-23 15:13:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca benjamin simon.fraser oldest_to_newest 1017664 0 thorton 2014-06-23 13:30:49 -0700 <rdar://problem/17369463> 1017671 1 233633 thorton 2014-06-23 13:37:57 -0700 Created attachment 233633 patch 1017701 2 233633 benjamin 2014-06-23 14:58:13 -0700 Comment on attachment 233633 patch View in context: https://bugs.webkit.org/attachment.cgi?id=233633&action=review > Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:169 > [m_snapshotView setBackgroundColor:[UIColor whiteColor]]; It would be need to use the real page background color instead of white. 1017710 3 thorton 2014-06-23 15:13:27 -0700 http://trac.webkit.org/changeset/170326 233633 2014-06-23 13:37:57 -0700 2014-06-23 14:58:13 -0700 patch snapshot-rejects.diff text/plain 2208 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjZDc5NTg2Li44N2FiMDhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDYtMjMgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgorCisgICAgICAgIFtpT1NdW3drMl0gRG9uJ3QgdXNlIHZpZXcgc25hcHNob3RzIGlmIHRoZSBk ZXN0aW5hdGlvbiBsYXllciBpcyBhIGRpZmZlcmVudCBzaXplCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQyMTAKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzE3MzY5NDYzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVUlQcm9jZXNzL2lvcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJJT1MubW06CisgICAg ICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6YmVnaW5Td2lwZUdlc3R1cmUpOgor ICAgICAgICBPbmx5IHVzZSB0aGUgdmlldyBzbmFwc2hvdCBpZiB0aGUgc25hcHNob3QgaXMgdGhl IHNhbWUgKGluIGRldmljZSBzcGFjZSkgc2l6ZQorICAgICAgICBhcyB0aGUgbGF5ZXIgaXQncyBn b2luZyB0byBiZSBwdXQgaW50bywgYW5kIG9ubHkgaWYgdGhlIGRldmljZSBzY2FsZSBmYWN0b3Ig aXMKKyAgICAgICAgdGhlIHNhbWUgYXMgaXQgd2FzIHdoZW4gdGhlIHNuYXBzaG90IHdhcyB0YWtl bi4KKwogMjAxNC0wNi0yMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K IAogICAgICAgICBNb3JlIGJ1aWxkIGZpeGluZyBhZnRlciByMTcwMjk1LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJJT1MubW0g Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1ZpZXdHZXN0dXJlQ29udHJvbGxlcklPUy5t bQppbmRleCBiZjcwMDI5Li5iODdiYjc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1ZpZXdHZXN0dXJlQ29udHJvbGxlcklPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1ZpZXdHZXN0dXJlQ29udHJvbGxlcklPUy5tbQpAQCAtMTU4LDggKzE1 OCwxMyBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6YmVnaW5Td2lwZUdlc3R1cmUoX1VJ TmF2aWdhdGlvbkludGVyYWN0aXZlVHJhbnNpdGlvbgogICAgIG1fc25hcHNob3RWaWV3ID0gYWRv cHROUyhbW1VJVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpsaXZlU3dpcGVWaWV3RnJhbWVdKTsK IAogICAgIFZpZXdTbmFwc2hvdCBzbmFwc2hvdDsKLSAgICBpZiAoVmlld1NuYXBzaG90U3RvcmU6 OnNoYXJlZCgpLmdldFNuYXBzaG90KHRhcmdldEl0ZW0sIHNuYXBzaG90KSAmJiBzbmFwc2hvdC5o YXNJbWFnZSgpKQotICAgICAgICBbbV9zbmFwc2hvdFZpZXcgbGF5ZXJdLmNvbnRlbnRzID0gc25h cHNob3QuYXNMYXllckNvbnRlbnRzKCk7CisgICAgaWYgKFZpZXdTbmFwc2hvdFN0b3JlOjpzaGFy ZWQoKS5nZXRTbmFwc2hvdCh0YXJnZXRJdGVtLCBzbmFwc2hvdCkgJiYgc25hcHNob3QuaGFzSW1h Z2UoKSkgeworICAgICAgICBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvciA9IG1fd2ViUGFnZVByb3h5 LmRldmljZVNjYWxlRmFjdG9yKCk7CisgICAgICAgIEZsb2F0U2l6ZSBzd2lwZUxheWVyU2l6ZUlu RGV2aWNlQ29vcmRpbmF0ZXMobGl2ZVN3aXBlVmlld0ZyYW1lLnNpemUpOworICAgICAgICBzd2lw ZUxheWVyU2l6ZUluRGV2aWNlQ29vcmRpbmF0ZXMuc2NhbGUoZGV2aWNlU2NhbGVGYWN0b3IpOwor ICAgICAgICBpZiAoc25hcHNob3Quc2l6ZSA9PSBzd2lwZUxheWVyU2l6ZUluRGV2aWNlQ29vcmRp bmF0ZXMgJiYgZGV2aWNlU2NhbGVGYWN0b3IgPT0gc25hcHNob3QuZGV2aWNlU2NhbGVGYWN0b3Ip CisgICAgICAgICAgICBbbV9zbmFwc2hvdFZpZXcgbGF5ZXJdLmNvbnRlbnRzID0gc25hcHNob3Qu YXNMYXllckNvbnRlbnRzKCk7CisgICAgfQogCiAgICAgW21fc25hcHNob3RWaWV3IHNldEJhY2tn cm91bmRDb2xvcjpbVUlDb2xvciB3aGl0ZUNvbG9yXV07CiAgICAgW21fc25hcHNob3RWaWV3IGxh eWVyXS5jb250ZW50c0dyYXZpdHkgPSBrQ0FHcmF2aXR5VG9wTGVmdDsK