13420 2007-04-20 15:22:04 -0700 Assert in addToTextEncodingNameMap() should use strcmp() 2007-04-20 16:08:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) PC Windows XP CLOSED FIXED P2 Normal --- 0 pkasting webkit-unassigned oldest_to_newest 13745 0 pkasting 2007-04-20 15:22:04 -0700 TextEncodingRegistry.cpp:addToTextEncodingNameMap() has the following code: ASSERT(alias == name || atomicName); ...where alias and name are both char*s. We need to use strcmp() here, because the pointers are not guaranteed to be the same. (Other similar statements elsewhere are safe, because they deal with the returned pointers out of the hash map.) Patch coming shortly. 13706 1 14115 pkasting 2007-04-20 15:36:04 -0700 Created attachment 14115 patch v1 Patch as discussed with olliej on IRC. 13699 2 oliver 2007-04-20 15:46:45 -0700 Landed in r20975 14115 2007-04-20 15:36:04 -0700 2007-04-20 15:40:44 -0700 patch v1 patch text/plain 1263 pkasting SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDk3MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDQtMjAgIFBldGVyIEthc3RpbmcgIDxwa2FzdGluZ0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IC0gZml4IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDIwCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9UZXh0RW5jb2RpbmdSZWdpc3RyeS5jcHA6CisgICAgICAgIChXZWJD b3JlOjphZGRUb1RleHRFbmNvZGluZ05hbWVNYXApOiBDaGFuZ2UgYSBwb2ludGVyIGNvbXBhcmlz b24gdG8gYQorICAgICAgICBzdHJjbXAoKSwgc2luY2UgdGhlIHN0cmluZ3MgaGVyZSBhcmUgbm90 IG5lY2Vzc2FyaWx5CisgICAgICAgIHBvaW50ZXItZXF1aXZhbGVudC4KKwogMjAwNy0wNC0yMCAg RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2Vv ZmYgR2FyZW4gYW5kIEpvaG4gU3VsbGl2YW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL1RleHRF bmNvZGluZ1JlZ2lzdHJ5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL1RleHRF bmNvZGluZ1JlZ2lzdHJ5LmNwcAkocmV2aXNpb24gMjA5NzMpCisrKyBXZWJDb3JlL3BsYXRmb3Jt L1RleHRFbmNvZGluZ1JlZ2lzdHJ5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM5LDcgKzEzOSw3 IEBAIHN0YXRpYyB2b2lkIGFkZFRvVGV4dEVuY29kaW5nTmFtZU1hcChjb24KIHsKICAgICBBU1NF UlQoc3RybGVuKGFsaWFzKSA8PSBtYXhFbmNvZGluZ05hbWVMZW5ndGgpOwogICAgIGNvbnN0IGNo YXIqIGF0b21pY05hbWUgPSB0ZXh0RW5jb2RpbmdOYW1lTWFwLT5nZXQobmFtZSk7Ci0gICAgQVNT RVJUKGFsaWFzID09IG5hbWUgfHwgYXRvbWljTmFtZSk7CisgICAgQVNTRVJUKHN0cmNtcChhbGlh cywgbmFtZSkgPT0gMCB8fCBhdG9taWNOYW1lKTsKICAgICBpZiAoIWF0b21pY05hbWUpCiAgICAg ICAgIGF0b21pY05hbWUgPSBuYW1lOwogICAgIGNoZWNrRXhpc3RpbmdOYW1lKGFsaWFzLCBhdG9t aWNOYW1lKTsK