134196 2014-06-23 09:44:27 -0700 REGRESSION (r160908): Unable to unset bold while entering text 2014-06-23 10:03:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned rniwa oldest_to_newest 1017578 0 koivisto 2014-06-23 09:44:27 -0700 ...with some wk1 clients. 1017579 1 koivisto 2014-06-23 09:44:58 -0700 <rdar://problem/17051653> 1017581 2 233612 koivisto 2014-06-23 09:51:43 -0700 Created attachment 233612 patch 1017584 3 233612 kling 2014-06-23 09:57:27 -0700 Comment on attachment 233612 patch View in context: https://bugs.webkit.org/attachment.cgi?id=233612&action=review r=me bro. Another lazy style regression down! > Source/WebCore/editing/Editor.h:493 > + static RenderStyle* styleForSelectionStart(Frame* , Node *&nodeToRemove); Disturbing * and & placements here. 1017587 4 koivisto 2014-06-23 10:03:20 -0700 https://trac.webkit.org/r170296 233612 2014-06-23 09:51:43 -0700 2014-06-23 09:57:26 -0700 patch editing-style-update.patch text/plain 6421 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDI5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA2LTIzICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTYwOTA4 KTogVW5hYmxlIHRvIHVuc2V0IGJvbGQgd2hpbGUgZW50ZXJpbmcgdGV4dAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MTk2CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8xNzA1MTY1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKyAgICAgICAgCisgICAgICAgIE5vIHRlc3QsIHRoaXMgY29kZSBwYXRoIGlzIHVzZWQgYnkg c29tZSBXSzEgQVBJIGNsaWVudHMgb25seS4KKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6c3R5bGVGb3JTZWxlY3Rpb25TdGFydCk6Cisg ICAgICAgIAorICAgICAgICAgICAgVGhpcyBuZWVkcyB0byB1cGRhdGUgdGhlIHN0eWxlIGJlZm9y ZSByZXF1ZXN0aW5nIHRoZSByZW5kZXJlci4KKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmg6 CisgICAgICAgICogZWRpdGluZy9pb3MvRWRpdG9ySU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6 c3R5bGVGb3JTZWxlY3Rpb25TdGFydCk6IERlbGV0ZWQuCisgICAgICAgICogZWRpdGluZy9tYWMv RWRpdG9yTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6c3R5bGVGb3JTZWxlY3Rpb25TdGFydCk6 IERlbGV0ZWQuCisgICAgICAgIAorICAgICAgICAgICAgUmVtb3ZlZCB0aGUgZHVwbGljYXRlZCBm dW5jdGlvbnMsIG1vdmVkIHRvIEVkaXRvci5jcHAuCisKIDIwMTQtMDYtMjMgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbaU9TXSBGaXggdmlk ZW8gaW4gV2ViR0wuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCShyZXZpc2lvbiAx NzAyNjApCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM2NDQsNCArMzY0NCwzOCBAQCBEb2N1bWVudCYgRWRpdG9yOjpkb2N1bWVudCgpIGNv bnN0CiAgICAgcmV0dXJuICptX2ZyYW1lLmRvY3VtZW50KCk7CiB9CiAKKyNpZiBQTEFURk9STShD T0NPQSkKKy8vIEZJWE1FOiBUaGlzIGZpZ3VyZXMgb3V0IHRoZSBjdXJyZW50IHN0eWxlIGJ5IGlu c2VydGluZyBhIDxzcGFuPiEKK1JlbmRlclN0eWxlKiBFZGl0b3I6OnN0eWxlRm9yU2VsZWN0aW9u U3RhcnQoRnJhbWUqIGZyYW1lLCBOb2RlICombm9kZVRvUmVtb3ZlKQoreworICAgIG5vZGVUb1Jl bW92ZSA9IG51bGxwdHI7CisKKyAgICBpZiAoZnJhbWUtPnNlbGVjdGlvbigpLmlzTm9uZSgpKQor ICAgICAgICByZXR1cm4gbnVsbHB0cjsKKworICAgIFBvc2l0aW9uIHBvc2l0aW9uID0gZnJhbWUt PnNlbGVjdGlvbigpLnNlbGVjdGlvbigpLnZpc2libGVTdGFydCgpLmRlZXBFcXVpdmFsZW50KCk7 CisgICAgaWYgKCFwb3NpdGlvbi5pc0NhbmRpZGF0ZSgpIHx8IHBvc2l0aW9uLmlzTnVsbCgpKQor ICAgICAgICByZXR1cm4gbnVsbHB0cjsKKworICAgIFJlZlB0cjxFZGl0aW5nU3R5bGU+IHR5cGlu Z1N0eWxlID0gZnJhbWUtPnNlbGVjdGlvbigpLnR5cGluZ1N0eWxlKCk7CisgICAgaWYgKCF0eXBp bmdTdHlsZSB8fCAhdHlwaW5nU3R5bGUtPnN0eWxlKCkpCisgICAgICAgIHJldHVybiAmcG9zaXRp b24uZGVwcmVjYXRlZE5vZGUoKS0+cmVuZGVyZXIoKS0+c3R5bGUoKTsKKworICAgIFJlZlB0cjxF bGVtZW50PiBzdHlsZUVsZW1lbnQgPSBmcmFtZS0+ZG9jdW1lbnQoKS0+Y3JlYXRlRWxlbWVudChz cGFuVGFnLCBmYWxzZSk7CisKKyAgICBTdHJpbmcgc3R5bGVUZXh0ID0gdHlwaW5nU3R5bGUtPnN0 eWxlKCktPmFzVGV4dCgpICsgIiBkaXNwbGF5OiBpbmxpbmUiOworICAgIHN0eWxlRWxlbWVudC0+ c2V0QXR0cmlidXRlKHN0eWxlQXR0ciwgc3R5bGVUZXh0KTsKKworICAgIHN0eWxlRWxlbWVudC0+ YXBwZW5kQ2hpbGQoZnJhbWUtPmRvY3VtZW50KCktPmNyZWF0ZUVkaXRpbmdUZXh0Tm9kZSgiIiks IEFTU0VSVF9OT19FWENFUFRJT04pOworCisgICAgcG9zaXRpb24uZGVwcmVjYXRlZE5vZGUoKS0+ cGFyZW50Tm9kZSgpLT5hcHBlbmRDaGlsZChzdHlsZUVsZW1lbnQsIEFTU0VSVF9OT19FWENFUFRJ T04pOworCisgICAgbm9kZVRvUmVtb3ZlID0gc3R5bGVFbGVtZW50LmdldCgpOworCisgICAgZnJh bWUtPmRvY3VtZW50KCktPnVwZGF0ZVN0eWxlSWZOZWVkZWQoKTsKKyAgICAKKyAgICByZXR1cm4g c3R5bGVFbGVtZW50LT5yZW5kZXJlcigpID8gJnN0eWxlRWxlbWVudC0+cmVuZGVyZXIoKS0+c3R5 bGUoKSA6IG51bGxwdHI7Cit9CisjZW5kaWYKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRl eDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCShyZXZpc2lvbiAxNzAyNjApCisrKyBTb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL0VkaXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC00ODksNiArNDg5LDggQEAg cHJpdmF0ZToKICAgICBQYXNzUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGNyZWF0ZUZyYWdtZW50 Rm9ySW1hZ2VSZXNvdXJjZUFuZEFkZFJlc291cmNlKFBhc3NSZWZQdHI8QXJjaGl2ZVJlc291cmNl Pik7CiAgICAgUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBjcmVhdGVGcmFnbWVudEFuZEFk ZFJlc291cmNlcyhOU0F0dHJpYnV0ZWRTdHJpbmcgKik7CiAgICAgdm9pZCBmaWxsSW5Vc2VyVmlz aWJsZUZvcm0oUGFzdGVib2FyZFVSTCYpOworCisgICAgc3RhdGljIFJlbmRlclN0eWxlKiBzdHls ZUZvclNlbGVjdGlvblN0YXJ0KEZyYW1lKiAsIE5vZGUgKiZub2RlVG9SZW1vdmUpOwogI2VuZGlm CiAKICAgICBGcmFtZSYgbV9mcmFtZTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvaW9z L0VkaXRvcklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2lvcy9F ZGl0b3JJT1MubW0JKHJldmlzaW9uIDE3MDI2MCkKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcv aW9zL0VkaXRvcklPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTg1LDM5ICsxODUsNiBAQCBib29s IEVkaXRvcjo6aW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9ySW5RCiAgICAgcmV0dXJuIHRydWU7CiB9 CiAKLS8vIEZJWE1FOiBDb3BpZWQgZnJvbSBFZGl0b3JNYWMuIFRoaXMgc2hvdWxkIGJlIHNoYXJl ZCBiZXR3ZWVuIHRoZSB0d28gc28gdGhhdAotLy8gdGhlIGltcGxlbWVudGF0aW9uIGRvZXMgbm90 IGRpZmZlci4KLXN0YXRpYyBSZW5kZXJTdHlsZSogc3R5bGVGb3JTZWxlY3Rpb25TdGFydChGcmFt ZSogZnJhbWUsIE5vZGUgKiZub2RlVG9SZW1vdmUpCi17Ci0gICAgbm9kZVRvUmVtb3ZlID0gMDsK LQotICAgIGlmIChmcmFtZS0+c2VsZWN0aW9uKCkuaXNOb25lKCkpCi0gICAgICAgIHJldHVybiAw OwotCi0gICAgUG9zaXRpb24gcG9zaXRpb24gPSBmcmFtZS0+c2VsZWN0aW9uKCkuc2VsZWN0aW9u KCkudmlzaWJsZVN0YXJ0KCkuZGVlcEVxdWl2YWxlbnQoKTsKLSAgICBpZiAoIXBvc2l0aW9uLmlz Q2FuZGlkYXRlKCkgfHwgcG9zaXRpb24uaXNOdWxsKCkpCi0gICAgICAgIHJldHVybiAwOwotCi0g ICAgUmVmUHRyPEVkaXRpbmdTdHlsZT4gdHlwaW5nU3R5bGUgPSBmcmFtZS0+c2VsZWN0aW9uKCku dHlwaW5nU3R5bGUoKTsKLSAgICBpZiAoIXR5cGluZ1N0eWxlIHx8ICF0eXBpbmdTdHlsZS0+c3R5 bGUoKSkKLSAgICAgICAgcmV0dXJuICZwb3NpdGlvbi5kZXByZWNhdGVkTm9kZSgpLT5yZW5kZXJl cigpLT5zdHlsZSgpOwotCi0gICAgUmVmUHRyPEVsZW1lbnQ+IHN0eWxlRWxlbWVudCA9IGZyYW1l LT5kb2N1bWVudCgpLT5jcmVhdGVFbGVtZW50KHNwYW5UYWcsIGZhbHNlKTsKLQotICAgIFN0cmlu ZyBzdHlsZVRleHQgPSB0eXBpbmdTdHlsZS0+c3R5bGUoKS0+YXNUZXh0KCkgKyAiIGRpc3BsYXk6 IGlubGluZSI7Ci0gICAgc3R5bGVFbGVtZW50LT5zZXRBdHRyaWJ1dGUoc3R5bGVBdHRyLCBzdHls ZVRleHQuaW1wbCgpKTsKLQotICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgIHN0eWxlRWxl bWVudC0+YXBwZW5kQ2hpbGQoZnJhbWUtPmRvY3VtZW50KCktPmNyZWF0ZUVkaXRpbmdUZXh0Tm9k ZSgiIiksIGVjKTsKLSAgICBBU1NFUlQoIWVjKTsKLQotICAgIHBvc2l0aW9uLmRlcHJlY2F0ZWRO b2RlKCktPnBhcmVudE5vZGUoKS0+YXBwZW5kQ2hpbGQoc3R5bGVFbGVtZW50LCBlYyk7Ci0gICAg QVNTRVJUKCFlYyk7Ci0KLSAgICBub2RlVG9SZW1vdmUgPSBzdHlsZUVsZW1lbnQuZ2V0KCk7Ci0g ICAgcmV0dXJuIHN0eWxlRWxlbWVudC0+cmVuZGVyZXIoKSA/ICZzdHlsZUVsZW1lbnQtPnJlbmRl cmVyKCktPnN0eWxlKCkgOiAwOwotfQotCiBjb25zdCBTaW1wbGVGb250RGF0YSogRWRpdG9yOjpm b250Rm9yU2VsZWN0aW9uKGJvb2wmIGhhc011bHRpcGxlRm9udHMpIGNvbnN0CiB7CiAgICAgaGFz TXVsdGlwbGVGb250cyA9IGZhbHNlOwpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYWMv RWRpdG9yTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0Vk aXRvck1hYy5tbQkocmV2aXNpb24gMTcwMjYwKQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9t YWMvRWRpdG9yTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYsMzQgKzEwNiw2IEBAIGJvb2wg RWRpdG9yOjppbnNlcnRQYXJhZ3JhcGhTZXBhcmF0b3JJblEKICAgICByZXR1cm4gdHJ1ZTsKIH0K IAotc3RhdGljIFJlbmRlclN0eWxlKiBzdHlsZUZvclNlbGVjdGlvblN0YXJ0KEZyYW1lKiBmcmFt ZSwgTm9kZSAqJm5vZGVUb1JlbW92ZSkKLXsKLSAgICBub2RlVG9SZW1vdmUgPSAwOwotCi0gICAg aWYgKGZyYW1lLT5zZWxlY3Rpb24oKS5pc05vbmUoKSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KLSAg ICBQb3NpdGlvbiBwb3NpdGlvbiA9IGZyYW1lLT5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKS52aXNp YmxlU3RhcnQoKS5kZWVwRXF1aXZhbGVudCgpOwotICAgIGlmICghcG9zaXRpb24uaXNDYW5kaWRh dGUoKSB8fCBwb3NpdGlvbi5pc051bGwoKSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICBSZWZQ dHI8RWRpdGluZ1N0eWxlPiB0eXBpbmdTdHlsZSA9IGZyYW1lLT5zZWxlY3Rpb24oKS50eXBpbmdT dHlsZSgpOwotICAgIGlmICghdHlwaW5nU3R5bGUgfHwgIXR5cGluZ1N0eWxlLT5zdHlsZSgpKQot ICAgICAgICByZXR1cm4gJnBvc2l0aW9uLmRlcHJlY2F0ZWROb2RlKCktPnJlbmRlcmVyKCktPnN0 eWxlKCk7Ci0KLSAgICBSZWZQdHI8RWxlbWVudD4gc3R5bGVFbGVtZW50ID0gZnJhbWUtPmRvY3Vt ZW50KCktPmNyZWF0ZUVsZW1lbnQoc3BhblRhZywgZmFsc2UpOwotCi0gICAgU3RyaW5nIHN0eWxl VGV4dCA9IHR5cGluZ1N0eWxlLT5zdHlsZSgpLT5hc1RleHQoKSArICIgZGlzcGxheTogaW5saW5l IjsKLSAgICBzdHlsZUVsZW1lbnQtPnNldEF0dHJpYnV0ZShzdHlsZUF0dHIsIHN0eWxlVGV4dCk7 Ci0KLSAgICBzdHlsZUVsZW1lbnQtPmFwcGVuZENoaWxkKGZyYW1lLT5kb2N1bWVudCgpLT5jcmVh dGVFZGl0aW5nVGV4dE5vZGUoIiIpLCBBU1NFUlRfTk9fRVhDRVBUSU9OKTsKLQotICAgIHBvc2l0 aW9uLmRlcHJlY2F0ZWROb2RlKCktPnBhcmVudE5vZGUoKS0+YXBwZW5kQ2hpbGQoc3R5bGVFbGVt ZW50LCBBU1NFUlRfTk9fRVhDRVBUSU9OKTsKLQotICAgIG5vZGVUb1JlbW92ZSA9IHN0eWxlRWxl bWVudC5nZXQoKTsKLSAgICByZXR1cm4gc3R5bGVFbGVtZW50LT5yZW5kZXJlcigpID8gJnN0eWxl RWxlbWVudC0+cmVuZGVyZXIoKS0+c3R5bGUoKSA6IDA7Ci19Ci0KIGNvbnN0IFNpbXBsZUZvbnRE YXRhKiBFZGl0b3I6OmZvbnRGb3JTZWxlY3Rpb24oYm9vbCYgaGFzTXVsdGlwbGVGb250cykgY29u c3QKIHsKICAgICBoYXNNdWx0aXBsZUZvbnRzID0gZmFsc2U7Cg==