134183 2014-06-22 20:59:08 -0700 [iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D 2022-02-28 03:26:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino bfulgham commit-queue kondapallykalyan roger_fong simon.fraser thorton oldest_to_newest 1017474 0 dino 2014-06-22 20:59:08 -0700 [iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D 1017478 1 233583 dino 2014-06-22 21:02:29 -0700 Created attachment 233583 Patch 1017483 2 233583 sam 2014-06-22 22:42:35 -0700 Comment on attachment 233583 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233583&action=review > Source/WebCore/ChangeLog:13 > + * platform/graphics/GraphicsContext3D.h: Replace RefPtr<PlatformLayer> > + with RefPtr<WebGLLayer>. RetainPtr, not RefPtr. > Source/WebCore/platform/graphics/GraphicsContext3D.h:1010 > #if PLATFORM(IOS) > PlatformGraphicsContext3D m_contextObj; > - RetainPtr<PlatformLayer> m_webGLLayer; > + RetainPtr<WebGLLayer> m_webGLLayer; > #elif PLATFORM(MAC) > CGLContextObj m_contextObj; > RetainPtr<WebGLLayer> m_webGLLayer; Can this just be turned into PLATFORM(COCOA)? 1017500 3 dino 2014-06-23 01:06:24 -0700 Committed r170285: <http://trac.webkit.org/changeset/170285> 233583 2014-06-22 21:02:29 -0700 2022-02-28 03:26:35 -0800 Patch bug-134183-20140623140205.patch text/plain 2331 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk2MzY3OGZlYjhjNjY5 YTE5Y2MzZWZkZGRjMmU2NDkxOWQ3MzQ5ZC4uZTk3OWNmYzg0N2Q1MTNiNzA4ZjVkNzEzNWI0Y2Iw ZGYzNzA2MGNjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTA2LTIyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAgICBbaU9TXSBVc2UgV2ViR0xMYXll ciByYXRoZXIgdGhhbiBQbGF0Zm9ybUxheWVyIGluIEdyYXBoaWNzQ29udGV4dDNECisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQxODMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHcmFwaGljc0NvbnRleHQz RCBoYXMgYSByZWZlcmVuY2UgdG8gYSBXZWJHTExheWVyIHRoYXQgd2FzCisgICAgICAgIGhpZGRl biBiZWhpbmQgYSBQbGF0Zm9ybUxheWVyLiBUaGlzIG1lYW50IHdlIGhhZCB0byBjYXN0IGl0Cisg ICAgICAgIHRvIHVzZSBhIFdlYkdMTGF5ZXIgbWV0aG9kLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaDogUmVwbGFjZSBSZWZQdHI8UGxhdGZvcm1MYXll cj4KKyAgICAgICAgd2l0aCBSZWZQdHI8V2ViR0xMYXllcj4uCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6 R3JhcGhpY3NDb250ZXh0M0Q6On5HcmFwaGljc0NvbnRleHQzRCk6IE5vIG5lZWQgdG8gY2FzdC4K KworMjAxNC0wNi0yMiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisKICAgICAgICAg QXR0ZW1wdGVkIGlPUyBidWlsZCBmaXguCiAKICAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9t YWMvR3JhcGhpY3NDb250ZXh0M0RNYWMubW06CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAppbmRleCBjNTg2OTA1NDcxNmRkMDlh Mjg2OWQ5MjM2OTczMmZlYzY2NDdiOTRiLi4wYTYyNjZiZGU4ZjgyOWM1ZjI3MjAwNGE2ZmI4NmIx Nzk1ODMyYTEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9H cmFwaGljc0NvbnRleHQzRC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dyYXBoaWNzQ29udGV4dDNELmgKQEAgLTEwMDQsNyArMTAwNCw3IEBAIHByaXZhdGU6CiAKICNp ZiBQTEFURk9STShJT1MpCiAgICAgUGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCBtX2NvbnRleHRP Ymo7Ci0gICAgUmV0YWluUHRyPFBsYXRmb3JtTGF5ZXI+IG1fd2ViR0xMYXllcjsKKyAgICBSZXRh aW5QdHI8V2ViR0xMYXllcj4gbV93ZWJHTExheWVyOwogI2VsaWYgUExBVEZPUk0oTUFDKQogICAg IENHTENvbnRleHRPYmogbV9jb250ZXh0T2JqOwogICAgIFJldGFpblB0cjxXZWJHTExheWVyPiBt X3dlYkdMTGF5ZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMubW0KaW5kZXggY2JiYTYwODQ3ZjYyZWU2 NzRkNGZiYWMyMTA2ZTRiMWEwYWJiZmQwNS4uZDI1YjY3ZGQ5MTE5MTVmYWI2MWJjMjI3NzVlNWNm NzNlMjVhOWFmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv bWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL21hYy9HcmFwaGljc0NvbnRleHQzRE1hYy5tbQpAQCAtMzMyLDcgKzMzMiw3IEBA IEdyYXBoaWNzQ29udGV4dDNEOjp+R3JhcGhpY3NDb250ZXh0M0QoKQogICAgICAgICBDR0xTZXRD dXJyZW50Q29udGV4dCgwKTsKICAgICAgICAgQ0dMRGVzdHJveUNvbnRleHQobV9jb250ZXh0T2Jq KTsKICNlbmRpZgotICAgICAgICBbc3RhdGljX2Nhc3Q8V2ViR0xMYXllcio+KG1fd2ViR0xMYXll cikgc2V0Q29udGV4dDpudWxscHRyXTsKKyAgICAgICAgW21fd2ViR0xMYXllciBzZXRDb250ZXh0 Om51bGxwdHJdOwogICAgICAgICBudW1BY3RpdmVDb250ZXh0cy0tOwogICAgIH0KIH0K