134181 2014-06-22 18:14:12 -0700 [iOS][wk2] Swiping back sometimes results in a missing (not blank) swipe snapshot 2014-06-22 18:32:38 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton benjamin simon.fraser webkit-bug-importer oldest_to_newest 1017461 0 thorton 2014-06-22 18:14:12 -0700 In r170036, I made it so that setRenderTreeSize would remove the snapshot even if m_snapshotRemovalTargetRenderTreeSize wasn't set, so that we would still wait until the first relevant layer tree commit to remove the snapshot. However, this also removed the only guard that ensured that we only removed the snapshot after the swipe was complete; now, any layer tree commit that comes in *during* the swipe will cause the snapshot to be removed. Oops! Let's make the old behavior more explicit. 1017462 1 233581 thorton 2014-06-22 18:17:13 -0700 Created attachment 233581 patch 1017464 2 webkit-bug-importer 2014-06-22 18:19:57 -0700 <rdar://problem/17413411> 1017466 3 233581 benjamin 2014-06-22 18:23:36 -0700 Comment on attachment 233581 patch Thanks! :) 1017467 4 thorton 2014-06-22 18:32:38 -0700 http://trac.webkit.org/changeset/170277 233581 2014-06-22 18:17:13 -0700 2014-06-22 18:23:35 -0700 patch rendertreesize.diff text/plain 3464 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzY2NjNzQxLi5jMGQ0YTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDYtMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW2lPU11bd2syXSBTd2lwaW5nIGJhY2sgc29tZXRpbWVzIHJlc3VsdHMgaW4gYSBt aXNzaW5nIChub3QgYmxhbmspIHN3aXBlIHNuYXBzaG90CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQxODEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvVmlld0dlc3R1cmVDb250 cm9sbGVySU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OlZp ZXdHZXN0dXJlQ29udHJvbGxlcik6CisgICAgICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJv bGxlcjo6ZW5kU3dpcGVHZXN0dXJlKToKKyAgICAgICAgKFdlYktpdDo6Vmlld0dlc3R1cmVDb250 cm9sbGVyOjpzZXRSZW5kZXJUcmVlU2l6ZSk6CisgICAgICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJl Q29udHJvbGxlcjo6cmVtb3ZlU3dpcGVTbmFwc2hvdCk6CisgICAgICAgICogVUlQcm9jZXNzL21h Yy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuaDoKKyAgICAgICAgTWFrZSBpdCBleHBsaWNpdCB0aGF0 IHdlIHNob3VsZCBvbmx5IHJlbW92ZSB0aGUgc3dpcGUgc25hcHNob3Qgd2hlbiBhCisgICAgICAg IGJpZy1lbm91Z2ggcmVuZGVyIHRyZWUgc2l6ZSBhcnJpdmVzICphZnRlciB0aGUgc3dpcGUgZW5k cyouCisKIDIwMTQtMDYtMjIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXBsYWNlIGEgY291cGxlIG9mIHVzZXMgb2YgYmluZCB3aXRoIGxhbWJkYXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvVmlld0dlc3R1cmVDb250 cm9sbGVySU9TLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9WaWV3R2VzdHVyZUNv bnRyb2xsZXJJT1MubW0KaW5kZXggMjhlZDZkOC4uYmY3MDAyOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJJT1MubW0KKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJJT1MubW0K QEAgLTEyOCw2ICsxMjgsNyBAQCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OlZpZXdHZXN0dXJlQ29u dHJvbGxlcihXZWJQYWdlUHJveHkmIHdlYlBhZ2VQcm94eSkKICAgICAsIG1fYWN0aXZlR2VzdHVy ZVR5cGUoVmlld0dlc3R1cmVUeXBlOjpOb25lKQogICAgICwgbV9zd2lwZVdhdGNoZG9nVGltZXIo dGhpcywgJlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6c3dpcGVTbmFwc2hvdFdhdGNoZG9nVGltZXJG aXJlZCkKICAgICAsIG1fc25hcHNob3RSZW1vdmFsVGFyZ2V0UmVuZGVyVHJlZVNpemUoMCkKKyAg ICAsIG1fc2hvdWxkUmVtb3ZlU25hcHNob3RXaGVuVGFyZ2V0UmVuZGVyVHJlZVNpemVIaXQoZmFs c2UpCiB7CiB9CiAKQEAgLTIzOCw2ICsyMzksOCBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxl cjo6ZW5kU3dpcGVHZXN0dXJlKFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qIHRhcmdldEl0ZW0sCiAg ICAgVmlld1NuYXBzaG90U3RvcmU6OnNoYXJlZCgpLmVuYWJsZVNuYXBzaG90dGluZygpOwogCiAg ICAgbV9zd2lwZVdhdGNoZG9nVGltZXIuc3RhcnRPbmVTaG90KHN3aXBlU25hcHNob3RSZW1vdmFs V2F0Y2hkb2dEdXJhdGlvbi5jb3VudCgpKTsKKworICAgIG1fc2hvdWxkUmVtb3ZlU25hcHNob3RX aGVuVGFyZ2V0UmVuZGVyVHJlZVNpemVIaXQgPSB0cnVlOwogfQogICAgIAogdm9pZCBWaWV3R2Vz dHVyZUNvbnRyb2xsZXI6OnNldFJlbmRlclRyZWVTaXplKHVpbnQ2NF90IHJlbmRlclRyZWVTaXpl KQpAQCAtMjQ1LDYgKzI0OCw5IEBAIHZvaWQgVmlld0dlc3R1cmVDb250cm9sbGVyOjpzZXRSZW5k ZXJUcmVlU2l6ZSh1aW50NjRfdCByZW5kZXJUcmVlU2l6ZSkKICAgICBpZiAobV9hY3RpdmVHZXN0 dXJlVHlwZSAhPSBWaWV3R2VzdHVyZVR5cGU6OlN3aXBlKQogICAgICAgICByZXR1cm47CiAKKyAg ICBpZiAoIW1fc2hvdWxkUmVtb3ZlU25hcHNob3RXaGVuVGFyZ2V0UmVuZGVyVHJlZVNpemVIaXQp CisgICAgICAgIHJldHVybjsKKwogICAgIC8vIERvbid0IHJlbW92ZSB0aGUgc3dpcGUgc25hcHNo b3QgdW50aWwgd2UgZ2V0IGEgZHJhd2luZyBhcmVhIHRyYW5zYWN0aW9uIG1vcmUgcmVjZW50IHRo YW4gdGhlIG5hdmlnYXRpb24sCiAgICAgLy8gYW5kIHdlIGhpdCB0aGUgcmVuZGVyIHRyZWUgc2l6 ZSB0aHJlc2hvbGQuIFRoaXMgYXZvaWRzIHBvdGVudGlhbGx5IHJlbW92aW5nIHRoZSBzbmFwc2hv dCBlYXJseSwKICAgICAvLyB3aGVuIHJlY2VpdmluZyBjb21taXRzIGZyb20gdGhlIHByZXZpb3Vz IChwcmUtbmF2aWdhdGlvbikgcGFnZS4KQEAgLTI1OSw2ICsyNjUsOCBAQCB2b2lkIFZpZXdHZXN0 dXJlQ29udHJvbGxlcjo6c3dpcGVTbmFwc2hvdFdhdGNoZG9nVGltZXJGaXJlZChUaW1lcjxWaWV3 R2VzdHVyZUNvbgogCiB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6cmVtb3ZlU3dpcGVTbmFw c2hvdCgpCiB7CisgICAgbV9zaG91bGRSZW1vdmVTbmFwc2hvdFdoZW5UYXJnZXRSZW5kZXJUcmVl U2l6ZUhpdCA9IGZhbHNlOworCiAgICAgbV9zd2lwZVdhdGNoZG9nVGltZXIuc3RvcCgpOwogCiAg ICAgaWYgKG1fYWN0aXZlR2VzdHVyZVR5cGUgIT0gVmlld0dlc3R1cmVUeXBlOjpTd2lwZSkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9s bGVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxl ci5oCmluZGV4IDhmYjNlN2UuLjcyZDY4MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuaApAQCAtMTg1LDYgKzE4NSw3IEBA IHByaXZhdGU6CiAgICAgUmV0YWluUHRyPFdLU3dpcGVUcmFuc2l0aW9uQ29udHJvbGxlcj4gbV9z d2lwZUludGVyYWN0aXZlVHJhbnNpdGlvbkRlbGVnYXRlOwogICAgIHVpbnQ2NF90IG1fc25hcHNo b3RSZW1vdmFsVGFyZ2V0UmVuZGVyVHJlZVNpemU7CiAgICAgdWludDY0X3QgbV9zbmFwc2hvdFJl bW92YWxUYXJnZXRUcmFuc2FjdGlvbklEOworICAgIGJvb2wgbV9zaG91bGRSZW1vdmVTbmFwc2hv dFdoZW5UYXJnZXRSZW5kZXJUcmVlU2l6ZUhpdDsKICNlbmRpZgogfTsKIAo=