134179 2014-06-22 16:33:17 -0700 [Apple] WebGL layer may use GC3D after free with remote layer hosting 2014-06-22 17:00:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino commit-queue kondapallykalyan roger_fong oldest_to_newest 1017445 0 dino 2014-06-22 16:33:17 -0700 [Apple] WebGL layer may use GC3D after free with remote layer hosting 1017447 1 dino 2014-06-22 16:39:01 -0700 <rdar://problem/17412931> 1017448 2 233580 dino 2014-06-22 16:40:48 -0700 Created attachment 233580 Patch 1017449 3 233580 thorton 2014-06-22 16:43:53 -0700 Comment on attachment 233580 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233580&action=review > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:335 > + [m_webGLLayer.get() setContext:nullptr]; no .get() required! > Source/WebCore/platform/graphics/mac/WebGLLayer.mm:45 > +@synthesize context=m_context; ObjC members don't usually have an 'm_' prefix, just '_'. (I see this predates your changes, though). 1017450 4 dino 2014-06-22 16:45:52 -0700 (In reply to comment #3) > (From update of attachment 233580 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233580&action=review > > > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:335 > > + [m_webGLLayer.get() setContext:nullptr]; > > no .get() required! I was wondering what the approved syntax is here. I wanted to just do .context = nullptr; > > > Source/WebCore/platform/graphics/mac/WebGLLayer.mm:45 > > +@synthesize context=m_context; > > ObjC members don't usually have an 'm_' prefix, just '_'. (I see this predates your changes, though). Yeah, I considered changing that. Since you complained, I'll do it :) 1017452 5 dino 2014-06-22 17:00:54 -0700 Committed r170271: <http://trac.webkit.org/changeset/170271> 233580 2014-06-22 16:40:48 -0700 2014-06-22 16:43:52 -0700 Patch bug-134179-20140623094024.patch text/plain 4574 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWY5YzRjZjExZjRhMDY5 NzA3YzdjZDdkYjc3ODlkZTlmNWI2OGVkYy4uOWFiM2U3ZmQwMGJiYzYxZTMxOGM1YzYxN2FiOTgy NGI1YWI1NjcxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA2LTIyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbQXBwbGVdIFdlYkdMIGxheWVy IG1heSB1c2UgR0MzRCBhZnRlciBmcmVlIHdpdGggcmVtb3RlIGxheWVyIGhvc3RpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDE3OQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTc0MTI5MzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2l0aCByZW1vdGUgbGF5ZXIgaG9zdGluZywgYSBXZWJHTExh eWVyIG1heSBhdHRlbXB0IHRvIGRyYXcgYWZ0ZXIKKyAgICAgICAgdGhlIEdyYXBoaWNzQ29udGV4 dDNEIGhhcyBiZWVuIGRlc3Ryb3llZC4gV2UgbmVlZCB0byBtYWtlIHN1cmUKKyAgICAgICAgdGhl IEdDM0QgdGVsbHMgdGhlIFdlYkdMTGF5ZXIgdGhhdCBpdCBpcyBubyBsb25nZXIgdmFsaWQuCisK KyAgICAgICAgVGhpcyBpcyB0ZXN0ZWQgYnkgcnVuLXdlYmtpdC10ZXN0cyB3aXRoIHRoZSAtLXJl bW90ZS1sYXllci10cmVlCisgICAgICAgIG9wdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL21hYy9HcmFwaGljc0NvbnRleHQzRE1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzQ29udGV4dDNEOjp+R3JhcGhpY3NDb250ZXh0M0QpOiBTZXQgdGhlIGNvbnRleHQgcmVm ZXJlbmNlIG9uIFdlYkdMTGF5ZXIKKyAgICAgICAgdG8gYmUgbnVsbC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9tYWMvV2ViR0xMYXllci5oOiBOZXcgcHJvcGVydHkgdG8gcmVmZXJlbmNl IHRoZSBHQzNEIChzbyB3ZSBjYW4KKyAgICAgICAgc2V0IGl0IGFib3ZlKS4KKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9tYWMvV2ViR0xMYXllci5tbTogU3ludGhlc2l6ZSB0aGUgcHJvcGVy dHkuCisgICAgICAgICgtW1dlYkdMTGF5ZXIgZHJhd0luQ0dMQ29udGV4dDpwaXhlbEZvcm1hdDpm b3JMYXllclRpbWU6ZGlzcGxheVRpbWU6XSk6IENoZWNrIGZvciBudWxsLgorICAgICAgICAoLVtX ZWJHTExheWVyIGNvcHlJbWFnZVNuYXBzaG90V2l0aENvbG9yU3BhY2U6XSk6IERpdHRvLgorICAg ICAgICAoLVtXZWJHTExheWVyIGRpc3BsYXldKTogRGl0dG8uCisKIDIwMTQtMDYtMjAgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gRnJhbWVz ZXQgZnJhbWVzIGFyZSBub3Qgc2Nyb2xsYWJsZSBhZnRlciBsb2FkaW5nIChhbmQgc2hvdWxkIGJl KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBo aWNzQ29udGV4dDNETWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFj L0dyYXBoaWNzQ29udGV4dDNETWFjLm1tCmluZGV4IDFlOWY5NTMyNDdhN2MwODNlN2IxNWMzMjE3 YWY5MWYxMjA4MTQ4N2EuLmM5MThhYjE4MWIxYTRjOWQxY2U4M2M0YjNlYzRmNmJmNTFhNzM0YTQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HcmFwaGlj c0NvbnRleHQzRE1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvR3JhcGhpY3NDb250ZXh0M0RNYWMubW0KQEAgLTMzMiw2ICszMzIsNyBAQCBHcmFwaGljc0Nv bnRleHQzRDo6fkdyYXBoaWNzQ29udGV4dDNEKCkKICAgICAgICAgQ0dMU2V0Q3VycmVudENvbnRl eHQoMCk7CiAgICAgICAgIENHTERlc3Ryb3lDb250ZXh0KG1fY29udGV4dE9iaik7CiAjZW5kaWYK KyAgICAgICAgW21fd2ViR0xMYXllci5nZXQoKSBzZXRDb250ZXh0Om51bGxwdHJdOwogICAgICAg ICBudW1BY3RpdmVDb250ZXh0cy0tOwogICAgIH0KIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9XZWJHTExheWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9tYWMvV2ViR0xMYXllci5oCmluZGV4IDAxMWFhZjcxMzlkNGE2Mzdj YWRhMTkzOGE1MzI3ZWIwMDNmMGI3ZDYuLjc1MjUwODNhZjA2MThmMWI4MDEwMjMwM2IyNDY4OWE3 Y2MwMGNlOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21h Yy9XZWJHTExheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFj L1dlYkdMTGF5ZXIuaApAQCAtNDIsNiArNDIsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0QqIG1fY29udGV4dDsKIH0KIAorQHByb3BlcnR5IChu b25hdG9taWMpIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEKiBjb250ZXh0OworCiAtIChpZClp bml0V2l0aEdyYXBoaWNzQ29udGV4dDNEOihXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRCopY29u dGV4dDsKIAogLSAoQ0dJbWFnZVJlZiljb3B5SW1hZ2VTbmFwc2hvdFdpdGhDb2xvclNwYWNlOihD R0NvbG9yU3BhY2VSZWYpY29sb3JTcGFjZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL21hYy9XZWJHTExheWVyLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvbWFjL1dlYkdMTGF5ZXIubW0KaW5kZXggMmZkN2M0NmIxMTc5YmYyZWFmMDNi NDVkYTI0YWY3N2QzNTJlYjg0ZC4uNjY1OTFmMTZlNDE1YjlhOTk4YjU1MjU3ZTEwYzMyMDBkZTMy ZDg1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1dl YkdMTGF5ZXIubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1dl YkdMTGF5ZXIubW0KQEAgLTQyLDYgKzQyLDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAK IEBpbXBsZW1lbnRhdGlvbiBXZWJHTExheWVyCiAKK0BzeW50aGVzaXplIGNvbnRleHQ9bV9jb250 ZXh0OworCiAtKGlkKWluaXRXaXRoR3JhcGhpY3NDb250ZXh0M0Q6KEdyYXBoaWNzQ29udGV4dDNE Kiljb250ZXh0CiB7CiAgICAgbV9jb250ZXh0ID0gY29udGV4dDsKQEAgLTcxLDYgKzczLDkgQEAg dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIC0odm9pZClkcmF3SW5DR0xDb250ZXh0OihDR0xD b250ZXh0T2JqKWdsQ29udGV4dCBwaXhlbEZvcm1hdDooQ0dMUGl4ZWxGb3JtYXRPYmopcGl4ZWxG b3JtYXQgZm9yTGF5ZXJUaW1lOihDRlRpbWVJbnRlcnZhbCl0aW1lSW50ZXJ2YWwgZGlzcGxheVRp bWU6KGNvbnN0IENWVGltZVN0YW1wICopdGltZVN0YW1wCiB7CisgICAgaWYgKCFtX2NvbnRleHQp CisgICAgICAgIHJldHVybjsKKwogICAgIG1fY29udGV4dC0+cHJlcGFyZVRleHR1cmUoKTsKIAog ICAgIENHTFNldEN1cnJlbnRDb250ZXh0KGdsQ29udGV4dCk7CkBAIC0xMTQsOSArMTE5LDEyIEBA IHN0YXRpYyB2b2lkIGZyZWVEYXRhKHZvaWQgKiwgY29uc3Qgdm9pZCAqZGF0YSwgc2l6ZV90IC8q IHNpemUgKi8pCiAKIC0oQ0dJbWFnZVJlZiljb3B5SW1hZ2VTbmFwc2hvdFdpdGhDb2xvclNwYWNl OihDR0NvbG9yU3BhY2VSZWYpY29sb3JTcGFjZQogeworICAgIGlmICghbV9jb250ZXh0KQorICAg ICAgICByZXR1cm4gbnVsbHB0cjsKKwogI2lmIFBMQVRGT1JNKElPUykKICAgICBVTlVTRURfUEFS QU0oY29sb3JTcGFjZSk7Ci0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIG51bGxwdHI7CiAjZWxz ZQogICAgIENHTFNldEN1cnJlbnRDb250ZXh0KG1fY29udGV4dC0+cGxhdGZvcm1HcmFwaGljc0Nv bnRleHQzRCgpKTsKIApAQCAtMTMzLDcgKzE0MSw3IEBAIHN0YXRpYyB2b2lkIGZyZWVEYXRhKHZv aWQgKiwgY29uc3Qgdm9pZCAqZGF0YSwgc2l6ZV90IC8qIHNpemUgKi8pCiAgICAgc2l6ZV90IGRh dGFTaXplID0gcm93Qnl0ZXMgKiBoZWlnaHQ7CiAgICAgdm9pZCogZGF0YSA9IGZhc3RNYWxsb2Mo ZGF0YVNpemUpOwogICAgIGlmICghZGF0YSkKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJl dHVybiBudWxscHRyOwogCiAgICAgZ2xQaXhlbFN0b3JlaShHTF9QQUNLX1JPV19MRU5HVEgsIHJv d0J5dGVzIC8gNCk7CiAgICAgZ2xSZWFkUGl4ZWxzKDAsIDAsIHdpZHRoLCBoZWlnaHQsIEdMX0JH UkEsIEdMX1VOU0lHTkVEX0lOVF84XzhfOF84X1JFViwgZGF0YSk7CkBAIC0xNTAsNiArMTU4LDkg QEAgc3RhdGljIHZvaWQgZnJlZURhdGEodm9pZCAqLCBjb25zdCB2b2lkICpkYXRhLCBzaXplX3Qg Lyogc2l6ZSAqLykKIAogLSAodm9pZClkaXNwbGF5CiB7CisgICAgaWYgKCFtX2NvbnRleHQpCisg ICAgICAgIHJldHVybjsKKwogI2lmIFBMQVRGT1JNKElPUykKICAgICBtX2NvbnRleHQtPmVuZFBh aW50KCk7CiAjZWxzZQo=