13417 2007-04-20 04:04:17 -0700 Repro crash when the first argument to getMatchedCSSRules is not an element 2007-04-21 01:33:41 -0700 1 1 1 Unclassified WebKit CSS 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED javascript:getMatchedCSSRules(null, "", false) HasReduction P1 Major --- 1 mitz webkit-unassigned oldest_to_newest 13826 0 mitz 2007-04-20 04:04:17 -0700 To reproduce, open the URL. The release build crashes, the debug build fails the ASSERT in Node::document(). 13828 1 14108 mitz 2007-04-20 04:05:12 -0700 Created attachment 14108 Add null check Includes layout test and change log. 13751 2 14108 darin 2007-04-20 08:05:38 -0700 Comment on attachment 14108 Add null check r=me 13637 3 mrowe 2007-04-21 01:33:41 -0700 Landed in r20993. 14108 2007-04-20 04:05:12 -0700 2007-04-20 08:05:38 -0700 Add null check 13417_r1.patch text/plain 2801 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwOTcxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDQtMjAgIE1pdHogUGV0dGVsICA8bWl0 ekB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIC0gdGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM0MTcKKyAgICAgICAgICBSZXBybyBjcmFzaCB3aGVuIHRoZSBmaXJzdCBhcmd1bWVudCB0byBn ZXRNYXRjaGVkQ1NTUnVsZXMgaXMgbm90IGFuIGVsZW1lbnQKKworICAgICAgICAqIGZhc3QvZG9t L1dpbmRvdy9nZXRNYXRjaGVkQ1NTUnVsZXMtbnVsbC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy9nZXRNYXRjaGVkQ1NTUnVsZXMtbnVsbC1jcmFz aC5odG1sOiBBZGRlZC4KKwogMjAwNy0wNC0xOSAgTWl0eiBQZXR0ZWwgIDxtaXR6QHdlYmtpdC5v cmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQWRhbS4KSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZG9tL1dpbmRvdy9nZXRNYXRjaGVkQ1NTUnVsZXMtbnVsbC1jcmFzaC1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2dldE1hdGNoZWRD U1NSdWxlcy1udWxsLWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3QvZG9tL1dpbmRvdy9nZXRNYXRjaGVkQ1NTUnVsZXMtbnVsbC1jcmFzaC1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1NVQ0NFU1MgKGdldE1hdGNoZWRDU1NS dWxlKG51bGwsIC4uLikgZGlkIG5vdCBjcmFzaCkuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9XaW5kb3cvZ2V0TWF0Y2hlZENTU1J1bGVzLW51bGwtY3Jhc2guaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvZ2V0TWF0Y2hlZENTU1J1bGVzLW51bGwtY3Jh c2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9nZXRN YXRjaGVkQ1NTUnVsZXMtbnVsbC1jcmFzaC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYg QEAKKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIHZhciBydWxlcyA9IGdl dE1hdGNoZWRDU1NSdWxlcyhudWxsLCAiIiwgZmFsc2UpOworPC9zY3JpcHQ+CitTVUNDRVNTICg8 Y29kZT5nZXRNYXRjaGVkQ1NTUnVsZShudWxsLCAuLi4pPC9jb2RlPiBkaWQgbm90IGNyYXNoKS4K SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDk3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDctMDQtMjAgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDE3CisgICAgICAgICAg UmVwcm8gY3Jhc2ggd2hlbiB0aGUgZmlyc3QgYXJndW1lbnQgdG8gZ2V0TWF0Y2hlZENTU1J1bGVz IGlzIG5vdCBhbiBlbGVtZW50CisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vV2luZG93L2dldE1h dGNoZWRDU1NSdWxlcy1udWxsLWNyYXNoLmh0bWwKKworICAgICAgICAqIGNzcy9jc3NzdHlsZXNl bGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OnN0eWxlUnVs ZXNGb3JFbGVtZW50KTogQWRkZWQgbnVsbCBjaGVjay4KKwogMjAwNy0wNC0xOSAgQWxwIFRva2Vy ICA8YWxwQGF0b2tlci5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyay4KSW5kZXg6IFdl YkNvcmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3Nz L2Nzc3N0eWxlc2VsZWN0b3IuY3BwCShyZXZpc2lvbiAyMDk2NykKKysrIFdlYkNvcmUvY3NzL2Nz c3N0eWxlc2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTc4LDcgKzExNzgsNyBAQCB2 b2lkIENTU1N0eWxlU2VsZWN0b3I6OmNhY2hlQm9yZGVyQW5kQmFjCiAKIFJlZlB0cjxDU1NSdWxl TGlzdD4gQ1NTU3R5bGVTZWxlY3Rvcjo6c3R5bGVSdWxlc0ZvckVsZW1lbnQoRWxlbWVudCogZSwg Ym9vbCBhdXRob3JPbmx5KQogewotICAgIGlmICghZS0+ZG9jdW1lbnQoKS0+aGF2ZVN0eWxlc2hl ZXRzTG9hZGVkKCkpCisgICAgaWYgKCFlIHx8ICFlLT5kb2N1bWVudCgpLT5oYXZlU3R5bGVzaGVl dHNMb2FkZWQoKSkKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBtX2NvbGxlY3RSdWxlc09ubHkg PSB0cnVlOwo=