134163 2014-06-21 13:38:22 -0700 Begin work on decoding form data 2014-06-21 14:02:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1017331 0 andersca 2014-06-21 13:38:22 -0700 Begin work on decoding form data 1017332 1 233545 andersca 2014-06-21 13:39:21 -0700 Created attachment 233545 Patch 1017333 2 commit-queue 2014-06-21 13:41:17 -0700 Attachment 233545 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:314: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1017335 3 233545 sam 2014-06-21 13:52:21 -0700 Comment on attachment 233545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233545&action=review > Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:316 > + uint32_t underlyingEnumValue; > + *this >> underlyingEnumValue; Can this use std::underlying_type<>? 1017336 4 andersca 2014-06-21 14:01:54 -0700 Committed r170252: <http://trac.webkit.org/changeset/170252> 1017337 5 andersca 2014-06-21 14:02:37 -0700 (In reply to comment #3) > (From update of attachment 233545 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233545&action=review > > > Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:316 > > + uint32_t underlyingEnumValue; > > + *this >> underlyingEnumValue; > > Can this use std::underlying_type<>? No, it needs to always use uint32_t. 233545 2014-06-21 13:39:21 -0700 2014-06-21 13:52:20 -0700 Patch bug-134163-20140621133859.patch text/plain 5083 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTU4M2Y2YTlhZjg5NmIy YzhjMGQ1MjMxMjdlZmU4Yzc3N2I0ZTAwZi4uZDE0OGVhOTg2NThjMjBlZjFmYTkwMTlkNDg2ZDc2 YzYyMjUxOWEzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE0LTA2LTIxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQmVnaW4gd29yayBv biBkZWNvZGluZyBmb3JtIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNDE2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9MZWdhY3lTZXNzaW9uU3RhdGVDb2RpbmcuY3Bw OgorICAgICAgICAoV2ViS2l0OjpIaXN0b3J5RW50cnlEYXRhRGVjb2Rlcjo6b3BlcmF0b3I+Pik6 CisgICAgICAgIChXZWJLaXQ6Okhpc3RvcnlFbnRyeURhdGFEZWNvZGVyOjppc1ZhbGlkKToKKyAg ICAgICAgKFdlYktpdDo6aXNWYWxpZEVudW0pOgorICAgICAgICAoV2ViS2l0OjpkZWNvZGVGb3Jt RGF0YUVsZW1lbnQpOgorICAgICAgICAoV2ViS2l0OjpkZWNvZGVGb3JtRGF0YSk6CisgICAgICAg IChXZWJLaXQ6OmRlY29kZUJhY2tGb3J3YXJkVHJlZU5vZGUpOgorCisyMDE0LTA2LTIxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgT25seSBpbml0aWFs aXplIFdlYlByZWZlcmVuY2VzIGZyb20gTlNVc2VyRGVmYXVsdHMgaWYgdGhlcmUncyBhbiBpZGVu dGlmaWVyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzQxNjIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9MZWdhY3lT ZXNzaW9uU3RhdGVDb2RpbmcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9MZWdh Y3lTZXNzaW9uU3RhdGVDb2RpbmcuY3BwCmluZGV4IGM2N2RiYTFlNWJkZGNhNWUzMTFhYmU0Mjdl Y2ZkOTM5ZTE4Mjg3OGIuLjhlMDVmY2EzNjdkNTVjMDZlMmMwYzMzZjU2NjRjNDMxZmJlYmM4MTYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvTGVnYWN5U2Vzc2lvblN0 YXRlQ29kaW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL0xlZ2FjeVNl c3Npb25TdGF0ZUNvZGluZy5jcHAKQEAgLTE5OCw2ICsxOTgsOCBAQCBib29sIExlZ2FjeVNlc3Np b25TdGF0ZURlY29kZXI6OmRlY29kZVNlc3Npb25IaXN0b3J5RW50cnkoQ0ZEaWN0aW9uYXJ5UmVm IGVudHJ5RAogICAgIHJldHVybiB0cnVlOwogfQogCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPiB2b2lk IGlzVmFsaWRFbnVtKFQpOworCiBjbGFzcyBIaXN0b3J5RW50cnlEYXRhRGVjb2RlciB7CiBwdWJs aWM6CiAgICAgSGlzdG9yeUVudHJ5RGF0YURlY29kZXIoY29uc3QgdWludDhfdCogYnVmZmVyLCBz aXplX3QgYnVmZmVyU2l6ZSkKQEAgLTI3Myw2ICsyNzUsNTYgQEAgcHVibGljOgogICAgICAgICBy ZXR1cm4gKnRoaXM7CiAgICAgfQogCisgICAgSGlzdG9yeUVudHJ5RGF0YURlY29kZXImIG9wZXJh dG9yPj4oVmVjdG9yPHVpbnQ4X3Q+JiB2YWx1ZSkKKyAgICB7CisgICAgICAgIHZhbHVlID0geyB9 OworCisgICAgICAgIHVpbnQ2NF90IHNpemU7CisgICAgICAgICp0aGlzID4+IHNpemU7CisKKyAg ICAgICAgaWYgKCFhbGlnbkJ1ZmZlclBvc2l0aW9uKDEsIHNpemUpKQorICAgICAgICAgICAgcmV0 dXJuICp0aGlzOworCisgICAgICAgIGNvbnN0IHVpbnQ4X3QqIGRhdGEgPSBtX2J1ZmZlcjsKKyAg ICAgICAgbV9idWZmZXIgKz0gc2l6ZTsKKworICAgICAgICB2YWx1ZS5hcHBlbmQoZGF0YSwgc2l6 ZSk7CisgICAgICAgIHJldHVybiAqdGhpczsKKyAgICB9CisKKyAgICBIaXN0b3J5RW50cnlEYXRh RGVjb2RlciYgb3BlcmF0b3I+PihWZWN0b3I8Y2hhcj4mIHZhbHVlKQorICAgIHsKKyAgICAgICAg dmFsdWUgPSB7IH07CisKKyAgICAgICAgdWludDY0X3Qgc2l6ZTsKKyAgICAgICAgKnRoaXMgPj4g c2l6ZTsKKworICAgICAgICBpZiAoIWFsaWduQnVmZmVyUG9zaXRpb24oMSwgc2l6ZSkpCisgICAg ICAgICAgICByZXR1cm4gKnRoaXM7CisKKyAgICAgICAgY29uc3QgdWludDhfdCogZGF0YSA9IG1f YnVmZmVyOworICAgICAgICBtX2J1ZmZlciArPSBzaXplOworCisgICAgICAgIHZhbHVlLmFwcGVu ZChkYXRhLCBzaXplKTsKKyAgICAgICAgcmV0dXJuICp0aGlzOworICAgIH0KKworICAgIHRlbXBs YXRlPHR5cGVuYW1lIFQ+CisgICAgYXV0byBvcGVyYXRvcj4+KE9wdGlvbmFsPFQ+JiB2YWx1ZSkg LT4gdHlwZW5hbWUgc3RkOjplbmFibGVfaWY8c3RkOjppc19lbnVtPFQ+Ojp2YWx1ZSwgSGlzdG9y eUVudHJ5RGF0YURlY29kZXImPjo6dHlwZQorICAgIHsKKyAgICAgICAgdWludDMyX3QgdW5kZXJs eWluZ0VudW1WYWx1ZTsKKyAgICAgICAgKnRoaXMgPj4gdW5kZXJseWluZ0VudW1WYWx1ZTsKKwor ICAgICAgICBpZiAoIWlzVmFsaWQoKSB8fCAhaXNWYWxpZEVudW0oc3RhdGljX2Nhc3Q8VD4odW5k ZXJseWluZ0VudW1WYWx1ZSkpKQorICAgICAgICAgICAgdmFsdWUgPSBOdWxsb3B0OworICAgICAg ICBlbHNlCisgICAgICAgICAgICB2YWx1ZSA9IHN0YXRpY19jYXN0PFQ+KHVuZGVybHlpbmdFbnVt VmFsdWUpOworCisgICAgICAgIHJldHVybiAqdGhpczsKKyAgICB9CisKKyAgICBib29sIGlzVmFs aWQoKSBjb25zdCB7IHJldHVybiBtX2J1ZmZlciA8PSBtX2J1ZmZlckVuZDsgfQorCiAgICAgYm9v bCBmaW5pc2hEZWNvZGluZygpIHsgcmV0dXJuIG1fYnVmZmVyID09IG1fYnVmZmVyRW5kOyB9CiAK IHByaXZhdGU6CkBAIC0zNDMsNiArMzk1LDYzIEBAIHByaXZhdGU6CiAgICAgY29uc3QgdWludDhf dCogbV9idWZmZXJFbmQ7CiB9OwogCitlbnVtIGNsYXNzIEZvcm1EYXRhRWxlbWVudFR5cGUgewor ICAgIERhdGEgPSAwLAorICAgIEVuY29kZWRGaWxlID0gMSwKKyAgICBFbmNvZGVkQmxvYiA9IDIs Cit9OworCitzdGF0aWMgYm9vbCBpc1ZhbGlkRW51bShGb3JtRGF0YUVsZW1lbnRUeXBlIHR5cGUp Cit7CisgICAgc3dpdGNoICh0eXBlKSB7CisgICAgY2FzZSBGb3JtRGF0YUVsZW1lbnRUeXBlOjpE YXRhOgorICAgIGNhc2UgRm9ybURhdGFFbGVtZW50VHlwZTo6RW5jb2RlZEZpbGU6CisgICAgY2Fz ZSBGb3JtRGF0YUVsZW1lbnRUeXBlOjpFbmNvZGVkQmxvYjoKKyAgICAgICAgcmV0dXJuIHRydWU7 CisgICAgfQorCisgICAgcmV0dXJuIGZhbHNlOworfQorCitzdGF0aWMgdm9pZCBkZWNvZGVGb3Jt RGF0YUVsZW1lbnQoSGlzdG9yeUVudHJ5RGF0YURlY29kZXImIGRlY29kZXIsIEhUVFBCb2R5OjpF bGVtZW50JiBmb3JtRGF0YUVsZW1lbnQpCit7CisgICAgT3B0aW9uYWw8Rm9ybURhdGFFbGVtZW50 VHlwZT4gZWxlbWVudFR5cGU7CisgICAgZGVjb2RlciA+PiBlbGVtZW50VHlwZTsKKyAgICBpZiAo IWVsZW1lbnRUeXBlKQorICAgICAgICByZXR1cm47CisKKyAgICBzd2l0Y2ggKGVsZW1lbnRUeXBl LnZhbHVlKCkpIHsKKyAgICBjYXNlIEZvcm1EYXRhRWxlbWVudFR5cGU6OkRhdGE6CisgICAgICAg IGZvcm1EYXRhRWxlbWVudC50eXBlID0gSFRUUEJvZHk6OkVsZW1lbnQ6OlR5cGU6OkRhdGE7Cisg ICAgICAgIGRlY29kZXIgPj4gZm9ybURhdGFFbGVtZW50LmRhdGE7CisgICAgICAgIGJyZWFrOwor CisgICAgY2FzZSBGb3JtRGF0YUVsZW1lbnRUeXBlOjpFbmNvZGVkRmlsZToKKyAgICBjYXNlIEZv cm1EYXRhRWxlbWVudFR5cGU6OkVuY29kZWRCbG9iOgorICAgICAgICAvLyBGSVhNRTogSW1wbGVt ZW50LgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICB9Cit9CisKK3N0YXRpYyB2 b2lkIGRlY29kZUZvcm1EYXRhKEhpc3RvcnlFbnRyeURhdGFEZWNvZGVyJiBkZWNvZGVyLCBIVFRQ Qm9keSYgZm9ybURhdGEpCit7CisgICAgYm9vbCBhbHdheXNTdHJlYW07CisgICAgZGVjb2RlciA+ PiBhbHdheXNTdHJlYW07CisKKyAgICBWZWN0b3I8dWludDhfdD4gYm91bmRhcnk7CisgICAgZGVj b2RlciA+PiBib3VuZGFyeTsKKworICAgIHVpbnQ2NF90IGZvcm1EYXRhRWxlbWVudENvdW50Owor ICAgIGRlY29kZXIgPj4gZm9ybURhdGFFbGVtZW50Q291bnQ7CisKKyAgICBmb3IgKHVpbnQ2NF90 IGkgPSAwOyBpIDwgZm9ybURhdGFFbGVtZW50Q291bnQ7ICsraSkgeworICAgICAgICBIVFRQQm9k eTo6RWxlbWVudCBmb3JtRGF0YUVsZW1lbnQ7CisgICAgICAgIGRlY29kZUZvcm1EYXRhRWxlbWVu dChkZWNvZGVyLCBmb3JtRGF0YUVsZW1lbnQpOworCisgICAgICAgIGZvcm1EYXRhLmVsZW1lbnRz LmFwcGVuZChzdGQ6Om1vdmUoZm9ybURhdGFFbGVtZW50KSk7CisgICAgfQorfQorCiBzdGF0aWMg dm9pZCBkZWNvZGVCYWNrRm9yd2FyZFRyZWVOb2RlKEhpc3RvcnlFbnRyeURhdGFEZWNvZGVyJiBk ZWNvZGVyLCBGcmFtZVN0YXRlJiBmcmFtZVN0YXRlKQogewogICAgIHVpbnQ2NF90IGNoaWxkQ291 bnQ7CkBAIC0zNzQsOCArNDgzLDEyIEBAIHN0YXRpYyB2b2lkIGRlY29kZUJhY2tGb3J3YXJkVHJl ZU5vZGUoSGlzdG9yeUVudHJ5RGF0YURlY29kZXImIGRlY29kZXIsIEZyYW1lU3RhCiAgICAgZGVj b2RlciA+PiBoYXNGb3JtRGF0YTsKIAogICAgIGlmIChoYXNGb3JtRGF0YSkgewotICAgICAgICAv LyBGSVhNRTogSW1wbGVtZW50LgotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAg ICAgSFRUUEJvZHkgaHR0cEJvZHk7CisgICAgICAgIGh0dHBCb2R5LmNvbnRlbnRUeXBlID0gc3Rk Ojptb3ZlKGZvcm1Db250ZW50VHlwZSk7CisKKyAgICAgICAgZGVjb2RlRm9ybURhdGEoZGVjb2Rl ciwgaHR0cEJvZHkpOworCisgICAgICAgIGZyYW1lU3RhdGUuaHR0cEJvZHkgPSBzdGQ6Om1vdmUo aHR0cEJvZHkpOwogICAgIH0KIAogICAgIGRlY29kZXIgPj4gZnJhbWVTdGF0ZS5pdGVtU2VxdWVu Y2VOdW1iZXI7Cg==