134152 2014-06-20 23:43:43 -0700 Commit queue has been failing due to a build failure in WKFoundation.h 2014-06-23 01:01:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa andersca beidson lforschler mitz mrowe ossy sam oldest_to_newest 1017214 0 rniwa 2014-06-20 23:43:43 -0700 Commit queue has been failing due to a build failure in WKFoundation.h 1017216 1 233513 rniwa 2014-06-20 23:48:08 -0700 Created attachment 233513 Fix CQ build failure 1017217 2 233513 rniwa 2014-06-21 00:11:50 -0700 Comment on attachment 233513 Fix CQ build failure View in context: https://bugs.webkit.org/attachment.cgi?id=233513&action=review > Source/WebKit2/ChangeLog:12 > + The availability of this type depends on the version of SDK, > + not the target operating system. The enum is defined using NS_ENUM_AVAILABLE, which in turn uses CF_AVAILABLE: #define CF_AVAILABLE(_mac, _ios) __attribute__((availability(macosx,__NSi_##_mac))) http://opensource.apple.com/source/CF/CF-855.11/CFAvailability.h Enum types defined with by the attribute seems to still exist as a type so re-defining it results in a compilation error. 1017220 3 233513 mitz 2014-06-21 00:20:58 -0700 Comment on attachment 233513 Fix CQ build failure I think that if you want to check the SDK version, you should check if __MAC_OS_X_VERSION_MAX_ALLOWED is defined and is less than 1090. 1017222 4 233514 rniwa 2014-06-21 00:36:21 -0700 Created attachment 233514 Fixed per Dan's comment 1017223 5 233515 rniwa 2014-06-21 00:36:55 -0700 Created attachment 233515 Use if instead of ifdef 1017235 6 233515 ossy 2014-06-21 01:42:03 -0700 Comment on attachment 233515 Use if instead of ifdef rs=me to unbreak CQ ASAP. Let's see if CQ can land this fix. :) 1017266 7 beidson 2014-06-21 07:38:11 -0700 Okay, it's kind of comedic that we're trying to let the commit queue land this, don't you think? =/ 1017269 8 beidson 2014-06-21 07:44:19 -0700 Landed in http://trac.webkit.org/changeset/170237 1017496 9 ossy 2014-06-23 00:53:10 -0700 (In reply to comment #7) > Okay, it's kind of comedic that we're trying to let the commit queue land this, don't you think? =/ Not at all. Commit queue should handle this situation. When the build is broken, CQ can rollout the revision which caused the build breakage. But after a little bit digging, rollout patches are handled specifically, they aren't built and tested at all. Maybe we should teach CQ how to handle quick and important fixes which aren't rollout patches. 1017499 10 233515 ossy 2014-06-23 01:01:07 -0700 Comment on attachment 233515 Use if instead of ifdef removing flags, it was already landed 233513 2014-06-20 23:48:08 -0700 2014-06-21 00:36:17 -0700 Fix CQ build failure bug-134152-20140620234747.patch text/plain 1459 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzIzMDZhYzhjN2M1MDk3 ODgyNzk3NWIwNTI4ZjY2MjBlNzI3YzMwNy4uY2Q2NTE0NzM3MjQ2YzYzMWYwZWQ2NDA1OGFmNzBk YWMzMWQ3NTRiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTIwICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENvbW1pdCBxdWV1ZSBoYXMg YmVlbiBmYWlsaW5nIGR1ZSB0byBhIGJ1aWxkIGZhaWx1cmUgaW4gV0tGb3VuZGF0aW9uLmgKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDE1MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWlsZCBm YWlsdXJlIHdhcyBjYXVzZWQgYnkgV0tGb3VuZGF0aW9uLmggZXJyb25lb3VzbHkgcmVkZWZpbmlu ZworICAgICAgICBOU1VSTFNlc3Npb25BdXRoQ2hhbGxlbmdlRGlzcG9zaXRpb24gZXZlbiB3aGVu IGJ1aWxkaW5nIHdpdGggMTAuOSBTREsuCisKKyAgICAgICAgVGhlIGF2YWlsYWJpbGl0eSBvZiB0 aGlzIHR5cGUgZGVwZW5kcyBvbiB0aGUgdmVyc2lvbiBvZiBTREssCisgICAgICAgIG5vdCB0aGUg dGFyZ2V0IG9wZXJhdGluZyBzeXN0ZW0uCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL1dL Rm91bmRhdGlvbi5oOgorCiAyMDE0LTA2LTIwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IG1vcmUgb2YgTGVnYWN5U2Vzc2lvblN0YXRl RGVjb2RlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS0Zv dW5kYXRpb24uaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tGb3VuZGF0aW9u LmgKaW5kZXggNDcwNTJhMjE1OWUzODdiNzVmN2VlNTUyNzZjMDQxNTk4N2I3OWY5OC4uZTQ3ZWI4 YWIyMDZiNmVkYzA0MGFiYWI4ZTVjOWY3ZTI3ZTdiZTNhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS0ZvdW5kYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvQVBJL0NvY29hL1dLRm91bmRhdGlvbi5oCkBAIC01NCw3ICs1NCw3IEBACiAjaW1w b3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRpb24uaD4KIHR5cGVkZWYgTlNVSW50ZWdlciBOU0V2ZW50 TW9kaWZpZXJGbGFnczsKIAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAx MDkwCisjaWZuZGVmIF9fTUFDXzEwXzkKIHR5cGVkZWYgTlNJbnRlZ2VyIE5TVVJMU2Vzc2lvbkF1 dGhDaGFsbGVuZ2VEaXNwb3NpdGlvbjsKICNlbmRpZgogCg== 233514 2014-06-21 00:36:21 -0700 2014-06-21 00:36:51 -0700 Fixed per Dan's comment bug-134152-20140621003559.patch text/plain 1486 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzIzMDZhYzhjN2M1MDk3 ODgyNzk3NWIwNTI4ZjY2MjBlNzI3YzMwNy4uY2Q2NTE0NzM3MjQ2YzYzMWYwZWQ2NDA1OGFmNzBk YWMzMWQ3NTRiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTIwICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENvbW1pdCBxdWV1ZSBoYXMg YmVlbiBmYWlsaW5nIGR1ZSB0byBhIGJ1aWxkIGZhaWx1cmUgaW4gV0tGb3VuZGF0aW9uLmgKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDE1MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWlsZCBm YWlsdXJlIHdhcyBjYXVzZWQgYnkgV0tGb3VuZGF0aW9uLmggZXJyb25lb3VzbHkgcmVkZWZpbmlu ZworICAgICAgICBOU1VSTFNlc3Npb25BdXRoQ2hhbGxlbmdlRGlzcG9zaXRpb24gZXZlbiB3aGVu IGJ1aWxkaW5nIHdpdGggMTAuOSBTREsuCisKKyAgICAgICAgVGhlIGF2YWlsYWJpbGl0eSBvZiB0 aGlzIHR5cGUgZGVwZW5kcyBvbiB0aGUgdmVyc2lvbiBvZiBTREssCisgICAgICAgIG5vdCB0aGUg dGFyZ2V0IG9wZXJhdGluZyBzeXN0ZW0uCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL1dL Rm91bmRhdGlvbi5oOgorCiAyMDE0LTA2LTIwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IG1vcmUgb2YgTGVnYWN5U2Vzc2lvblN0YXRl RGVjb2RlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS0Zv dW5kYXRpb24uaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tGb3VuZGF0aW9u LmgKaW5kZXggNDcwNTJhMjE1OWUzODdiNzVmN2VlNTUyNzZjMDQxNTk4N2I3OWY5OC4uYjdlZDU0 ZGE1Y2I0NDJhYWIyZTEzNDJlZGE3NDhjY2RiNDI4YTY2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS0ZvdW5kYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvQVBJL0NvY29hL1dLRm91bmRhdGlvbi5oCkBAIC01NCw3ICs1NCw3IEBACiAjaW1w b3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRpb24uaD4KIHR5cGVkZWYgTlNVSW50ZWdlciBOU0V2ZW50 TW9kaWZpZXJGbGFnczsKIAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAx MDkwCisjaWZuZGVmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA8IDEwOTAKIHR5cGVk ZWYgTlNJbnRlZ2VyIE5TVVJMU2Vzc2lvbkF1dGhDaGFsbGVuZ2VEaXNwb3NpdGlvbjsKICNlbmRp ZgogCg== 233515 2014-06-21 00:36:55 -0700 2014-06-23 01:01:07 -0700 Use if instead of ifdef bug-134152-20140621003633.patch text/plain 1482 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzIzMDZhYzhjN2M1MDk3 ODgyNzk3NWIwNTI4ZjY2MjBlNzI3YzMwNy4uY2Q2NTE0NzM3MjQ2YzYzMWYwZWQ2NDA1OGFmNzBk YWMzMWQ3NTRiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTIwICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENvbW1pdCBxdWV1ZSBoYXMg YmVlbiBmYWlsaW5nIGR1ZSB0byBhIGJ1aWxkIGZhaWx1cmUgaW4gV0tGb3VuZGF0aW9uLmgKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDE1MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWlsZCBm YWlsdXJlIHdhcyBjYXVzZWQgYnkgV0tGb3VuZGF0aW9uLmggZXJyb25lb3VzbHkgcmVkZWZpbmlu ZworICAgICAgICBOU1VSTFNlc3Npb25BdXRoQ2hhbGxlbmdlRGlzcG9zaXRpb24gZXZlbiB3aGVu IGJ1aWxkaW5nIHdpdGggMTAuOSBTREsuCisKKyAgICAgICAgVGhlIGF2YWlsYWJpbGl0eSBvZiB0 aGlzIHR5cGUgZGVwZW5kcyBvbiB0aGUgdmVyc2lvbiBvZiBTREssCisgICAgICAgIG5vdCB0aGUg dGFyZ2V0IG9wZXJhdGluZyBzeXN0ZW0uCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL1dL Rm91bmRhdGlvbi5oOgorCiAyMDE0LTA2LTIwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IG1vcmUgb2YgTGVnYWN5U2Vzc2lvblN0YXRl RGVjb2RlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS0Zv dW5kYXRpb24uaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tGb3VuZGF0aW9u LmgKaW5kZXggNDcwNTJhMjE1OWUzODdiNzVmN2VlNTUyNzZjMDQxNTk4N2I3OWY5OC4uNjhhNTIy YTExZjk4MTdhMmQ5YTdmZTA2MjM5NTk3ODE5YzVjOWRhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS0ZvdW5kYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvQVBJL0NvY29hL1dLRm91bmRhdGlvbi5oCkBAIC01NCw3ICs1NCw3IEBACiAjaW1w b3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRpb24uaD4KIHR5cGVkZWYgTlNVSW50ZWdlciBOU0V2ZW50 TW9kaWZpZXJGbGFnczsKIAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAx MDkwCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEIDwgMTA5MAogdHlwZWRlZiBO U0ludGVnZXIgTlNVUkxTZXNzaW9uQXV0aENoYWxsZW5nZURpc3Bvc2l0aW9uOwogI2VuZGlmCiAK