134133 2014-06-20 15:31:00 -0700 [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree 2014-06-30 17:46:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield bunhere cdumez commit-queue dino gyuyoung.kim jonlee sergio simonjam thorton oldest_to_newest 1017079 0 mmaxfield 2014-06-20 15:31:00 -0700 GSFontAddCGFont is deprecated and we use it in DumpRenderTree 1017085 1 233470 mmaxfield 2014-06-20 15:37:53 -0700 Created attachment 233470 Patch 1017419 2 mmaxfield 2014-06-22 11:34:03 -0700 CTFontManagerRegisterGraphicsFont is preferable. 1019373 3 234088 mmaxfield 2014-06-30 13:01:32 -0700 Created attachment 234088 Patch 1019378 4 234088 simon.fraser 2014-06-30 13:27:25 -0700 Comment on attachment 234088 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234088&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:535 > fprintf(stderr, "Failed to add CGFont to GraphicsServices for the %s font.\n", sectionName.c_str()); Shouldn't this print error details? 1019379 5 234088 mmaxfield 2014-06-30 13:28:16 -0700 Comment on attachment 234088 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234088&action=review >> Tools/DumpRenderTree/mac/DumpRenderTree.mm:535 >> fprintf(stderr, "Failed to add CGFont to GraphicsServices for the %s font.\n", sectionName.c_str()); > > Shouldn't this print error details? Can also remove GSFont header 1019512 6 mmaxfield 2014-06-30 17:46:27 -0700 http://trac.webkit.org/changeset/170623 233470 2014-06-20 15:37:53 -0700 2014-06-30 13:01:30 -0700 Patch bug-134133-20140620153731.patch text/plain 1258 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMjA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2Y1Zjc1ZGU5NTlkMGIzMDBiOTIzOWI0YmY3NWQ0YWRl OGJiYTgyOS4uY2EwYmY4YjFkMjBlYWViMThlZmFmNDM4YWY4MmJjZTFjOGFjYzk2MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA2LTIwICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgR1NGb250QWRkQ0dGb250IGlzIGRlcHJlY2F0ZWQgYW5kIHdlIHVzZSBpdCBp biBEdW1wUmVuZGVyVHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM0MTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAgICAg IChhY3RpdmF0ZUZvbnRzSU9TKToKKwogMjAxNC0wNi0yMCAgSmF2aWVyIEZlcm5hbmRleiAgPGpm ZXJuYW5kZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBBZGRpbmcgbXlzZWxm IHRvIGNvbW1pdHRlcnMuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVt cFJlbmRlclRyZWUubW0gYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUu bW0KaW5kZXggMjRiODllNzAwNzdmMTc4Mjk0OTZkZDgyMWQxZTU4ZjA5NjdlOTE2OS4uMTM3OTVl Y2MxNjcyY2QzNTk1YTNhODk3OGU5MDM5NDJiZDcxMWU0OSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQpAQCAtNTUxLDcgKzU1MSw3IEBAIHN0YXRpYyB2b2lk IGFjdGl2YXRlRm9udHNJT1MoKQogICAgICAgICAgICAgZXhpdCgxKTsKICAgICAgICAgfQogCi0g ICAgICAgIGlmICghR1NGb250QWRkQ0dGb250KGNnRm9udCkpIHsKKyAgICAgICAgaWYgKCFHU0Zv bnRSZWdpc3RlckNHRm9udChjZ0ZvbnQpKSB7CiAgICAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwg IkZhaWxlZCB0byBhZGQgQ0dGb250IHRvIEdyYXBoaWNzU2VydmljZXMgZm9yIHRoZSAlcyBmb250 LlxuIiwgZm9udFNlY3Rpb25OYW1lc1tpXSk7CiAgICAgICAgICAgICBleGl0KDEpOwogICAgICAg ICB9Cg== 234088 2014-06-30 13:01:32 -0700 2014-06-30 13:28:16 -0700 Patch bug-134133-20140630130113.patch text/plain 5227 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwNDU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjYxNjM4MjczZWNkMDZmOTk1NzJiNWQ5NjdhYWI5MGVm NWVlOWQwNC4uNWMwNDM1MTc4ZWI5YjFjMTYxZDgwNzY4ZGJlZGI1NDZjMmIyZGM0YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA2LTMwICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgW2lPU10gR1NGb250QWRkQ0dGb250IGlzIGRlcHJlY2F0ZWQgYW5kIHdlIHVz ZSBpdCBpbiBEdW1wUmVuZGVyVHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM0MTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVwbGFjZSBpdCB3aXRoIENURm9udE1hbmFnZXJSZWdpc3RlckdyYXBo aWNzRm9udAorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUueGNvZGVw cm9qL3Byb2plY3QucGJ4cHJvajoKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJl bmRlclRyZWUubW06CisgICAgICAgIChhY3RpdmF0ZUZvbnRJT1MpOgorCiAyMDE0LTA2LTI1ICBD aHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGFuIHVu ZG8gZ3JvdXAgZm9yIGVhY2ggZGljdGF0ZWQgdXR0ZXJhbmNlIGluIFdlYktpdApkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvaiBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLnhjb2RlcHJvai9w cm9qZWN0LnBieHByb2oKaW5kZXggODZiYzA3NDU2NDk5N2FmNDQxNDg1ODMzMjAxNTMwYzg0ZDlh MDFjMy4uMmIwNzhlMmY3NDM3NzAzYmQyNWVlZDM1NTNhODYzZmU2ODNmZjM2ZiAxMDA2NDQKLS0t IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvagorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS54Y29kZXBy b2ovcHJvamVjdC5wYnhwcm9qCkBAIC01NCw2ICs1NCw3IEBACiAJCTFBRDg2ODNGMTYzQjJGRDAw MEEyODU4MyAvKiBOUFJ1bnRpbWVDYWxsc1dpdGhOdWxsTlBQLmNwcCBpbiBTb3VyY2VzICovID0g e2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDFBRDg2ODNEMTYzQjJGRDAwMEEyODU4MyAv KiBOUFJ1bnRpbWVDYWxsc1dpdGhOdWxsTlBQLmNwcCAqLzsgfTsKIAkJMUFEOUQyRkUxMjAyODQw OTAwMUE3MEQxIC8qIFBsdWdpblNjcmlwdGFibGVOUE9iamVjdEludm9rZURlZmF1bHQuY3BwIGlu IFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMUFEOUQyRkQxMjAy ODQwOTAwMUE3MEQxIC8qIFBsdWdpblNjcmlwdGFibGVOUE9iamVjdEludm9rZURlZmF1bHQuY3Bw ICovOyB9OwogCQkxQUZGNjZCQzEzN0RFRkQyMDA3OTE2OTYgLyogR2V0VVJMTm90aWZ5V2l0aFVS TFRoYXRGYWlsc1RvTG9hZC5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7 IGZpbGVSZWYgPSAxQUZGNjZCQjEzN0RFQTgzMDA3OTE2OTYgLyogR2V0VVJMTm90aWZ5V2l0aFVS TFRoYXRGYWlsc1RvTG9hZC5jcHAgKi87IH07CisJCTFDQjY3NDIwMTk1QkFFN0IwMDBGMzVCNSAv KiBDb3JlVGV4dC5mcmFtZXdvcmsgaW4gRnJhbWV3b3JrcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZp bGU7IGZpbGVSZWYgPSAxQ0I2NzQxRjE5NUJBRTdCMDAwRjM1QjUgLyogQ29yZVRleHQuZnJhbWV3 b3JrICovOyB9OwogCQkyOUNGQkExMTEyMjczNkU2MDBCQzMwQzAgLyogQWNjZXNzaWJpbGl0eVRl eHRNYXJrZXIuY3BwIGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVm ID0gMjlDRkJBMEYxMjI3MzZFNjAwQkMzMEMwIC8qIEFjY2Vzc2liaWxpdHlUZXh0TWFya2VyLmNw cCAqLzsgfTsKIAkJMjlDRkJBMkUxMjI3M0ExMDAwQkMzMEMwIC8qIEFjY2Vzc2liaWxpdHlUZXh0 TWFya2VyTWFjLm1tIGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVm ID0gMjlDRkJBMkQxMjI3M0ExMDAwQkMzMEMwIC8qIEFjY2Vzc2liaWxpdHlUZXh0TWFya2VyTWFj Lm1tICovOyB9OwogCQkyQ0U4OEZBMjE3MTI0RDhDMDA3MzRGQzAgLyogSmF2YVNjcmlwdFRocmVh ZGluZy5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAy Q0U4OEZBMTE3MTI0Q0VFMDA3MzRGQzAgLyogSmF2YVNjcmlwdFRocmVhZGluZy5jcHAgKi87IH07 CkBAIC0yNDMsNiArMjQ0LDcgQEAKIAkJMUFEODY4M0QxNjNCMkZEMDAwQTI4NTgzIC8qIE5QUnVu dGltZUNhbGxzV2l0aE51bGxOUFAuY3BwICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZp bGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBw YXRoID0gTlBSdW50aW1lQ2FsbHNXaXRoTnVsbE5QUC5jcHA7IHNvdXJjZVRyZWUgPSAiPGdyb3Vw PiI7IH07CiAJCTFBRDlEMkZEMTIwMjg0MDkwMDFBNzBEMSAvKiBQbHVnaW5TY3JpcHRhYmxlTlBP YmplY3RJbnZva2VEZWZhdWx0LmNwcCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxl RW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLmNwcDsgcGF0 aCA9IFBsdWdpblNjcmlwdGFibGVOUE9iamVjdEludm9rZURlZmF1bHQuY3BwOyBzb3VyY2VUcmVl ID0gIjxncm91cD4iOyB9OwogCQkxQUZGNjZCQjEzN0RFQTgzMDA3OTE2OTYgLyogR2V0VVJMTm90 aWZ5V2l0aFVSTFRoYXRGYWlsc1RvTG9hZC5jcHAgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5j ZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5j cHA7IHBhdGggPSBHZXRVUkxOb3RpZnlXaXRoVVJMVGhhdEZhaWxzVG9Mb2FkLmNwcDsgc291cmNl VHJlZSA9ICI8Z3JvdXA+IjsgfTsKKwkJMUNCNjc0MUYxOTVCQUU3QjAwMEYzNUI1IC8qIENvcmVU ZXh0LmZyYW1ld29yayAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBsYXN0S25vd25GaWxl VHlwZSA9IHdyYXBwZXIuZnJhbWV3b3JrOyBuYW1lID0gQ29yZVRleHQuZnJhbWV3b3JrOyBwYXRo ID0gU3lzdGVtL0xpYnJhcnkvRnJhbWV3b3Jrcy9Db3JlVGV4dC5mcmFtZXdvcms7IHNvdXJjZVRy ZWUgPSBTREtST09UOyB9OwogCQkyM0JDQjg4RjBFQTU3NjIzMDAzQzYyODkgLyogT3BlbkdMLmZy YW1ld29yayAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBsYXN0S25vd25GaWxlVHlwZSA9 IHdyYXBwZXIuZnJhbWV3b3JrOyBuYW1lID0gT3BlbkdMLmZyYW1ld29yazsgcGF0aCA9IC9TeXN0 ZW0vTGlicmFyeS9GcmFtZXdvcmtzL09wZW5HTC5mcmFtZXdvcms7IHNvdXJjZVRyZWUgPSAiPGFi c29sdXRlPiI7IH07CiAJCTI5Q0ZCQTBFMTIyNzM2RTYwMEJDMzBDMCAvKiBBY2Nlc3NpYmlsaXR5 VGV4dE1hcmtlci5oICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9 IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBBY2Nlc3NpYmls aXR5VGV4dE1hcmtlci5oOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQkyOUNGQkEwRjEy MjczNkU2MDBCQzMwQzAgLyogQWNjZXNzaWJpbGl0eVRleHRNYXJrZXIuY3BwICovID0ge2lzYSA9 IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0g c291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gQWNjZXNzaWJpbGl0eVRleHRNYXJrZXIuY3BwOyBz b3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwpAQCAtNDI0LDYgKzQyNiw3IEBACiAJCQlpc2EgPSBQ QlhGcmFtZXdvcmtzQnVpbGRQaGFzZTsKIAkJCWJ1aWxkQWN0aW9uTWFzayA9IDIxNDc0ODM2NDc7 CiAJCQlmaWxlcyA9ICgKKwkJCQkxQ0I2NzQyMDE5NUJBRTdCMDAwRjM1QjUgLyogQ29yZVRleHQu ZnJhbWV3b3JrIGluIEZyYW1ld29ya3MgKi8sCiAJCQkpOwogCQkJcnVuT25seUZvckRlcGxveW1l bnRQb3N0cHJvY2Vzc2luZyA9IDA7CiAJCX07CkBAIC03MDcsNiArNzEwLDcgQEAKIAkJQTgwM0ZG NjQwOUNBQUNDMTAwOUIyQTM3IC8qIEZyYW1ld29ya3MgKi8gPSB7CiAJCQlpc2EgPSBQQlhHcm91 cDsKIAkJCWNoaWxkcmVuID0gKAorCQkJCTFDQjY3NDFGMTk1QkFFN0IwMDBGMzVCNSAvKiBDb3Jl VGV4dC5mcmFtZXdvcmsgKi8sCiAJCQkJMUE3OTYxMDYxODAzNDU0QzAwRkU0MkNEIC8qIElPS2l0 LmZyYW1ld29yayAqLywKIAkJCQlCQ0IyODRCMjBDRkE4MkNCMDA3RTUzM0UgLyogQXBwbGljYXRp b25TZXJ2aWNlcy5mcmFtZXdvcmsgKi8sCiAJCQkJQUU4MjU3RUYwOEQyMjM4OTAwMDUwN0FCIC8q IENhcmJvbi5mcmFtZXdvcmsgKi8sCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9t YWMvRHVtcFJlbmRlclRyZWUubW0gYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRl clRyZWUubW0KaW5kZXggZmFlYjI4ZDMxOTZlY2E0ZTc2NTZkZWY3OWJmYjlkNGFhNjViNTEwMC4u MDc5NjNkYmZlYWZhNThhZWE5NjVmM2I2NTE2MzAyZjRiMTEwODI0NyAxMDA2NDQKLS0tIGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQpAQCAtNTI5LDcgKzUyOSw5IEBAIHN0YXRp YyB2b2lkIGFjdGl2YXRlRm9udElPUyhjb25zdCB1aW50OF90KiBmb250RGF0YSwgdW5zaWduZWQg bG9uZyBsZW5ndGgsIHN0ZDo6CiAgICAgICAgIGV4aXQoMSk7CiAgICAgfQogCi0gICAgaWYgKCFH U0ZvbnRBZGRDR0ZvbnQoY2dGb250KSkgeworICAgIENGRXJyb3JSZWYgZXJyb3IgPSBudWxscHRy OworICAgIENURm9udE1hbmFnZXJSZWdpc3RlckdyYXBoaWNzRm9udChjZ0ZvbnQsICZlcnJvcik7 CisgICAgaWYgKGVycm9yKSB7CiAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiRmFpbGVkIHRvIGFk ZCBDR0ZvbnQgdG8gR3JhcGhpY3NTZXJ2aWNlcyBmb3IgdGhlICVzIGZvbnQuXG4iLCBzZWN0aW9u TmFtZS5jX3N0cigpKTsKICAgICAgICAgZXhpdCgxKTsKICAgICB9Cg==