13413 2007-04-19 15:58:48 -0700 Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets 2007-06-18 10:07:02 -0700 1 1 1 Unclassified WebKit DOM 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://docs.google.com/ GoogleBug P2 Normal --- 1 aroben webkit-unassigned adele aroben justin.garcia oldest_to_newest 13947 0 aroben 2007-04-19 15:58:48 -0700 I'm seeing an assertion failure whenever I try to view a spreadsheet in Google Spreadsheets: 0x011859c0 in WebCore::RenderTextControl::setSelectionRange (this=0x17e426ec, start=0, end=0) at /Volumes/Data/Users/adamroben/dev/WebKit/OpenSource/WebCore/rendering/RenderTextControl.cpp:433 433 ASSERT(startPosition.isNotNull() && endPosition.isNotNull()); Repro steps: 1. Go to http://docs.google.com/ and log in 2. Click the "New spreadsheet" link 3. Click "OK" in the alert that tells you Safari is not supported Here's a bit of the backtrace: #0 0x011859c0 in WebCore::RenderTextControl::setSelectionRange (this=0x17e426ec, start=0, end=0) at /Volumes/Data/Users/adamroben/dev/WebKit/OpenSource/WebCore/rendering/RenderTextControl.cpp:433 #1 0x010ad23b in WebCore::HTMLTextAreaElement::setSelectionRange (this=0x17e4c5f0, start=0, end=0) at /Volumes/Data/Users/adamroben/dev/WebKit/OpenSource/WebCore/html/HTMLTextAreaElement.cpp:123 #2 0x010ad864 in WebCore::HTMLTextAreaElement::updateFocusAppearance (this=0x17e4c5f0, restorePreviousSelection=true) at /Volumes/Data/Users/adamroben/dev/WebKit/OpenSource/WebCore/html/HTMLTextAreaElement.cpp:229 #3 0x010ad7d0 in WebCore::HTMLTextAreaElement::focus (this=0x17e4c5f0) at /Volumes/Data/Users/adamroben/dev/WebKit/OpenSource/WebCore/html/HTMLTextAreaElement.cpp:218 #4 0x012a70bd in WebCore::JSHTMLTextAreaElementPrototypeFunction::callAsFunction (this=0x17c2d3e0, exec=0xbfffc43c, thisObj=0x17a33e50, args=@0xbfffc168) at /Volumes/Data/development/BuildProducts/Debug/DerivedSources/WebCore/JSHTMLTextAreaElement.cpp:271 #5 0x006918fa in KJS::JSObject::call (this=0x17c2d3e0, exec=0xbfffc43c, thisObj=0x17a33e50, args=@0xbfffc168) at /Volumes/Data/Users/adamroben/dev/WebKit/OpenSource/JavaScriptCore/kjs/object.cpp:97 13906 1 14099 mitz 2007-04-19 16:53:46 -0700 Created attachment 14099 Reduction 11484 2 14298 mitz 2007-05-01 13:03:27 -0700 Created attachment 14298 Possible fix This fixes the reduction, but given bug 13467 I'm not sure what's the effect on Google Spreadsheets. There is also a subtle difference from Firefox, which allows you to enter text into a 0-height textarea. I don't know if it makes a difference in practice. 11486 3 14298 mitz 2007-05-01 13:28:42 -0700 Comment on attachment 14298 Possible fix With this patch, after rolling out r20972 (which caused bug 13467), I don't hit the assert in Google Spreadsheets and it seems to function okay, in that i can type into the first cell without having to click or do anything to focus it. 7656 4 15006 mitz 2007-06-13 13:50:58 -0700 Created attachment 15006 Do not set the selection in zero-height text controls Same as before, now with change log and a layout test. 7658 5 15006 adele 2007-06-13 13:54:01 -0700 Comment on attachment 15006 Do not set the selection in zero-height text controls This seems reasonable to me 7194 6 mrowe 2007-06-18 10:07:02 -0700 Landed in r23565. 14099 2007-04-19 16:53:46 -0700 2007-04-19 16:53:46 -0700 Reduction 13413 reduction.html text/html 73 mitz VGFiIGludG8gdGhpcyAwLWhlaWdodCB0ZXh0YXJlYToKPHRleHRhcmVhIHN0eWxlPSJoZWlnaHQ6 IDAiPjwvdGV4dGFyZWE+Cg== 14298 2007-05-01 13:03:27 -0700 2007-06-13 13:50:58 -0700 Possible fix 13413_r0.patch text/plain 627 mitz SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHAJKHJldmlzaW9uIDIx MjA2KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00MTYsNyArNDE2LDcgQEAgdm9pZCBSZW5kZXJUZXh0Q29udHJvbDo6c2V0U2Vs ZWN0aW9uUmFuZwogCiAgICAgZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0KCk7CiAKLSAgICBpZiAo c3R5bGUoKS0+dmlzaWJpbGl0eSgpID09IEhJRERFTikgeworICAgIGlmIChzdHlsZSgpLT52aXNp YmlsaXR5KCkgPT0gSElEREVOIHx8ICFtX2lubmVyVGV4dCB8fCAhbV9pbm5lclRleHQtPnJlbmRl cmVyKCkgfHwgIW1faW5uZXJUZXh0LT5yZW5kZXJlcigpLT5oZWlnaHQoKSkgewogICAgICAgICBp ZiAobV9tdWx0aUxpbmUpCiAgICAgICAgICAgICBzdGF0aWNfY2FzdDxIVE1MVGV4dEFyZWFFbGVt ZW50Kj4obm9kZSgpKS0+Y2FjaGVTZWxlY3Rpb24oc3RhcnQsIGVuZCk7CiAgICAgICAgIGVsc2UK 15006 2007-06-13 13:50:58 -0700 2007-06-13 13:54:01 -0700 Do not set the selection in zero-height text controls 13413_r1.patch text/plain 3239 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzUwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDctMDYtMTMgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDEzCisgICAgICAgICAg RmFpbGVkIGFzc2VydGlvbiBpbiBSZW5kZXJUZXh0Q29udHJvbDo6c2V0U2VsZWN0aW9uUmFuZ2Ug aW4gR29vZ2xlIFNwcmVhZHNoZWV0cworCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvaW5wdXQt emVyby1oZWlnaHQtZm9jdXMuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRleHRD b250cm9sLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHRDb250cm9sOjpzZXRTZWxl Y3Rpb25SYW5nZSk6IEF2b2lkIHNldHRpbmcgdGhlCisgICAgICAgIHNlbGVjdGlvbiBpbiBhIHpl cm8taGVpZ2h0IHRleHQgY29udHJvbC4KKwogMjAwNy0wNi0xMyAgU2ltb24gSGF1c21hbm4gIDxo YXVzbWFubkBrZGUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IExhcnMuCkluZGV4OiBXZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwCShyZXZpc2lvbiAyMzQ4MykKKysrIFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDIxLDcgKzQyMSw3IEBAIHZvaWQgUmVuZGVyVGV4dENvbnRyb2w6OnNldFNlbGVjdGlvblJhbmcK IAogICAgIGRvY3VtZW50KCktPnVwZGF0ZUxheW91dCgpOwogCi0gICAgaWYgKHN0eWxlKCktPnZp c2liaWxpdHkoKSA9PSBISURERU4pIHsKKyAgICBpZiAoc3R5bGUoKS0+dmlzaWJpbGl0eSgpID09 IEhJRERFTiB8fCAhbV9pbm5lclRleHQgfHwgIW1faW5uZXJUZXh0LT5yZW5kZXJlcigpIHx8ICFt X2lubmVyVGV4dC0+cmVuZGVyZXIoKS0+aGVpZ2h0KCkpIHsKICAgICAgICAgaWYgKG1fbXVsdGlM aW5lKQogICAgICAgICAgICAgc3RhdGljX2Nhc3Q8SFRNTFRleHRBcmVhRWxlbWVudCo+KG5vZGUo KSktPmNhY2hlU2VsZWN0aW9uKHN0YXJ0LCBlbmQpOwogICAgICAgICBlbHNlCkluZGV4OiBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy ZXZpc2lvbiAyMzUwNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDA3LTA2LTEzICBNaXR6IFBldHRlbCAgPG1pdHpAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIHRl c3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDEzCisgICAg ICAgICAgRmFpbGVkIGFzc2VydGlvbiBpbiBSZW5kZXJUZXh0Q29udHJvbDo6c2V0U2VsZWN0aW9u UmFuZ2UgaW4gR29vZ2xlIFNwcmVhZHNoZWV0cworCisgICAgICAgICogZmFzdC9mb3Jtcy9pbnB1 dC16ZXJvLWhlaWdodC1mb2N1cy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv Zm9ybXMvaW5wdXQtemVyby1oZWlnaHQtZm9jdXMuaHRtbDogQWRkZWQuCisKIDIwMDctMDYtMTAg IEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBCZXRoIERha2luLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC16ZXJvLWhl aWdodC1mb2N1cy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9pbnB1dC16ZXJvLWhlaWdodC1mb2N1cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LXplcm8taGVpZ2h0LWZvY3VzLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1IEBACitUZXN0IGZvciBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQxMyBGYWlsZWQgYXNzZXJ0aW9uIGluIFJlbmRl clRleHRDb250cm9sOjpzZXRTZWxlY3Rpb25SYW5nZSBpbiBHb29nbGUgU3ByZWFkc2hlZXRzLgor CitUaGlzIHRlc3Qgc2hvdWxkIG5vdCBBU1NFUlQuCisKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9pbnB1dC16ZXJvLWhlaWdodC1mb2N1cy5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtemVyby1oZWlnaHQtZm9jdXMuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtemVyby1oZWlnaHQtZm9jdXMuaHRt bAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPHA+CisgICAgVGVzdCBmb3IgPGk+PGEg aHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MTMiPmh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDEzPC9hPgorICAgIEZhaWxlZCBh c3NlcnRpb24gaW4gUmVuZGVyVGV4dENvbnRyb2w6OnNldFNlbGVjdGlvblJhbmdlIGluIEdvb2ds ZSBTcHJlYWRzaGVldHM8L2k+LgorPC9wPgorPHA+CisgICAgVGhpcyB0ZXN0IHNob3VsZCBub3Qg QVNTRVJULgorPC9wPgorPHRleHRhcmVhIGlkPSJ0YXJnZXQiIHN0eWxlPSJoZWlnaHQ6IDAiPjwv dGV4dGFyZWE+Cis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0IikuZm9jdXMoKTsKKzwvc2NyaXB0Pgo=