<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134124</bug_id>
          
          <creation_ts>2014-06-20 14:32:14 -0700</creation_ts>
          <short_desc>Mark TextRun&apos;s constructors as explicit</short_desc>
          <delta_ts>2014-07-21 12:06:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Myles C. Maxfield">mmaxfield</reporter>
          <assigned_to name="Myles C. Maxfield">mmaxfield</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>jonlee</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1017050</commentid>
    <comment_count>0</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2014-06-20 14:32:14 -0700</bug_when>
    <thetext>Mark TextRun&apos;s constructors as explicit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1017053</commentid>
    <comment_count>1</comment_count>
      <attachid>233457</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2014-06-20 14:35:08 -0700</bug_when>
    <thetext>Created attachment 233457
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1017307</commentid>
    <comment_count>2</comment_count>
      <attachid>233457</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-06-21 11:27:46 -0700</bug_when>
    <thetext>Comment on attachment 233457
Patch

Clearing flags on attachment: 233457

Committed r170247: &lt;http://trac.webkit.org/changeset/170247&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1017308</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-06-21 11:27:49 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1023738</commentid>
    <comment_count>4</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-07-21 12:05:06 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1023739</commentid>
    <comment_count>5</comment_count>
      <attachid>235234</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-07-21 12:05:10 -0700</bug_when>
    <thetext>Created attachment 235234
Ignore. Accidentally added to wrong bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1023740</commentid>
    <comment_count>6</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-07-21 12:06:58 -0700</bug_when>
    <thetext>Re-closing. Nothing to see here!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>233457</attachid>
            <date>2014-06-20 14:35:08 -0700</date>
            <delta_ts>2014-07-21 12:04:58 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-134124-20140620143446.patch</filename>
            <type>text/plain</type>
            <size>2798</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU5NDBkNjI0OTZiMWRi
NjY5NmUwZTFmMTE4ZGIxNGMzYzRlMTM3ZS4uOGYyYWI5NGY2YTE3N2MxZjJkMDY4NmUwOWEwYmI4
MTFhNzU0NWEwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE0LTA2LTIwICBNeWxl
cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFyayBUZXh0
UnVuJ3MgY29uc3RydWN0b3JzIGFzIGV4cGxpY2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQxMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciByMTcwMDcyLCBub2JvZHkgaXMgaW1wbGljaXRs
eSBjb252ZXJ0aW5nIGEgc3RyaW5nIHRvIGEgVGV4dFJ1bi4gVGhlcmVmb3JlLAorICAgICAgICB3
ZSBjYW4gbWFrZSB0aGUgY29uc3RydWN0b3JzIGV4cGxpY2l0LgorCisgICAgICAgIE5vIG5ldyB0
ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBs
YXRmb3JtL2dyYXBoaWNzL1RleHRSdW4uaDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRSdW46OlRl
eHRSdW4pOgorCisyMDE0LTA2LTIwICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBs
ZS5jb20+CisKICAgICAgICAgUmVtb3ZpbmcgZGVhZCBjb2RlIGluIHBsYXRmb3JtL2dyYXBoaWNz
L2dwdQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0
MDY1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RleHRS
dW4uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RleHRSdW4uaAppbmRleCAz
NzIwODQ1NmViM2M5YzM2NWRjNTYyZmMzNWUwMzRjMGUxNTI1MmQxLi4zZTFmZjczNjBhMzBhYmRl
YTI2MTI3NzkxY2M0YjBjMDM3YTNmNTZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9UZXh0UnVuLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh
cGhpY3MvVGV4dFJ1bi5oCkBAIC0xMDEsNyArMTAxLDcgQEAgcHVibGljOgogICAgICAgICBtX2Rh
dGEuY2hhcmFjdGVyczE2ID0gYzsKICAgICB9CiAgICAgCi0gICAgVGV4dFJ1bihjb25zdCBTdHJp
bmcmIHMsIGZsb2F0IHhwb3MgPSAwLCBmbG9hdCBleHBhbnNpb24gPSAwLCBFeHBhbnNpb25CZWhh
dmlvciBleHBhbnNpb25CZWhhdmlvciA9IEFsbG93VHJhaWxpbmdFeHBhbnNpb24gfCBGb3JiaWRM
ZWFkaW5nRXhwYW5zaW9uLCBUZXh0RGlyZWN0aW9uIGRpcmVjdGlvbiA9IExUUiwgYm9vbCBkaXJl
Y3Rpb25hbE92ZXJyaWRlID0gZmFsc2UsIGJvb2wgY2hhcmFjdGVyU2NhbkZvckNvZGVQYXRoID0g
dHJ1ZSwgUm91bmRpbmdIYWNrcyByb3VuZGluZ0hhY2tzID0gUnVuUm91bmRpbmcgfCBXb3JkUm91
bmRpbmcpCisgICAgZXhwbGljaXQgVGV4dFJ1bihjb25zdCBTdHJpbmcmIHMsIGZsb2F0IHhwb3Mg
PSAwLCBmbG9hdCBleHBhbnNpb24gPSAwLCBFeHBhbnNpb25CZWhhdmlvciBleHBhbnNpb25CZWhh
dmlvciA9IEFsbG93VHJhaWxpbmdFeHBhbnNpb24gfCBGb3JiaWRMZWFkaW5nRXhwYW5zaW9uLCBU
ZXh0RGlyZWN0aW9uIGRpcmVjdGlvbiA9IExUUiwgYm9vbCBkaXJlY3Rpb25hbE92ZXJyaWRlID0g
ZmFsc2UsIGJvb2wgY2hhcmFjdGVyU2NhbkZvckNvZGVQYXRoID0gdHJ1ZSwgUm91bmRpbmdIYWNr
cyByb3VuZGluZ0hhY2tzID0gUnVuUm91bmRpbmcgfCBXb3JkUm91bmRpbmcpCiAgICAgICAgIDog
bV9jaGFyYWN0ZXJzTGVuZ3RoKHMubGVuZ3RoKCkpCiAgICAgICAgICwgbV9sZW4ocy5sZW5ndGgo
KSkKICAgICAgICAgLCBtX3hwb3MoeHBvcykKQEAgLTEyNiw3ICsxMjYsNyBAQCBwdWJsaWM6CiAg
ICAgICAgIH0KICAgICB9CiAKLSAgICBUZXh0UnVuKFN0cmluZ1ZpZXcgcywgZmxvYXQgeHBvcyA9
IDAsIGZsb2F0IGV4cGFuc2lvbiA9IDAsIEV4cGFuc2lvbkJlaGF2aW9yIGV4cGFuc2lvbkJlaGF2
aW9yID0gQWxsb3dUcmFpbGluZ0V4cGFuc2lvbiB8IEZvcmJpZExlYWRpbmdFeHBhbnNpb24sIFRl
eHREaXJlY3Rpb24gZGlyZWN0aW9uID0gTFRSLCBib29sIGRpcmVjdGlvbmFsT3ZlcnJpZGUgPSBm
YWxzZSwgYm9vbCBjaGFyYWN0ZXJTY2FuRm9yQ29kZVBhdGggPSB0cnVlLCBSb3VuZGluZ0hhY2tz
IHJvdW5kaW5nSGFja3MgPSBSdW5Sb3VuZGluZyB8IFdvcmRSb3VuZGluZykKKyAgICBleHBsaWNp
dCBUZXh0UnVuKFN0cmluZ1ZpZXcgcywgZmxvYXQgeHBvcyA9IDAsIGZsb2F0IGV4cGFuc2lvbiA9
IDAsIEV4cGFuc2lvbkJlaGF2aW9yIGV4cGFuc2lvbkJlaGF2aW9yID0gQWxsb3dUcmFpbGluZ0V4
cGFuc2lvbiB8IEZvcmJpZExlYWRpbmdFeHBhbnNpb24sIFRleHREaXJlY3Rpb24gZGlyZWN0aW9u
ID0gTFRSLCBib29sIGRpcmVjdGlvbmFsT3ZlcnJpZGUgPSBmYWxzZSwgYm9vbCBjaGFyYWN0ZXJT
Y2FuRm9yQ29kZVBhdGggPSB0cnVlLCBSb3VuZGluZ0hhY2tzIHJvdW5kaW5nSGFja3MgPSBSdW5S
b3VuZGluZyB8IFdvcmRSb3VuZGluZykKICAgICAgICAgOiBtX2NoYXJhY3RlcnNMZW5ndGgocy5s
ZW5ndGgoKSkKICAgICAgICAgLCBtX2xlbihzLmxlbmd0aCgpKQogICAgICAgICAsIG1feHBvcyh4
cG9zKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>235234</attachid>
            <date>2014-07-21 12:05:10 -0700</date>
            <delta_ts>2014-07-21 12:06:36 -0700</delta_ts>
            <desc>Ignore. Accidentally added to wrong bug.</desc>
            <filename>bug-134124-20140721120423.patch</filename>
            <type>text/plain</type>
            <size>1808</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli
cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxMzA5KQorKysgV2ViS2l0TGlicmFyaWVzL0No
YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA3LTIxICBCcmVu
dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIEV4dGVuZCBh
dXRvLXZlcnNpb24ucGwgdG8gaGFuZGxlIDUtdHVwbGUgdmVyc2lvbnMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDEyNAorICAgICAgICA8cmRhcjov
L3Byb2JsZW0vMTc3NTAzMzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgRXh0ZW5kIHR1cGxlIHBhcnNpbmcgdG8gaGFuZGxlIHVwIHRvIGZpdmUgdHVw
bGVzLCBhbmQgYXMKKyAgICAgICAgZmV3IGFzIGEgc2luZ2xlIHR1cGxlLiBPbiBXaW5kb3dzLCB0
aGUgdHdvIGFkZGl0aW9uYWwKKyAgICAgICAgdHVwbGVzIGFyZSB1bnVzZWQuCisKKyAgICAgICAg
KiB3aW4vdG9vbHMvc2NyaXB0cy9hdXRvLXZlcnNpb24ucGw6CisKIDIwMTQtMDctMjEgIEJyZW50
IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gQ29ycmVjdCBh
dXRvLXZlcnNpb24ucGwgc2NyaXB0IGZvciB0d28tZGlnaXQgdmVyc2lvbiBudW1iZXJzCkluZGV4
OiBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3NjcmlwdHMvYXV0by12ZXJzaW9uLnBsCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvc2NyaXB0cy9hdXRvLXZlcnNpb24u
cGwJKHJldmlzaW9uIDE3MTMwNSkKKysrIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvc2NyaXB0
cy9hdXRvLXZlcnNpb24ucGwJKHdvcmtpbmcgY29weSkKQEAgLTcxLDEwICs3MSwxMyBAQCBjaG9t
cCgkUFJPUE9TRURfVkVSU0lPTik7CiAjIFNwbGl0IG91dCB0aGUgdGhyZWUgY29tcG9uZW50cyBv
ZiB0aGUgZG90dGVkIHZlcnNpb24gbnVtYmVyLiAgV2UgcGFkCiAjIHRoZSBpbnB1dCB3aXRoIHRy
YWlsaW5nIGRvdHMgdG8gaGFuZGxlIHRoZSBjYXNlIHdoZXJlIHRoZSBpbnB1dCB2ZXJzaW9uCiAj
IGhhcyBmZXdlciBjb21wb25lbnRzIHRoYW4gd2UgZXhwZWN0LgotJFBST1BPU0VEX1ZFUlNJT04g
PX4gbS9eKD86KFxkKylcLik/KD86KFxkKylcLik/KFwqfFxkKykkLyBvciBkaWUgIkNvdWxkbid0
IHBhcnNlICRQUk9QT1NFRF9WRVJTSU9OIjsKKyRQUk9QT1NFRF9WRVJTSU9OID1+IG0vXig/Oihc
ZCspXC4pPyg/OihcZCspXC4pPyg/OihcZCspXC4pPyg/OihcZCspXC4pPyhcKnxcZCspJC8gb3Ig
ZGllICJDb3VsZG4ndCBwYXJzZSAkUFJPUE9TRURfVkVSU0lPTiI7CiBteSAkQlVJTERfTUFKT1Jf
VkVSU0lPTiA9ICQxOwogbXkgJEJVSUxEX01JTk9SX1ZFUlNJT04gPSAkMjsKIG15ICRCVUlMRF9U
SU5ZX1ZFUlNJT04gPSAkMzsKK2lmICghZGVmaW5lZCAkMykgeworICAgICRCVUlMRF9USU5ZX1ZF
UlNJT04gPSAkNTsKK30KIAogIyBUaGUgZGVmYXVsdCB2ZXJzaW9uICh3aXRoIG5vIGRlY2ltYWxz
KSB3aWxsIGJlIG1hdGNoZWQgYnkgdGhlIHJlZ2V4cAogIyB0byAkQlVJTERfVElOWV9WRVJTSU9O
LiBJZiB0aGF0IGhhcHBlbnMsIHdlIG5lZWQgdG8gbW92ZSBpdCB0bwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>