134119 2014-06-20 13:49:56 -0700 Add copy/move constructors and assignment operators to WTF::Optional 2014-06-20 13:55:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 1017016 0 andersca 2014-06-20 13:49:56 -0700 Add copy/move constructors and assignment operators to WTF::Optional 1017017 1 233449 andersca 2014-06-20 13:50:22 -0700 Created attachment 233449 Patch 1017020 2 233449 kling 2014-06-20 13:54:26 -0700 Comment on attachment 233449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233449&action=review r=me with a bug fix: > Source/WTF/wtf/Optional.h:137 > + new (NotNull, std::addressof(m_value)) T(std::forward<U>(u)); > + return *this; Missing "m_isEngaged = true;" here. 1017021 3 andersca 2014-06-20 13:55:30 -0700 Committed r170202: <http://trac.webkit.org/changeset/170202> 233449 2014-06-20 13:50:22 -0700 2014-06-20 13:54:25 -0700 Patch bug-134119-20140620135000.patch text/plain 3096 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDM1MWQwZTdlOTBiZjI2NjliZjE4MTdm MmQ2NGM4MDE3ZTBhNzJkMTIuLmRkZWM5YzJkMDk0NDgwNjM2NmI0NjhkNGJiYjAzZGM4NTk1OWU4 OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDYtMjAgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgY29weS9tb3ZlIGNvbnN0cnVjdG9ycyBh bmQgYXNzaWdubWVudCBvcGVyYXRvcnMgdG8gV1RGOjpPcHRpb25hbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MTE5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvT3B0aW9uYWwuaDoKKyAgICAg ICAgKFdURjo6T3B0aW9uYWw6Ok9wdGlvbmFsKToKKyAgICAgICAgKFdURjo6T3B0aW9uYWw6Om9w ZXJhdG9yPSk6CisKIDIwMTQtMDYtMTkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgV1RGOjpPcHRpb25hbCBjbGFzcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvT3B0aW9uYWwuaCBiL1NvdXJjZS9XVEYvd3RmL09wdGlvbmFsLmgKaW5kZXgg ZjNkNjhjYjgyYzMxMDFmZTJlMDczZWE4OTgxMzZiNDcxMjQzOTEyYi4uZWU4YTMxOWRkODhlZGM4 YzY2MDEwNTM5MTZiZjljMzFiODhhN2IyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvT3B0 aW9uYWwuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9PcHRpb25hbC5oCkBAIC0yOCw2ICsyOCw3IEBA CiAKICNpbmNsdWRlIDx0eXBlX3RyYWl0cz4KICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgor I2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAogLy8gV1RGOjpPcHRpb25hbCBpcyBhIGNs YXNzIGJhc2VkIG9uIHN0ZDo6b3B0aW9uYWwsIGRlc2NyaWJlZCBoZXJlOgogLy8gaHR0cDovL3d3 dy5vcGVuLXN0ZC5vcmcvSlRDMS9TQzIyL1dHMjEvZG9jcy9wYXBlcnMvMjAxMy9uMzUyNy5odG1s CkBAIC01Nyw2ICs1OCwyMCBAQCBwdWJsaWM6CiAgICAgewogICAgIH0KIAorICAgIE9wdGlvbmFs KGNvbnN0IE9wdGlvbmFsJiBvdGhlcikKKyAgICAgICAgOiBtX2lzRW5nYWdlZChvdGhlci5tX2lz RW5nYWdlZCkKKyAgICB7CisgICAgICAgIGlmIChtX2lzRW5nYWdlZCkKKyAgICAgICAgICAgIG5l dyAoTm90TnVsbCwgc3RkOjphZGRyZXNzb2YobV92YWx1ZSkpIFQob3RoZXIubV92YWx1ZSk7Cisg ICAgfQorCisgICAgT3B0aW9uYWwoT3B0aW9uYWwmJiBvdGhlcikKKyAgICAgICAgOiBtX2lzRW5n YWdlZChvdGhlci5tX2lzRW5nYWdlZCkKKyAgICB7CisgICAgICAgIGlmIChtX2lzRW5nYWdlZCkK KyAgICAgICAgICAgIG5ldyAoTm90TnVsbCwgc3RkOjphZGRyZXNzb2YobV92YWx1ZSkpIFQoc3Rk Ojptb3ZlKG90aGVyLm1fdmFsdWUpKTsKKyAgICB9CisKICAgICBPcHRpb25hbChUJiYgdmFsdWUp CiAgICAgICAgIDogbV9pc0VuZ2FnZWQodHJ1ZSkKICAgICAgICAgLCBtX3ZhbHVlKHN0ZDo6bW92 ZSh2YWx1ZSkpCkBAIC02OCw3ICs4Myw2IEBAIHB1YmxpYzoKICAgICAgICAgOiBtX2lzRW5nYWdl ZCh0cnVlKQogICAgICAgICAsIG1fdmFsdWUoc3RkOjpmb3J3YXJkPEFyZ3M+KGFyZ3MpLi4uKQog ICAgIHsKLQogICAgIH0KIAogICAgIH5PcHRpb25hbCgpCkBAIC03Nyw2ICs5MSw1MiBAQCBwdWJs aWM6CiAgICAgICAgICAgICBtX3ZhbHVlLn5UKCk7CiAgICAgfQogCisgICAgT3B0aW9uYWwmIG9w ZXJhdG9yPShjb25zdCBPcHRpb25hbCYgb3RoZXIpCisgICAgeworICAgICAgICBpZiAobV9pc0Vu Z2FnZWQgPT0gb3RoZXIubV9pc0VuZ2FnZWQpIHsKKyAgICAgICAgICAgIGlmIChtX2lzRW5nYWdl ZCkKKyAgICAgICAgICAgICAgICBtX3ZhbHVlID0gb3RoZXIubV92YWx1ZTsKKyAgICAgICAgICAg IHJldHVybiAqdGhpczsKKyAgICAgICAgfQorCisgICAgICAgIGlmIChtX2lzRW5nYWdlZCkKKyAg ICAgICAgICAgIG1fdmFsdWUuflQoKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbmV3IChO b3ROdWxsLCBzdGQ6OmFkZHJlc3NvZihtX3ZhbHVlKSkgVChvdGhlci5tX3ZhbHVlKTsKKyAgICAg ICAgbV9pc0VuZ2FnZWQgPSBvdGhlci5tX2lzRW5nYWdlZDsKKworICAgICAgICByZXR1cm4gKnRo aXM7CisgICAgfQorCisgICAgT3B0aW9uYWwmIG9wZXJhdG9yPShPcHRpb25hbCYmIG90aGVyKQor ICAgIHsKKyAgICAgICAgaWYgKG1faXNFbmdhZ2VkID09IG90aGVyLm1faXNFbmdhZ2VkKSB7Cisg ICAgICAgICAgICBpZiAobV9pc0VuZ2FnZWQpCisgICAgICAgICAgICAgICAgbV92YWx1ZSA9IHN0 ZDo6bW92ZShvdGhlci5tX3ZhbHVlKTsKKyAgICAgICAgICAgIHJldHVybiAqdGhpczsKKyAgICAg ICAgfQorCisgICAgICAgIGlmIChtX2lzRW5nYWdlZCkKKyAgICAgICAgICAgIG1fdmFsdWUuflQo KTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbmV3IChOb3ROdWxsLCBzdGQ6OmFkZHJlc3Nv ZihtX3ZhbHVlKSkgVChzdGQ6Om1vdmUob3RoZXIubV92YWx1ZSkpOworICAgICAgICBtX2lzRW5n YWdlZCA9IG90aGVyLm1faXNFbmdhZ2VkOworCisgICAgICAgIHJldHVybiAqdGhpczsKKyAgICB9 CisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPgorICAgIE9wdGlvbmFsJiBvcGVyYXRvcj0oVSYm IHUpCisgICAgeworICAgICAgICBpZiAobV9pc0VuZ2FnZWQpIHsKKyAgICAgICAgICAgIG1fdmFs dWUgPSBzdGQ6OmZvcndhcmQ8VT4odSk7CisgICAgICAgICAgICByZXR1cm4gKnRoaXM7CisgICAg ICAgIH0KKworICAgICAgICBuZXcgKE5vdE51bGwsIHN0ZDo6YWRkcmVzc29mKG1fdmFsdWUpKSBU KHN0ZDo6Zm9yd2FyZDxVPih1KSk7CisgICAgICAgIHJldHVybiAqdGhpczsKKyAgICB9CisKICAg ICBleHBsaWNpdCBvcGVyYXRvciBib29sKCkgY29uc3QgeyByZXR1cm4gbV9pc0VuZ2FnZWQ7IH0K IAogICAgIFQmIHZhbHVlKCkK