134117 2014-06-20 13:28:32 -0700 Unreproducible crashes under WebCore::ScrollingTree::updateTreeFromStateNode() from messaging a deleted Obj-C object 2014-06-20 22:14:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin andersca bdakin cmarcelo commit-queue gyuyoung.kim jamesr luiz simon.fraser thorton tonikitoo oldest_to_newest 1017006 0 bdakin 2014-06-20 13:28:32 -0700 There are many unreproducible crashes under WebCore::ScrollingTree::updateTreeFromStateNode() from messaging a deleted Obj-C object. We suspect that we could fix this if ScrollingStateNodes retained their LayerRepresentations. <rdar://problem/17149252> 1017007 1 233446 bdakin 2014-06-20 13:32:15 -0700 Created attachment 233446 Patch 1017008 2 233446 thorton 2014-06-20 13:35:36 -0700 Comment on attachment 233446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233446&action=review > Source/WebCore/page/scrolling/ScrollingStateNode.h:179 > - PlatformLayer *m_platformLayer; > + PlatformLayer* m_platformLayer; the star was already on the right side 1017012 3 233447 bdakin 2014-06-20 13:47:25 -0700 Created attachment 233447 Patch 1017032 4 233447 simon.fraser 2014-06-20 14:05:08 -0700 Comment on attachment 233447 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233447&action=review > Source/WebCore/page/scrolling/ScrollingStateNode.h:88 > + LayerRepresentation(const LayerRepresentation& other) > + : m_platformLayer(other.m_platformLayer) > + , m_layerID(other.m_layerID) > + , m_representation(other.m_representation) This fails to assign m_graphicsLayer. > Source/WebCore/page/scrolling/ScrollingStateNode.h:133 > + LayerRepresentation& operator=(const LayerRepresentation& other) > + { > + m_platformLayer = other.m_platformLayer; > + m_layerID = other.m_layerID; > + m_representation = other.m_representation; > + > + if (m_representation == PlatformLayerRepresentation) > + retainPlatformLayer(m_platformLayer); > + > + return *this; > + } This fails to copy m_graphicsLayer. 1017133 5 bdakin 2014-06-20 16:44:55 -0700 Thanks, Simon! http://trac.webkit.org/changeset/170224 1017194 6 gyuyoung.kim 2014-06-20 22:14:53 -0700 (In reply to comment #5) > Thanks, Simon! http://trac.webkit.org/changeset/170224 I add retainPlatformLayer() and releasePlatformLayer() to EFL port in order to fix a build break since r170224. http://trac.webkit.org/changeset/170229 233446 2014-06-20 13:32:15 -0700 2014-06-20 13:47:25 -0700 Patch for-review.txt text/plain 5170 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDE5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA2LTIwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MTE3CisgICAgICAgIFVucmVwcm9kdWNpYmxlIGNyYXNoZXMg dW5kZXIgV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZTo6dXBkYXRlVHJlZUZyb21TdGF0ZU5vZGUoKSAK KyAgICAgICAgZnJvbSBtZXNzYWdpbmcgYSBkZWxldGVkIE9iai1DIG9iamVjdAorICAgICAgICAt YW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzE0OTI1Mj4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEg c3BlY3VsYXRpdmUgZml4LiBJdCBtYWtlcyBMYXllclJlcHJlc2VudGF0aW9uIHJldGFpbiBtX3Bs YXRmb3JtTGF5ZXIuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgKiBwYWdl L3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVy UmVwcmVzZW50YXRpb246OkxheWVyUmVwcmVzZW50YXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6 TGF5ZXJSZXByZXNlbnRhdGlvbjo6fkxheWVyUmVwcmVzZW50YXRpb24pOgorICAgICAgICAoV2Vi Q29yZTo6TGF5ZXJSZXByZXNlbnRhdGlvbjo6b3BlcmF0b3I9KToKKyAgICAgICAgKFdlYkNvcmU6 OkxheWVyUmVwcmVzZW50YXRpb246Om9wZXJhdG9yPT0pOgorICAgICAgICAoV2ViQ29yZTo6TGF5 ZXJSZXByZXNlbnRhdGlvbjo6b3BlcmF0b3IgPT0pOiBEZWxldGVkLgorICAgICAgICAqIHBhZ2Uv c2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdTdGF0ZU5vZGVNYWMubW06CisgICAgICAgIChXZWJDb3Jl OjpMYXllclJlcHJlc2VudGF0aW9uOjpyZXRhaW5QbGF0Zm9ybUxheWVyKToKKyAgICAgICAgKFdl YkNvcmU6OkxheWVyUmVwcmVzZW50YXRpb246OnJlbGVhc2VQbGF0Zm9ybUxheWVyKToKKwogMjAx NC0wNi0xOSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBbaU9TIFdlYktpdDJdIE1ha2UgLXdlYmtpdC1vdmVyZmxvdy1zY3JvbGxpbmc6dG91Y2ggd29y ayBpbiBpZnJhbWVzIChicmVha3MgTVNXb3JkIHByZXZpZXdzKQpJbmRleDogU291cmNlL1dlYkNv cmUvV2ViQ29yZS5leHAuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS5l eHAuaW4JKHJldmlzaW9uIDE3MDE5OCkKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmlu CSh3b3JraW5nIGNvcHkpCkBAIC04MDUsNiArODA1LDggQEAgX19aTjdXZWJDb3JlMTlMYXllckZs dXNoU2NoZWR1bGVyQzFFUE5TXwogX19aTjdXZWJDb3JlMTlMYXllckZsdXNoU2NoZWR1bGVyQzJF UE5TXzI1TGF5ZXJGbHVzaFNjaGVkdWxlckNsaWVudEUKIF9fWk43V2ViQ29yZTE5TGF5ZXJGbHVz aFNjaGVkdWxlckQxRXYKIF9fWk43V2ViQ29yZTE5TGF5ZXJGbHVzaFNjaGVkdWxlckQyRXYKK19f Wk43V2ViQ29yZTE5TGF5ZXJSZXByZXNlbnRhdGlvbjE5cmV0YWluUGxhdGZvcm1MYXllckVQN0NB TGF5ZXIKK19fWk43V2ViQ29yZTE5TGF5ZXJSZXByZXNlbnRhdGlvbjIwcmVsZWFzZVBsYXRmb3Jt TGF5ZXJFUDdDQUxheWVyCiBfX1pON1dlYkNvcmUxOU1lZGlhU2Vzc2lvbk1hbmFnZXIxMnJlbW92 ZUNsaWVudEVQTlNfMjVNZWRpYVNlc3Npb25NYW5hZ2VyQ2xpZW50RQogX19aTjdXZWJDb3JlMTlN ZWRpYVNlc3Npb25NYW5hZ2VyMTJyZXN0cmljdGlvbnNFTlNfMTJNZWRpYVNlc3Npb245TWVkaWFU eXBlRQogX19aTjdXZWJDb3JlMTlNZWRpYVNlc3Npb25NYW5hZ2VyMTNzaGFyZWRNYW5hZ2VyRXYK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlTm9kZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0 YXRlTm9kZS5oCShyZXZpc2lvbiAxNzAxOTgpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9s bGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaAkod29ya2luZyBjb3B5KQpAQCAtNzEsMTQgKzcxLDMy IEBAIHB1YmxpYzoKICAgICAgICAgOiBtX3BsYXRmb3JtTGF5ZXIocGxhdGZvcm1MYXllcikKICAg ICAgICAgLCBtX2xheWVySUQoMCkKICAgICAgICAgLCBtX3JlcHJlc2VudGF0aW9uKFBsYXRmb3Jt TGF5ZXJSZXByZXNlbnRhdGlvbikKLSAgICB7IH0KKyAgICB7CisgICAgICAgIHJldGFpblBsYXRm b3JtTGF5ZXIocGxhdGZvcm1MYXllcik7CisgICAgfQogCiAgICAgTGF5ZXJSZXByZXNlbnRhdGlv bihHcmFwaGljc0xheWVyOjpQbGF0Zm9ybUxheWVySUQgbGF5ZXJJRCkKICAgICAgICAgOiBtX2dy YXBoaWNzTGF5ZXIobnVsbHB0cikKICAgICAgICAgLCBtX2xheWVySUQobGF5ZXJJRCkKICAgICAg ICAgLCBtX3JlcHJlc2VudGF0aW9uKFBsYXRmb3JtTGF5ZXJJRFJlcHJlc2VudGF0aW9uKQotICAg IHsgfQotICAgIAorICAgIHsKKyAgICB9CisKKyAgICBMYXllclJlcHJlc2VudGF0aW9uKGNvbnN0 IExheWVyUmVwcmVzZW50YXRpb24mIG90aGVyKQorICAgICAgICA6IG1fcGxhdGZvcm1MYXllcihv dGhlci5tX3BsYXRmb3JtTGF5ZXIpCisgICAgICAgICwgbV9sYXllcklEKG90aGVyLm1fbGF5ZXJJ RCkKKyAgICAgICAgLCBtX3JlcHJlc2VudGF0aW9uKG90aGVyLm1fcmVwcmVzZW50YXRpb24pCisg ICAgeworICAgICAgICBpZiAobV9yZXByZXNlbnRhdGlvbiA9PSBQbGF0Zm9ybUxheWVyUmVwcmVz ZW50YXRpb24pCisgICAgICAgICAgICByZXRhaW5QbGF0Zm9ybUxheWVyKG1fcGxhdGZvcm1MYXll cik7CisgICAgfQorCisgICAgfkxheWVyUmVwcmVzZW50YXRpb24oKQorICAgIHsKKyAgICAgICAg aWYgKG1fcmVwcmVzZW50YXRpb24gPT0gUGxhdGZvcm1MYXllclJlcHJlc2VudGF0aW9uKQorICAg ICAgICAgICAgcmVsZWFzZVBsYXRmb3JtTGF5ZXIobV9wbGF0Zm9ybUxheWVyKTsKKyAgICB9CisK ICAgICBvcGVyYXRvciBHcmFwaGljc0xheWVyKigpIGNvbnN0CiAgICAgewogICAgICAgICBBU1NF UlQobV9yZXByZXNlbnRhdGlvbiA9PSBHcmFwaGljc0xheWVyUmVwcmVzZW50YXRpb24pOwpAQCAt MTAxLDggKzExOSwyMCBAQCBwdWJsaWM6CiAgICAgICAgIEFTU0VSVChtX3JlcHJlc2VudGF0aW9u ICE9IFBsYXRmb3JtTGF5ZXJSZXByZXNlbnRhdGlvbik7CiAgICAgICAgIHJldHVybiBtX2xheWVy SUQ7CiAgICAgfQotICAgIAotICAgIGJvb2wgb3BlcmF0b3IgPT0oY29uc3QgTGF5ZXJSZXByZXNl bnRhdGlvbiYgb3RoZXIpIGNvbnN0CisKKyAgICBMYXllclJlcHJlc2VudGF0aW9uJiBvcGVyYXRv cj0oY29uc3QgTGF5ZXJSZXByZXNlbnRhdGlvbiYgb3RoZXIpCisgICAgeworICAgICAgICBtX3Bs YXRmb3JtTGF5ZXIgPSBvdGhlci5tX3BsYXRmb3JtTGF5ZXI7CisgICAgICAgIG1fbGF5ZXJJRCA9 IG90aGVyLm1fbGF5ZXJJRDsKKyAgICAgICAgbV9yZXByZXNlbnRhdGlvbiA9IG90aGVyLm1fcmVw cmVzZW50YXRpb247CisKKyAgICAgICAgaWYgKG1fcmVwcmVzZW50YXRpb24gPT0gUGxhdGZvcm1M YXllclJlcHJlc2VudGF0aW9uKQorICAgICAgICAgICAgcmV0YWluUGxhdGZvcm1MYXllcihtX3Bs YXRmb3JtTGF5ZXIpOworCisgICAgICAgIHJldHVybiAqdGhpczsKKyAgICB9CisKKyAgICBib29s IG9wZXJhdG9yPT0oY29uc3QgTGF5ZXJSZXByZXNlbnRhdGlvbiYgb3RoZXIpIGNvbnN0CiAgICAg ewogICAgICAgICBpZiAobV9yZXByZXNlbnRhdGlvbiAhPSBvdGhlci5tX3JlcHJlc2VudGF0aW9u KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMTQxLDkgKzE3MSwxMiBAQCBwdWJsaWM6 CiAgICAgYm9vbCByZXByZXNlbnRzUGxhdGZvcm1MYXllcklEKCkgY29uc3QgeyByZXR1cm4gbV9y ZXByZXNlbnRhdGlvbiA9PSBQbGF0Zm9ybUxheWVySURSZXByZXNlbnRhdGlvbjsgfQogICAgIAog cHJpdmF0ZToKKyAgICB2b2lkIHJldGFpblBsYXRmb3JtTGF5ZXIoUGxhdGZvcm1MYXllciopOwor ICAgIHZvaWQgcmVsZWFzZVBsYXRmb3JtTGF5ZXIoUGxhdGZvcm1MYXllciopOworCiAgICAgdW5p b24gewogICAgICAgICBHcmFwaGljc0xheWVyKiBtX2dyYXBoaWNzTGF5ZXI7Ci0gICAgICAgIFBs YXRmb3JtTGF5ZXIgKm1fcGxhdGZvcm1MYXllcjsKKyAgICAgICAgUGxhdGZvcm1MYXllciogbV9w bGF0Zm9ybUxheWVyOwogICAgIH07CiAKICAgICBHcmFwaGljc0xheWVyOjpQbGF0Zm9ybUxheWVy SUQgbV9sYXllcklEOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Nj cm9sbGluZ1N0YXRlTm9kZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nU3RhdGVOb2RlTWFjLm1tCShyZXZpc2lvbiAxNzAxOTgp CisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nU3RhdGVOb2Rl TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMywxNiBAQAogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKK3ZvaWQgTGF5ZXJSZXByZXNlbnRhdGlvbjo6cmV0YWluUGxhdGZvcm1MYXllcihQ bGF0Zm9ybUxheWVyKiBsYXllcikKK3sKKyAgICBbbGF5ZXIgcmV0YWluXTsKK30KKwordm9pZCBM YXllclJlcHJlc2VudGF0aW9uOjpyZWxlYXNlUGxhdGZvcm1MYXllcihQbGF0Zm9ybUxheWVyKiBs YXllcikKK3sKKyAgICBbbGF5ZXIgcmVsZWFzZV07Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUKIAogI2VuZGlmIC8vIEVOQUJMRShBU1lOQ19TQ1JPTExJTkcpCg== 233447 2014-06-20 13:47:25 -0700 2014-06-20 14:05:08 -0700 Patch for-review-2.txt text/plain 5922 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDIwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDE0LTA2LTIwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MTE3CisgICAgICAgIFVucmVwcm9kdWNpYmxlIGNyYXNoZXMg dW5kZXIgV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZTo6dXBkYXRlVHJlZUZyb21TdGF0ZU5vZGUoKSAK KyAgICAgICAgZnJvbSBtZXNzYWdpbmcgYSBkZWxldGVkIE9iai1DIG9iamVjdAorICAgICAgICAt YW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzE0OTI1Mj4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEg c3BlY3VsYXRpdmUgZml4LiBJdCBtYWtlcyBMYXllclJlcHJlc2VudGF0aW9uIHJldGFpbiBtX3Bs YXRmb3JtTGF5ZXIuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgKiBwYWdl L3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVy UmVwcmVzZW50YXRpb246OkxheWVyUmVwcmVzZW50YXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6 TGF5ZXJSZXByZXNlbnRhdGlvbjo6fkxheWVyUmVwcmVzZW50YXRpb24pOgorICAgICAgICAoV2Vi Q29yZTo6TGF5ZXJSZXByZXNlbnRhdGlvbjo6b3BlcmF0b3I9KToKKyAgICAgICAgKFdlYkNvcmU6 OkxheWVyUmVwcmVzZW50YXRpb246Om9wZXJhdG9yPT0pOgorICAgICAgICAoV2ViQ29yZTo6TGF5 ZXJSZXByZXNlbnRhdGlvbjo6b3BlcmF0b3IgPT0pOiBEZWxldGVkLgorCisgICAgICAgIE1ha2Ug dGhpcyBBU1NFUlQgYW4gQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04KKyAgICAgICAg KiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNj cm9sbGluZ1RyZWU6OnVwZGF0ZVRyZWVGcm9tU3RhdGVOb2RlKToKKworICAgICAgICBBY3R1YWwg aW1wbGVtZW50YXRpb24gZm9yIHJldGFpbiBhbmQgcmVsZWFzZS4KKyAgICAgICAgKiBwYWdlL3Nj cm9sbGluZy9tYWMvU2Nyb2xsaW5nU3RhdGVOb2RlTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6 TGF5ZXJSZXByZXNlbnRhdGlvbjo6cmV0YWluUGxhdGZvcm1MYXllcik6CisgICAgICAgIChXZWJD b3JlOjpMYXllclJlcHJlc2VudGF0aW9uOjpyZWxlYXNlUGxhdGZvcm1MYXllcik6CisKIDIwMTQt MDYtMjAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUg cmVkdW5kYW50IFJlbmRlckxheWVyOjpjb21wdXRlT2Zmc2V0RnJvbVJvb3QoKSBmdW5jdGlvbi4K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCShyZXZpc2lvbiAxNzAxOTgpCisrKyBTb3VyY2UvV2Vi Q29yZS9XZWJDb3JlLmV4cC5pbgkod29ya2luZyBjb3B5KQpAQCAtODA1LDYgKzgwNSw4IEBAIF9f Wk43V2ViQ29yZTE5TGF5ZXJGbHVzaFNjaGVkdWxlckMxRVBOU18KIF9fWk43V2ViQ29yZTE5TGF5 ZXJGbHVzaFNjaGVkdWxlckMyRVBOU18yNUxheWVyRmx1c2hTY2hlZHVsZXJDbGllbnRFCiBfX1pO N1dlYkNvcmUxOUxheWVyRmx1c2hTY2hlZHVsZXJEMUV2CiBfX1pON1dlYkNvcmUxOUxheWVyRmx1 c2hTY2hlZHVsZXJEMkV2CitfX1pON1dlYkNvcmUxOUxheWVyUmVwcmVzZW50YXRpb24xOXJldGFp blBsYXRmb3JtTGF5ZXJFUDdDQUxheWVyCitfX1pON1dlYkNvcmUxOUxheWVyUmVwcmVzZW50YXRp b24yMHJlbGVhc2VQbGF0Zm9ybUxheWVyRVA3Q0FMYXllcgogX19aTjdXZWJDb3JlMTlNZWRpYVNl c3Npb25NYW5hZ2VyMTJyZW1vdmVDbGllbnRFUE5TXzI1TWVkaWFTZXNzaW9uTWFuYWdlckNsaWVu dEUKIF9fWk43V2ViQ29yZTE5TWVkaWFTZXNzaW9uTWFuYWdlcjEycmVzdHJpY3Rpb25zRU5TXzEy TWVkaWFTZXNzaW9uOU1lZGlhVHlwZUUKIF9fWk43V2ViQ29yZTE5TWVkaWFTZXNzaW9uTWFuYWdl cjEzc2hhcmVkTWFuYWdlckV2CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdTdGF0ZU5vZGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaAkocmV2aXNpb24gMTcwMTk4KQorKysgU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVOb2RlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTcxLDE0ICs3MSwzMiBAQCBwdWJsaWM6CiAgICAgICAgIDogbV9wbGF0Zm9ybUxheWVy KHBsYXRmb3JtTGF5ZXIpCiAgICAgICAgICwgbV9sYXllcklEKDApCiAgICAgICAgICwgbV9yZXBy ZXNlbnRhdGlvbihQbGF0Zm9ybUxheWVyUmVwcmVzZW50YXRpb24pCi0gICAgeyB9CisgICAgewor ICAgICAgICByZXRhaW5QbGF0Zm9ybUxheWVyKHBsYXRmb3JtTGF5ZXIpOworICAgIH0KIAogICAg IExheWVyUmVwcmVzZW50YXRpb24oR3JhcGhpY3NMYXllcjo6UGxhdGZvcm1MYXllcklEIGxheWVy SUQpCiAgICAgICAgIDogbV9ncmFwaGljc0xheWVyKG51bGxwdHIpCiAgICAgICAgICwgbV9sYXll cklEKGxheWVySUQpCiAgICAgICAgICwgbV9yZXByZXNlbnRhdGlvbihQbGF0Zm9ybUxheWVySURS ZXByZXNlbnRhdGlvbikKLSAgICB7IH0KLSAgICAKKyAgICB7CisgICAgfQorCisgICAgTGF5ZXJS ZXByZXNlbnRhdGlvbihjb25zdCBMYXllclJlcHJlc2VudGF0aW9uJiBvdGhlcikKKyAgICAgICAg OiBtX3BsYXRmb3JtTGF5ZXIob3RoZXIubV9wbGF0Zm9ybUxheWVyKQorICAgICAgICAsIG1fbGF5 ZXJJRChvdGhlci5tX2xheWVySUQpCisgICAgICAgICwgbV9yZXByZXNlbnRhdGlvbihvdGhlci5t X3JlcHJlc2VudGF0aW9uKQorICAgIHsKKyAgICAgICAgaWYgKG1fcmVwcmVzZW50YXRpb24gPT0g UGxhdGZvcm1MYXllclJlcHJlc2VudGF0aW9uKQorICAgICAgICAgICAgcmV0YWluUGxhdGZvcm1M YXllcihtX3BsYXRmb3JtTGF5ZXIpOworICAgIH0KKworICAgIH5MYXllclJlcHJlc2VudGF0aW9u KCkKKyAgICB7CisgICAgICAgIGlmIChtX3JlcHJlc2VudGF0aW9uID09IFBsYXRmb3JtTGF5ZXJS ZXByZXNlbnRhdGlvbikKKyAgICAgICAgICAgIHJlbGVhc2VQbGF0Zm9ybUxheWVyKG1fcGxhdGZv cm1MYXllcik7CisgICAgfQorCiAgICAgb3BlcmF0b3IgR3JhcGhpY3NMYXllciooKSBjb25zdAog ICAgIHsKICAgICAgICAgQVNTRVJUKG1fcmVwcmVzZW50YXRpb24gPT0gR3JhcGhpY3NMYXllclJl cHJlc2VudGF0aW9uKTsKQEAgLTEwMSw4ICsxMTksMjAgQEAgcHVibGljOgogICAgICAgICBBU1NF UlQobV9yZXByZXNlbnRhdGlvbiAhPSBQbGF0Zm9ybUxheWVyUmVwcmVzZW50YXRpb24pOwogICAg ICAgICByZXR1cm4gbV9sYXllcklEOwogICAgIH0KLSAgICAKLSAgICBib29sIG9wZXJhdG9yID09 KGNvbnN0IExheWVyUmVwcmVzZW50YXRpb24mIG90aGVyKSBjb25zdAorCisgICAgTGF5ZXJSZXBy ZXNlbnRhdGlvbiYgb3BlcmF0b3I9KGNvbnN0IExheWVyUmVwcmVzZW50YXRpb24mIG90aGVyKQor ICAgIHsKKyAgICAgICAgbV9wbGF0Zm9ybUxheWVyID0gb3RoZXIubV9wbGF0Zm9ybUxheWVyOwor ICAgICAgICBtX2xheWVySUQgPSBvdGhlci5tX2xheWVySUQ7CisgICAgICAgIG1fcmVwcmVzZW50 YXRpb24gPSBvdGhlci5tX3JlcHJlc2VudGF0aW9uOworCisgICAgICAgIGlmIChtX3JlcHJlc2Vu dGF0aW9uID09IFBsYXRmb3JtTGF5ZXJSZXByZXNlbnRhdGlvbikKKyAgICAgICAgICAgIHJldGFp blBsYXRmb3JtTGF5ZXIobV9wbGF0Zm9ybUxheWVyKTsKKworICAgICAgICByZXR1cm4gKnRoaXM7 CisgICAgfQorCisgICAgYm9vbCBvcGVyYXRvcj09KGNvbnN0IExheWVyUmVwcmVzZW50YXRpb24m IG90aGVyKSBjb25zdAogICAgIHsKICAgICAgICAgaWYgKG1fcmVwcmVzZW50YXRpb24gIT0gb3Ro ZXIubV9yZXByZXNlbnRhdGlvbikKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTE0MSw2 ICsxNzEsOSBAQCBwdWJsaWM6CiAgICAgYm9vbCByZXByZXNlbnRzUGxhdGZvcm1MYXllcklEKCkg Y29uc3QgeyByZXR1cm4gbV9yZXByZXNlbnRhdGlvbiA9PSBQbGF0Zm9ybUxheWVySURSZXByZXNl bnRhdGlvbjsgfQogICAgIAogcHJpdmF0ZToKKyAgICB2b2lkIHJldGFpblBsYXRmb3JtTGF5ZXIo UGxhdGZvcm1MYXllciopOworICAgIHZvaWQgcmVsZWFzZVBsYXRmb3JtTGF5ZXIoUGxhdGZvcm1M YXllciopOworCiAgICAgdW5pb24gewogICAgICAgICBHcmFwaGljc0xheWVyKiBtX2dyYXBoaWNz TGF5ZXI7CiAgICAgICAgIFBsYXRmb3JtTGF5ZXIgKm1fcGxhdGZvcm1MYXllcjsKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuY3BwCShyZXZp c2lvbiAxNzAxOTgpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdU cmVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg0LDcgKzE4NCw3IEBAIHZvaWQgU2Nyb2xsaW5n VHJlZTo6dXBkYXRlVHJlZUZyb21TdGF0ZU4KIAogICAgIGlmIChwYXJlbnROb2RlSUQpIHsKICAg ICAgICAgYXV0byBwYXJlbnRJdCA9IG1fbm9kZU1hcC5maW5kKHBhcmVudE5vZGVJRCk7Ci0gICAg ICAgIEFTU0VSVChwYXJlbnRJdCAhPSBtX25vZGVNYXAuZW5kKCkpOworICAgICAgICBBU1NFUlRf V0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihwYXJlbnRJdCAhPSBtX25vZGVNYXAuZW5kKCkpOwog ICAgICAgICBpZiAocGFyZW50SXQgIT0gbV9ub2RlTWFwLmVuZCgpKSB7CiAgICAgICAgICAgICBT Y3JvbGxpbmdUcmVlTm9kZSogcGFyZW50ID0gcGFyZW50SXQtPnZhbHVlOwogICAgICAgICAgICAg bm9kZS0+c2V0UGFyZW50KHBhcmVudCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9s bGluZy9tYWMvU2Nyb2xsaW5nU3RhdGVOb2RlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdTdGF0ZU5vZGVNYWMubW0JKHJldmlz aW9uIDE3MDE5OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxp bmdTdGF0ZU5vZGVNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTMzLDYgKzMzLDE2IEBACiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAordm9pZCBMYXllclJlcHJlc2VudGF0aW9uOjpyZXRhaW5QbGF0 Zm9ybUxheWVyKFBsYXRmb3JtTGF5ZXIqIGxheWVyKQoreworICAgIFtsYXllciByZXRhaW5dOwor fQorCit2b2lkIExheWVyUmVwcmVzZW50YXRpb246OnJlbGVhc2VQbGF0Zm9ybUxheWVyKFBsYXRm b3JtTGF5ZXIqIGxheWVyKQoreworICAgIFtsYXllciByZWxlYXNlXTsKK30KKwogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5BQkxFKEFTWU5DX1NDUk9MTElORykK