134097 2014-06-20 01:00:55 -0700 REGRESSION(r170163): It made everything crash on EFL 2014-06-24 00:40:02 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 134073 1 zsborbely.u-szeged gyuyoung.kim gyuyoung.kim gyuyoung.kim koivisto lucas.de.marchi ossy simon.fraser oldest_to_newest 1016878 0 zsborbely.u-szeged 2014-06-20 01:00:55 -0700 Running Animation/balls.html (1 of 139) error: Animation/balls.html 1 0x7f1625e21bf0 2 0x7f16261afff0 3 0x7f1626864446 WebKit::WebPage::didCompletePageTransition() 4 0x7f1626842e26 WebKit::WebFrameLoaderClient::frameLoadCompleted() 5 0x7f162447b409 WebCore::FrameLoader::frameLoadCompleted() 6 0x7f162447b495 WebCore::FrameLoader::setState(WebCore::FrameState) 7 0x7f162447fa25 WebCore::FrameLoader::checkLoadCompleteForThisFrame() 8 0x7f162447fe03 WebCore::FrameLoader::checkLoadComplete() 9 0x7f162447ffa2 WebCore::FrameLoader::checkCompleted() 10 0x7f162447ae95 WebCore::FrameLoader::init() 11 0x7f162685d47f WebKit::WebFrame::createWithCoreMainFrame(WebKit::WebPage*, WebCore::Frame*) 12 0x7f1626871b45 WebKit::WebPage::WebPage(unsigned long, WebKit::WebPageCreationParameters const&) 13 0x7f162687213f WebKit::WebPage::create(unsigned long, WebKit::WebPageCreationParameters const&) 14 0x7f16267eff25 WebKit::WebProcess::createWebPage(unsigned long, WebKit::WebPageCreationParameters const&) 15 0x7f16268f487e WebKit::WebProcess::didReceiveWebProcessMessage(IPC::Connection*, IPC::MessageDecoder&) 16 0x7f16266f86b4 IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >) 17 0x7f16266f8814 IPC::Connection::dispatchOneMessage() 18 0x7f1626902ce3 WTF::RunLoop::performWork() 19 0x7f16226fb2de 20 0x7f16226fba66 21 0x7f16226faa91 22 0x7f16226fac97 ecore_main_loop_begin 23 0x7f16268d3fa9 int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain>(int, char**) 24 0x7f162619ade5 __libc_start_main 25 0x4007c3 FAILED Finished: 0.726421 s 1016894 1 gyuyoung.kim 2014-06-20 01:53:55 -0700 AFAIK, m_mainFrame is null in WebPage::didCompletePageTransition() since r170163. So, if we simply add a null checking code as below, it looks EFL port is fine. However, we need to investigate r170163 further to sync with EFL port. void WebPage::didCompletePageTransition() { #if USE(TILED_BACKING_STORE) if (m_mainFrame && m_mainFrame->coreFrame()->view()->delegatesScrolling()) // Wait until the UI process sent us the visible rect it wants rendered. send(Messages::WebPageProxy::PageTransitionViewportReady()); else #endif m_drawingArea->setLayerTreeStateIsFrozen(false); } 1016895 2 ossy 2014-06-20 01:56:12 -0700 It seems not only perf tests, but layout tests crash too - http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/15217 1017200 3 233508 gyuyoung.kim 2014-06-20 22:26:42 -0700 Created attachment 233508 Patch 1017468 4 gyuyoung.kim 2014-06-22 19:27:21 -0700 Committed r170279: <http://trac.webkit.org/changeset/170279> 1017885 5 233508 koivisto 2014-06-24 00:38:14 -0700 Comment on attachment 233508 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233508&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2268 > + // m_mainFrame can be null since r170163. Comments like this are not useful. 1017887 6 gyuyoung.kim 2014-06-24 00:40:02 -0700 (In reply to comment #5) > (From update of attachment 233508 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233508&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2268 > > + // m_mainFrame can be null since r170163. > > Comments like this are not useful. I see. I will not use similar comment in next time. Do you want to remove it now ? 233508 2014-06-20 22:26:42 -0700 2014-06-24 00:38:14 -0700 Patch bug-134097-20140621142620.patch text/plain 1609 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzIzMDZhYzhjN2M1MDk3 ODgyNzk3NWIwNTI4ZjY2MjBlNzI3YzMwNy4uMThhOGJjNjRiZDAxOWJjZTE5ODgyN2QwNzNmOTc4 ZTgzMTI1MjgzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA2LTIwICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TihyMTcwMTYzKTogSXQgbWFkZSBldmVyeXRoaW5nIGNyYXNoIG9uIEVGTAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MDk3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5jcHA6IEFkZCBhIG51bGwgY2hlY2sgZm9yIG1fbWFpbkZyYW1lLgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlOjpkaWRDb21wbGV0ZVBhZ2VUcmFuc2l0aW9uKToKKwogMjAxNC0wNi0y MCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxl bWVudCBtb3JlIG9mIExlZ2FjeVNlc3Npb25TdGF0ZURlY29kZXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCAzYjQ2MjVmMDFiMzFhMWZlYTcz NmNkNGY1NmYzMGM4NzQxMjI0ZjFhLi4zYWFjYWEyZmFiZWEyNmFkOGIzMDY3MTQ1ZWY3ZTNlNzAy YWEwMGRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu Y3BwCkBAIC0yMjY1LDEwICsyMjY1LDExIEBAIHZvaWQgV2ViUGFnZTo6ZGlkU3RhcnRQYWdlVHJh bnNpdGlvbigpCiB2b2lkIFdlYlBhZ2U6OmRpZENvbXBsZXRlUGFnZVRyYW5zaXRpb24oKQogewog I2lmIFVTRShUSUxFRF9CQUNLSU5HX1NUT1JFKQotICAgIGlmIChtX21haW5GcmFtZS0+Y29yZUZy YW1lKCktPnZpZXcoKS0+ZGVsZWdhdGVzU2Nyb2xsaW5nKCkpCisgICAgLy8gbV9tYWluRnJhbWUg Y2FuIGJlIG51bGwgc2luY2UgcjE3MDE2My4KKyAgICBpZiAobV9tYWluRnJhbWUgJiYgbV9tYWlu RnJhbWUtPmNvcmVGcmFtZSgpLT52aWV3KCktPmRlbGVnYXRlc1Njcm9sbGluZygpKSB7CiAgICAg ICAgIC8vIFdhaXQgdW50aWwgdGhlIFVJIHByb2Nlc3Mgc2VudCB1cyB0aGUgdmlzaWJsZSByZWN0 IGl0IHdhbnRzIHJlbmRlcmVkLgogICAgICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6 OlBhZ2VUcmFuc2l0aW9uVmlld3BvcnRSZWFkeSgpKTsKLSAgICBlbHNlCisgICAgfSBlbHNlCiAj ZW5kaWYKICAgICAgICAgCiAgICAgbV9kcmF3aW5nQXJlYS0+c2V0TGF5ZXJUcmVlU3RhdGVJc0Zy b3plbihmYWxzZSk7Cg==