134093 2014-06-19 23:15:42 -0700 [EFL][CMAKE] Disable WebKit1 build as a default 2014-06-19 23:52:44 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 134087 1 ryuan.choi ryuan.choi bunhere commit-queue gyuyoung.kim lucas.de.marchi rakuco sergio oldest_to_newest 1016852 0 ryuan.choi 2014-06-19 23:15:42 -0700 SSIA 1016853 1 233408 ryuan.choi 2014-06-19 23:20:09 -0700 Created attachment 233408 Patch 1016856 2 233408 gyuyoung.kim 2014-06-19 23:36:21 -0700 Comment on attachment 233408 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233408&action=review r=me except for my questions. > Source/cmake/OptionsEfl.cmake:8 > +set(ENABLE_WEBKIT OFF) Should we keep this flag ? > Tools/CMakeLists.txt:10 > add_subdirectory(DumpRenderTree/TestNetscapePlugIn) ditto 1016858 3 233408 ryuan.choi 2014-06-19 23:52:35 -0700 Comment on attachment 233408 Patch Clearing flags on attachment: 233408 Committed r170175: <http://trac.webkit.org/changeset/170175> 1016859 4 ryuan.choi 2014-06-19 23:52:44 -0700 All reviewed patches have been landed. Closing bug. 233408 2014-06-19 23:20:09 -0700 2014-06-19 23:52:35 -0700 Patch bug-134093-20140620151946.patch text/plain 2758 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGEwZDQ1 OGU0NWFjMzZlNzc3NGM0ZmVmNTMwODAxNWY1NWZiOTFlN2YuLjQ3NzM5MDRkMmY3ZTg0MzA3ZTFl YmZmNjQ1YzJkYTM3ZjFiNzU2NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC01LDkgKzUsOCBA QCBzZXQoUFJPSkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfS4ke1BST0pFQ1Rf VkVSU0lPTl9NSU5PUn0uJHtQUk9KRUNUXwogCiBhZGRfZGVmaW5pdGlvbnMoLURCVUlMRElOR19F RkxfXz0xKQogCi1pZiAoTk9UIERFRklORUQgRU5BQkxFX1dFQktJVDIpCi0gICAgc2V0KEVOQUJM RV9XRUJLSVQyIE9OKQotZW5kaWYgKCkKK3NldChFTkFCTEVfV0VCS0lUIE9GRikKK3NldChFTkFC TEVfV0VCS0lUMiBPTikKIAogZmluZF9wYWNrYWdlKENhaXJvIDEuMTAuMiBSRVFVSVJFRCkKIGZp bmRfcGFja2FnZShGb250Y29uZmlnIDIuOC4wIFJFUVVJUkVEKQpAQCAtMTYzLDcgKzE2Miw3IEBA IGZpbmRfcGFja2FnZShIYXJmQnV6eiAwLjkuMiBSRVFVSVJFRCkKIGFkZF9kZWZpbml0aW9ucygt RFdURl9VU0VfRlJFRVRZUEU9MSkKIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfSEFSRkJVWlo9 MSkKIAotaWYgKEVOQUJMRV9XRUJLSVQyIEFORCBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSkK K2lmIChFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICBzZXQoRU5BQkxFX1BMVUdJTl9Q Uk9DRVNTIDEpCiBlbmRpZiAoKQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggNmE3MjRhNjBmYWQ2MTRiN2JlMTg2Nzk3YzQ5YmM1OWRjM2Y1MTE4 ZC4uOTQxYzVhZjA4MzMwMDU2ZmQxY2JlODQ2YTJlMWYyN2Y2YjUyZTZjNyAxMDA2NDQKLS0tIGEv VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDE0LTA2LTE5ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBbRUZMXVtDTUFLRV0gRGlzYWJsZSBXZWJLaXQxIGJ1aWxkIGFzIGEgZGVmYXVsdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MDkzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4 dDoKKwogMjAxNC0wNi0xOSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFJlbW92ZSBlZmwgd2sxIGJ1aWxkYm90IGFuZCBld3MKZGlmZiAtLWdpdCBh L1Rvb2xzL0NNYWtlTGlzdHMudHh0IGIvVG9vbHMvQ01ha2VMaXN0cy50eHQKaW5kZXggMzUyYjFi ODA2NmRhMGUwNzdhMmQyZWY1ZjkwN2JjMTE4NDQ1ZjhhOS4uZmYwNDIzNzQyZjdmMzAxNDIwZmNh NjE2MzljZjQ3NGUxNjc0ODUwZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ01ha2VMaXN0cy50eHQKKysr IGIvVG9vbHMvQ01ha2VMaXN0cy50eHQKQEAgLTYsMTQgKzYsNyBAQCBpZiAoIiR7UE9SVH0iIFNU UkVRVUFMICJFZmwiKQogICAgIGFkZF9zdWJkaXJlY3RvcnkoSW1hZ2VEaWZmKQogICAgIGFkZF9z dWJkaXJlY3RvcnkoRVdlYkxhdW5jaGVyL0NvbnRyb2xUaGVtZSkKIAotICAgIGlmIChFTkFCTEVf V0VCS0lUKQotICAgICAgICBhZGRfc3ViZGlyZWN0b3J5KER1bXBSZW5kZXJUcmVlKQotICAgICAg ICBhZGRfc3ViZGlyZWN0b3J5KEVXZWJMYXVuY2hlcikKLSAgICBlbmRpZiAoKQotCi0gICAgaWYg KEVOQUJMRV9XRUJLSVQyKQotICAgICAgICBhZGRfc3ViZGlyZWN0b3J5KE1pbmlCcm93c2VyL2Vm bCkKLSAgICBlbmRpZiAoKQorICAgIGFkZF9zdWJkaXJlY3RvcnkoTWluaUJyb3dzZXIvZWZsKQog ICAgIGFkZF9zdWJkaXJlY3RvcnkoRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luKQog ZWxzZWlmICgiJHtQT1JUfSIgU1RSRVFVQUwgIkdUSyIpCiAgICAgYWRkX3N1YmRpcmVjdG9yeShJ bWFnZURpZmYpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggOWE2Zjgz Y2VjY2M4NDViN2MyYjA2YzNhMzcwMDhmZjRlNmUyNmJhNy4uM2RhMjRkOTM5ZDIyYjhlN2YwNzYy YzRmNmM4YzZkNjFmY2MyOTgwZiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA2LTE5ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBz YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtDTUFLRV0gRGlzYWJsZSBXZWJLaXQxIGJ1aWxk IGFzIGEgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM0MDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRGlzYWJsZSBXZWJLaXQxIGJ1aWxkIGFuZCBlbmFibGUgV2ViS2l0MiBidWlsZCBmb3Ig dGhlIEVGTCBwb3J0LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6 CisKIDIwMTQtMDYtMTkgIETDoW5pZWwgQsOhdHlhaSAgPGRiYXR5YWkudS1zemVnZWRAcGFydG5l ci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmUgRU5BQkxFKExMSU5UKSBhbmQgRU5BQkxF KExMSU5UX0NfTE9PUCkgZ3VhcmRzCg==