134088 2014-06-19 19:41:40 -0700 Remove redundant RenderLayer::computeOffsetFromRoot() function. 2014-06-20 13:43:52 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified CLOSED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1016824 0 zalan 2014-06-19 19:41:40 -0700 It's odd code anyway. 1016825 1 233402 zalan 2014-06-19 19:45:09 -0700 Created attachment 233402 Patch 1016974 2 233402 zalan 2014-06-20 11:35:01 -0700 Comment on attachment 233402 Patch will land it manually. 1017009 3 zalan 2014-06-20 13:37:24 -0700 Committed r170200: <http://trac.webkit.org/changeset/170200> 233402 2014-06-19 19:45:09 -0700 2014-06-20 11:35:01 -0700 Patch bug-134088-20140619194447.patch text/plain 3493 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDMzODFhYzg5ODg5NDcy ZDNiMjdhZGU5NDgwYTY1OTAzZTU0MjVhMi4uNzdkNjNjYTFkMzkwZWVhNjdjMTJmZmY4ZDdmZDBk ZDNkZmY0N2E4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTE5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHJlZHVuZGFudCBS ZW5kZXJMYXllcjo6Y29tcHV0ZU9mZnNldEZyb21Sb290KCkgZnVuY3Rpb24uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQwODgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rp b25hbGl0eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJMYXllcjo6Y2FsY3VsYXRlQ2xpcFJlY3RzKToKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckxheWVyOjpjb21wdXRlT2Zmc2V0RnJvbVJvb3QpOiBEZWxldGVkLgorICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5oOgorCiAyMDE0LTA2LTE4ICBTYW0gV2Vpbmln ICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBnZW5lcmF0ZSBwcm90b3R5cGUgYW5k IGNvbnN0cnVjdG9yIGNsYXNzZXMgaW50byB0aGUgZ2VuZXJhdGVkIGltcGxlbWVudGF0aW9uIGZp bGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA0YjViYzBi MGRhMWY5YTkzYTE3MzQ4ZTE1ZmM5MzFlZmU0ZTI5MjI1Li5hM2VjMzQ2YTY5Mzk5MjEwYTE4ZTUy OWQ3ZWFmOTdhNzUwOTFkMmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5jcHAKQEAgLTM0NywyOCArMzQ3LDYgQEAgRmlsdGVyRWZmZWN0UmVuZGVyZXIqIFJlbmRlckxh eWVyOjpmaWx0ZXJSZW5kZXJlcigpIGNvbnN0CiAKICNlbmRpZgogCi1MYXlvdXRQb2ludCBSZW5k ZXJMYXllcjo6Y29tcHV0ZU9mZnNldEZyb21Sb290KGJvb2wmIGhhc0xheWVyT2Zmc2V0KSBjb25z dAotewotICAgIGhhc0xheWVyT2Zmc2V0ID0gdHJ1ZTsKLQotICAgIGlmICghcGFyZW50KCkpCi0g ICAgICAgIHJldHVybiBMYXlvdXRQb2ludCgpOwotCi0gICAgLy8gVGhpcyBpcyBzaW1pbGFyIHRv IHJvb3QoKSBidXQgd2UgY2hlY2sgaWYgYW4gYW5jZXN0b3IgbGF5ZXIgd291bGQKLSAgICAvLyBw cmV2ZW50IHRoZSBvcHRpbWl6YXRpb24gZnJvbSB3b3JraW5nLgotICAgIGNvbnN0IFJlbmRlckxh eWVyKiByb290TGF5ZXIgPSAwOwotICAgIGZvciAoY29uc3QgUmVuZGVyTGF5ZXIqIHBhcmVudExh eWVyID0gcGFyZW50KCk7IHBhcmVudExheWVyOyByb290TGF5ZXIgPSBwYXJlbnRMYXllciwgcGFy ZW50TGF5ZXIgPSBwYXJlbnRMYXllci0+cGFyZW50KCkpIHsKLSAgICAgICAgaGFzTGF5ZXJPZmZz ZXQgPSBwYXJlbnRMYXllci0+Y2FuVXNlQ29udmVydFRvTGF5ZXJDb29yZHMoKTsKLSAgICAgICAg aWYgKCFoYXNMYXllck9mZnNldCkKLSAgICAgICAgICAgIHJldHVybiBMYXlvdXRQb2ludCgpOwot ICAgIH0KLSAgICBBU1NFUlQocm9vdExheWVyID09IHJvb3QoKSk7Ci0KLSAgICBMYXlvdXRQb2lu dCBvZmZzZXQ7Ci0gICAgcGFyZW50KCktPmNvbnZlcnRUb0xheWVyQ29vcmRzKHJvb3RMYXllciwg b2Zmc2V0KTsKLSAgICByZXR1cm4gb2Zmc2V0OwotfQotCiB2b2lkIFJlbmRlckxheWVyOjp1cGRh dGVMYXllclBvc2l0aW9uc0FmdGVyTGF5b3V0KGNvbnN0IFJlbmRlckxheWVyKiByb290TGF5ZXIs IFVwZGF0ZUxheWVyUG9zaXRpb25zRmxhZ3MgZmxhZ3MpCiB7CiAgICAgUmVuZGVyR2VvbWV0cnlN YXAgZ2VvbWV0cnlNYXAoVXNlVHJhbnNmb3Jtcyk7CkBAIC01MzA3LDcgKzUyODUsNiBAQCB2b2lk IFJlbmRlckxheWVyOjpjYWxjdWxhdGVSZWN0cyhjb25zdCBDbGlwUmVjdHNDb250ZXh0JiBjbGlw UmVjdHNDb250ZXh0LCBjb25zdAogICAgIGVsc2UKICAgICAgICAgY29udmVydFRvTGF5ZXJDb29y ZHMoY2xpcFJlY3RzQ29udGV4dC5yb290TGF5ZXIsIG9mZnNldCk7CiAKLQogICAgIFJlbmRlck5h bWVkRmxvd0ZyYWdtZW50KiBuYW1lZEZsb3dGcmFnbWVudCA9IGN1cnJlbnRSZW5kZXJOYW1lZEZs b3dGcmFnbWVudCgpOwogICAgIC8vIElmIHRoZSB2aWV3IGlzIHNjcm9sbGVkLCB0aGUgZmxvdyB0 aHJlYWQgaXMgbm90IHNjcm9sbGVkIHdpdGggaXQgYW5kIHdlIHNob3VsZAogICAgIC8vIHRha2Ug dGhlIHNjcm9sbCBvZmZzZXQgaW50byBhY2NvdW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuaAppbmRleCBjNDVhMDM5NGZkMjE3MjZiMTNmYjc2YzFkNTgyY2RlMTdmMzE4ZDRj Li40Mjc1ZmNiMGQ3NzU5MTNiMzBiNjY1NTgzZjhmNDU4NTc3MTFlZGJjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaApAQCAtNzU1LDkgKzc1NSw2IEBAIHB1YmxpYzoKICAg ICAvLyBDYW4gcGFzcyBvZmZzZXRGcm9tUm9vdCBpZiBrbm93bi4KICAgICBMYXlvdXRSZWN0IGNh bGN1bGF0ZUxheWVyQm91bmRzKGNvbnN0IFJlbmRlckxheWVyKiBhbmNlc3RvckxheWVyLCBjb25z dCBMYXlvdXRQb2ludCogb2Zmc2V0RnJvbVJvb3QgPSBudWxscHRyLCBDYWxjdWxhdGVMYXllckJv dW5kc0ZsYWdzID0gRGVmYXVsdENhbGN1bGF0ZUxheWVyQm91bmRzRmxhZ3MpIGNvbnN0OwogICAg IAotICAgIC8vIFdBUk5JTkc6IFRoaXMgbWV0aG9kIHJldHVybnMgdGhlIG9mZnNldCBmb3IgdGhl IHBhcmVudCBhcyB0aGlzIGlzIHdoYXQgdXBkYXRlTGF5ZXJQb3NpdGlvbnMgZXhwZWN0cy4KLSAg ICBMYXlvdXRQb2ludCBjb21wdXRlT2Zmc2V0RnJvbVJvb3QoYm9vbCYgaGFzTGF5ZXJPZmZzZXQp IGNvbnN0OwotCiAgICAgLy8gUmV0dXJuIGEgY2FjaGVkIHJlcGFpbnQgcmVjdCwgY29tcHV0ZWQg cmVsYXRpdmUgdG8gdGhlIGxheWVyIHJlbmRlcmVyJ3MgY29udGFpbmVyRm9yUmVwYWludC4KICAg ICBMYXlvdXRSZWN0IHJlcGFpbnRSZWN0KCkgY29uc3QgeyByZXR1cm4gbV9yZXBhaW50UmVjdDsg fQogICAgIExheW91dFJlY3QgcmVwYWludFJlY3RJbmNsdWRpbmdOb25Db21wb3NpdGluZ0Rlc2Nl bmRhbnRzKCkgY29uc3Q7Cg==