134084 2014-06-19 17:46:29 -0700 iOS WebKit2: selection handles become too large when zooming a page. 2022-10-25 13:33:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica ahmad.saleem792 commit-queue oldest_to_newest 1016809 0 enrica 2014-06-19 17:46:29 -0700 This happens only in WebKit2, since the WKContentView is now zoomed and all the selection views are child views of the document view. <rdar://problem/16799164> 1016811 1 233398 enrica 2014-06-19 17:51:52 -0700 Created attachment 233398 Patch 1016813 2 commit-queue 2014-06-19 17:53:34 -0700 Attachment 233398 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1719: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1720: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1017043 3 233398 benjamin 2014-06-20 14:23:39 -0700 Comment on attachment 233398 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233398&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:201 > + CGFloat inverseScale = 1 / [[self layer] transform].m11; > + [_inverseScaleRootView setTransform:CGAffineTransformMakeScale(inverseScale, inverseScale)]; Can you just call [self _updateUnscaledView]? > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:291 > + hitView = [hitView hitTest:[hitView convertPoint:point fromView:self] withEvent:event]; I would not reuse "hitView" but use a different UIView* local variable for clarity. maybe: for (UIView *subView ...) { if (UIView *hitView...) > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1695 > - (UITextRange *)selectedTextRange I would store inverseScale in a local variable. I think this deserve a comment with a little explanation of how the UI works regarding the caret width/height. 1908211 4 ahmad.saleem792 2022-10-25 13:33:29 -0700 Landed - https://github.com/WebKit/WebKit/commit/81101735c10d2c44bbcd0d5684177d7fc473310d and didn't backed out. Marking this bug as "RESOLVED FIXED". Thanks! 233398 2014-06-19 17:51:52 -0700 2014-06-20 14:23:38 -0700 Patch zoomselection-webkit.txt text/plain 7052 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDE2NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA2LTE5ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgaU9TIFdlYktpdDI6IHNlbGVj dGlvbiBoYW5kbGVzIGJlY29tZSB0b28gbGFyZ2Ugd2hlbiB6b29taW5nIGEgcGFnZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDA4NAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTY3OTkxNjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU2luY2UgdGhlIGRvY3VtZW50IHZpZXcgaXMgem9vbWVkLCB3 ZSBhZGQgYSBzdWJ2aWV3IHRoYXQgaGFzIHRoZSBpbnZlcnNlIHRyYW5zZm9ybQorICAgICAgICBv ZiB0aGUgZG9jdW1lbnQgdmlldy4gVGhpcyBuZXcgdmlldyBiZWNvbWVzIHRoZSByb290IGZvciB0 aGUgc2VsZWN0aW9uIGhpZXJhcmNoeS4KKyAgICAgICAgVGhlIG5ldyB2aWV3IGhhcyB6ZXJvIHNp emUsIG5vdCB0byBpbnRlcmZlcmUgd2l0aCB0aGUgZXhpc3RpbmcgZ2VzdHVyZXMgb24gdGhlIFdL Q29udGVuVmlldworICAgICAgICB0aGVyZWZvcmUgd2UgaW1wbGVtZW50IGhpdFRlc3QgdG8gZGV0 ZWN0IGludGVyYWN0aW9uIHdpdGggdGhlIHNlbGVjdGlvbiBlbGVtZW50cy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbToKKyAgICAgICAgKC1bV0tDb250ZW50Vmll dyBkaWRVcGRhdGVWaXNpYmxlUmVjdDp1bm9ic2N1cmVkUmVjdDp1bm9ic2N1cmVkUmVjdEluU2Ny b2xsVmlld0Nvb3JkaW5hdGVzOnNjYWxlOm1pbmltdW1TY2FsZTppblN0YWJsZVN0YXRlOmlzQ2hh bmdpbmdPYnNjdXJlZEluc2V0c0ludGVyYWN0aXZlbHk6XSk6CisgICAgICAgICogVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBz ZXR1cEludGVyYWN0aW9uXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgY2xlYW51cEludGVy YWN0aW9uXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgdW5zY2FsZWRWaWV3XSk6CisgICAg ICAgICgtW1dLQ29udGVudFZpZXcgaW52ZXJzZVNjYWxlXSk6CisgICAgICAgICgtW1dLQ29udGVu dFZpZXcgX3VwZGF0ZVVuc2NhbGVkVmlld10pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGhp dFRlc3Q6d2l0aEV2ZW50Ojo6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgc2VsZWN0ZWRU ZXh0UmFuZ2VdKToKKwogMjAxNC0wNi0xOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgogCiAgICAgICAgIEFub3RoZXIgYnVpbGQgZml4IGF0dGVtcHQuCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCShyZXZpc2lvbiAx NzAxMTApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0J KHdvcmtpbmcgY29weSkKQEAgLTMxMCw2ICszMTAsNyBAQCAtICh2b2lkKWRpZFVwZGF0ZVZpc2li bGVSZWN0OihDR1JlY3QpdmlzCiAKICAgICBpZiAoYXV0byBkcmF3aW5nQXJlYSA9IF9wYWdlLT5k cmF3aW5nQXJlYSgpKQogICAgICAgICBkcmF3aW5nQXJlYS0+dXBkYXRlRGVidWdJbmRpY2F0b3Io KTsKKyAgICBbc2VsZiBfdXBkYXRlVW5zY2FsZWRWaWV3XTsKIH0KIAogLSAodm9pZClzZXRNaW5p bXVtU2l6ZTooQ0dTaXplKXNpemUKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAkocmV2aXNpb24gMTcwMTEw KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24uaAkod29ya2luZyBjb3B5KQpAQCAtMTAwLDYgKzEwMCw3IEBAIHN0cnVjdCBXS0F1dG9Db3Jy ZWN0aW9uRGF0YSB7CiAgICAgUmV0YWluUHRyPFVJV2ViRm9ybUFjY2Vzc29yeT4gX2Zvcm1BY2Nl c3NvcnlWaWV3OwogICAgIFJldGFpblB0cjxVSVZpZXc+IF9oaWdobGlnaHRSb290VmlldzsKICAg ICBSZXRhaW5QdHI8X1VJSGlnaGxpZ2h0Vmlldz4gX2hpZ2hsaWdodFZpZXc7CisgICAgUmV0YWlu UHRyPFVJVmlldz4gX2ludmVyc2VTY2FsZVJvb3RWaWV3OwogICAgIFJldGFpblB0cjxOU1N0cmlu Zz4gX21hcmtlZFRleHQ7CiAgICAgUmV0YWluUHRyPFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQ+IF9h Y3Rpb25TaGVldEFzc2lzdGFudDsKICAgICBSZXRhaW5QdHI8V0tBaXJQbGF5Um91dGVQaWNrZXI+ IF9haXJQbGF5Um91dGVQaWNrZXI7CkBAIC0xNzQsNiArMTc1LDcgQEAgc3RydWN0IFdLQXV0b0Nv cnJlY3Rpb25EYXRhIHsKIC0gKHZvaWQpYWNjZXNzb3J5RG9uZTsKIC0gKHZvaWQpX2RpZEhhbmRs ZUtleUV2ZW50OihXZWJJT1NFdmVudCAqKWV2ZW50OwogLSAoVmVjdG9yPFdlYktpdDo6V0tPcHRp b25JdGVtPiYpIGFzc2lzdGVkTm9kZVNlbGVjdE9wdGlvbnM7CistICh2b2lkKV91cGRhdGVVbnNj YWxlZFZpZXc7CiBAZW5kCiAKICNlbmRpZiAvLyBQTEFURk9STShJT1MpCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQkocmV2aXNpb24gMTcwMTEwKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTE5MSw2ICsx OTEsMTUgQEAgLSAodm9pZClpbnZhbGlkYXRlCiAKIC0gKHZvaWQpc2V0dXBJbnRlcmFjdGlvbgog eworICAgIGlmICghX2ludmVyc2VTY2FsZVJvb3RWaWV3KSB7CisgICAgICAgIF9pbnZlcnNlU2Nh bGVSb290VmlldyA9IGFkb3B0TlMoW1tVSVZpZXcgYWxsb2NdIGluaXRdKTsKKyAgICAgICAgW19p bnZlcnNlU2NhbGVSb290VmlldyBzZXRPcGFxdWU6Tk9dOworICAgICAgICBbX2ludmVyc2VTY2Fs ZVJvb3RWaWV3IGxheWVyXS5hbmNob3JQb2ludCA9IENHUG9pbnRNYWtlKDAsIDApOworICAgIH0K KyAgICBbc2VsZiBhZGRTdWJ2aWV3Ol9pbnZlcnNlU2NhbGVSb290Vmlldy5nZXQoKV07CisgICAg Q0dGbG9hdCBpbnZlcnNlU2NhbGUgPSAxIC8gW1tzZWxmIGxheWVyXSB0cmFuc2Zvcm1dLm0xMTsK KyAgICBbX2ludmVyc2VTY2FsZVJvb3RWaWV3IHNldFRyYW5zZm9ybTpDR0FmZmluZVRyYW5zZm9y bU1ha2VTY2FsZShpbnZlcnNlU2NhbGUsIGludmVyc2VTY2FsZSldOworCiAgICAgX3RvdWNoRXZl bnRHZXN0dXJlUmVjb2duaXplciA9IGFkb3B0TlMoW1tVSVdlYlRvdWNoRXZlbnRzR2VzdHVyZVJl Y29nbml6ZXIgYWxsb2NdIGluaXRXaXRoVGFyZ2V0OnNlbGYgYWN0aW9uOkBzZWxlY3Rvcihfd2Vi VG91Y2hFdmVudHNSZWNvZ25pemVkOikgdG91Y2hEZWxlZ2F0ZTpzZWxmXSk7CiAgICAgW190b3Vj aEV2ZW50R2VzdHVyZVJlY29nbml6ZXIgc2V0RGVsZWdhdGU6c2VsZl07CiAgICAgW3NlbGYgYWRk R2VzdHVyZVJlY29nbml6ZXI6X3RvdWNoRXZlbnRHZXN0dXJlUmVjb2duaXplci5nZXQoKV07CkBA IC0yNDIsNiArMjUxLDcgQEAgLSAodm9pZCljbGVhbnVwSW50ZXJhY3Rpb24KICAgICBfZm9ybUlu cHV0U2Vzc2lvbiA9IG5pbDsKICAgICBbX2hpZ2hsaWdodFZpZXcgcmVtb3ZlRnJvbVN1cGVydmll d107CiAgICAgW19oaWdobGlnaHRSb290VmlldyByZW1vdmVGcm9tU3VwZXJ2aWV3XTsKKyAgICBb X2ludmVyc2VTY2FsZVJvb3RWaWV3IHJlbW92ZUZyb21TdXBlcnZpZXddOwogICAgIFtfdG91Y2hF dmVudEdlc3R1cmVSZWNvZ25pemVyIHNldERlbGVnYXRlOm5pbF07CiAgICAgW19zaW5nbGVUYXBH ZXN0dXJlUmVjb2duaXplciBzZXREZWxlZ2F0ZTpuaWxdOwogICAgIFtfc2luZ2xlVGFwR2VzdHVy ZVJlY29nbml6ZXIgc2V0R2VzdHVyZVJlY29nbml6ZWRUYXJnZXQ6bmlsIGFjdGlvbjpuaWxdOwpA QCAtMjU3LDYgKzI2NywzNCBAQCAtICh2b2lkKWNsZWFudXBJbnRlcmFjdGlvbgogICAgIH0KIH0K IAorLSAoVUlWaWV3Kil1bnNjYWxlZFZpZXcKK3sKKyAgICByZXR1cm4gX2ludmVyc2VTY2FsZVJv b3RWaWV3LmdldCgpOworfQorCistIChDR0Zsb2F0KWludmVyc2VTY2FsZQoreworICAgIHJldHVy biBbW19pbnZlcnNlU2NhbGVSb290VmlldyBsYXllcl0gdHJhbnNmb3JtXS5tMTE7Cit9CisKKy0g KHZvaWQpX3VwZGF0ZVVuc2NhbGVkVmlldworeworICAgIENHRmxvYXQgaW52ZXJzZVNjYWxlID0g MSAvIFtbc2VsZiBsYXllcl0gdHJhbnNmb3JtXS5tMTE7CisgICAgW19pbnZlcnNlU2NhbGVSb290 VmlldyBzZXRUcmFuc2Zvcm06Q0dBZmZpbmVUcmFuc2Zvcm1NYWtlU2NhbGUoaW52ZXJzZVNjYWxl LCBpbnZlcnNlU2NhbGUpXTsKKyAgICBfc2VsZWN0aW9uTmVlZHNVcGRhdGUgPSBZRVM7CisgICAg W3NlbGYgX3VwZGF0ZUNoYW5nZWRTZWxlY3Rpb25dOworfQorCistIChVSVZpZXcgKiloaXRUZXN0 OihDR1BvaW50KXBvaW50IHdpdGhFdmVudDooOjpVSUV2ZW50ICopZXZlbnQKK3sKKyAgICBmb3Ig KFVJVmlldyAqaGl0VmlldyBpbiBbX2ludmVyc2VTY2FsZVJvb3RWaWV3LmdldCgpIHN1YnZpZXdz XSkgeworICAgICAgICBoaXRWaWV3ID0gW2hpdFZpZXcgaGl0VGVzdDpbaGl0VmlldyBjb252ZXJ0 UG9pbnQ6cG9pbnQgZnJvbVZpZXc6c2VsZl0gd2l0aEV2ZW50OmV2ZW50XTsKKyAgICAgICAgaWYg KGhpdFZpZXcpCisgICAgICAgICAgICByZXR1cm4gaGl0VmlldzsKKyAgICB9CisgICAgcmV0dXJu IFtzdXBlciBoaXRUZXN0OnBvaW50IHdpdGhFdmVudDpldmVudF07Cit9CisKIC0gKGNvbnN0IElu dGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uJilwb3NpdGlvbkluZm9ybWF0aW9uCiB7CiAg ICAgcmV0dXJuIF9wb3NpdGlvbkluZm9ybWF0aW9uOwpAQCAtMTY1NiwxMSArMTY5NCwzMCBAQCAt ICh2b2lkKXJlcGxhY2VSYW5nZTooVUlUZXh0UmFuZ2UgKilyYW5nCiAKIC0gKFVJVGV4dFJhbmdl ICopc2VsZWN0ZWRUZXh0UmFuZ2UKIHsKKyAgICBGbG9hdFJlY3Qgc3RhcnRSZWN0ID0gX3BhZ2Ut PmVkaXRvclN0YXRlKCkuY2FyZXRSZWN0QXRTdGFydDsKKyAgICBGbG9hdFJlY3QgZW5kUmVjdCA9 IF9wYWdlLT5lZGl0b3JTdGF0ZSgpLmNhcmV0UmVjdEF0RW5kOworICAgIC8vIFRha2luZyBpbnRv IGFjY291bnQgaG9yaXpvbnRhbCB2cy4gdmVydGljYWwuCisgICAgaWYgKHN0YXJ0UmVjdC53aWR0 aCgpIDwgc3RhcnRSZWN0LmhlaWdodCgpKQorICAgICAgICBzdGFydFJlY3Quc2V0V2lkdGgoc3Rh cnRSZWN0LndpZHRoKCkgKiBbc2VsZiBpbnZlcnNlU2NhbGVdKTsKKyAgICBlbHNlCisgICAgICAg IHN0YXJ0UmVjdC5zZXRIZWlnaHQoc3RhcnRSZWN0LmhlaWdodCgpICogW3NlbGYgaW52ZXJzZVNj YWxlXSk7CisgICAgZG91YmxlIGRlbHRhID0gMDsKKyAgICBpZiAoZW5kUmVjdC53aWR0aCgpIDwg ZW5kUmVjdC5oZWlnaHQoKSkgeworICAgICAgICBkZWx0YSA9IGVuZFJlY3Qud2lkdGgoKTsKKyAg ICAgICAgZW5kUmVjdC5zZXRXaWR0aChlbmRSZWN0LndpZHRoKCkgKiBbc2VsZiBpbnZlcnNlU2Nh bGVdKTsKKyAgICAgICAgZGVsdGEgPSBlbmRSZWN0LndpZHRoKCkgLSBkZWx0YTsKKyAgICAgICAg ZW5kUmVjdC5tb3ZlKGRlbHRhLCAwKTsKKyAgICB9IGVsc2UgeworICAgICAgICBkZWx0YSA9IGVu ZFJlY3QuaGVpZ2h0KCk7CisgICAgICAgIGVuZFJlY3Quc2V0SGVpZ2h0KGVuZFJlY3QuaGVpZ2h0 KCkgKiBbc2VsZiBpbnZlcnNlU2NhbGVdKTsKKyAgICAgICAgZGVsdGEgPSBlbmRSZWN0LmhlaWdo dCgpIC0gZGVsdGE7CisgICAgICAgIGVuZFJlY3QubW92ZSgwLCBkZWx0YSk7CisgICAgfQogICAg IHJldHVybiBbV0tUZXh0UmFuZ2UgdGV4dFJhbmdlV2l0aFN0YXRlOl9wYWdlLT5lZGl0b3JTdGF0 ZSgpLnNlbGVjdGlvbklzTm9uZQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp c1JhbmdlOl9wYWdlLT5lZGl0b3JTdGF0ZSgpLnNlbGVjdGlvbklzUmFuZ2UKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaXNFZGl0YWJsZTpfcGFnZS0+ZWRpdG9yU3RhdGUoKS5pc0Nv bnRlbnRFZGl0YWJsZQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnRSZWN0 Ol9wYWdlLT5lZGl0b3JTdGF0ZSgpLmNhcmV0UmVjdEF0U3RhcnQKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZW5kUmVjdDpfcGFnZS0+ZWRpdG9yU3RhdGUoKS5jYXJldFJlY3RB dEVuZAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnRSZWN0OnN0YXJ0UmVj dAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbmRSZWN0OmVuZFJlY3QKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxlY3Rpb25SZWN0czpbc2VsZiB3ZWJTZWxlY3Rp b25SZWN0c10KICAgICAgICAgICAgICAgICAgICAgICAgIHNlbGVjdGVkVGV4dExlbmd0aDpfcGFn ZS0+ZWRpdG9yU3RhdGUoKS5zZWxlY3RlZFRleHRMZW5ndGhdOwogfQo=