134077 2014-06-19 14:43:17 -0700 [ftlopt] StructureSet::onlyStructure() should return nullptr if it's not a singleton (instead of asserting) 2024-02-25 04:59:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 fpizlo fpizlo ahmad.saleem792 ashvayka barraclough ggaren mark.lam mhahnenberg msaboff oliver sam ysuzuki oldest_to_newest 1016775 0 fpizlo 2014-06-19 14:43:17 -0700 Patch forthcoming. 1016776 1 233385 fpizlo 2014-06-19 14:44:29 -0700 Created attachment 233385 the patch 2016685 2 ahmad.saleem792 2024-02-25 04:59:34 -0800 This function is following: https://searchfox.org/wubkat/rev/dc6a01c9fd207e1b1394a1cb8261b410a1909cf6/Source/JavaScriptCore/bytecode/StructureSet.h#52 Structure* onlyStructure() const { return onlyEntry(); } While onlyEntry is: // Returns the only entry if the array has exactly one entry. T onlyEntry() const { if (isThin()) return singleEntry(); OutOfLineList* list = this->list(); if (list->m_length != 1) return T(); return list->list()[0]; } __ Which is similar to proposed patch, so I think it is fixed. Marking this as 'RESOLVED CONFIGURATION CHANGED' and CCing - Alexey and Yusuke. 233385 2014-06-19 14:44:29 -0700 2014-06-19 14:48:48 -0700 the patch blah.patch text/plain 1681 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcwMTYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTA2LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg W2Z0bG9wdF0gU3RydWN0dXJlU2V0Ojpvbmx5U3RydWN0dXJlKCkgc2hvdWxkIHJldHVybiBudWxs cHRyIGlmIGl0J3Mgbm90IGEgc2luZ2xldG9uIChpbnN0ZWFkIG9mIGFzc2VydGluZykKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDA3NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhpcyBt YWtlcyBTdHJ1Y3R1cmVTZXQgYW5kIFN0cnVjdHVyZUFic3RyYWN0VmFsdWUgbW9yZSBjb25zaXN0 ZW50IGFuZCBmaXhlcyBhIGRlYnVnIGFzc2VydAorICAgICAgICBpbiB0aGUgYWJzdHJhY3QgaW50 ZXJwcmV0ZXIuCisKKyAgICAgICAgKiBieXRlY29kZS9TdHJ1Y3R1cmVTZXQuaDoKKyAgICAgICAg KEpTQzo6U3RydWN0dXJlU2V0Ojpvbmx5U3RydWN0dXJlKToKKwogMjAxNC0wNi0xOCAgRmlsaXAg UGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIERGRyBBSSBhbmQgY29uc3RhbnQg Zm9sZGVyIHNob3VsZCBiZSBhYmxlIHRvIHByZWNpc2VseSBwcnVuZSBNdWx0aUdldEJ5T2Zmc2V0 L011bHRpUHV0QnlPZmZzZXQgZXZlbiBpZiB0aGUgYmFzZSBzdHJ1Y3R1cmUgYWJzdHJhY3QgdmFs dWUgaXMgbm90IGEgc2luZ2xldG9uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvU3RydWN0dXJlU2V0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL1N0cnVjdHVyZVNldC5oCShyZXZpc2lvbiAxNzAxNjApCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvU3RydWN0dXJlU2V0LmgJKHdvcmtpbmcgY29weSkKQEAgLTczLDEy ICs3MywxMiBAQCBwdWJsaWM6CiAgICAgCiAgICAgU3RydWN0dXJlKiBvbmx5U3RydWN0dXJlKCkg Y29uc3QKICAgICB7Ci0gICAgICAgIGlmIChpc1RoaW4oKSkgewotICAgICAgICAgICAgQVNTRVJU KHNpbmdsZVN0cnVjdHVyZSgpKTsKKyAgICAgICAgaWYgKGlzVGhpbigpKQogICAgICAgICAgICAg cmV0dXJuIHNpbmdsZVN0cnVjdHVyZSgpOwotICAgICAgICB9Ci0gICAgICAgIEFTU0VSVChzdHJ1 Y3R1cmVMaXN0KCktPm1fbGVuZ3RoID09IDEpOwotICAgICAgICByZXR1cm4gc3RydWN0dXJlTGlz dCgpLT5saXN0KClbMF07CisgICAgICAgIE91dE9mTGluZUxpc3QqIGxpc3QgPSBzdHJ1Y3R1cmVM aXN0KCk7CisgICAgICAgIGlmIChsaXN0LT5tX2xlbmd0aCAhPSAxKQorICAgICAgICAgICAgcmV0 dXJuIG51bGxwdHI7CisgICAgICAgIHJldHVybiBsaXN0LT5saXN0KClbMF07CiAgICAgfQogICAg IAogICAgIGJvb2wgaXNFbXB0eSgpIGNvbnN0Cg==