134073 2014-06-19 13:58:12 -0700 Unfreeze the layer tree on DidFirstVisuallyNonEmptyLayout 2014-06-20 01:04:33 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 134097 1 koivisto webkit-unassigned simon.fraser thorton zsborbely.u-szeged oldest_to_newest 1016757 0 koivisto 2014-06-19 13:58:12 -0700 DidFirstLayout is too early and we usually get a blank page. This doesn't match existing iOS behavior either. 1016760 1 koivisto 2014-06-19 14:01:48 -0700 <rdar://problem/17383962> 1016761 2 233381 koivisto 2014-06-19 14:05:03 -0700 Created attachment 233381 patch 1016764 3 233381 simon.fraser 2014-06-19 14:09:56 -0700 Comment on attachment 233381 patch View in context: https://bugs.webkit.org/attachment.cgi?id=233381&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:577 > + if (m_frame == m_frame->page()->mainWebFrame()) { .isMainFrame()? > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:580 > + m_didCompletePageTransitionAlready = true; The "Already" here seems superfluous. 1016779 4 koivisto 2014-06-19 15:16:04 -0700 http://trac.webkit.org/changeset/170163 1016879 5 zsborbely.u-szeged 2014-06-20 01:04:33 -0700 It made all performance tests crash on EFL, here is the new bug report about is: https://bugs.webkit.org/show_bug.cgi?id=134097 Have you got any idea what happened? 233381 2014-06-19 14:05:03 -0700 2014-06-19 14:14:04 -0700 patch layer-tree-unfreeze.patch text/plain 3807 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDE2MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTE5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBVbmZyZWV6ZSB0aGUgbGF5ZXIg dHJlZSBvbiBEaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDA3MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgRGlkRmlyc3RMYXlvdXQgaXMg dG9vIGVhcmx5IGFuZCB3ZSB1c3VhbGx5IGdldCBhIGJsYW5rIHBhZ2UuIFRoaXMgZG9lc24ndCBt YXRjaCB0aGUgZXhpc3RpbmcgaU9TIGJlaGF2aW9yIGVpdGhlci4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRMYXlvdXQpOgorICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UGFnZTo6V2ViUGFnZSk6CisKIDIwMTQtMDYtMTkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBbQ29jb2FdIE5lZWQgU1BJIHRvIGRldGVybWluZSBpZiB0aGUgV0tXZWJW aWV3IGlzIGRpc3BsYXlpbmcgYSBzdGFuZGFsb25lIGltYWdlCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZy YW1lTG9hZGVyQ2xpZW50LmNwcAkocmV2aXNpb24gMTY5ODA2KQorKysgU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTU2MywxMyArNTYzLDYgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6 ZGlzcGF0Y2hEaWRMYQogICAgICAgICB3ZWJQYWdlLT5pbmplY3RlZEJ1bmRsZUxvYWRlckNsaWVu dCgpLmRpZEZpcnN0TGF5b3V0Rm9yRnJhbWUod2ViUGFnZSwgbV9mcmFtZSwgdXNlckRhdGEpOwog ICAgICAgICB3ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRpZEZpcnN0TGF5 b3V0Rm9yRnJhbWUobV9mcmFtZS0+ZnJhbWVJRCgpLCBJbmplY3RlZEJ1bmRsZVVzZXJNZXNzYWdl RW5jb2Rlcih1c2VyRGF0YS5nZXQoKSkpKTsKIAotICAgICAgICBpZiAobV9mcmFtZSA9PSBtX2Zy YW1lLT5wYWdlKCktPm1haW5XZWJGcmFtZSgpKSB7Ci0gICAgICAgICAgICBpZiAoIXdlYlBhZ2Ut PmNvcmVQYWdlKCktPnNldHRpbmdzKCkuc3VwcHJlc3Nlc0luY3JlbWVudGFsUmVuZGVyaW5nKCkg JiYgIW1fZGlkQ29tcGxldGVQYWdlVHJhbnNpdGlvbkFscmVhZHkpIHsKLSAgICAgICAgICAgICAg ICB3ZWJQYWdlLT5kaWRDb21wbGV0ZVBhZ2VUcmFuc2l0aW9uKCk7Ci0gICAgICAgICAgICAgICAg bV9kaWRDb21wbGV0ZVBhZ2VUcmFuc2l0aW9uQWxyZWFkeSA9IHRydWU7Ci0gICAgICAgICAgICB9 Ci0gICAgICAgIH0KLSAgICAKICNpZiBVU0UoVElMRURfQkFDS0lOR19TVE9SRSkKICAgICAgICAg Ly8gTWFrZSBzdXJlIHZpZXdwb3J0IHByb3BlcnRpZXMgYXJlIGRpc3BhdGNoZWQgb24gdGhlIG1h aW4gZnJhbWUgYnkgdGhlIHRpbWUgdGhlIGZpcnN0IGxheW91dCBoYXBwZW5zLgogICAgICAgICBB U1NFUlQoIXdlYlBhZ2UtPnVzZUZpeGVkTGF5b3V0KCkgfHwgbV9mcmFtZSAhPSBtX2ZyYW1lLT5w YWdlKCktPm1haW5XZWJGcmFtZSgpIHx8IG1fZnJhbWUtPmNvcmVGcmFtZSgpLT5kb2N1bWVudCgp LT5kaWREaXNwYXRjaFZpZXdwb3J0UHJvcGVydGllc0NoYW5nZWQoKSk7CkBAIC01ODEsNiArNTc0 LDEzIEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkTGEKICAgICB3ZWJQ YWdlLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRpZExheW91dChtaWxlc3RvbmVzLCBJ bmplY3RlZEJ1bmRsZVVzZXJNZXNzYWdlRW5jb2Rlcih1c2VyRGF0YS5nZXQoKSkpKTsKIAogICAg IGlmIChtaWxlc3RvbmVzICYgRGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0KSB7CisgICAg ICAgIGlmIChtX2ZyYW1lID09IG1fZnJhbWUtPnBhZ2UoKS0+bWFpbldlYkZyYW1lKCkpIHsKKyAg ICAgICAgICAgIGlmICghd2ViUGFnZS0+Y29yZVBhZ2UoKS0+c2V0dGluZ3MoKS5zdXBwcmVzc2Vz SW5jcmVtZW50YWxSZW5kZXJpbmcoKSAmJiAhbV9kaWRDb21wbGV0ZVBhZ2VUcmFuc2l0aW9uQWxy ZWFkeSkgeworICAgICAgICAgICAgICAgIHdlYlBhZ2UtPmRpZENvbXBsZXRlUGFnZVRyYW5zaXRp b24oKTsKKyAgICAgICAgICAgICAgICBtX2RpZENvbXBsZXRlUGFnZVRyYW5zaXRpb25BbHJlYWR5 ID0gdHJ1ZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCiAgICAgICAgIC8vIEZJWE1FOiBX ZSBzaG91bGQgY29uc2lkZXIgcmVtb3ZpbmcgdGhlIG9sZCBkaWRGaXJzdFZpc3VhbGx5Tm9uRW1w dHlMYXlvdXRGb3JGcmFtZSBBUEkgc2luY2UgdGhpcyBpcyBkb2luZwogICAgICAgICAvLyBkb3Vi bGUgZHV0eSB3aXRoIHRoZSBuZXcgZGlkTGF5b3V0IEFQSS4KICAgICAgICAgd2ViUGFnZS0+aW5q ZWN0ZWRCdW5kbGVMb2FkZXJDbGllbnQoKS5kaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRG b3JGcmFtZSh3ZWJQYWdlLCBtX2ZyYW1lLCB1c2VyRGF0YSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCShyZXZpc2lvbiAxNjk4MDYpCisr KyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ0Miw4ICs0NDIsOCBAQCBXZWJQYWdlOjpXZWJQYWdlKHVpbnQ2NF90IHBhZ2VJ RCwgY29uc3QgCiAgICAgCiAgICAgc2V0TWVkaWFWb2x1bWUocGFyYW1ldGVycy5tZWRpYVZvbHVt ZSk7CiAKLSAgICAvLyBXZSB1c2UgdGhlIERpZEZpcnN0TGF5b3V0IG1pbGVzdG9uZSB0byBkZXRl cm1pbmUgd2hlbiB0byB1bmZyZWV6ZSB0aGUgbGF5ZXIgdHJlZS4KLSAgICBtX3BhZ2UtPmFkZExh eW91dE1pbGVzdG9uZXMoRGlkRmlyc3RMYXlvdXQpOworICAgIC8vIFdlIHVzZSB0aGUgRGlkRmly c3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0IG1pbGVzdG9uZSB0byBkZXRlcm1pbmUgd2hlbiB0byB1 bmZyZWV6ZSB0aGUgbGF5ZXIgdHJlZS4KKyAgICBtX3BhZ2UtPmFkZExheW91dE1pbGVzdG9uZXMo RGlkRmlyc3RMYXlvdXQgfCBEaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQpOwogCiAgICAg V2ViUHJvY2Vzczo6c2hhcmVkKCkuYWRkTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2VzOjpXZWJQYWdl OjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIG1fcGFnZUlELCAqdGhpcyk7CiAK