134072 2014-06-19 13:35:24 -0700 [iOS]: Overrelease of RetainPtr object in file upload 2014-06-20 10:58:55 -0700 1 1 1 Unclassified WebKit WebKit2 412.x Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue ddkilzer dgorbik enrica joepeck oldest_to_newest 1016744 0 joepeck 2014-06-19 13:35:24 -0700 There is a -release call being sent to a RetainPtr object. That is unnecessary and will lead to an overrelease / extra release called on a deallocated object. 1016746 1 233377 joepeck 2014-06-19 13:36:59 -0700 Created attachment 233377 [PATCH] Proposed fix 1016747 2 joepeck 2014-06-19 13:38:23 -0700 <rdar://problem/17383446> 1016905 3 ddkilzer 2014-06-20 02:51:49 -0700 Commit queue has been stuck a long time on this patch. 1016964 4 joepeck 2014-06-20 10:58:55 -0700 <http://trac.webkit.org/changeset/170192> 233377 2014-06-19 13:36:59 -0700 2014-06-20 10:57:49 -0700 [PATCH] Proposed fix retainptr-fix.patch text/plain 1302 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmYzJmOGFlLi40OTNjZjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDYtMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbaU9TXTogT3ZlcnJlbGVhc2Ugb2YgUmV0YWluUHRyIG9iamVjdCBpbiBmaWxlIHVw bG9hZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0 MDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBpdmFyIGlzIGEgUmV0YWluUHRyLCB0aGUgcmVsZWFzZSB3aWxsIGJlIGRvbmUgYXV0b21hdGlj YWxseQorICAgICAgICBmb3IgdXMgd2hlbiB3ZSBhc3NpZ24gdG8gbmlsIG9yIGRlc3RydWN0Lgor CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06Cisg ICAgICAgICgtW1dLQ29udGVudFZpZXcgZmlsZVVwbG9hZFBhbmVsRGlkRGlzbWlzczpdKToKKwog MjAxNC0wNi0xNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCBTUEkgdG8gZ2V0IHRoZSBOU1VSTFJlcXVlc3QgZnJvbSBhIFdLTmF2aWdhdGlvblJl c3BvbnNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDdjNjg0YTUuLmZmZDdkYmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCkBAIC0yMjkwLDcgKzIyOTAsNiBAQCBzdGF0aWMgVUlUZXh0QXV0b2NhcGl0YWxpemF0 aW9uVHlwZSB0b1VJVGV4dEF1dG9jYXBpdGFsaXplKFdlYkF1dG9jYXBpdGFsaXplVHlwZQogICAg IEFTU0VSVChfZmlsZVVwbG9hZFBhbmVsLmdldCgpID09IGZpbGVVcGxvYWRQYW5lbCk7CiAKICAg ICBbX2ZpbGVVcGxvYWRQYW5lbCBzZXREZWxlZ2F0ZTpuaWxdOwotICAgIFtfZmlsZVVwbG9hZFBh bmVsIHJlbGVhc2VdOwogICAgIF9maWxlVXBsb2FkUGFuZWwgPSBuaWw7CiB9CiAK