134068 2014-06-19 12:18:03 -0700 Web Inspector: Esc in quick console no longer toggles console drawer 2014-06-21 07:51:46 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells timothy webkit-bug-importer oldest_to_newest 1016719 0 joepeck 2014-06-19 12:18:03 -0700 Regression. Pushing Esc in the quick console no longer toggles the console drawer. It should! 1016730 1 joepeck 2014-06-19 12:59:51 -0700 This appears to be a CodeMirror 4 regression, because CodeMirror now has a basic keymap for "Esc". 1016732 2 webkit-bug-importer 2014-06-19 13:01:04 -0700 <rdar://problem/17382967> 1016734 3 joepeck 2014-06-19 13:02:09 -0700 In CodeMirror 4 with multiple selection: Esc - singleSelection When multiple selections are present, this deselects all but the primary selection. 1016735 4 joepeck 2014-06-19 13:09:01 -0700 Maybe, CodeMirror should only prevent default if it actually did something. In any case we may be able to workaround this because we only want to toggle the console when there is no text. 1016768 5 joepeck 2014-06-19 14:27:32 -0700 This was annoying me quite a bit, so I made a workaround. I think we should still go through and suggest a code mirror change to only prevent default if an action was taken (if multiple selections were collapsed to one). 1016769 6 233383 joepeck 2014-06-19 14:27:48 -0700 Created attachment 233383 [PATCH] Proposed Fix 1016770 7 233383 timothy 2014-06-19 14:30:23 -0700 Comment on attachment 233383 [PATCH] Proposed Fix Looks good! I agree that CodeMirror should pass on the key if it doesn't do anything. 1017271 8 233383 commit-queue 2014-06-21 07:51:43 -0700 Comment on attachment 233383 [PATCH] Proposed Fix Clearing flags on attachment: 233383 Committed r170238: <http://trac.webkit.org/changeset/170238> 1017272 9 commit-queue 2014-06-21 07:51:46 -0700 All reviewed patches have been landed. Closing bug. 233383 2014-06-19 14:27:48 -0700 2014-06-21 07:51:43 -0700 [PATCH] Proposed Fix escape.patch text/plain 4290 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc3MTM2N2YuLmQyM2I2MGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE0LTA2LTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRXNjIGlu IHF1aWNrIGNvbnNvbGUgbm8gbG9uZ2VyIHRvZ2dsZXMgY29uc29sZSBkcmF3ZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDA2OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBFc2NhcGUgdG8gdG9n Z2xlIGNvbnNvbGUgYmVoYXZpb3Igd2Ugd2VyZSByZWx5aW5nIG9uIHRoZSBFc2NhcGUKKyAgICAg ICAga2V5Ym9hcmQgZXZlbnQgdG8gcHJvcGFnYXRlIHVwIHRvIHRoZSB3aW5kb3cgYW5kIGJlIGhh bmRsZWQgYnkKKyAgICAgICAgUXVpY2tDb25zb2xlJ3MgZ2xvYmFsIGtleWJvYXJkIHNob3J0Y3V0 LiBXaXRoIENvZGVNaXJyb3IgNCwgYWxsCisgICAgICAgIGVkaXRvcnMgaGF2ZSBhIGRlZmF1bHQg IkVzYyIga2V5IGhhbmRsZXIgdG8gcmVkdWNlIG11bHRpcGxlIHNlbGVjdGlvbnMKKyAgICAgICAg dG8gYSBzaW5nbGUgc2VsZWN0aW9uLiBVbmZvcnR1bmF0ZWx5IHRoaXMgYWx3YXlzIHByZXZlbnRz IGRlZmF1bHQsCisgICAgICAgIHdoaWNoIG91ciBrZXlib2FyZCBzaG9ydGN1dCByZXNwZWN0cyBh bmQgZG9lc24ndCB0b2dnbGUgdGhlIGNvbnNvbGUuCisKKyAgICAgICAgV29ya2Fyb3VuZCB0aGlz IGJ5IHB1dHRpbmcgYSBzcGVjaWZpYyBoYW5kbGVyIGZvciB3aGVuIGEgQ29uc29sZQorICAgICAg ICBQcm9tcHQgaXMgZW1wdHkgYW5kIHRoZSBFc2NhcGUga2V5IGlzIHRyaWdnZXJlZC4gVGhpcyBk b2VzIG5vdCBnbworICAgICAgICB0aHJvdWdoIHRoZSBub3JtYWwgQ29uc29sZVByb21wdCBkZWxl Z2F0ZSBiZWNhdXNlIHRoZSBkZWxlZ2F0ZQorICAgICAgICBpcyBuZXZlciB0aGUgUXVpY2tDb25z b2xlLCBpdCBpcyBhY3R1YWxseSB0aGUgSmF2YVNjcmlwdCBsb2cuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVQcm9tcHQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu Q29uc29sZVByb21wdCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVByb21wdC5wcm90 b3R5cGUuc2V0IGVzY2FwZUtleUhhbmRsZXJXaGVuRW1wdHkpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkNvbnNvbGVQcm9tcHQucHJvdG90eXBlLl9oYW5kbGVFc2NhcGVLZXkpOgorICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvUXVpY2tDb25zb2xlLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlF1aWNrQ29uc29sZS50aGlzLnByb21wdC5lc2NhcGVLZXlIYW5kbGVyV2hlbkVtcHR5KToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5RdWlja0NvbnNvbGUpOgorCiAyMDE0LTA2LTE3ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogUHJldHR5UHJpbnRpbmcgcmVncmVzc2lvbiBvbiAidmFyIGE9MSIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVQcm9tcHQuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlUHJvbXB0 LmpzCmluZGV4IDcxYjEzMjYuLmM1MTJiZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVQcm9tcHQuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZVByb21wdC5qcwpAQCAtNDks NyArNDksOCBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVByb21wdCA9IGZ1bmN0aW9uKGRlbGVnYXRl LCBtaW1lVHlwZSwgZWxlbWVudCkKICAgICAgICAgIkN0cmwtUCI6IHRoaXMuX2hhbmRsZVByZXZp b3VzS2V5LmJpbmQodGhpcyksCiAgICAgICAgICJDdHJsLU4iOiB0aGlzLl9oYW5kbGVOZXh0S2V5 LmJpbmQodGhpcyksCiAgICAgICAgICJFbnRlciI6IHRoaXMuX2hhbmRsZUVudGVyS2V5LmJpbmQo dGhpcyksCi0gICAgICAgICJDbWQtRW50ZXIiOiB0aGlzLl9oYW5kbGVDb21tYW5kRW50ZXJLZXku YmluZCh0aGlzKQorICAgICAgICAiQ21kLUVudGVyIjogdGhpcy5faGFuZGxlQ29tbWFuZEVudGVy S2V5LmJpbmQodGhpcyksCisgICAgICAgICJFc2MiOiB0aGlzLl9oYW5kbGVFc2NhcGVLZXkuYmlu ZCh0aGlzKQogICAgIH07CiAKICAgICB0aGlzLl9jb2RlTWlycm9yLmFkZEtleU1hcChrZXlNYXAp OwpAQCAtODQsNiArODUsMTEgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVQcm9tcHQucHJvdG90eXBl ID0gewogICAgICAgICB0aGlzLl9kZWxlZ2F0ZSA9IGRlbGVnYXRlIHx8IG51bGw7CiAgICAgfSwK IAorICAgIHNldCBlc2NhcGVLZXlIYW5kbGVyV2hlbkVtcHR5KGhhbmRsZXIpCisgICAgeworICAg ICAgICB0aGlzLl9lc2NhcGVLZXlIYW5kbGVyV2hlbkVtcHR5ID0gaGFuZGxlcjsKKyAgICB9LAor CiAgICAgZ2V0IHRleHQoKQogICAgIHsKICAgICAgICAgcmV0dXJuIHRoaXMuX2NvZGVNaXJyb3Iu Z2V0VmFsdWUoKTsKQEAgLTE1Miw2ICsxNTgsMTcgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVQcm9t cHQucHJvdG90eXBlID0gewogICAgIH0sCiAKICAgICAvLyBQcml2YXRlCisgICAgCisgICAgX2hh bmRsZUVzY2FwZUtleTogZnVuY3Rpb24oY29kZU1pcnJvcikKKyAgICB7CisgICAgICAgIGlmICh0 aGlzLnRleHQpCisgICAgICAgICAgICByZXR1cm4gQ29kZU1pcnJvci5QYXNzOworCisgICAgICAg IGlmICghdGhpcy5fZXNjYXBlS2V5SGFuZGxlcldoZW5FbXB0eSkKKyAgICAgICAgICAgIHJldHVy biBDb2RlTWlycm9yLlBhc3M7CisKKyAgICAgICAgdGhpcy5fZXNjYXBlS2V5SGFuZGxlcldoZW5F bXB0eSgpOworICAgIH0sCiAKICAgICBfaGFuZGxlUHJldmlvdXNLZXk6IGZ1bmN0aW9uKGNvZGVN aXJyb3IpCiAgICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUXVpY2tDb25zb2xlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvUXVpY2tDb25zb2xlLmpzCmluZGV4IGFiYTIzYWYuLmQ2MzE5MDcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1F1aWNr Q29uc29sZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9RdWlja0NvbnNvbGUuanMKQEAgLTQzLDYgKzQzLDEzIEBAIFdlYkluc3BlY3Rvci5RdWlja0Nv bnNvbGUgPSBmdW5jdGlvbihlbGVtZW50KQogICAgIHRoaXMucHJvbXB0LmVsZW1lbnQuY2xhc3NM aXN0LmFkZChXZWJJbnNwZWN0b3IuUXVpY2tDb25zb2xlLlRleHRQcm9tcHRTdHlsZUNsYXNzTmFt ZSk7CiAgICAgdGhpcy5fZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLnByb21wdC5lbGVtZW50KTsK IAorICAgIC8vIEZJWE1FOiBDb2RlTWlycm9yIDQgaGFzIGEgZGVmYXVsdCAiRXNjIiBrZXkgaGFu ZGxlciB0aGF0IGFsd2F5cyBwcmV2ZW50cyBkZWZhdWx0LgorICAgIC8vIE91ciBrZXlib2FyZCBz aG9ydGN1dCBhYm92ZSB3aWxsIHJlc3BlY3QgdGhlIGRlZmF1bHQgcHJldmVudGVkIGFuZCBpZ25v cmUgdGhlIGV2ZW50CisgICAgLy8gYW5kIG5vdCB0b2dnbGUgdGhlIGNvbnNvbGUuIEluc3RhbGwg b3VyIG93biBFc2NhcGUga2V5IGhhbmRsZXIgdGhhdCB3aWxsIHRyaWdnZXIKKyAgICAvLyB3aGVu IHRoZSBDb25zb2xlUHJvbXB0IGlzIGVtcHR5LCB0byByZXN0b3JlIHRvZ2dsaW5nIGJlaGF2aW9y LiBBIGJldHRlciBzb2x1dGlvbgorICAgIC8vIHdvdWxkIGJlIGZvciBDb2RlTWlycm9yJ3MgZXZl bnQgaGFuZGxlciB0byBwYXNzIGlmIGl0IGRvZXNuJ3QgZG8gYW55dGhpbmcuCisgICAgdGhpcy5w cm9tcHQuZXNjYXBlS2V5SGFuZGxlcldoZW5FbXB0eSA9IGZ1bmN0aW9uKCkgeyBXZWJJbnNwZWN0 b3IudG9nZ2xlU3BsaXRDb25zb2xlKCk7IH07CisKICAgICB0aGlzLnByb21wdC5zaG93bigpOwog CiAgICAgdGhpcy5fbmF2aWdhdGlvbkJhciA9IG5ldyBXZWJJbnNwZWN0b3IuUXVpY2tDb25zb2xl TmF2aWdhdGlvbkJhcjsK