134059 2014-06-19 04:43:04 -0700 REGRESSION (r168685): css calc() expression fails 2014-06-27 11:56:17 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.9 RESOLVED FIXED http://jsfiddle.net/hooleyhoop/3RZ8Q/4/ InRadar P2 Normal --- 132870 1 steven.hooley webkit-unassigned benjamin bunhere cdumez commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard mhodovan mhodovan.u-szeged ossy sergio simon.fraser webkit-bug-importer oldest_to_newest 1016660 0 steven.hooley 2014-06-19 04:43:04 -0700 This expression no longer works.. width: calc((100% - 20px) / 3; equivalent expression still works width: calc(100%/3 - 20px/3) 1016926 1 simon.fraser 2014-06-20 08:28:06 -0700 Regressed in http://trac.webkit.org/changeset/168685. 1017886 2 webkit-bug-importer 2014-06-24 00:39:16 -0700 <rdar://problem/17431912> 1017959 3 simon.fraser 2014-06-24 08:58:32 -0700 Martin, can you take a look please, so we don't have to roll out your patch? 1017963 4 mhodovan 2014-06-24 09:05:39 -0700 Yes, I am already working on it, I just need a little more time. I will upload a patch till tomorrow. 1018047 5 mhodovan 2014-06-24 12:16:56 -0700 I have reverted my repository to the revision before right my patch (r168684) and it does not work either. This expression can not be parsed properly because of the superfluous '(' character, but seems like it is an older issue. () However, I am glad to investigate it. The following example shows two rectangle of the same size: <div width="300px"> <div style="height:100px; width: calc((100% - 20px) / 3); border: 1px solid;" ></div> <div style="height:100px; width: calc(100%/3 - 20px/3); border: 1px solid;"></div> </div> 1018050 6 simon.fraser 2014-06-24 12:32:20 -0700 The test case def. worked in http://trac.webkit.org/changeset/168684 1018292 7 mhodovan.u-szeged 2014-06-25 02:57:11 -0700 (In reply to comment #0) > This expression no longer works.. > > width: calc((100% - 20px) / 3; I think there has been some misunderstanding here. Your first example is a malformed expression, because a closing brace is missing from the end, and therefore it can not be parsed properly. I thought that my patch has ruined some error recovery feature, which seemed a little unlikely, since my patch did not change the CSS grammar. So I double-checked it and the expression you mentioned has never worked before. (Maybe I should report it, if it needs auto-correction at all.) But now I get it. "width: calc((100% - 20px) / 3)" is now a well-formed expression and it really does not work since my patch has landed. Thank you for your patience, I will upload a fix very soon. 1018974 8 233987 mhodovan.u-szeged 2014-06-27 09:25:00 -0700 Created attachment 233987 Proposed patch 1019040 9 233987 commit-queue 2014-06-27 11:56:10 -0700 Comment on attachment 233987 Proposed patch Clearing flags on attachment: 233987 Committed r170544: <http://trac.webkit.org/changeset/170544> 1019041 10 commit-queue 2014-06-27 11:56:17 -0700 All reviewed patches have been landed. Closing bug. 233987 2014-06-27 09:25:00 -0700 2014-06-27 11:56:10 -0700 Proposed patch 0001-calc-percentage-pixel.patch text/plain 4367 mhodovan.u-szeged RnJvbSBmZWYxOGI1OTQwOTA2YWUzM2NkZjQ4YTlkZDY4NTZiOTcxNzk5Zjc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtYXJ0aW4gPG1ob2RvdmFuLnUtc3plZ2VkQHBhcnRuZXIuc2Ft c3VuZy5jb20+CkRhdGU6IEZyaSwgMjcgSnVuIDIwMTQgMTg6MjA6MDYgKzAyMDAKU3ViamVjdDog W1BBVENIXSBjYWxjLXBlcmNlbnRhZ2UtcGl4ZWwKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMyArKysrKysrKysrKysrCiBM YXlvdXRUZXN0cy9mYXN0L2Nzcy9jYWxjLXBlcmNlbnRhZ2UtcGl4ZWwtZXhwZWN0ZWQuaHRtbCB8 IDE0ICsrKysrKysrKysrKysrCiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9jYWxjLXBlcmNlbnRhZ2Ut cGl4ZWwuaHRtbCAgICAgICAgICB8IDE0ICsrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDE2ICsrKysrKysrKysr KysrKysKIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcCAgICAgICAg ICAgICAgIHwgIDQgKystLQogNSBmaWxlcyBjaGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2Zhc3QvY3NzL2NhbGMt cGVyY2VudGFnZS1waXhlbC1leHBlY3RlZC5odG1sCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0 VGVzdHMvZmFzdC9jc3MvY2FsYy1wZXJjZW50YWdlLXBpeGVsLmh0bWwKCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDM1NmI1 MC4uNDIxY2VkYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA2LTI3ICBNYXJ0aW4gSG9k b3ZhbiAgPG1ob2RvdmFuLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTiAocjE2ODY4NSk6IGNzcyBjYWxjKCkgZXhwcmVzc2lvbiBmYWlscyAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNDA1OQorCisgICAg ICAgIEFkZGVkIHRlc3QgZGVtb25zdHJhdGVzIHRoYXQgZXhwcmVzc2lvbnMgbGlrZQorICAgICAg ICAnY2FsYygoMTAwJSAtIDIwcHgpIC8gMycgd29yayBjb3JyZWN0bHkgYWdhaW4uCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9jYWxj LXBlcmNlbnRhZ2UtcGl4ZWwtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9j c3MvY2FsYy1wZXJjZW50YWdlLXBpeGVsLmh0bWw6IEFkZGVkLgorCiAyMDE0LTA2LTI2ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBpT1MgOCBiZXRh IDIgRVM2ICdTZXQnIGNsZWFyKCkgYnJva2VuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9jYWxjLXBlcmNlbnRhZ2UtcGl4ZWwtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvY3NzL2NhbGMtcGVyY2VudGFnZS1waXhlbC1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLmMxOGRiYTgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Nzcy9jYWxjLXBlcmNlbnRhZ2UtcGl4ZWwtZXhwZWN0ZWQuaHRtbApAQCAtMCww ICsxLDE0IEBACis8aHRtbD4KKyAgPGhlYWQ+CisgICAgPHN0eWxlPgorICAgICAgI3JlY3Rhbmds ZSB7IAorICAgICAgICB3aWR0aDogY2FsYygxMDAlLzMgLSAyMHB4LzMpOworICAgICAgICBoZWln aHQ6IGNhbGMoMzAlLzMgKyAxMHB4LzMpOworICAgICAgICBiYWNrZ3JvdW5kOiBncmVlbjsKKyAg ICAgIH0KKyAgICA8L3N0eWxlPgorICA8L2hlYWQ+CisgIDxib2R5PgorICAJPGRpdiBpZD0icmVj dGFuZ2xlIj48L2Rpdj4KKyAgPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2NhbGMtcGVyY2VudGFnZS1w aXhlbC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY2FsYy1wZXJjZW50YWdlLXBpeGVsLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMjE3NmU4ZAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2NhbGMtcGVyY2VudGFnZS1waXhlbC5odG1s CkBAIC0wLDAgKzEsMTQgQEAKKzxodG1sPgorICA8aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICAj cmVjdGFuZ2xlIHsgCisgICAgICAgIHdpZHRoOiBjYWxjKCgxMDAlIC0gMjBweCkgLyAzKTsKKyAg ICAgICAgaGVpZ2h0OiBjYWxjKCgzMCUgKyAxMHB4KSAvIDMpOworICAgICAgICBiYWNrZ3JvdW5k OiBncmVlbjsKKyAgICAgIH0KKyAgICA8L3N0eWxlPgorICA8L2hlYWQ+CisgIDxib2R5PgorICAJ PGRpdiBpZD0icmVjdGFuZ2xlIj48L2Rpdj4KKyAgPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xp bmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwZWUxYWIzLi43OGU5NTEyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDYtMjcgIE1hcnRpbiBIb2RvdmFuICA8bWhvZG92 YW4udS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MTY4Njg1KTogY3NzIGNhbGMoKSBleHByZXNzaW9uIGZhaWxzIAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MDU5CisKKyAgICAgICAgVGhlIGV4cHJl c3Npb24gJ2NhbGMoKDEwMCUgLSAyMHB4KSAvIDMnIGRpZCBub3Qgd29yayBwcm9wZXJseSBhZnRl ciByMTY4Njg1LAorICAgICAgICBiZWNhdXNlIHByaW1pdGl2ZVR5cGUoKSBmdW5jdGlvbiBpbiBD U1NDYWxjdWxhdGlvblZhbHVlLmNwcCBoYXMgaGFuZGxlZAorICAgICAgICBDYWxjUGVyY2VudExl bmd0aCBhbmQgQ2FsY1BlcmNlbnROdW1iZXIgY2F0ZWdvcmllcyBhcyBpZiB0aGV5IHdlcmUgYW5n bGVzLgorICAgICAgICBUaGUgcGF0Y2ggZml4ZXMgdGhpcyBpbmNvcnJlY3QgYmVoYXZpb3IuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFz dC9jc3MvY2FsYy1wZXJjZW50YWdlLXBpeGVsLmh0bWwKKworICAgICAgICAqIGNzcy9DU1NDYWxj dWxhdGlvblZhbHVlLmNwcDoKKwogMjAxNC0wNi0yNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3Jt YW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gOHRyYWNrcy5jb20gdHJpZ2dlcnMgYW5u b3lpbmcgcG9wLXVwIHdpbmRvdy9pbnN0YWxsYXRpb24gb2YgIkFib3V0IHByb3RvY29sIHNvdXJj ZSBwbHVnaW4iIChHU3RyZWFtZXI/KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U0NhbGN1bGF0aW9uVmFsdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NhbGN1bGF0aW9u VmFsdWUuY3BwCmluZGV4IDVhYzZmNDkuLjYzNWRhODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTQ2FsY3VsYXRpb25WYWx1ZS5jcHAKQEAgLTQ5MywxNCArNDkzLDE0IEBAIHByaXZhdGU6CiAg ICAgICAgICAgICAgICAgcmV0dXJuIGxlZnRUeXBlOwogICAgICAgICAgICAgcmV0dXJuIENTU1By aW1pdGl2ZVZhbHVlOjpDU1NfVU5LTk9XTjsKICAgICAgICAgfQotICAgICAgICBjYXNlIENhbGNQ ZXJjZW50TGVuZ3RoOgotICAgICAgICBjYXNlIENhbGNQZXJjZW50TnVtYmVyOgogICAgICAgICBj YXNlIENhbGNBbmdsZToKICAgICAgICAgICAgIHJldHVybiBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NT X0RFRzsKICAgICAgICAgY2FzZSBDYWxjVGltZToKICAgICAgICAgICAgIHJldHVybiBDU1NQcmlt aXRpdmVWYWx1ZTo6Q1NTX01TOwogICAgICAgICBjYXNlIENhbGNGcmVxdWVuY3k6CiAgICAgICAg ICAgICByZXR1cm4gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19IWjsKKyAgICAgICAgY2FzZSBDYWxj UGVyY2VudExlbmd0aDoKKyAgICAgICAgY2FzZSBDYWxjUGVyY2VudE51bWJlcjoKICAgICAgICAg Y2FzZSBDYWxjT3RoZXI6CiAgICAgICAgICAgICByZXR1cm4gQ1NTUHJpbWl0aXZlVmFsdWU6OkNT U19VTktOT1dOOwogICAgICAgICB9Ci0tIAoxLjguMS4yCgo=