134044 2014-06-18 15:44:15 -0700 Remove IWebFramePrivate::loadType 2014-06-19 04:44:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca andersca ossy thorton oldest_to_newest 1016565 0 andersca 2014-06-18 15:44:15 -0700 Remove IWebFramePrivate::loadType 1016566 1 233332 andersca 2014-06-18 15:46:21 -0700 Created attachment 233332 Patch 1016570 2 andersca 2014-06-18 15:57:54 -0700 Committed r170125: <http://trac.webkit.org/changeset/170125> 1016661 3 ossy 2014-06-19 04:44:30 -0700 It broke the Apple Windows build: 1>WebFrame.obj : error LNK2001: unresolved external symbol "public: virtual long __stdcall WebFrame::unused3(void)" (?unused3@WebFrame@@UAGJXZ) 1>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals 233332 2014-06-18 15:46:21 -0700 2014-06-18 15:53:19 -0700 Patch bug-134044-20140618154603.patch text/plain 5029 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggZGQ3ZGUzNWQ4 ZDQ2OGU4ZDhkZDhhYWJmMGNmMDViNTFlZmFjYTYwNy4uYzU1YWRiNjZjYTE3NjZiMGVmY2QxMjlm ODFlYzliYjY3ZTUwODFjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0 LTA2LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAg UmVtb3ZlIElXZWJGcmFtZVByaXZhdGU6OmxvYWRUeXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzQwNDQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEludGVyZmFjZXMvSVdlYkZyYW1lUHJpdmF0ZS5p ZGw6CisgICAgICAgICogV2ViRnJhbWUuY3BwOgorICAgICAgICAoV2ViRnJhbWU6OmxvYWRUeXBl KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkZyYW1lOjp1bnVzZWQyKTogRGVsZXRlZC4KKyAgICAg ICAgKiBXZWJGcmFtZS5oOgorCiAyMDE0LTA2LTEyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1A YXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIEF2b2lkIGNyYXNoZXMgaW4gY29kZSB0aGF0IGNv bnZlcnRlZCBDRkRpY3Rpb25hcmllcyB0byBIYXNoTWFwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJGcmFtZVByaXZhdGUuaWRsIGIvU291cmNlL1dlYktpdC93 aW4vSW50ZXJmYWNlcy9JV2ViRnJhbWVQcml2YXRlLmlkbAppbmRleCAxM2FhOTU5MGNiYTMwNDc5 Nzc0MzQ0OWQwZTRiZDIwN2E4NTA3ODk4Li5iMWNiMjlkOWEzMTc4ZGNmN2VkODdmNTgzOTY2Njhm OGRiNWU2OTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJG cmFtZVByaXZhdGUuaWRsCisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYkZy YW1lUHJpdmF0ZS5pZGwKQEAgLTU0LDEzICs1NCwxMyBAQCB0eXBlZGVmIGVudW0gewogCiBpbnRl cmZhY2UgSVdlYkZyYW1lUHJpdmF0ZSA6IElVbmtub3duCiB7Ci0gICAgSFJFU1VMVCB1bnVzZWQx KFtvdXQsIHJldHZhbF0gQlNUUiopOworICAgIEhSRVNVTFQgdW51c2VkMSgpOwogICAgIEhSRVNV TFQgc2Nyb2xsT2Zmc2V0KFtvdXQsIHJldHZhbF0gU0laRSogb2Zmc2V0KTsKIAogICAgIC8vIEZJ WE1FOiBUaGlzIHNob3VsZG4ndCBiZSBuZWVkZWQgb25jZSBJV2ViRG9jdW1lbnRWaWV3IGlzIGlt cGxlbWVudGVkLgogICAgIEhSRVNVTFQgbGF5b3V0KCk7CiAgICAgSFJFU1VMVCBmaXJzdExheW91 dERvbmUoW291dCwgcmV0dmFsXSBCT09MKiByZXN1bHQpOwotICAgIEhSRVNVTFQgbG9hZFR5cGUo W291dCwgcmV0dmFsXSBXZWJGcmFtZUxvYWRUeXBlKiB0eXBlKTsKKyAgICBIUkVTVUxUIHVudXNl ZDIoKTsKIAogICAgIEhSRVNVTFQgc2V0SW5QcmludGluZ01vZGUoW2luXSBCT09MIHZhbHVlLCBb aW5dIEhEQyBwcmludERDKTsKICAgICBIUkVTVUxUIGdldFByaW50ZWRQYWdlQ291bnQoW2luXSBI REMgcHJpbnREQywgW291dCwgcmV0dmFsXSBVSU5UKiBwYWdlQ291bnQpOwpAQCAtNzgsNyArNzgs NyBAQCBpbnRlcmZhY2UgSVdlYkZyYW1lUHJpdmF0ZSA6IElVbmtub3duCiAKICAgICBIUkVTVUxU IHBlbmRpbmdGcmFtZVVubG9hZEV2ZW50Q291bnQoW291dCwgcmV0dmFsXSBVSU5UKiByZXN1bHQp OwogCi0gICAgSFJFU1VMVCB1bnVzZWQyKCk7CisgICAgSFJFU1VMVCB1bnVzZWQzKCk7CiAKICAg ICBIUkVTVUxUIHBhaW50RG9jdW1lbnRSZWN0VG9Db250ZXh0KFtpbl0gUkVDVCByZWN0LCBbaW5d IE9MRV9IQU5ETEUgZGV2aWNlQ29udGV4dCk7CiAKQEAgLTk2LDcgKzk2LDcgQEAgaW50ZXJmYWNl IElXZWJGcmFtZVByaXZhdGUgOiBJVW5rbm93bgogCiAgICAgW2xvY2FsXSBKU0dsb2JhbENvbnRl eHRSZWYgZ2xvYmFsQ29udGV4dEZvclNjcmlwdFdvcmxkKFtpbl0gSVdlYlNjcmlwdFdvcmxkKik7 CiAKLSAgICBIUkVTVUxUIHVudXNlZDMoW2luXSBCU1RSLCBbb3V0LCByZXR2YWxdIEJTVFIqKTsK KyAgICBIUkVTVUxUIHVudXNlZDQoKTsKIAogICAgIEhSRVNVTFQgdmlzaWJsZUNvbnRlbnRSZWN0 KFtvdXQsIHJldHZhbF0gUkVDVCopOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dpbi9X ZWJGcmFtZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAKaW5kZXggODBjNjNh NmJjZWZhMzRjYzZlMTBkYjI1ZmVkZGFmYzlkY2JiZDBhOC4uMjczOGI1ZGI2ZDBhNGIxNTc3ZjNl MDcwMDY3NmY5OTlkZWZjNjA5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vV2ViRnJh bWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL1dlYkZyYW1lLmNwcApAQCAtOTUwLDI0ICs5 NTAsNiBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYkZyYW1lOjpmaXJzdExheW91dERv bmUoCiAgICAgcmV0dXJuIFNfT0s7CiB9CiAKLUhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgV2Vi RnJhbWU6OmxvYWRUeXBlKCAKLSAgICAvKiBbcmV0dmFsXVtvdXRdICovIFdlYkZyYW1lTG9hZFR5 cGUqIHR5cGUpCi17Ci0gICAgaWYgKCF0eXBlKSB7Ci0gICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hF RCgpOwotICAgICAgICByZXR1cm4gRV9QT0lOVEVSOwotICAgIH0KLQotICAgICp0eXBlID0gKFdl YkZyYW1lTG9hZFR5cGUpMDsKLQotICAgIEZyYW1lKiBjb3JlRnJhbWUgPSBjb3JlKHRoaXMpOwot ICAgIGlmICghY29yZUZyYW1lKQotICAgICAgICByZXR1cm4gRV9GQUlMOwotCi0gICAgKnR5cGUg PSAoV2ViRnJhbWVMb2FkVHlwZSljb3JlRnJhbWUtPmxvYWRlcigpLmxvYWRUeXBlKCk7Ci0gICAg cmV0dXJuIFNfT0s7Ci19Ci0KIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgV2ViRnJhbWU6OnBl bmRpbmdGcmFtZVVubG9hZEV2ZW50Q291bnQoIAogICAgIC8qIFtyZXR2YWxdW291dF0gKi8gVUlO VCogcmVzdWx0KQogewpAQCAtOTg2LDExICs5NjgsNiBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExU WVBFIFdlYkZyYW1lOjpwZW5kaW5nRnJhbWVVbmxvYWRFdmVudENvdW50KAogICAgIHJldHVybiBT X09LOwogfQogCi1IUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFdlYkZyYW1lOjp1bnVzZWQyKCkK LXsKLSAgICByZXR1cm4gRV9OT1RJTVBMOwotfQotCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBF IFdlYkZyYW1lOjpoYXNTcGVsbGluZ01hcmtlcigKICAgICAgICAgLyogW2luXSAqLyBVSU5UIGZy b20sCiAgICAgICAgIC8qIFtpbl0gKi8gVUlOVCBsZW5ndGgsCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L3dpbi9XZWJGcmFtZS5oIGIvU291cmNlL1dlYktpdC93aW4vV2ViRnJhbWUuaAppbmRl eCBlZTUwYTg0N2M5NWQ2MjhmOTE2YWUwZGUzMjAyYjNiN2VjNGQ1N2RjLi4zNmRjZGMyMzMzZjM4 ZGZhNDU1NzVkYzAzNjE0MGI4ZjNiZjQyMzhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3dp bi9XZWJGcmFtZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL1dlYkZyYW1lLmgKQEAgLTE1Nyw3 ICsxNTcsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCAvKiBbbG9jYWxdICovIEpTR2xvYmFsQ29u dGV4dFJlZiBTVERNRVRIT0RDQUxMVFlQRSBnbG9iYWxDb250ZXh0KCk7CiAKICAgICAvLyBJV2Vi RnJhbWVQcml2YXRlCi0gICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHVudXNl ZDEoQlNUUiopIHsgcmV0dXJuIEVfTk9USU1QTDsgfQorICAgIHZpcnR1YWwgSFJFU1VMVCBTVERN RVRIT0RDQUxMVFlQRSB1bnVzZWQxKCkgeyByZXR1cm4gRV9OT1RJTVBMOyB9CiAgICAgdmlydHVh bCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHJlbmRlclRyZWVBc0V4dGVybmFsUmVwcmVzZW50 YXRpb24oQk9PTCBmb3JQcmludGluZywgQlNUUiAqcmVzdWx0KTsKIAogICAgIHZpcnR1YWwgSFJF U1VMVCBTVERNRVRIT0RDQUxMVFlQRSBwYWdlTnVtYmVyRm9yRWxlbWVudEJ5SWQoCkBAIC0xNzks MTMgKzE3OSwxMiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExU WVBFIGZpcnN0TGF5b3V0RG9uZSgKICAgICAgICAgLyogW3JldHZhbF1bb3V0XSAqLyBCT09MKiBy ZXN1bHQpOwogCi0gICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGxvYWRUeXBl KCAKLSAgICAgICAgLyogW3JldHZhbF1bb3V0XSAqLyBXZWJGcmFtZUxvYWRUeXBlKiB0eXBlKTsK KyAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgdW51c2VkMigpIHsgcmV0dXJu IEVfTk9USU1QTDsgfQogCiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHBl bmRpbmdGcmFtZVVubG9hZEV2ZW50Q291bnQoIAogICAgICAgICAvKiBbcmV0dmFsXVtvdXRdICov IFVJTlQqIHJlc3VsdCk7CiAKLSAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUg dW51c2VkMigpOworICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSB1bnVzZWQz KCk7CiAgICAgCiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHNldEluUHJp bnRpbmdNb2RlKCAKICAgICAgICAgLyogW2luXSAqLyBCT09MIHZhbHVlLApAQCAtMjc3LDcgKzI3 Niw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBz ZXRUZXh0RGlyZWN0aW9uKEJTVFIpOwogCi0gICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENB TExUWVBFIHVudXNlZDMoQlNUUiwgQlNUUiopIHsgcmV0dXJuIEVfTk9USU1QTDsgfQorICAgIHZp cnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSB1bnVzZWQ0KCkgeyByZXR1cm4gRV9OT1RJ TVBMOyB9CiAKICAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgcmVzdW1lQW5p bWF0aW9ucygpOwogCg==