134038 2014-06-18 13:51:55 -0700 -[JSContext setName:] leaks NSString 2014-06-19 20:39:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer commit-queue ggaren joepeck mhahnenberg timothy oldest_to_newest 1016529 0 ddkilzer 2014-06-18 13:51:55 -0700 JavaScriptCore/API/JSContext.mm:200:73: warning: Potential leak of an object JSStringRef nameJS = name ? JSStringCreateWithCFString((CFStringRef)[name copy]) : nullptr; ^ 1016530 1 233325 ddkilzer 2014-06-18 13:53:28 -0700 Created attachment 233325 Patch v1 1016532 2 233325 joepeck 2014-06-18 14:05:29 -0700 Comment on attachment 233325 Patch v1 r=me! Thanks 1016543 3 233325 commit-queue 2014-06-18 14:42:13 -0700 Comment on attachment 233325 Patch v1 Clearing flags on attachment: 233325 Committed r170117: <http://trac.webkit.org/changeset/170117> 1016544 4 commit-queue 2014-06-18 14:42:15 -0700 All reviewed patches have been landed. Closing bug. 1016832 5 233325 darin 2014-06-19 20:39:18 -0700 Comment on attachment 233325 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=233325&action=review > Source/JavaScriptCore/API/JSContext.mm:200 > - JSStringRef nameJS = name ? JSStringCreateWithCFString((CFStringRef)[name copy]) : nullptr; > + JSStringRef nameJS = name ? JSStringCreateWithCFString((CFStringRef)[[name copy] autorelease]) : nullptr; Why not just remove the call to copy? There’s no need for a copy here. 233325 2014-06-18 13:53:28 -0700 2014-06-19 20:39:18 -0700 Patch v1 bug-134038-20140618135306.patch text/plain 1703 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx N2RmYjY2MDU0ZjU5NzU2YTFmNjdmZTkwMmVhMjFhMDIwYmZiZGE4Li5mYTNmOGIxYTY0MDhhYjI3 MDAzNjA0MWU4MTMyOTQ1ZTBhYzUxODc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNC0wNi0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIC1bSlNDb250ZXh0IHNldE5hbWU6XSBsZWFrcyBOU1N0cmluZworICAgICAg ICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzQwMzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgdGhlIGZvbGxvd2luZyBzdGF0aWMgYW5hbHl6 ZXIgd2FybmluZzoKKworICAgICAgICAgICAgSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4dC5t bToyMDA6NzM6IHdhcm5pbmc6IFBvdGVudGlhbCBsZWFrIG9mIGFuIG9iamVjdAorICAgICAgICAg ICAgICAgIEpTU3RyaW5nUmVmIG5hbWVKUyA9IG5hbWUgPyBKU1N0cmluZ0NyZWF0ZVdpdGhDRlN0 cmluZygoQ0ZTdHJpbmdSZWYpW25hbWUgY29weV0pIDogbnVsbHB0cjsKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIF4KKworICAgICAgICAqIEFQSS9KU0NvbnRleHQubW06CisgICAgICAgICgt W0pTQ29udGV4dCBzZXROYW1lOl0pOiBBdXRvcmVsZWFzZSB0aGUgY29weSBvZiB8bmFtZXwuCisK IDIwMTQtMDYtMTYgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAg ICAgQ29udmVydCBBU1NFUlQgaW4gaW5saW5lRnVuY3Rpb25Gb3JDYXBhYmlsaXR5TGV2ZWwgdG8g ZWFybHkgcmV0dXJuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29u dGV4dC5tbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0Lm1tCmluZGV4IGM4 ZjRkNGM1MmI5YjlkYzMwY2VjNjUwZjk2OTNlMDZmYmVlN2QyOTUuLmVmNTlmZWY3MjA3M2JhYjA2 MGVlM2E3NzJhZjlkZWM4NTc4MDk1OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9BUEkvSlNDb250ZXh0Lm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250 ZXh0Lm1tCkBAIC0xOTcsNyArMTk3LDcgQEAgLSAoTlNTdHJpbmcgKiluYW1lCiAKIC0gKHZvaWQp c2V0TmFtZTooTlNTdHJpbmcgKiluYW1lCiB7Ci0gICAgSlNTdHJpbmdSZWYgbmFtZUpTID0gbmFt ZSA/IEpTU3RyaW5nQ3JlYXRlV2l0aENGU3RyaW5nKChDRlN0cmluZ1JlZilbbmFtZSBjb3B5XSkg OiBudWxscHRyOworICAgIEpTU3RyaW5nUmVmIG5hbWVKUyA9IG5hbWUgPyBKU1N0cmluZ0NyZWF0 ZVdpdGhDRlN0cmluZygoQ0ZTdHJpbmdSZWYpW1tuYW1lIGNvcHldIGF1dG9yZWxlYXNlXSkgOiBu dWxscHRyOwogICAgIEpTR2xvYmFsQ29udGV4dFNldE5hbWUobV9jb250ZXh0LCBuYW1lSlMpOwog ICAgIGlmIChuYW1lSlMpCiAgICAgICAgIEpTU3RyaW5nUmVsZWFzZShuYW1lSlMpOwo=