134036 2014-06-18 13:46:38 -0700 Simplify WebCredential 2014-06-18 13:56:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1016525 0 andersca 2014-06-18 13:46:38 -0700 Simplify WebCredential 1016527 1 233323 andersca 2014-06-18 13:48:31 -0700 Created attachment 233323 Patch 1016531 2 andersca 2014-06-18 13:56:36 -0700 Committed r170114: <http://trac.webkit.org/changeset/170114> 233323 2014-06-18 13:48:31 -0700 2014-06-18 13:49:58 -0700 Patch bug-134036-20140618134813.patch text/plain 6199 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjVkYjE2MDA1YmQ3N2Iw NWRjNTM4MjdhNTVjN2IzZGRhODY3ODZhYS4uNDMzY2FlMmI4Yjk1YTk4OTdhMmExODY1YTFmMjc5 NTlmMTE5NDY3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE0LTA2LTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgU2ltcGxpZnkgV2Vi Q3JlZGVudGlhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM0MDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tDcmVkZW50aWFsLmNwcDoKKyAgICAgICAgKFdLQ3JlZGVu dGlhbENyZWF0ZSk6CisgICAgICAgIChXS0NyZWRlbnRpYWxDcmVhdGVXaXRoQ2VydGlmaWNhdGVJ bmZvKToKKyAgICAgICAgKFdLQ3JlZGVudGlhbENvcHlVc2VyKToKKyAgICAgICAgKiBVSVByb2Nl c3MvQXV0aGVudGljYXRpb24vQXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94eS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlUHJveHk6OnVzZUNyZWRlbnRpYWwp OgorICAgICAgICAqIFVJUHJvY2Vzcy9BdXRoZW50aWNhdGlvbi9XZWJDcmVkZW50aWFsLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViQ3JlZGVudGlhbDo6Y3JlZGVudGlhbCk6CisgICAgICAgIChX ZWJLaXQ6OldlYkNyZWRlbnRpYWw6OmNvcmUpOiBEZWxldGVkLgorICAgICAgICAoV2ViS2l0OjpX ZWJDcmVkZW50aWFsOjp1c2VyKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQXV0aGVu dGljYXRpb24vV2ViQ3JlZGVudGlhbC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJDcmVkZW50aWFs OjpjcmVhdGUpOiBEZWxldGVkLgorCisyMDE0LTA2LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgR2l2ZSBXS1dlYlZpZXcgb24gaU9TIGEgbW9iaWxl IHVzZXIgYWdlbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNDAzNAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTczNDY0ODk+CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDcmVkZW50aWFsLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NyZWRlbnRpYWwuY3BwCmluZGV4IDZhOTU2MDAz YmUyZWMzODdjOGIxNzZjNWJiZGQ0ZTU3NWU0YTEwZmUuLmI3MGVlNDA3MGQ4NDVhOTY5NzQxZWZl OTZmOGFhOTBlY2ZjODQzMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQy9XS0NyZWRlbnRpYWwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Qy9XS0NyZWRlbnRpYWwuY3BwCkBAIC00MCwxOCArNDAsMTYgQEAgV0tUeXBlSUQgV0tDcmVkZW50 aWFsR2V0VHlwZUlEKCkKIAogV0tDcmVkZW50aWFsUmVmIFdLQ3JlZGVudGlhbENyZWF0ZShXS1N0 cmluZ1JlZiB1c2VybmFtZSwgV0tTdHJpbmdSZWYgcGFzc3dvcmQsIFdLQ3JlZGVudGlhbFBlcnNp c3RlbmNlIHBlcnNpc3RlbmNlKQogewotICAgIFJlZlB0cjxXZWJDcmVkZW50aWFsPiBjcmVkZW50 aWFsID0gV2ViQ3JlZGVudGlhbDo6Y3JlYXRlKHRvSW1wbCh1c2VybmFtZSksIHRvSW1wbChwYXNz d29yZCksIHRvQ3JlZGVudGlhbFBlcnNpc3RlbmNlKHBlcnNpc3RlbmNlKSk7Ci0gICAgcmV0dXJu IHRvQVBJKGNyZWRlbnRpYWwucmVsZWFzZSgpLmxlYWtSZWYoKSk7CisgICAgcmV0dXJuIHRvQVBJ KFdlYkNyZWRlbnRpYWw6OmNyZWF0ZShXZWJDb3JlOjpDcmVkZW50aWFsKHRvSW1wbCh1c2VybmFt ZSktPnN0cmluZygpLCB0b0ltcGwocGFzc3dvcmQpLT5zdHJpbmcoKSwgdG9DcmVkZW50aWFsUGVy c2lzdGVuY2UocGVyc2lzdGVuY2UpKSkubGVha1JlZigpKTsKIH0KIAogV0tDcmVkZW50aWFsUmVm IFdLQ3JlZGVudGlhbENyZWF0ZVdpdGhDZXJ0aWZpY2F0ZUluZm8oV0tDZXJ0aWZpY2F0ZUluZm9S ZWYgY2VydGlmaWNhdGVJbmZvKQogewotICAgIFJlZlB0cjxXZWJDcmVkZW50aWFsPiBjcmVkZW50 aWFsID0gV2ViQ3JlZGVudGlhbDo6Y3JlYXRlKHRvSW1wbChjZXJ0aWZpY2F0ZUluZm8pKTsKLSAg ICByZXR1cm4gdG9BUEkoY3JlZGVudGlhbC5yZWxlYXNlKCkubGVha1JlZigpKTsKKyAgICByZXR1 cm4gdG9BUEkoV2ViQ3JlZGVudGlhbDo6Y3JlYXRlKHRvSW1wbChjZXJ0aWZpY2F0ZUluZm8pKS5s ZWFrUmVmKCkpOwogfQogCiBXS1N0cmluZ1JlZiBXS0NyZWRlbnRpYWxDb3B5VXNlcihXS0NyZWRl bnRpYWxSZWYgY3JlZGVudGlhbFJlZikKIHsKLSAgICByZXR1cm4gdG9Db3BpZWRBUEkodG9JbXBs KGNyZWRlbnRpYWxSZWYpLT51c2VyKCkpOworICAgIHJldHVybiB0b0NvcGllZEFQSSh0b0ltcGwo Y3JlZGVudGlhbFJlZiktPmNyZWRlbnRpYWwoKS51c2VyKCkpOwogfQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24vQXV0aGVudGljYXRpb25DaGFs bGVuZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24v QXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94eS5jcHAKaW5kZXggMzgwOGVjMmU5NGQ4YzVhY2Jj NGYzNzg1NWVhNWRlY2E5Nzg0NDhiMi4uOWJkZDczYjQ0NWVmYTBmMTNiNmIzMmZmYWExOTZhNGI2 MjQzMDkxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dGhlbnRpY2F0 aW9uL0F1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BdXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5LmNw cApAQCAtNjIsMTUgKzYyLDE5IEBAIHZvaWQgQXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94eTo6 dXNlQ3JlZGVudGlhbChXZWJDcmVkZW50aWFsKiBjcmVkZW50aWFsKQogICAgIGlmICghbV9jaGFs bGVuZ2VJRCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFjcmVkZW50aWFsKQotICAgICAg ICBtX2Nvbm5lY3Rpb24tPnNlbmQoTWVzc2FnZXM6OkF1dGhlbnRpY2F0aW9uTWFuYWdlcjo6Q29u dGludWVXaXRob3V0Q3JlZGVudGlhbEZvckNoYWxsZW5nZShtX2NoYWxsZW5nZUlEKSwgMCk7Ci0g ICAgZWxzZSB7Ci0gICAgICAgIFdlYkNlcnRpZmljYXRlSW5mbyogY2VydGlmaWNhdGVJbmZvID0g Y3JlZGVudGlhbC0+Y2VydGlmaWNhdGVJbmZvKCk7Ci0gICAgICAgIFdlYkNvcmU6OkNlcnRpZmlj YXRlSW5mbyBwbGF0Zm9ybUluZm8gPSBjZXJ0aWZpY2F0ZUluZm8gPyBjZXJ0aWZpY2F0ZUluZm8t PmNlcnRpZmljYXRlSW5mbygpIDogV2ViQ29yZTo6Q2VydGlmaWNhdGVJbmZvKCk7Ci0gICAgICAg IG1fY29ubmVjdGlvbi0+c2VuZChNZXNzYWdlczo6QXV0aGVudGljYXRpb25NYW5hZ2VyOjpVc2VD cmVkZW50aWFsRm9yQ2hhbGxlbmdlKG1fY2hhbGxlbmdlSUQsIGNyZWRlbnRpYWwtPmNvcmUoKSwg cGxhdGZvcm1JbmZvKSwgMCk7CisgICAgdWludDY0X3QgY2hhbGxlbmdlSUQgPSBtX2NoYWxsZW5n ZUlEOworICAgIG1fY2hhbGxlbmdlSUQgPSAwOworCisgICAgaWYgKCFjcmVkZW50aWFsKSB7Cisg ICAgICAgIG1fY29ubmVjdGlvbi0+c2VuZChNZXNzYWdlczo6QXV0aGVudGljYXRpb25NYW5hZ2Vy OjpDb250aW51ZVdpdGhvdXRDcmVkZW50aWFsRm9yQ2hhbGxlbmdlKGNoYWxsZW5nZUlEKSwgMCk7 CisgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX2NoYWxsZW5nZUlEID0gMDsKKyAgICBX ZWJDb3JlOjpDZXJ0aWZpY2F0ZUluZm8gY2VydGlmaWNhdGVJbmZvOworICAgIGlmIChjcmVkZW50 aWFsLT5jZXJ0aWZpY2F0ZUluZm8oKSkKKyAgICAgICAgY2VydGlmaWNhdGVJbmZvID0gY3JlZGVu dGlhbC0+Y2VydGlmaWNhdGVJbmZvKCktPmNlcnRpZmljYXRlSW5mbygpOworCisgICAgbV9jb25u ZWN0aW9uLT5zZW5kKE1lc3NhZ2VzOjpBdXRoZW50aWNhdGlvbk1hbmFnZXI6OlVzZUNyZWRlbnRp YWxGb3JDaGFsbGVuZ2UoY2hhbGxlbmdlSUQsIGNyZWRlbnRpYWwtPmNyZWRlbnRpYWwoKSwgY2Vy dGlmaWNhdGVJbmZvKSwgMCk7CiB9CiAKIHZvaWQgQXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94 eTo6Y2FuY2VsKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRoZW50 aWNhdGlvbi9XZWJDcmVkZW50aWFsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRo ZW50aWNhdGlvbi9XZWJDcmVkZW50aWFsLmNwcAppbmRleCBhNjlkNTA5Yzc0YjFhMTFmNmRiNzc4 OTk5OGZmMWU5MWFjNGEwMzhkLi5hMmQxZDE3Y2QxZTc4ZWU5MGVlYjliMDFiN2U4NjZjYzEzMmYy MDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24v V2ViQ3JlZGVudGlhbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dGhlbnRp Y2F0aW9uL1dlYkNyZWRlbnRpYWwuY3BwCkBAIC00OSwxNCArNDksOSBAQCBXZWJDZXJ0aWZpY2F0 ZUluZm8qIFdlYkNyZWRlbnRpYWw6OmNlcnRpZmljYXRlSW5mbygpCiAgICAgcmV0dXJuIG1fY2Vy dGlmaWNhdGVJbmZvLmdldCgpOwogfQogCi1jb25zdCBXZWJDb3JlOjpDcmVkZW50aWFsJiBXZWJD cmVkZW50aWFsOjpjb3JlKCkKK2NvbnN0IFdlYkNvcmU6OkNyZWRlbnRpYWwmIFdlYkNyZWRlbnRp YWw6OmNyZWRlbnRpYWwoKQogewogICAgIHJldHVybiBtX2NvcmVDcmVkZW50aWFsOwogfQogCi1j b25zdCBTdHJpbmcmIFdlYkNyZWRlbnRpYWw6OnVzZXIoKSBjb25zdAotewotICAgIHJldHVybiBt X2NvcmVDcmVkZW50aWFsLnVzZXIoKTsKLX0KLQogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24vV2ViQ3JlZGVu dGlhbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dGhlbnRpY2F0aW9uL1dlYkNyZWRl bnRpYWwuaAppbmRleCBlZmZmNjU0OGMxYmJiYjkxNWRiZWE1YmE2MWNmNzllOGJjMjgwOWNlLi4y NmQ4MTk1NzE5ODQyOWM1ZTg4MTRhMjkxNTY2NDM2OTY0NDlhN2UxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24vV2ViQ3JlZGVudGlhbC5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRoZW50aWNhdGlvbi9XZWJDcmVkZW50aWFsLmgK QEAgLTQ0LDExICs0NCw2IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBX ZWJDcmVkZW50aWFsKGNyZWRlbnRpYWwpKTsKICAgICB9CiAgICAgCi0gICAgc3RhdGljIFBhc3NS ZWZQdHI8V2ViQ3JlZGVudGlhbD4gY3JlYXRlKEFQSTo6U3RyaW5nKiB1c2VybmFtZSwgQVBJOjpT dHJpbmcqIHBhc3N3b3JkLCBXZWJDb3JlOjpDcmVkZW50aWFsUGVyc2lzdGVuY2UgcGVyc2lzdGVu Y2UpCi0gICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFdlYkNyZWRlbnRpYWwoV2Vi Q29yZTo6Q3JlZGVudGlhbCh1c2VybmFtZS0+c3RyaW5nKCksIHBhc3N3b3JkLT5zdHJpbmcoKSwg cGVyc2lzdGVuY2UpKSk7Ci0gICAgfQotCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8V2ViQ3JlZGVu dGlhbD4gY3JlYXRlKFdlYkNlcnRpZmljYXRlSW5mbyogY2VydGlmaWNhdGVJbmZvKQogICAgIHsK ICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBXZWJDcmVkZW50aWFsKGNlcnRpZmljYXRlSW5m bykpOwpAQCAtNTYsMTAgKzUxLDggQEAgcHVibGljOgogICAgIAogICAgIFdlYkNlcnRpZmljYXRl SW5mbyogY2VydGlmaWNhdGVJbmZvKCk7CiAKLSAgICBjb25zdCBXZWJDb3JlOjpDcmVkZW50aWFs JiBjb3JlKCk7CisgICAgY29uc3QgV2ViQ29yZTo6Q3JlZGVudGlhbCYgY3JlZGVudGlhbCgpOwog Ci0gICAgY29uc3QgU3RyaW5nJiB1c2VyKCkgY29uc3Q7Ci0gICAgCiBwcml2YXRlOgogICAgIGV4 cGxpY2l0IFdlYkNyZWRlbnRpYWwoY29uc3QgV2ViQ29yZTo6Q3JlZGVudGlhbCYpOwogICAgIGV4 cGxpY2l0IFdlYkNyZWRlbnRpYWwoV2ViQ2VydGlmaWNhdGVJbmZvKik7Cg==