133994 2014-06-17 13:09:17 -0700 DFGGraph::m_doubleConstantMap will not map 0 values correctly 2014-06-18 11:58:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 134006 1 mark.lam mark.lam achristensen commit-queue fpizlo ggaren mhahnenberg mmirman msaboff oliver oldest_to_newest 1016225 0 mark.lam 2014-06-17 13:09:17 -0700 Filip noticed that m_doubleConstantsMap should not use a double as a key, because it means two unfortunate things: - It will probably break for zero. - It will think that -0 is the same as +0 under some circumstances, size -0==+0 even though they are distinct values (for example 1/-0 != 1/+0). Will fix. 1016251 1 233260 mark.lam 2014-06-17 14:27:31 -0700 Created attachment 233260 the patch. This patch has passed the JSC tests and the layout tests with a debug build on x86_64. 1016275 2 achristensen 2014-06-17 15:28:43 -0700 Are there ever cases where different NaNs would need to map to the same value? 1016280 3 233260 ggaren 2014-06-17 15:39:18 -0700 Comment on attachment 233260 the patch. r=me 1016281 4 ggaren 2014-06-17 15:40:11 -0700 (In reply to comment #2) > Are there ever cases where different NaNs would need to map to the same value? In user code, there are only ever two NaNs (positive unsignaling and negative unsignaling), and they do not need (or want) to map to the same value. 1016289 5 233260 commit-queue 2014-06-17 16:06:17 -0700 Comment on attachment 233260 the patch. Clearing flags on attachment: 233260 Committed r170082: <http://trac.webkit.org/changeset/170082> 1016290 6 commit-queue 2014-06-17 16:06:22 -0700 All reviewed patches have been landed. Closing bug. 1016314 7 commit-queue 2014-06-17 16:59:33 -0700 Re-opened since this is blocked by bug 134006 1016451 8 233309 mark.lam 2014-06-18 08:18:12 -0700 Created attachment 233309 patch 2: fixed build problem, and properly tested on 32-bit build. 1016498 9 233309 ggaren 2014-06-18 11:04:42 -0700 Comment on attachment 233309 patch 2: fixed build problem, and properly tested on 32-bit build. r=me 1016510 10 mark.lam 2014-06-18 11:58:32 -0700 Thanks. Landed in r170109: <http://trac.webkit.org/r170109>. 233260 2014-06-17 14:27:31 -0700 2014-06-18 08:18:12 -0700 the patch. bug-133994.patch text/plain 3129 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcwMDcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE0LTA2LTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE RkdHcmFwaDo6bV9kb3VibGVDb25zdGFudE1hcCB3aWxsIG5vdCBtYXAgMCB2YWx1ZXMgY29ycmVj dGx5LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTMzOTk0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERGR0dyYXBoOjptX2RvdWJsZUNv bnN0YW50c01hcCBzaG91bGQgbm90IHVzZSBhIGRvdWJsZSBhcyBhIGtleSB0byBpdHMgSGFzaE1h cCwKKyAgICAgICAgYmVjYXVzZSBpdCBtZWFucyB0d28gdW5mb3J0dW5hdGUgdGhpbmdzOgorICAg ICAgICAtIEl0IHdpbGwgcHJvYmFibHkgYnJlYWsgZm9yIHplcm8uCisgICAgICAgIC0gSXQgd2ls bCB0aGluayB0aGF0IC0wIGlzIHRoZSBzYW1lIGFzICswIHVuZGVyIHNvbWUgY2lyY3Vtc3RhbmNl cywgc2l6ZQorICAgICAgICAgIC0wPT0rMCBldmVuIHRob3VnaCB0aGV5IGFyZSBkaXN0aW5jdCB2 YWx1ZXMgKGZvciBleGFtcGxlIDEvLTAgIT0gMS8rMCkuCisKKyAgICAgICAgVGhlIGZpeCBpcyB0 byB1c2Ugc3RkOjp1bm9yZGVyZWRfbWFwIHdoaWNoIGRvZXMgbm90IHJlcXVpcmUgc3BlY2lhbCBl bXB0eQorICAgICAgICBhbmQgZGVsZXRlZCB2YWx1ZXMsIGFuZCB0byB1c2UgdGhlIHJhdyBiaXRz IGluc3RlYWQgb2YgdGhlIGRvdWJsZSB2YWx1ZSBhcworICAgICAgICB0aGUga2V5LgorCisgICAg ICAgICogZGZnL0RGR0dyYXBoLmg6CisgICAgICAgICogZGZnL0RGR0pJVENvbXBpbGVyLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpKSVRDb21waWxlcjo6YWRkcmVzc09mRG91YmxlQ29uc3RhbnQp OgorCiAyMDE0LTA2LTE2ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg TW92ZSBmb3J3YXJkIGRlY2xhcmF0aW9uIG9mIGJpbmRpbmdzIHN0YXRpYyBmdW5jdGlvbnMgaW50 byB0aGVpciBpbXBsZW1lbnRhdGlvbiBmaWxlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdHcmFwaC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHR3JhcGguaAkocmV2aXNpb24gMTcwMDU1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdHcmFwaC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw2ICs0MSw3IEBACiAjaW5jbHVkZSAi REZHU2Nhbm5hYmxlLmgiCiAjaW5jbHVkZSAiSlNTdGFjay5oIgogI2luY2x1ZGUgIk1ldGhvZE9m R2V0dGluZ0FWYWx1ZVByb2ZpbGUuaCIKKyNpbmNsdWRlIDx1bm9yZGVyZWRfbWFwPgogI2luY2x1 ZGUgPHd0Zi9CaXRWZWN0b3IuaD4KICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUg PHd0Zi9WZWN0b3IuaD4KQEAgLTg1NCw3ICs4NTUsNyBAQCBwdWJsaWM6CiAgICAgc3RkOjp1bmlx dWVfcHRyPFNsb3dBcmd1bWVudFtdPiBtX3Nsb3dBcmd1bWVudHM7CiAKICNpZiBVU0UoSlNWQUxV RTMyXzY0KQotICAgIEhhc2hNYXA8ZG91YmxlLCBkb3VibGUqPiBtX2RvdWJsZUNvbnN0YW50c01h cDsKKyAgICBzdGQ6OnVub3JkZXJlZF9tYXA8aW50NjRfdCwgZG91YmxlKj4gbV9kb3VibGVDb25z dGFudHNNYXA7CiAgICAgc3RkOjp1bmlxdWVfcHRyPEJhZzxkb3VibGU+PiBtX2RvdWJsZUNvbnN0 YW50czsKICNlbmRpZgogICAgIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdK SVRDb21waWxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdKSVRDb21waWxlci5jcHAJKHJldmlzaW9uIDE3MDA1NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDMsOCArNDQz LDggQEAgdm9pZCogSklUQ29tcGlsZXI6OmFkZHJlc3NPZkRvdWJsZUNvbnN0YQogICAgIEpTVmFs dWUganN2YWx1ZSA9IG5vZGUtPnZhbHVlT2ZKU0NvbnN0YW50KGNvZGVCbG9jaygpKTsKICAgICBB U1NFUlQoanN2YWx1ZS5pc0RvdWJsZSgpKTsKIAotICAgIGRvdWJsZSB2YWx1ZSA9IGpzdmFsdWUu YXNEb3VibGUoKTsKLSAgICBhdXRvIGl0ID0gbV9ncmFwaC5tX2RvdWJsZUNvbnN0YW50c01hcC5m aW5kKHZhbHVlKTsKKyAgICBpbnQ2NF90IHZhbHVlQml0cyA9IGpzdmFsdWUuYXNNYWNoaW5lSW50 KCk7CisgICAgYXV0byBpdCA9IG1fZ3JhcGgubV9kb3VibGVDb25zdGFudHNNYXAuZmluZCh2YWx1 ZUJpdHMpOwogICAgIGlmIChpdCAhPSBtX2dyYXBoLm1fZG91YmxlQ29uc3RhbnRzTWFwLmVuZCgp KQogICAgICAgICByZXR1cm4gaXQtPnZhbHVlOwogCkBAIC00NTIsOCArNDUyLDggQEAgdm9pZCog SklUQ29tcGlsZXI6OmFkZHJlc3NPZkRvdWJsZUNvbnN0YQogICAgICAgICBtX2dyYXBoLm1fZG91 YmxlQ29uc3RhbnRzID0gc3RkOjptYWtlX3VuaXF1ZTxCYWc8ZG91YmxlPj4oKTsKIAogICAgIGRv dWJsZSogYWRkcmVzc0luQ29uc3RhbnRQb29sID0gbV9ncmFwaC5tX2RvdWJsZUNvbnN0YW50cy0+ YWRkKCk7Ci0gICAgKmFkZHJlc3NJbkNvbnN0YW50UG9vbCA9IHZhbHVlOwotICAgIG1fZ3JhcGgu bV9kb3VibGVDb25zdGFudHNNYXAuYWRkKHZhbHVlLCBhZGRyZXNzSW5Db25zdGFudFBvb2wpOwor ICAgICphZGRyZXNzSW5Db25zdGFudFBvb2wgPSBqc3ZhbHVlLmFzRG91YmxlKCk7CisgICAgbV9n cmFwaC5tX2RvdWJsZUNvbnN0YW50c01hcFt2YWx1ZUJpdHNdID0gYWRkcmVzc0luQ29uc3RhbnRQ b29sOwogICAgIHJldHVybiBhZGRyZXNzSW5Db25zdGFudFBvb2w7CiB9CiAjZW5kaWYK 233309 2014-06-18 08:18:12 -0700 2014-06-18 11:04:41 -0700 patch 2: fixed build problem, and properly tested on 32-bit build. bug-133994.patch text/plain 2988 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcwMTAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE0LTA2LTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE RkdHcmFwaDo6bV9kb3VibGVDb25zdGFudE1hcCB3aWxsIG5vdCBtYXAgMCB2YWx1ZXMgY29ycmVj dGx5LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTMzOTk0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERGR0dyYXBoOjptX2RvdWJsZUNv bnN0YW50c01hcCBzaG91bGQgbm90IHVzZSBhIGRvdWJsZSBhcyBhIGtleSB0byBpdHMgSGFzaE1h cCwKKyAgICAgICAgYmVjYXVzZSBpdCBtZWFucyB0d28gdW5mb3J0dW5hdGUgdGhpbmdzOgorICAg ICAgICAtIEl0IHdpbGwgcHJvYmFibHkgYnJlYWsgZm9yIHplcm8uCisgICAgICAgIC0gSXQgd2ls bCB0aGluayB0aGF0IC0wIGlzIHRoZSBzYW1lIGFzICswIHVuZGVyIHNvbWUgY2lyY3Vtc3RhbmNl cywgc2l6ZQorICAgICAgICAgIC0wPT0rMCBldmVuIHRob3VnaCB0aGV5IGFyZSBkaXN0aW5jdCB2 YWx1ZXMgKGZvciBleGFtcGxlIDEvLTAgIT0gMS8rMCkuCisKKyAgICAgICAgVGhlIGZpeCBpcyB0 byB1c2Ugc3RkOjp1bm9yZGVyZWRfbWFwIHdoaWNoIGRvZXMgbm90IHJlcXVpcmUgc3BlY2lhbCBl bXB0eQorICAgICAgICBhbmQgZGVsZXRlZCB2YWx1ZXMsIGFuZCB0byB1c2UgdGhlIHJhdyBiaXRz IGluc3RlYWQgb2YgdGhlIGRvdWJsZSB2YWx1ZSBhcworICAgICAgICB0aGUga2V5LgorCisgICAg ICAgICogZGZnL0RGR0dyYXBoLmg6CisgICAgICAgICogZGZnL0RGR0pJVENvbXBpbGVyLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpKSVRDb21waWxlcjo6YWRkcmVzc09mRG91YmxlQ29uc3RhbnQp OgorCiAyMDE0LTA2LTE3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTcwMDgyLgpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHR3JhcGguaAkocmV2aXNpb24gMTcwMDkyKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw2ICs0MSw3 IEBACiAjaW5jbHVkZSAiREZHU2Nhbm5hYmxlLmgiCiAjaW5jbHVkZSAiSlNTdGFjay5oIgogI2lu Y2x1ZGUgIk1ldGhvZE9mR2V0dGluZ0FWYWx1ZVByb2ZpbGUuaCIKKyNpbmNsdWRlIDx1bm9yZGVy ZWRfbWFwPgogI2luY2x1ZGUgPHd0Zi9CaXRWZWN0b3IuaD4KICNpbmNsdWRlIDx3dGYvSGFzaE1h cC5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KQEAgLTg1NCw3ICs4NTUsNyBAQCBwdWJsaWM6 CiAgICAgc3RkOjp1bmlxdWVfcHRyPFNsb3dBcmd1bWVudFtdPiBtX3Nsb3dBcmd1bWVudHM7CiAK ICNpZiBVU0UoSlNWQUxVRTMyXzY0KQotICAgIEhhc2hNYXA8ZG91YmxlLCBkb3VibGUqPiBtX2Rv dWJsZUNvbnN0YW50c01hcDsKKyAgICBzdGQ6OnVub3JkZXJlZF9tYXA8aW50NjRfdCwgZG91Ymxl Kj4gbV9kb3VibGVDb25zdGFudHNNYXA7CiAgICAgc3RkOjp1bmlxdWVfcHRyPEJhZzxkb3VibGU+ PiBtX2RvdWJsZUNvbnN0YW50czsKICNlbmRpZgogICAgIApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAJKHJldmlzaW9uIDE3MDA5MikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00NDQsMTYgKzQ0NCwxNyBAQCB2b2lkKiBKSVRDb21waWxlcjo6YWRkcmVzc09mRG91Ymxl Q29uc3RhCiAgICAgQVNTRVJUKGpzdmFsdWUuaXNEb3VibGUoKSk7CiAKICAgICBkb3VibGUgdmFs dWUgPSBqc3ZhbHVlLmFzRG91YmxlKCk7Ci0gICAgYXV0byBpdCA9IG1fZ3JhcGgubV9kb3VibGVD b25zdGFudHNNYXAuZmluZCh2YWx1ZSk7CisgICAgaW50NjRfdCB2YWx1ZUJpdHMgPSBiaXR3aXNl X2Nhc3Q8aW50NjRfdD4odmFsdWUpOworICAgIGF1dG8gaXQgPSBtX2dyYXBoLm1fZG91YmxlQ29u c3RhbnRzTWFwLmZpbmQodmFsdWVCaXRzKTsKICAgICBpZiAoaXQgIT0gbV9ncmFwaC5tX2RvdWJs ZUNvbnN0YW50c01hcC5lbmQoKSkKLSAgICAgICAgcmV0dXJuIGl0LT52YWx1ZTsKKyAgICAgICAg cmV0dXJuIGl0LT5zZWNvbmQ7CiAKICAgICBpZiAoIW1fZ3JhcGgubV9kb3VibGVDb25zdGFudHMp CiAgICAgICAgIG1fZ3JhcGgubV9kb3VibGVDb25zdGFudHMgPSBzdGQ6Om1ha2VfdW5pcXVlPEJh Zzxkb3VibGU+PigpOwogCiAgICAgZG91YmxlKiBhZGRyZXNzSW5Db25zdGFudFBvb2wgPSBtX2dy YXBoLm1fZG91YmxlQ29uc3RhbnRzLT5hZGQoKTsKICAgICAqYWRkcmVzc0luQ29uc3RhbnRQb29s ID0gdmFsdWU7Ci0gICAgbV9ncmFwaC5tX2RvdWJsZUNvbnN0YW50c01hcC5hZGQodmFsdWUsIGFk ZHJlc3NJbkNvbnN0YW50UG9vbCk7CisgICAgbV9ncmFwaC5tX2RvdWJsZUNvbnN0YW50c01hcFt2 YWx1ZUJpdHNdID0gYWRkcmVzc0luQ29uc3RhbnRQb29sOwogICAgIHJldHVybiBhZGRyZXNzSW5D b25zdGFudFBvb2w7CiB9CiAjZW5kaWYK