133978 2014-06-17 05:12:26 -0700 Use references instead of pointers to RenderBlock in enclosingBoxModelObject() 2014-06-17 10:30:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 myid.shin webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1016102 0 myid.shin 2014-06-17 05:12:26 -0700 Use references instead of pointers to RenderBlock for return type of RenderObject::enclosingBoxModelObject(). Just a straightforward conversion from pointers to references. 1016114 1 233228 myid.shin 2014-06-17 07:01:37 -0700 Created attachment 233228 Patch 1016144 2 233228 commit-queue 2014-06-17 10:30:13 -0700 Comment on attachment 233228 Patch Clearing flags on attachment: 233228 Committed r170057: <http://trac.webkit.org/changeset/170057> 1016145 3 commit-queue 2014-06-17 10:30:16 -0700 All reviewed patches have been landed. Closing bug. 233228 2014-06-17 07:01:37 -0700 2014-06-17 10:30:13 -0700 Patch bug-133978-20140617230111.patch text/plain 4608 myid.shin U3VidmVyc2lvbiBSZXZpc2lvbjogMTcwMDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ4M2MxNmEyOTdiMmUz NDYwZjdkOTAxMWM1ZjQ5M2UzMmZjODE5MC4uMzY1ZWFiNmVjZWEyMmY0N2IwMThlNDNjMmQ0NTEw NTQ3NWFiYmJiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA2LTE3ICBNaXlv dW5nIFNoaW4gIDxteWlkLnNoaW5Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgVXNlIHJlZmVyZW5j ZXMgaW5zdGVhZCBvZiBwb2ludGVycyB0byBSZW5kZXJCbG9jayBpbiBlbmNsb3NpbmdCb3hNb2Rl bE9iamVjdCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzM5NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBKdXN0IGEgc3RyYWlnaHRmb3J3YXJkIGNvbnZlcnNpb24gZnJvbSBwb2ludGVycyB0byByZWZl cmVuY2VzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisg ICAgICAgICogcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SW5saW5lRmxvd0JveDo6cGFpbnQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6cGFpbnRPYmplY3QpOgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy T2JqZWN0OjplbmNsb3NpbmdCb3hNb2RlbE9iamVjdCk6CisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlck9iamVjdC5oOgorCiAyMDE0LTA2LTE3ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdh bGlhLmNvbT4KIAogICAgICAgICBDYWNoZSB0aGUgZ3N0X3F1ZXJ5X2dldF9uX2J1ZmZlcmluZ19y YW5nZXMoKSByZXR1cm4gdmFsdWUgZm9yIHRoZSBmb3ItbG9vcCBjb25kaXRpb25hbApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwCmluZGV4IGMzODZhNjg0MTg2NjUw ZDZjZDIwZmNlOGM1MGJkNzRhNGU5YjgwNzAuLjQ2MjMzY2I3NmVjZjJhZmFjODNmYzRjYTc4ODg3 NzQyNDMzN2ZhNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVG bG93Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lRmxvd0JveC5j cHAKQEAgLTExMzQsNyArMTEzNCw3IEBAIHZvaWQgSW5saW5lRmxvd0JveDo6cGFpbnQoUGFpbnRJ bmZvJiBwYWludEluZm8sIGNvbnN0IExheW91dFBvaW50JiBwYWludE9mZnNldCwKICAgICAgICAg ICAgICAgICAgICAgICAgIGNvbnRhaW5pbmdCbG9ja1BhaW50c0NvbnRpbnVhdGlvbk91dGxpbmUg PSBmYWxzZTsKICAgICAgICAgICAgICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICAgICAgICAg ICAgICBjYiA9IGVuY2xvc2luZ0Fub255bW91c0Jsb2NrLT5jb250YWluaW5nQmxvY2soKTsKLSAg ICAgICAgICAgICAgICAgICAgICAgIGZvciAoYXV0byBib3ggPSAmcmVuZGVyZXIoKTsgYm94ICE9 IGNiOyBib3ggPSBib3gtPnBhcmVudCgpLT5lbmNsb3NpbmdCb3hNb2RlbE9iamVjdCgpKSB7Cisg ICAgICAgICAgICAgICAgICAgICAgICBmb3IgKGF1dG8gYm94ID0gJnJlbmRlcmVyKCk7IGJveCAh PSBjYjsgYm94ID0gJmJveC0+cGFyZW50KCktPmVuY2xvc2luZ0JveE1vZGVsT2JqZWN0KCkpIHsK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoYm94LT5oYXNTZWxmUGFpbnRpbmdMYXll cigpKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRhaW5pbmdCbG9ja1Bh aW50c0NvbnRpbnVhdGlvbk91dGxpbmUgPSBmYWxzZTsKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgYnJlYWs7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2suY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApp bmRleCA5NmE1ZjEwZjdkYjBhZjRmODViN2FiNjg1NDk1ZmU0OWNlYzYyNjJiLi44NjM2ZDNiOTdh OTJkZWM0ZDc5YTJiNzFlYWZiNjI2YWMzMjc1NGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9jay5jcHAKQEAgLTE3MDMsNyArMTcwMyw3IEBAIHZvaWQgUmVuZGVyQmxvY2s6 OnBhaW50T2JqZWN0KFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBMYXlvdXRQb2ludCYgcGFp bnRPZmZzCiAgICAgICAgICAgICBSZW5kZXJCbG9jayogY2IgPSBjb250YWluaW5nQmxvY2soKTsK IAogICAgICAgICAgICAgYm9vbCBpbmxpbmVFbmNsb3NlZEluU2VsZlBhaW50aW5nTGF5ZXIgPSBm YWxzZTsKLSAgICAgICAgICAgIGZvciAoUmVuZGVyQm94TW9kZWxPYmplY3QqIGJveCA9IGlubGlu ZVJlbmRlcmVyOyBib3ggIT0gY2I7IGJveCA9IGJveC0+cGFyZW50KCktPmVuY2xvc2luZ0JveE1v ZGVsT2JqZWN0KCkpIHsKKyAgICAgICAgICAgIGZvciAoUmVuZGVyQm94TW9kZWxPYmplY3QqIGJv eCA9IGlubGluZVJlbmRlcmVyOyBib3ggIT0gY2I7IGJveCA9ICZib3gtPnBhcmVudCgpLT5lbmNs b3NpbmdCb3hNb2RlbE9iamVjdCgpKSB7CiAgICAgICAgICAgICAgICAgaWYgKGJveC0+aGFzU2Vs ZlBhaW50aW5nTGF5ZXIoKSkgewogICAgICAgICAgICAgICAgICAgICBpbmxpbmVFbmNsb3NlZElu U2VsZlBhaW50aW5nTGF5ZXIgPSB0cnVlOwogICAgICAgICAgICAgICAgICAgICBicmVhazsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKaW5kZXggM2IzZjAxMGVmMTY3 NWE1NDdiMWE5ZjBlM2JjMTQ5ZDRmMmM4YTYwZC4uYmNkNzBhNzU3MWE5YzEyOTQzZGY3MzFjZDJh ZmY4M2EzMTQ2YmI2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5j cHAKQEAgLTQ5NSwxMCArNDk1LDkgQEAgUmVuZGVyQm94JiBSZW5kZXJPYmplY3Q6OmVuY2xvc2lu Z0JveCgpIGNvbnN0CiAgICAgcmV0dXJuICpsaW5lYWdlT2ZUeXBlPFJlbmRlckJveD4oY29uc3Rf Y2FzdDxSZW5kZXJPYmplY3QmPigqdGhpcykpLmZpcnN0KCk7CiB9CiAKLVJlbmRlckJveE1vZGVs T2JqZWN0KiBSZW5kZXJPYmplY3Q6OmVuY2xvc2luZ0JveE1vZGVsT2JqZWN0KCkgY29uc3QKK1Jl bmRlckJveE1vZGVsT2JqZWN0JiBSZW5kZXJPYmplY3Q6OmVuY2xvc2luZ0JveE1vZGVsT2JqZWN0 KCkgY29uc3QKIHsKLSAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcmV0dXJuIGEgcmVmZXJlbmNl OyBpdCBjYW4gYWx3YXlzIGZpbmQgdGhlIHJvb3QgUmVuZGVyVmlldy4KLSAgICByZXR1cm4gbGlu ZWFnZU9mVHlwZTxSZW5kZXJCb3hNb2RlbE9iamVjdD4oY29uc3RfY2FzdDxSZW5kZXJPYmplY3Qm PigqdGhpcykpLmZpcnN0KCk7CisgICAgcmV0dXJuICpsaW5lYWdlT2ZUeXBlPFJlbmRlckJveE1v ZGVsT2JqZWN0Pihjb25zdF9jYXN0PFJlbmRlck9iamVjdCY+KCp0aGlzKSkuZmlyc3QoKTsKIH0K IAogYm9vbCBSZW5kZXJPYmplY3Q6OmZpeGVkUG9zaXRpb25lZFdpdGhOYW1lZEZsb3dDb250YWlu aW5nQmxvY2soKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlck9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCmlu ZGV4IDY5Mjk3MDlmZTcyYzk4OWFiZGIyMmJkMjA3ZjdhNTZiMmY3ODk5OGMuLjExYTQyZGVjZTQy OTA4MmIzOTc5YzBjNjMwMGI5NjM2YTdjMzI3M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyT2JqZWN0LmgKQEAgLTIwNyw3ICsyMDcsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBDb252 ZW5pZW5jZSBmdW5jdGlvbiBmb3IgZ2V0dGluZyB0byB0aGUgbmVhcmVzdCBlbmNsb3NpbmcgYm94 IG9mIGEgUmVuZGVyT2JqZWN0LgogICAgIFJlbmRlckJveCYgZW5jbG9zaW5nQm94KCkgY29uc3Q7 Ci0gICAgUmVuZGVyQm94TW9kZWxPYmplY3QqIGVuY2xvc2luZ0JveE1vZGVsT2JqZWN0KCkgY29u c3Q7CisgICAgUmVuZGVyQm94TW9kZWxPYmplY3QmIGVuY2xvc2luZ0JveE1vZGVsT2JqZWN0KCkg Y29uc3Q7CiAKICAgICBib29sIGZpeGVkUG9zaXRpb25lZFdpdGhOYW1lZEZsb3dDb250YWluaW5n QmxvY2soKSBjb25zdDsKICAgICAvLyBGdW5jdGlvbiB0byByZXR1cm4gb3VyIGVuY2xvc2luZyBm bG93IHRocmVhZCBpZiB3ZSBhcmUgY29udGFpbmVkIGluc2lkZSBvbmUuIFRoaXMK