133968 2014-06-16 21:29:52 -0700 String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference 2019-06-18 00:27:48 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198957 P2 Normal --- 1 mitz mitz andersca benjamin cmarcelo commit-queue oldest_to_newest 1016057 0 mitz 2014-06-16 21:29:52 -0700 Patch forthcoming. 1016058 1 233215 mitz 2014-06-16 21:34:57 -0700 Created attachment 233215 Remove const qualifier from isolatedCopy() && 1016059 2 commit-queue 2014-06-16 21:35:43 -0700 Attachment 233215 did not pass style-queue: ERROR: Source/WTF/wtf/text/WTFString.cpp:691: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1016125 3 mitz 2014-06-17 09:17:06 -0700 Fixed in <http://trac.webkit.org/r170055> 1019036 4 mitz 2014-06-27 11:47:29 -0700 <rdar://problem/17487072> 233215 2014-06-16 21:34:57 -0700 2014-06-17 07:28:16 -0700 Remove const qualifier from isolatedCopy() && bug-133968-20140616213434.patch text/plain 3223 mitz SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNzAwNDIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA2LTE2ICBEYW4gQmVybnN0ZWluICA8bWl0 ekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RyaW5nOjppc29sYXRlZENvcHkgZG9lc27igJl0IHJl dHVybiBhbiBpc29sYXRlZCBjb3B5IHdoZW4gdXNlZCBvbiBhbiBydmFsdWUgcmVmZXJlbmNlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM5NjgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWRlIHRoZSBy dmFsdWUgcmVmZXJlbmNlIG92ZXJsb2FkIG9mIGlzb2xhdGVkQ29weSgpIG5vbi1jb25zdCwgc28g dGhhdCBzdGQ6Om1vdmUoKnRoaXMpIGlzCisgICAgICAgIGFuIHJ2YWx1ZSByZWZlcmVuY2UgdGhh dCBjYW4gYmUgbW92ZWQsIHJhdGhlciB0aGFuIGNvcGllZCwgaW50byB0aGUgcmV0dXJuZWQgU3Ry aW5nLgorCisgICAgICAgICogd3RmL3RleHQvV1RGU3RyaW5nLmNwcDoKKyAgICAgICAgKFdURjo6 U3RyaW5nOjppc29sYXRlZENvcHkpOgorICAgICAgICAqIHd0Zi90ZXh0L1dURlN0cmluZy5oOgor CiAyMDE0LTA2LTE1ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAg aU9TIGJ1aWxkIGZpeCBhZnRlciByMTY5OTk1LgpJbmRleDogU291cmNlL1dURi93dGYvdGV4dC9X VEZTdHJpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5n LmNwcAkocmV2aXNpb24gMTcwMDQwKQorKysgU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02ODgsNyArNjg4LDcgQEAgU3RyaW5nIFN0cmluZzo6aXNv bGF0ZWRDb3B5KCkgY29uc3QgJgogICAgIHJldHVybiBtX2ltcGwtPmlzb2xhdGVkQ29weSgpOwog fQogCi1TdHJpbmcgU3RyaW5nOjppc29sYXRlZENvcHkoKSBjb25zdCAmJgorU3RyaW5nIFN0cmlu Zzo6aXNvbGF0ZWRDb3B5KCkgJiYKIHsKICAgICBpZiAoaXNTYWZlVG9TZW5kVG9Bbm90aGVyVGhy ZWFkKCkpIHsKICAgICAgICAgLy8gU2luY2Ugd2Uga25vdyB0aGF0IG91ciBzdHJpbmcgaXMgYSB0 ZW1wb3JhcnkgdGhhdCB3aWxsIGJlIGRlc3Ryb3llZApJbmRleDogU291cmNlL1dURi93dGYvdGV4 dC9XVEZTdHJpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmlu Zy5oCShyZXZpc2lvbiAxNzAwNDApCisrKyBTb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5o CSh3b3JraW5nIGNvcHkpCkBAIC0zNzMsNyArMzczLDcgQEAgcHVibGljOgogCiAjaWYgQ09NUElM RVJfU1VQUE9SVFMoQ1hYX1JFRkVSRU5DRV9RVUFMSUZJRURfRlVOQ1RJT05TKQogICAgIFdURl9F WFBPUlRfU1RSSU5HX0FQSSBTdHJpbmcgaXNvbGF0ZWRDb3B5KCkgY29uc3QgJjsKLSAgICBXVEZf RVhQT1JUX1NUUklOR19BUEkgU3RyaW5nIGlzb2xhdGVkQ29weSgpIGNvbnN0ICYmOworICAgIFdU Rl9FWFBPUlRfU1RSSU5HX0FQSSBTdHJpbmcgaXNvbGF0ZWRDb3B5KCkgJiY7CiAjZWxzZQogICAg IFdURl9FWFBPUlRfU1RSSU5HX0FQSSBTdHJpbmcgaXNvbGF0ZWRDb3B5KCkgY29uc3Q7CiAjZW5k aWYKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDE3MDA0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE0IEBACisyMDE0LTA2LTE2ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+ CisKKyAgICAgICAgU3RyaW5nOjppc29sYXRlZENvcHkgZG9lc27igJl0IHJldHVybiBhbiBpc29s YXRlZCBjb3B5IHdoZW4gdXNlZCBvbiBhbiBydmFsdWUgcmVmZXJlbmNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM5NjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMv V1RGL1dURlN0cmluZy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKTogQWRkZWQg YSB0ZXN0IHRoYXQgYW4gaXNvbGF0ZWQgY29weSBvZiBhbiBydmFsdWUgcmVmZXJlbmNlIGRvZXNu 4oCZdAorICAgICAgICBzaGFyZSBhbiBpbXBsKCkgd2l0aCB0aGUgb3JpZ2luYWwuCisKIDIwMTQt MDYtMTYgIEd3YW5nIFlvb24gSHdhbmcgIDx5b29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S10gQWRkIGxsdm1waXBlIChNZXNhKSB0byB0aGUgSkhCdWlsZCBtb2R1bGVzZXQgYW5kIGZvcmNl IGl0IHdoZW4gcnVubmluZyBsYXlvdXQgdGVzdHMKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV1RGL1dURlN0cmluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcAkocmV2aXNpb24gMTcwMDQwKQorKysgVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUz LDUgKzE1MywxMSBAQCBURVNUKFdURiwgU3RyaW5nUmVwbGFjZVdpdGhMaXRlcmFsKQogICAgIEFT U0VSVF9TVFJFUSgicsOpc3Vtw6kiLCB0ZXN0U3RyaW5nLnV0ZjgoKS5kYXRhKCkpOwogfQogCitU RVNUKFdURiwgU3RyaW5nSXNvbGF0ZWRDb3B5KQoreworICAgIFN0cmluZyBvcmlnaW5hbCA9ICIx MjM0IjsKKyAgICBhdXRvIGNvcHkgPSBzdGQ6Om1vdmUob3JpZ2luYWwpLmlzb2xhdGVkQ29weSgp OworICAgIEFTU0VSVF9GQUxTRShvcmlnaW5hbC5pbXBsKCkgPT0gY29weS5pbXBsKCkpOworfQog CiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==