133931 2014-06-15 18:06:04 -0700 [ftlopt] Remove the DFG optimization fixpoint and remove some obvious reasons why we previously benefited from it 2014-06-16 11:20:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 1015797 0 fpizlo 2014-06-15 18:06:04 -0700 Patch forthcoming. 1015799 1 233149 fpizlo 2014-06-15 18:25:14 -0700 Created attachment 233149 the patch 1015897 2 fpizlo 2014-06-16 11:20:44 -0700 Landed in http://trac.webkit.org/changeset/170017 233149 2014-06-15 18:25:14 -0700 2014-06-16 10:09:14 -0700 the patch blah.patch text/plain 7540 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY5OTk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTA2LTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg W2Z0bG9wdF0gUmVtb3ZlIHRoZSBERkcgb3B0aW1pemF0aW9uIGZpeHBvaW50IGFuZCByZW1vdmUg c29tZSBvYnZpb3VzIHJlYXNvbnMgd2h5IHdlIHByZXZpb3VzbHkgYmVuZWZpdGVkIGZyb20gaXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzkzMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RG R0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkRGRzo6QWJzdHJh Y3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHlwZT46OmV4ZWN1dGVFZmZlY3RzKTogVHJpZ2dl ciBjb25zdGFudC1mb2xkaW5nIGZvciBHZXRNeUFyZ3VtZW50QnlWYWwgKHdoaWNoIG1lYW5zIHR1 cm5pbmcgaXQgaW50byBHZXRMb2NhbFVubGlua2VkKSBhbmQgY29ycmVjdCB0aGUgaGFuZGxpbmcg b2YgVXBzaWxvbiBzbyB3ZSBkb24ndCBmb2xkIHRoZW0gYXdheS4KKyAgICAgICAgKiBkZmcvREZH Q29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkNvbnN0YW50Rm9s ZGluZ1BoYXNlOjpmb2xkQ29uc3RhbnRzKTogSW1wbGVtZW50IGNvbnN0YW50LWZvbGRpbmcgZm9y IEdldE15QXJndW1lbnRCeVZhbC4KKyAgICAgICAgKiBkZmcvREZHUGxhbi5jcHA6CisgICAgICAg IChKU0M6OkRGRzo6UGxhbjo6Y29tcGlsZUluVGhyZWFkSW1wbCk6IFJlbW92ZSB0aGUgZml4cG9p bnQuCisKIDIwMTQtMDYtMTIgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAg ICAgICBbZnRsb3B0XSBBIERGRyBpbmxpbmVkIEJ5SWQgYWNjZXNzIHZhcmlhbnQgc2hvdWxkIG5v dCBzcGVhayBvZiBhIGNoYWluLCBidXQgb25seSBvZiB3aGF0IHN0cnVjdHVyZXMgdG8gdGVzdCB0 aGUgYmFzZSBmb3IsIHdoZXRoZXIgdG8gdXNlIGEgY29uc3RhbnQgYXMgYW4gYWx0ZXJuYXRlIGJh c2UgZm9yIHRoZSBhY3R1YWwgYWNjZXNzLCBhbmQgd2hhdCBzdHJ1Y3R1cmVzIHRvIGNoZWNrIG9u IHdoYXQgYWRkaXRpb25hbCBjZWxsIGNvbnN0YW50cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaAko cmV2aXNpb24gMTY5OTg5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFj dEludGVycHJldGVySW5saW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzgwLDEzICsxMzgwLDI0 IEBAIGJvb2wgQWJzdHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHkKICAgICAgICAgZm9y Tm9kZShub2RlKS5tYWtlSGVhcFRvcCgpOwogICAgICAgICBicmVhazsKICAgICAgICAgCi0gICAg Y2FzZSBHZXRNeUFyZ3VtZW50QnlWYWw6CisgICAgY2FzZSBHZXRNeUFyZ3VtZW50QnlWYWw6IHsK ICAgICAgICAgbm9kZS0+c2V0Q2FuRXhpdCh0cnVlKTsKLSAgICAgICAgLy8gV2Uga25vdyB0aGF0 IHRoaXMgZXhlY3V0YWJsZSBkb2VzIG5vdCBlc2NhcGUgaXRzIGFyZ3VtZW50cywgc28gd2UgY2Fu IG9wdGltaXplCi0gICAgICAgIC8vIHRoZSBhcmd1bWVudHMgYSBiaXQuIE5vdGUgdGhhdCB0aGlz IGVuZHMgdXAgYmVpbmcgZnVydGhlciBvcHRpbWl6ZWQgYnkgdGhlCi0gICAgICAgIC8vIEFyZ3Vt ZW50c1NpbXBsaWZpY2F0aW9uUGhhc2UuCisgICAgICAgIElubGluZUNhbGxGcmFtZSogaW5saW5l Q2FsbEZyYW1lID0gbm9kZS0+b3JpZ2luLnNlbWFudGljLmlubGluZUNhbGxGcmFtZTsKKyAgICAg ICAgSlNWYWx1ZSB2YWx1ZSA9IGZvck5vZGUobm9kZS0+Y2hpbGQxKCkpLm1fdmFsdWU7CisgICAg ICAgIGlmIChpbmxpbmVDYWxsRnJhbWUgJiYgdmFsdWUgJiYgdmFsdWUuaXNJbnQzMigpKSB7Cisg ICAgICAgICAgICBpbnQzMl90IGluZGV4ID0gdmFsdWUuYXNJbnQzMigpOworICAgICAgICAgICAg aWYgKGluZGV4ID49IDAKKyAgICAgICAgICAgICAgICAmJiBzdGF0aWNfY2FzdDxzaXplX3Q+KGlu ZGV4ICsgMSkgPCBpbmxpbmVDYWxsRnJhbWUtPmFyZ3VtZW50cy5zaXplKCkpIHsKKyAgICAgICAg ICAgICAgICBmb3JOb2RlKG5vZGUpID0gbV9zdGF0ZS52YXJpYWJsZXMoKS5vcGVyYW5kKAorICAg ICAgICAgICAgICAgICAgICBpbmxpbmVDYWxsRnJhbWUtPnN0YWNrT2Zmc2V0ICsKKyAgICAgICAg ICAgICAgICAgICAgbV9ncmFwaC5iYXNlbGluZUNvZGVCbG9ja0ZvcihpbmxpbmVDYWxsRnJhbWUp LT5hcmd1bWVudEluZGV4QWZ0ZXJDYXB0dXJlKGluZGV4KSk7CisgICAgICAgICAgICAgICAgbV9z dGF0ZS5zZXRGb3VuZENvbnN0YW50cyh0cnVlKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAg ICAgICAgICAgIH0KKyAgICAgICAgfQogICAgICAgICBmb3JOb2RlKG5vZGUpLm1ha2VIZWFwVG9w KCk7CiAgICAgICAgIGJyZWFrOworICAgIH0KICAgICAgICAgCiAgICAgY2FzZSBHZXRNeUFyZ3Vt ZW50QnlWYWxTYWZlOgogICAgICAgICBub2RlLT5zZXRDYW5FeGl0KHRydWUpOwpAQCAtMTg2MCw5 ICsxODcxLDcgQEAgYm9vbCBBYnN0cmFjdEludGVycHJldGVyPEFic3RyYWN0U3RhdGVUeQogICAg ICAgICAKICAgICBjYXNlIFVwc2lsb246IHsKICAgICAgICAgbV9zdGF0ZS5jcmVhdGVWYWx1ZUZv ck5vZGUobm9kZS0+cGhpKCkpOwotICAgICAgICBBYnN0cmFjdFZhbHVlIHZhbHVlID0gZm9yTm9k ZShub2RlLT5jaGlsZDEoKSk7Ci0gICAgICAgIGZvck5vZGUobm9kZSkgPSB2YWx1ZTsKLSAgICAg ICAgZm9yTm9kZShub2RlLT5waGkoKSkgPSB2YWx1ZTsKKyAgICAgICAgZm9yTm9kZShub2RlLT5w aGkoKSkgPSBmb3JOb2RlKG5vZGUtPmNoaWxkMSgpKTsKICAgICAgICAgYnJlYWs7CiAgICAgfQog ICAgICAgICAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xk aW5nUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Q29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwCShyZXZpc2lvbiAxNjk5ODkpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjQ2LDYgKzI0NiwzNCBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgIG5vZGUtPmNv bnZlcnRUb0lkZW50aXR5KCk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9 CisgICAgICAgICAgICAgICAgCisgICAgICAgICAgICBjYXNlIEdldE15QXJndW1lbnRCeVZhbDog eworICAgICAgICAgICAgICAgIElubGluZUNhbGxGcmFtZSogaW5saW5lQ2FsbEZyYW1lID0gbm9k ZS0+b3JpZ2luLnNlbWFudGljLmlubGluZUNhbGxGcmFtZTsKKyAgICAgICAgICAgICAgICBKU1Zh bHVlIHZhbHVlID0gbV9zdGF0ZS5mb3JOb2RlKG5vZGUtPmNoaWxkMSgpKS5tX3ZhbHVlOworICAg ICAgICAgICAgICAgIGlmIChpbmxpbmVDYWxsRnJhbWUgJiYgdmFsdWUgJiYgdmFsdWUuaXNJbnQz MigpKSB7CisgICAgICAgICAgICAgICAgICAgIGludDMyX3QgaW5kZXggPSB2YWx1ZS5hc0ludDMy KCk7CisgICAgICAgICAgICAgICAgICAgIGlmIChpbmRleCA+PSAwCisgICAgICAgICAgICAgICAg ICAgICAgICAmJiBzdGF0aWNfY2FzdDxzaXplX3Q+KGluZGV4ICsgMSkgPCBpbmxpbmVDYWxsRnJh bWUtPmFyZ3VtZW50cy5zaXplKCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIFJvbGwg dGhlIGludGVycHJldGVyIG92ZXIgdGhpcy4KKyAgICAgICAgICAgICAgICAgICAgICAgIG1faW50 ZXJwcmV0ZXIuZXhlY3V0ZShpbmRleEluQmxvY2spOworICAgICAgICAgICAgICAgICAgICAgICAg ZWxpbWluYXRlZCA9IHRydWU7CisgICAgICAgICAgICAgICAgICAgICAgICAKKyAgICAgICAgICAg ICAgICAgICAgICAgIGludCBvcGVyYW5kID0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBp bmxpbmVDYWxsRnJhbWUtPnN0YWNrT2Zmc2V0ICsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICBtX2dyYXBoLmJhc2VsaW5lQ29kZUJsb2NrRm9yKGlubGluZUNhbGxGcmFtZSktPmFyZ3VtZW50 SW5kZXhBZnRlckNhcHR1cmUoaW5kZXgpOworICAgICAgICAgICAgICAgICAgICAgICAgCisgICAg ICAgICAgICAgICAgICAgICAgICBtX2luc2VydGlvblNldC5pbnNlcnROb2RlKAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGluZGV4SW5CbG9jaywgU3BlY05vbmUsIENoZWNrQXJndW1lbnRz Tm90Q3JlYXRlZCwgbm9kZS0+b3JpZ2luKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIG1faW5z ZXJ0aW9uU2V0Lmluc2VydE5vZGUoCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5kZXhJ bkJsb2NrLCBTcGVjTm9uZSwgUGhhbnRvbSwgbm9kZS0+b3JpZ2luLCBub2RlLT5jaGlsZHJlbik7 CisgICAgICAgICAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUt PmNvbnZlcnRUb0dldExvY2FsVW5saW5rZWQoVmlydHVhbFJlZ2lzdGVyKG9wZXJhbmQpKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgICAgICB9CisgICAg ICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgICAgIGJy ZWFrOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1BsYW4uY3BwCShyZXZpc2lvbiAx Njk5ODkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1BsYW4uY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yMzgsMzIgKzIzOCwzNSBAQCBQbGFuOjpDb21waWxhdGlvblBhdGggUGxhbjo6 Y29tcGlsZUluVGhyCiAgICAgcGVyZm9ybUludmFsaWRhdGlvblBvaW50SW5qZWN0aW9uKGRmZyk7 CiAgICAgcGVyZm9ybVR5cGVDaGVja0hvaXN0aW5nKGRmZyk7CiAgICAgCi0gICAgdW5zaWduZWQg Y291bnQgPSAxOwogICAgIGRmZy5tX2ZpeHBvaW50U3RhdGUgPSBGaXhwb2ludE5vdENvbnZlcmdl ZDsKLSAgICBmb3IgKDs7ICsrY291bnQpIHsKLSAgICAgICAgaWYgKGxvZ0NvbXBpbGF0aW9uQ2hh bmdlcyhtb2RlKSkKLSAgICAgICAgICAgIGRhdGFMb2dGKCJERkcgYmVnaW5uaW5nIG9wdGltaXph dGlvbiBmaXhwb2ludCBpdGVyYXRpb24gIyV1LlxuIiwgY291bnQpOwotICAgICAgICBib29sIGNo YW5nZWQgPSBmYWxzZTsKLSAgICAgICAgCi0gICAgICAgIGlmICh2YWxpZGF0aW9uRW5hYmxlZCgp KQotICAgICAgICAgICAgdmFsaWRhdGUoZGZnKTsKLSAgICAgICAgCi0gICAgICAgIGNoYW5nZWQg fD0gcGVyZm9ybVN0cmVuZ3RoUmVkdWN0aW9uKGRmZyk7CisgICAgCisgICAgLy8gRm9yIG5vdyB3 ZSdyZSBiYWNrIHRvIGF2b2lkaW5nIGEgZml4cG9pbnQuIE5vdGUgdGhhdCB3ZSd2ZSBwaW5nLXBv bmdlZCBvbiB0aGlzIGRlY2lzaW9uCisgICAgLy8gbWFueSB0aW1lcy4gRm9yIG1heGltdW0gdGhy b3VnaHB1dCwgaXQncyBiZXN0IHRvIGZpeHBvaW50LiBCdXQgdGhlIHRocm91Z2hwdXQgYmVuZWZp dCBpcworICAgIC8vIHNtYWxsIGFuZCBub3QgbGlrZWx5IHRvIHNob3cgdXAgaW4gRlRMIGFueXdh eS4gT24gdGhlIG90aGVyIGhhbmQsIG5vdCBmaXhwb2ludGluZyBtZWFucworICAgIC8vIHRoYXQg dGhlIGNvbXBpbGVyIGNvbXBpbGVzIG1vcmUgcXVpY2tseS4gV2Ugd2FudCB0aGUgdGhpcmQgdGll ciB0byBjb21waWxlIHF1aWNrbHksIHdoaWNoCisgICAgLy8gbm90IGZpeHBvaW50aW5nIGFjY29t cGxpc2hlczsgYW5kIHRoZSBmb3VydGggdGllciBzaG91bGRuJ3QgbmVlZCBhIGZpeHBvaW50Lgor ICAgIGlmICh2YWxpZGF0aW9uRW5hYmxlZCgpKQorICAgICAgICB2YWxpZGF0ZShkZmcpOworICAg ICAgICAKKyAgICBwZXJmb3JtU3RyZW5ndGhSZWR1Y3Rpb24oZGZnKTsKKyAgICBwZXJmb3JtQ1NF KGRmZyk7CisgICAgcGVyZm9ybUFyZ3VtZW50c1NpbXBsaWZpY2F0aW9uKGRmZyk7CisgICAgcGVy Zm9ybUNQU1JldGhyZWFkaW5nKGRmZyk7CisgICAgcGVyZm9ybUNGQShkZmcpOworICAgIHBlcmZv cm1Db25zdGFudEZvbGRpbmcoZGZnKTsKKyAgICBib29sIGNoYW5nZWQgPSBmYWxzZTsKKyAgICBj aGFuZ2VkIHw9IHBlcmZvcm1DRkdTaW1wbGlmaWNhdGlvbihkZmcpOworICAgIGNoYW5nZWQgfD0g cGVyZm9ybUNTRShkZmcpOworICAgIAorICAgIGlmICh2YWxpZGF0aW9uRW5hYmxlZCgpKQorICAg ICAgICB2YWxpZGF0ZShkZmcpOworCisgICAgcGVyZm9ybUNQU1JldGhyZWFkaW5nKGRmZyk7Cisg ICAgaWYgKGNoYW5nZWQpIHsKICAgICAgICAgcGVyZm9ybUNGQShkZmcpOwotICAgICAgICBjaGFu Z2VkIHw9IHBlcmZvcm1Db25zdGFudEZvbGRpbmcoZGZnKTsKLSAgICAgICAgY2hhbmdlZCB8PSBw ZXJmb3JtQXJndW1lbnRzU2ltcGxpZmljYXRpb24oZGZnKTsKLSAgICAgICAgY2hhbmdlZCB8PSBw ZXJmb3JtQ0ZHU2ltcGxpZmljYXRpb24oZGZnKTsKLSAgICAgICAgY2hhbmdlZCB8PSBwZXJmb3Jt Q1NFKGRmZyk7Ci0gICAgICAgIAotICAgICAgICBpZiAoIWNoYW5nZWQpCi0gICAgICAgICAgICBi cmVhazsKLSAgICAgICAgCi0gICAgICAgIHBlcmZvcm1DUFNSZXRocmVhZGluZyhkZmcpOworICAg ICAgICBwZXJmb3JtQ29uc3RhbnRGb2xkaW5nKGRmZyk7CiAgICAgfQogICAgIAotICAgIGlmIChs b2dDb21waWxhdGlvbkNoYW5nZXMobW9kZSkpCi0gICAgICAgIGRhdGFMb2dGKCJERkcgb3B0aW1p emF0aW9uIGZpeHBvaW50IGNvbnZlcmdlZCBpbiAldSBpdGVyYXRpb25zLlxuIiwgY291bnQpOwot CiAgICAgLy8gSWYgd2UncmUgZG9pbmcgdmFsaWRhdGlvbiwgdGhlbiBydW4gc29tZSBhbmFseXNl cywgdG8gZ2l2ZSB0aGVtIGFuIG9wcG9ydHVuaXR5CiAgICAgLy8gdG8gc2VsZi12YWxpZGF0ZS4g Tm93IGlzIGFzIGdvb2QgYSB0aW1lIGFzIGFueSB0byBkbyB0aGlzLgogICAgIGlmICh2YWxpZGF0 aW9uRW5hYmxlZCgpKSB7Cg==