133928 2014-06-15 12:16:05 -0700 Get rid of VoidAPICallback 2014-06-15 19:32:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca gyuyoung.kim sam oldest_to_newest 1015776 0 mitz 2014-06-15 12:16:05 -0700 Get rid of VoidAPICallback 1015778 1 233144 mitz 2014-06-15 12:18:50 -0700 Created attachment 233144 Remove VoidAPICallback 1015788 2 mitz 2014-06-15 13:51:19 -0700 Committed <http://trac.webkit.org/r169994>. 1015802 3 gyuyoung.kim 2014-06-15 19:32:17 -0700 (In reply to comment #2) > Committed <http://trac.webkit.org/r169994>. There are build breaks on GTK and EFL port since r169994. ../../Source/WebKit2/UIProcess/API/C/WKPluginSiteDataManager.cpp: In lambda function: ../../Source/WebKit2/UIProcess/API/C/WKPluginSiteDataManager.cpp:76:48: error: expected unqualified-id before numeric constant function(error == CallbackBase::Error::None ? nullptr : toAPI(API::Error::create().get()), context); ^ ../../Source/WebKit2/UIProcess/API/C/WKPluginSiteDataManager.cpp: In lambda function: ../../Source/WebKit2/UIProcess/API/C/WKPluginSiteDataManager.cpp:92:48: error: expected unqualified-id before numeric constant function(error == CallbackBase::Error::None ? nullptr : toAPI(API::Error::create().get()), context); ^ 233144 2014-06-15 12:18:50 -0700 2014-06-15 13:47:47 -0700 Remove VoidAPICallback bug-133928-20140615121827.patch text/plain 6598 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTk5MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE0LTA2LTE1ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgR2V0IHJpZCBvZiBWb2lkQVBJQ2Fs bGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MzkyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHA6CisgICAgICAgIChXS1BhZ2VGb3JjZVJlcGFpbnQp OiBXcmFwIHRoZSBBUEkgY2FsbGJhY2sgaW4gYSBnZW5lcmljIGNhbGxiYWNrIGhlcmUuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXIuY3BwOgorICAg ICAgICAoV0tQbHVnaW5TaXRlRGF0YU1hbmFnZXJDbGVhclNpdGVEYXRhKTogRGl0dG8uCisgICAg ICAgIChXS1BsdWdpblNpdGVEYXRhTWFuYWdlckNsZWFyQWxsU2l0ZURhdGEpOiBEaXR0by4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9HZW5lcmljQ2FsbGJhY2suaDoKKyAgICAgICAgKFdlYktpdDo6 R2VuZXJpY0NhbGxiYWNrOjpwZXJmb3JtQ2FsbGJhY2spOiBBZGRlZCB0aGlzIGhlbHBlciBmb3Ig MC1hcmd1bWVudCBjYWxsYmFja3MuCisgICAgICAgIChXZWJLaXQ6OlZvaWRDYWxsYmFjazo6Y3Jl YXRlKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYktpdDo6Vm9pZENhbGxiYWNrOjp+Vm9pZENhbGxi YWNrKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYktpdDo6Vm9pZENhbGxiYWNrOjpwZXJmb3JtQ2Fs bGJhY2spOiBEZWxldGVkLgorICAgICAgICAoV2ViS2l0OjpWb2lkQ2FsbGJhY2s6OmludmFsaWRh dGUpOiBEZWxldGVkLgorICAgICAgICAoV2ViS2l0OjpWb2lkQ2FsbGJhY2s6OlZvaWRDYWxsYmFj ayk6IERlbGV0ZWQuCisgICAgICAgIChXZWJLaXQ6OlZvaWRBUElDYWxsYmFjazo6Y3JlYXRlKTog RGVsZXRlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29u dHJvbGxlci5oOgorCiAyMDE0LTA2LTE1ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIFdLUGFnZVJ1bkphdmFTY3JpcHRJbk1haW5GcmFtZV9i CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvR2VuZXJpY0NhbGxiYWNrLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oCShyZXZp c2lvbiAxNjk5OTEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvR2VuZXJpY0NhbGxiYWNr LmgJKHdvcmtpbmcgY29weSkKQEAgLTY5LDYxICs2OSw2IEBAIHByaXZhdGU6CiAgICAgdWludDY0 X3QgbV9jYWxsYmFja0lEOwogfTsKIAotY2xhc3MgVm9pZENhbGxiYWNrIDogcHVibGljIENhbGxi YWNrQmFzZSB7Ci1wdWJsaWM6Ci0gICAgdHlwZWRlZiBzdGQ6OmZ1bmN0aW9uPHZvaWQgKEVycm9y KT4gQ2FsbGJhY2tGdW5jdGlvbjsKLQotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFZvaWRDYWxsYmFj az4gY3JlYXRlKENhbGxiYWNrRnVuY3Rpb24gY2FsbGJhY2spCi0gICAgewotICAgICAgICByZXR1 cm4gYWRvcHRSZWYobmV3IFZvaWRDYWxsYmFjayhjYWxsYmFjaykpOwotICAgIH0KLQotICAgIHZp cnR1YWwgflZvaWRDYWxsYmFjaygpCi0gICAgewotICAgICAgICBBU1NFUlQoIW1fY2FsbGJhY2sp OwotICAgIH0KLQotICAgIHZvaWQgcGVyZm9ybUNhbGxiYWNrKCkKLSAgICB7Ci0gICAgICAgIGlm ICghbV9jYWxsYmFjaykKLSAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICBtX2NhbGxiYWNr KEVycm9yOjpOb25lKTsKLQotICAgICAgICBtX2NhbGxiYWNrID0gbnVsbHB0cjsKLSAgICB9Ci0g ICAgCi0gICAgdm9pZCBpbnZhbGlkYXRlKEVycm9yIGVycm9yKQotICAgIHsKLSAgICAgICAgaWYg KCFtX2NhbGxiYWNrKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIG1fY2FsbGJhY2so ZXJyb3IpOwotCi0gICAgICAgIG1fY2FsbGJhY2sgPSBudWxscHRyOwotICAgIH0KLQotcHJpdmF0 ZToKLSAgICBWb2lkQ2FsbGJhY2soQ2FsbGJhY2tGdW5jdGlvbiBjYWxsYmFjaykKLSAgICAgICAg OiBtX2NhbGxiYWNrKGNhbGxiYWNrKQotICAgIHsKLSAgICB9Ci0KLSAgICBDYWxsYmFja0Z1bmN0 aW9uIG1fY2FsbGJhY2s7Ci19OwotCi1jbGFzcyBWb2lkQVBJQ2FsbGJhY2sgOiBwdWJsaWMgQ2Fs bGJhY2tCYXNlIHsKLXB1YmxpYzoKLSAgICB0eXBlZGVmIHZvaWQgKCpDYWxsYmFja0Z1bmN0aW9u KShXS0Vycm9yUmVmLCB2b2lkKik7Ci0KLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxWb2lkQ2FsbGJh Y2s+IGNyZWF0ZSh2b2lkKiBjb250ZXh0LCBDYWxsYmFja0Z1bmN0aW9uIGNhbGxiYWNrKQotICAg IHsKLSAgICAgICAgcmV0dXJuIFZvaWRDYWxsYmFjazo6Y3JlYXRlKFtjb250ZXh0LCBjYWxsYmFj a10oRXJyb3IgZXJyb3IpIHsKLSAgICAgICAgICAgIGNhbGxiYWNrKGVycm9yICE9IEVycm9yOjpO b25lID8gdG9BUEkoQVBJOjpFcnJvcjo6Y3JlYXRlKCkuZ2V0KCkpIDogMCwgY29udGV4dCk7Ci0g ICAgICAgIH0pOwotICAgIH0KLX07Ci0KIHRlbXBsYXRlPHR5cGVuYW1lLi4uIFQ+CiBjbGFzcyBH ZW5lcmljQ2FsbGJhY2sgOiBwdWJsaWMgQ2FsbGJhY2tCYXNlIHsKIHB1YmxpYzoKQEAgLTE0OCw3 ICs5MywxMiBAQCBwdWJsaWM6CiAKICAgICAgICAgbV9jYWxsYmFjayA9IG51bGxwdHI7CiAgICAg fQotICAgIAorCisgICAgdm9pZCBwZXJmb3JtQ2FsbGJhY2soKQorICAgIHsKKyAgICAgICAgcGVy Zm9ybUNhbGxiYWNrV2l0aFJldHVyblZhbHVlKCk7CisgICAgfQorCiAgICAgdm9pZCBpbnZhbGlk YXRlKEVycm9yIGVycm9yID0gRXJyb3I6OlVua25vd24pCiAgICAgewogICAgICAgICBpZiAoIW1f Y2FsbGJhY2spCkBAIC0xNzYsNiArMTI2LDcgQEAgc3RhdGljIHR5cGVuYW1lIEdlbmVyaWNDYWxs YmFjazxJbnRlcm5hbAogICAgIH07CiB9CiAKK3R5cGVkZWYgR2VuZXJpY0NhbGxiYWNrPD4gVm9p ZENhbGxiYWNrOwogdHlwZWRlZiBHZW5lcmljQ2FsbGJhY2s8Y29uc3QgVmVjdG9yPFdlYkNvcmU6 OkludFJlY3Q+JiwgZG91YmxlPiBDb21wdXRlZFBhZ2VzQ2FsbGJhY2s7CiB0eXBlZGVmIEdlbmVy aWNDYWxsYmFjazxjb25zdCBTaGFyZWFibGVCaXRtYXA6OkhhbmRsZSY+IEltYWdlQ2FsbGJhY2s7 CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCShyZXZp c2lvbiAxNjk5OTEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTYxMSw3ICsxNjExLDkgQEAgdm9pZCBXS1BhZ2VHZXRDb250 ZW50c0FzTUhUTUxEYXRhKFdLUGFnZQogCiB2b2lkIFdLUGFnZUZvcmNlUmVwYWludChXS1BhZ2VS ZWYgcGFnZVJlZiwgdm9pZCogY29udGV4dCwgV0tQYWdlRm9yY2VSZXBhaW50RnVuY3Rpb24gY2Fs bGJhY2spCiB7Ci0gICAgdG9JbXBsKHBhZ2VSZWYpLT5mb3JjZVJlcGFpbnQoVm9pZEFQSUNhbGxi YWNrOjpjcmVhdGUoY29udGV4dCwgY2FsbGJhY2spKTsKKyAgICB0b0ltcGwocGFnZVJlZiktPmZv cmNlUmVwYWludChWb2lkQ2FsbGJhY2s6OmNyZWF0ZShbY29udGV4dCwgY2FsbGJhY2tdKENhbGxi YWNrQmFzZTo6RXJyb3IgZXJyb3IpIHsKKyAgICAgICAgY2FsbGJhY2soZXJyb3IgPT0gQ2FsbGJh Y2tCYXNlOjpFcnJvcjo6Tm9uZSA/IG51bGxwdHIgOiB0b0FQSShBUEk6OkVycm9yOjpjcmVhdGUo KS5nZXQoKSksIGNvbnRleHQpOworICAgIH0pKTsKIH0KIAogV0tfRVhQT1JUIFdLVVJMUmVmIFdL UGFnZUNvcHlQZW5kaW5nQVBJUmVxdWVzdFVSTChXS1BhZ2VSZWYgcGFnZVJlZikKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BsdWdpblNpdGVEYXRhTWFuYWdlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGx1Z2luU2l0 ZURhdGFNYW5hZ2VyLmNwcAkocmV2aXNpb24gMTY5OTkxKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9DL1dLUGx1Z2luU2l0ZURhdGFNYW5hZ2VyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzIsNyArNzIsOSBAQCBzdGF0aWMgdWludDY0X3QgdG9OUENsZWFyU2l0ZURhdGFGbGFncyhX CiB2b2lkIFdLUGx1Z2luU2l0ZURhdGFNYW5hZ2VyQ2xlYXJTaXRlRGF0YShXS1BsdWdpblNpdGVE YXRhTWFuYWdlclJlZiBtYW5hZ2VyUmVmLCBXS0FycmF5UmVmIHNpdGVzUmVmLCBXS0NsZWFyU2l0 ZURhdGFGbGFncyBmbGFncywgdWludDY0X3QgbWF4QWdlSW5TZWNvbmRzLCB2b2lkKiBjb250ZXh0 LCBXS1BsdWdpblNpdGVEYXRhTWFuYWdlckNsZWFyU2l0ZURhdGFGdW5jdGlvbiBmdW5jdGlvbikK IHsKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKLSAgICB0b0ltcGwobWFuYWdlclJl ZiktPmNsZWFyU2l0ZURhdGEodG9JbXBsKHNpdGVzUmVmKSwgdG9OUENsZWFyU2l0ZURhdGFGbGFn cyhmbGFncyksIG1heEFnZUluU2Vjb25kcywgVm9pZEFQSUNhbGxiYWNrOjpjcmVhdGUoY29udGV4 dCwgZnVuY3Rpb24pKTsKKyAgICB0b0ltcGwobWFuYWdlclJlZiktPmNsZWFyU2l0ZURhdGEodG9J bXBsKHNpdGVzUmVmKSwgdG9OUENsZWFyU2l0ZURhdGFGbGFncyhmbGFncyksIG1heEFnZUluU2Vj b25kcywgVm9pZENhbGxiYWNrOjpjcmVhdGUoW2NvbnRleHQsIGZ1bmN0aW9uXShDYWxsYmFja0Jh c2U6OkVycm9yIGVycm9yKSB7CisgICAgICAgIGZ1bmN0aW9uKGVycm9yID09IENhbGxiYWNrQmFz ZTo6RXJyb3I6Ok5vbmUgPyBudWxscHRyIDogdG9BUEkoQVBJOjpFcnJvcjo6Y3JlYXRlKCkuZ2V0 KCkpLCBjb250ZXh0KTsKKyAgICB9KSk7CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTShtYW5hZ2Vy UmVmKTsKICAgICBVTlVTRURfUEFSQU0oc2l0ZXNSZWYpOwpAQCAtODYsNyArODgsOSBAQCB2b2lk IFdLUGx1Z2luU2l0ZURhdGFNYW5hZ2VyQ2xlYXJTaXRlRGF0CiB2b2lkIFdLUGx1Z2luU2l0ZURh dGFNYW5hZ2VyQ2xlYXJBbGxTaXRlRGF0YShXS1BsdWdpblNpdGVEYXRhTWFuYWdlclJlZiBtYW5h Z2VyUmVmLCB2b2lkKiBjb250ZXh0LCBXS1BsdWdpblNpdGVEYXRhTWFuYWdlckNsZWFyU2l0ZURh dGFGdW5jdGlvbiBmdW5jdGlvbikKIHsKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkK LSAgICB0b0ltcGwobWFuYWdlclJlZiktPmNsZWFyU2l0ZURhdGEoMCwgTlBfQ0xFQVJfQUxMLCBz dGQ6Om51bWVyaWNfbGltaXRzPHVpbnQ2NF90Pjo6bWF4KCksIFZvaWRBUElDYWxsYmFjazo6Y3Jl YXRlKGNvbnRleHQsIGZ1bmN0aW9uKSk7CisgICAgdG9JbXBsKG1hbmFnZXJSZWYpLT5jbGVhclNp dGVEYXRhKDAsIE5QX0NMRUFSX0FMTCwgc3RkOjpudW1lcmljX2xpbWl0czx1aW50NjRfdD46Om1h eCgpLCBWb2lkQ2FsbGJhY2s6OmNyZWF0ZShbY29udGV4dCwgZnVuY3Rpb25dKENhbGxiYWNrQmFz ZTo6RXJyb3IgZXJyb3IpIHsKKyAgICAgICAgZnVuY3Rpb24oZXJyb3IgPT0gQ2FsbGJhY2tCYXNl OjpFcnJvcjo6Tm9uZSA/IG51bGxwdHIgOiB0b0FQSShBUEk6OkVycm9yOjpjcmVhdGUoKS5nZXQo KSksIGNvbnRleHQpOworICAgIH0pKTsKICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKG1hbmFnZXJS ZWYpOwogICAgIFVOVVNFRF9QQVJBTShjb250ZXh0KTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl ci5oCShyZXZpc2lvbiAxNjk5OTEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dL RnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMjUsMTIgKzI1 LDEyIEBACiAKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCiAKKyNpbXBvcnQgIkdlbmVyaWND YWxsYmFjay5oIgogI2ltcG9ydCA8d3RmL093blB0ci5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0 ci5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsgCiBjbGFzcyBMYXllclRyZWVDb250ZXh0OwotY2xh c3MgVm9pZENhbGxiYWNrOwogfQogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Cg==