<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>133907</bug_id>
          
          <creation_ts>2014-06-14 11:34:02 -0700</creation_ts>
          <short_desc>Replace some uses of ResourceRequestBase::addHTTPHeaderField with setHTTPHeaderField</short_desc>
          <delta_ts>2014-06-14 12:11:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Anders Carlsson">andersca</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1015675</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-06-14 11:34:02 -0700</bug_when>
    <thetext>Replace some uses of ResourceRequestBase::addHTTPHeaderField with setHTTPHeaderField</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1015679</commentid>
    <comment_count>1</comment_count>
      <attachid>233114</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-06-14 12:03:54 -0700</bug_when>
    <thetext>Created attachment 233114
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1015680</commentid>
    <comment_count>2</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-06-14 12:11:07 -0700</bug_when>
    <thetext>Committed r169975: &lt;http://trac.webkit.org/changeset/169975&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>233114</attachid>
            <date>2014-06-14 12:03:54 -0700</date>
            <delta_ts>2014-06-14 12:05:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-133907-20140614120330.patch</filename>
            <type>text/plain</type>
            <size>6410</size>
            <attacher name="Anders Carlsson">andersca</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5OTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M2MmM4YjNjNDEwMDZl
YzZjM2FiYTIyNDZiY2YwYWE0M2FhMzA4OS4uZjNmY2U3Y2QyNWQxNWMxNDFhNzAzMTYxOGQyMTQy
NzJlMzg3YTQ1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA2LTE0ICBBbmRl
cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVwbGFjZSBzb21l
IHVzZXMgb2YgUmVzb3VyY2VSZXF1ZXN0QmFzZTo6YWRkSFRUUEhlYWRlckZpZWxkIHdpdGggc2V0
SFRUUEhlYWRlckZpZWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xMzM5MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIE1vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXRIYW5kc2hha2UuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6V2ViU29ja2V0SGFuZHNoYWtlOjpjbGllbnRIYW5kc2hha2VSZXF1ZXN0
KToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJOYW1lcy5pbjoKKyAgICAg
ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6YXBwbHlCYXNpY0F1dGhvcml6YXRpb25IZWFkZXIpOgorICAgICAgICAqIHBs
YXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tOgorICAgICAgICAoV2ViQ29y
ZTo6YXBwbHlCYXNpY0F1dGhvcml6YXRpb25IZWFkZXIpOgorCiAyMDE0LTA2LTEzICBBbmRlcnMg
Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgUmVzb3VyY2VS
ZXF1ZXN0QmFzZTo6c2V0SFRUUEhlYWRlckZpZWxkIG92ZXJsb2FkIHRoYXQgdGFrZXMgYSBIVFRQ
SGVhZGVyTmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRz
L1dlYlNvY2tldEhhbmRzaGFrZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tl
dHMvV2ViU29ja2V0SGFuZHNoYWtlLmNwcAppbmRleCA5YjRlYjUzYjcwMzkxNDMwZGRlNTJkMjE4
ZjlhNjc3NTM2ODcwNTQ2Li4wYzY0ZmExYWE0OWI1MTZkYmY5ODAxYmQ0YTc1OWNhMmFjNTJhN2Y5
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0
SGFuZHNoYWtlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvV2Vi
U29ja2V0SGFuZHNoYWtlLmNwcApAQCAtMjQwLDMyICsyNDAsMzIgQEAgUmVzb3VyY2VSZXF1ZXN0
IFdlYlNvY2tldEhhbmRzaGFrZTo6Y2xpZW50SGFuZHNoYWtlUmVxdWVzdCgpIGNvbnN0CiAgICAg
UmVzb3VyY2VSZXF1ZXN0IHJlcXVlc3QobV91cmwpOwogICAgIHJlcXVlc3Quc2V0SFRUUE1ldGhv
ZCgiR0VUIik7CiAKLSAgICByZXF1ZXN0LmFkZEhUVFBIZWFkZXJGaWVsZCgiQ29ubmVjdGlvbiIs
ICJVcGdyYWRlIik7Ci0gICAgcmVxdWVzdC5hZGRIVFRQSGVhZGVyRmllbGQoIkhvc3QiLCBob3N0
TmFtZShtX3VybCwgbV9zZWN1cmUpKTsKLSAgICByZXF1ZXN0LmFkZEhUVFBIZWFkZXJGaWVsZCgi
T3JpZ2luIiwgY2xpZW50T3JpZ2luKCkpOworICAgIHJlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxk
KEhUVFBIZWFkZXJOYW1lOjpDb25uZWN0aW9uLCAiVXBncmFkZSIpOworICAgIHJlcXVlc3Quc2V0
SFRUUEhlYWRlckZpZWxkKEhUVFBIZWFkZXJOYW1lOjpIb3N0LCBob3N0TmFtZShtX3VybCwgbV9z
ZWN1cmUpKTsKKyAgICByZXF1ZXN0LnNldEhUVFBIZWFkZXJGaWVsZChIVFRQSGVhZGVyTmFtZTo6
T3JpZ2luLCBjbGllbnRPcmlnaW4oKSk7CiAgICAgaWYgKCFtX2NsaWVudFByb3RvY29sLmlzRW1w
dHkoKSkKLSAgICAgICAgcmVxdWVzdC5hZGRIVFRQSGVhZGVyRmllbGQoIlNlYy1XZWJTb2NrZXQt
UHJvdG9jb2wiLCBtX2NsaWVudFByb3RvY29sKTsKKyAgICAgICAgcmVxdWVzdC5zZXRIVFRQSGVh
ZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6OlNlY1dlYlNvY2tldFByb3RvY29sLCBtX2NsaWVudFBy
b3RvY29sKTsKIAogICAgIFVSTCB1cmwgPSBodHRwVVJMRm9yQXV0aGVudGljYXRpb25BbmRDb29r
aWVzKCk7CiAgICAgaWYgKG1fY29udGV4dC0+aXNEb2N1bWVudCgpKSB7CiAgICAgICAgIERvY3Vt
ZW50KiBkb2N1bWVudCA9IHRvRG9jdW1lbnQobV9jb250ZXh0KTsKICAgICAgICAgU3RyaW5nIGNv
b2tpZSA9IGNvb2tpZVJlcXVlc3RIZWFkZXJGaWVsZFZhbHVlKGRvY3VtZW50LCB1cmwpOwogICAg
ICAgICBpZiAoIWNvb2tpZS5pc0VtcHR5KCkpCi0gICAgICAgICAgICByZXF1ZXN0LmFkZEhUVFBI
ZWFkZXJGaWVsZCgiQ29va2llIiwgY29va2llKTsKKyAgICAgICAgICAgIHJlcXVlc3Quc2V0SFRU
UEhlYWRlckZpZWxkKEhUVFBIZWFkZXJOYW1lOjpDb29raWUsIGNvb2tpZSk7CiAgICAgICAgIC8v
IFNldCAiQ29va2llMjogPGNvb2tpZT4iIGlmIGNvb2tpZXMgMiBleGlzdHMgZm9yIHVybD8KICAg
ICB9CiAKLSAgICByZXF1ZXN0LmFkZEhUVFBIZWFkZXJGaWVsZCgiUHJhZ21hIiwgIm5vLWNhY2hl
Iik7Ci0gICAgcmVxdWVzdC5hZGRIVFRQSGVhZGVyRmllbGQoIkNhY2hlLUNvbnRyb2wiLCAibm8t
Y2FjaGUiKTsKKyAgICByZXF1ZXN0LnNldEhUVFBIZWFkZXJGaWVsZChIVFRQSGVhZGVyTmFtZTo6
UHJhZ21hLCAibm8tY2FjaGUiKTsKKyAgICByZXF1ZXN0LnNldEhUVFBIZWFkZXJGaWVsZChIVFRQ
SGVhZGVyTmFtZTo6Q2FjaGVDb250cm9sLCAibm8tY2FjaGUiKTsKIAotICAgIHJlcXVlc3QuYWRk
SFRUUEhlYWRlckZpZWxkKCJTZWMtV2ViU29ja2V0LUtleSIsIG1fc2VjV2ViU29ja2V0S2V5KTsK
LSAgICByZXF1ZXN0LmFkZEhUVFBIZWFkZXJGaWVsZCgiU2VjLVdlYlNvY2tldC1WZXJzaW9uIiwg
IjEzIik7CisgICAgcmVxdWVzdC5zZXRIVFRQSGVhZGVyRmllbGQoSFRUUEhlYWRlck5hbWU6OlNl
Y1dlYlNvY2tldEtleSwgbV9zZWNXZWJTb2NrZXRLZXkpOworICAgIHJlcXVlc3Quc2V0SFRUUEhl
YWRlckZpZWxkKEhUVFBIZWFkZXJOYW1lOjpTZWNXZWJTb2NrZXRWZXJzaW9uLCAiMTMiKTsKICAg
ICBjb25zdCBTdHJpbmcgZXh0ZW5zaW9uVmFsdWUgPSBtX2V4dGVuc2lvbkRpc3BhdGNoZXIuY3Jl
YXRlSGVhZGVyVmFsdWUoKTsKICAgICBpZiAoZXh0ZW5zaW9uVmFsdWUubGVuZ3RoKCkpCi0gICAg
ICAgIHJlcXVlc3QuYWRkSFRUUEhlYWRlckZpZWxkKCJTZWMtV2ViU29ja2V0LUV4dGVuc2lvbnMi
LCBleHRlbnNpb25WYWx1ZSk7CisgICAgICAgIHJlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxkKEhU
VFBIZWFkZXJOYW1lOjpTZWNXZWJTb2NrZXRFeHRlbnNpb25zLCBleHRlbnNpb25WYWx1ZSk7CiAK
ICAgICAvLyBBZGQgYSBVc2VyLUFnZW50IGhlYWRlci4KLSAgICByZXF1ZXN0LmFkZEhUVFBIZWFk
ZXJGaWVsZCgiVXNlci1BZ2VudCIsIG1fY29udGV4dC0+dXNlckFnZW50KG1fY29udGV4dC0+dXJs
KCkpKTsKKyAgICByZXF1ZXN0LnNldEhUVFBIZWFkZXJGaWVsZChIVFRQSGVhZGVyTmFtZTo6VXNl
ckFnZW50LCBtX2NvbnRleHQtPnVzZXJBZ2VudChtX2NvbnRleHQtPnVybCgpKSk7CiAKICAgICBy
ZXR1cm4gcmVxdWVzdDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l
dHdvcmsvSFRUUEhlYWRlck5hbWVzLmluIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y
ay9IVFRQSGVhZGVyTmFtZXMuaW4KaW5kZXggNjU5ZTliZTYxZjZiNjhiNzgzM2YyNTMwOTIwMDU3
ZDYwZDQwYmVlOS4uOTE5NTQ4NGE2NzkwM2RkYjNiYjBiYzM1NTcwYjk3MWFmOWJiZjQwYiAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTmFtZXMu
aW4KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTmFtZXMu
aW4KQEAgLTMxLDYgKzMxLDcgQEAgQ2FjaGUtQ29udHJvbAogQ29ubmVjdGlvbgogQ29udGVudC1M
ZW5ndGgKIENvbnRlbnQtVHlwZQorQ29va2llCiBIb3N0CiBJZi1NYXRjaAogSWYtTW9kaWZpZWQt
U2luY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVz
b3VyY2VIYW5kbGVDRk5ldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nm
L1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwCmluZGV4IDgwODM5YmU1ZTFhOTU0NmYxNzMzZjQ3YWE3
OWM2ZDY5YWMxNDFlMDUuLmI2ZjZhMzg4NWExYzA3NTUxMzU2ODkxYTFmNTE1OTNjODIxMjRiZDcg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VI
YW5kbGVDRk5ldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9S
ZXNvdXJjZUhhbmRsZUNGTmV0LmNwcApAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgIkZvcm1E
YXRhU3RyZWFtQ0ZOZXQuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lTG9h
ZGVyLmgiCisjaW5jbHVkZSAiSFRUUEhlYWRlck5hbWVzLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5o
IgogI2luY2x1ZGUgIk5ldHdvcmtpbmdDb250ZXh0LmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VFcnJv
ci5oIgpAQCAtOTUsOCArOTYsOCBAQCBzdGF0aWMgSGFzaE1hcDxTdHJpbmcsIFJldGFpblB0cjxD
RkRhdGFSZWY+PiYgY2xpZW50Q2VydHMoKQogc3RhdGljIHZvaWQgYXBwbHlCYXNpY0F1dGhvcml6
YXRpb25IZWFkZXIoUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBDcmVkZW50aWFsJiBj
cmVkZW50aWFsKQogewogICAgIFN0cmluZyBhdXRoZW50aWNhdGlvbkhlYWRlciA9ICJCYXNpYyAi
ICsgYmFzZTY0RW5jb2RlKFN0cmluZyhjcmVkZW50aWFsLnVzZXIoKSArICI6IiArIGNyZWRlbnRp
YWwucGFzc3dvcmQoKSkudXRmOCgpKTsKLSAgICByZXF1ZXN0LmNsZWFySFRUUEF1dGhvcml6YXRp
b24oKTsgLy8gRklYTUU6IFNob3VsZCBhZGRIVFRQSGVhZGVyRmllbGQgYmUgc21hcnQgZW5vdWdo
IHRvIG5vdCBidWlsZCBjb21tYS1zZXBhcmF0ZWQgbGlzdHMgaW4gaGVhZGVycyBsaWtlIEF1dGhv
cml6YXRpb24/Ci0gICAgcmVxdWVzdC5hZGRIVFRQSGVhZGVyRmllbGQoIkF1dGhvcml6YXRpb24i
LCBhdXRoZW50aWNhdGlvbkhlYWRlcik7CisKKyAgICByZXF1ZXN0LnNldEhUVFBIZWFkZXJGaWVs
ZChIVFRQSGVhZGVyTmFtZTo6QXV0aG9yaXphdGlvbiwgYXV0aGVudGljYXRpb25IZWFkZXIpOwog
fQogCiBSZXNvdXJjZUhhbmRsZUludGVybmFsOjp+UmVzb3VyY2VIYW5kbGVJbnRlcm5hbCgpCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhh
bmRsZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNl
SGFuZGxlTWFjLm1tCmluZGV4IDQ3MDg0MzFmYmVhM2M0ZGE4ZmQ4ODBkNDFiNjBjMmI3NmEzOWZh
ZjUuLjljNzA3ZjExMTFiZmNmYmJjYmE3MjRhMzQ2YTY1MjYwM2FkYzBmNGQgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1t
CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxl
TWFjLm1tCkBAIC0xMDIsOCArMTAyLDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogc3RhdGljIHZv
aWQgYXBwbHlCYXNpY0F1dGhvcml6YXRpb25IZWFkZXIoUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0
LCBjb25zdCBDcmVkZW50aWFsJiBjcmVkZW50aWFsKQogewogICAgIFN0cmluZyBhdXRoZW50aWNh
dGlvbkhlYWRlciA9ICJCYXNpYyAiICsgYmFzZTY0RW5jb2RlKFN0cmluZyhjcmVkZW50aWFsLnVz
ZXIoKSArICI6IiArIGNyZWRlbnRpYWwucGFzc3dvcmQoKSkudXRmOCgpKTsKLSAgICByZXF1ZXN0
LmNsZWFySFRUUEF1dGhvcml6YXRpb24oKTsgLy8gRklYTUU6IFNob3VsZCBhZGRIVFRQSGVhZGVy
RmllbGQgYmUgc21hcnQgZW5vdWdoIHRvIG5vdCBidWlsZCBjb21tYS1zZXBhcmF0ZWQgbGlzdHMg
aW4gaGVhZGVycyBsaWtlIEF1dGhvcml6YXRpb24/Ci0gICAgcmVxdWVzdC5hZGRIVFRQSGVhZGVy
RmllbGQoIkF1dGhvcml6YXRpb24iLCBhdXRoZW50aWNhdGlvbkhlYWRlcik7CisKKyAgICByZXF1
ZXN0LnNldEhUVFBIZWFkZXJGaWVsZChIVFRQSGVhZGVyTmFtZTo6QXV0aG9yaXphdGlvbiwgYXV0
aGVudGljYXRpb25IZWFkZXIpOwogfQogCiBzdGF0aWMgTlNPcGVyYXRpb25RdWV1ZSAqb3BlcmF0
aW9uUXVldWVGb3JBc3luY0NsaWVudHMoKQo=
</data>
<flag name="review"
          id="257613"
          type_id="1"
          status="+"
          setter="kling"
    />
          </attachment>
      

    </bug>

</bugzilla>