133905 2014-06-14 10:23:49 -0700 operationCreateArguments could cause a GC during OSR exit 2014-06-16 12:47:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 1015665 0 msaboff 2014-06-14 10:23:49 -0700 We should delay GC during createArguments when called from OSR exit stub. 1015666 1 233110 msaboff 2014-06-14 10:32:30 -0700 Created attachment 233110 Patch 1015669 2 msaboff 2014-06-14 10:44:41 -0700 Committed r169973: <http://trac.webkit.org/changeset/169973> 1015900 3 233110 ggaren 2014-06-16 11:38:24 -0700 Comment on attachment 233110 Patch Why did you choose to special-case arguments recovery, rather than deferring GC throughout the OSR exit process? 1015934 4 msaboff 2014-06-16 12:47:28 -0700 (In reply to comment #3) > (From update of attachment 233110 [details]) > Why did you choose to special-case arguments recovery, rather than deferring GC throughout the OSR exit process? This was the only place that Mark H and I found where we callout and allocate an object. Also, it seemed more error prone to create a JIT equivalent of DeferGCForAWhile to wrap an OSR exit stub. 233110 2014-06-14 10:32:30 -0700 2014-06-16 11:38:24 -0700 Patch 133905.patch text/plain 6087 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY5OTcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTA2LTE0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIG9wZXJhdGlvbkNyZWF0ZUFyZ3VtZW50cyBjb3VsZCBjYXVzZSBhIEdDIGR1cmluZyBPU1Ig ZXhpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMz OTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVm ZXIgR0MgdmlhIG5ldyB3cmFwcGVyIGZ1bmN0aW9ucyBmb3Igb3BlcmF0aW9uQ3JlYXRlQXJndW1l bnRzIGFuZCBvcGVyYXRpb25DcmVhdGVJbmxpbmVkQXJndW1lbnRzCisgICAgICAgIGZvciB1c2Ug YnkgT1NSIGV4aXQgc3R1YnMuCisKKyAgICAgICAgKiBkZmcvREZHT1NSRXhpdENvbXBpbGVyQ29t bW9uLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpBcmd1bWVudHNSZWNvdmVyeUdlbmVyYXRvcjo6 Z2VuZXJhdGVGb3IpOgorICAgICAgICAqIGRmZy9ERkdPcGVyYXRpb25zLmNwcDoKKyAgICAgICAg KiBkZmcvREZHT3BlcmF0aW9ucy5oOgorICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoK KyAgICAgICAgKiBqaXQvSklUT3BlcmF0aW9ucy5oOgorCiAyMDE0LTA2LTEzICBNYXJrIEhhaG5l bmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgT1NSIGV4aXQgc2hvdWxk IGJhcnJpZXIgdGhlIEV4ZWN1dGFibGVzIGZvciBhbGwgSW5saW5lQ2FsbEZyYW1lcywgbm90IGp1 c3QgdGhvc2Ugb24gdGhlIHN0YWNrIGF0IHRoZSB0aW1lIG9mIGV4aXQKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXRDb21waWxlckNvbW1vbi5j cHAJKHJldmlzaW9uIDE2OTk3MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NS RXhpdENvbXBpbGVyQ29tbW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjY0LDcgKzI2NCw3IEBA IHZvaWQgQXJndW1lbnRzUmVjb3ZlcnlHZW5lcmF0b3I6OmdlbmVyYXQKICAgICAgICAgICAgIGpp dC5zZXR1cEFyZ3VtZW50c0V4ZWNTdGF0ZSgpOwogICAgICAgICBqaXQubW92ZSgKICAgICAgICAg ICAgIEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbVB0cigKLSAgICAgICAgICAgICAgICBiaXR3 aXNlX2Nhc3Q8dm9pZCo+KG9wZXJhdGlvbkNyZWF0ZUFyZ3VtZW50cykpLAorICAgICAgICAgICAg ICAgIGJpdHdpc2VfY2FzdDx2b2lkKj4ob3BlcmF0aW9uQ3JlYXRlQXJndW1lbnRzRHVyaW5nT1NS RXhpdCkpLAogICAgICAgICAgICAgR1BSSW5mbzo6bm9uQXJnR1BSMCk7CiAgICAgICAgIGppdC5j YWxsKEdQUkluZm86Om5vbkFyZ0dQUjApOwogICAgICAgICBqaXQuc3RvcmU2NChHUFJJbmZvOjpy ZXR1cm5WYWx1ZUdQUiwgQXNzZW1ibHlIZWxwZXJzOjphZGRyZXNzRm9yKGFyZ3VtZW50c1JlZ2lz dGVyKSk7CkBAIC0yNzgsMTMgKzI3OCwxMyBAQCB2b2lkIEFyZ3VtZW50c1JlY292ZXJ5R2VuZXJh dG9yOjpnZW5lcmF0CiAgICAgICAgICAgICAgICAgQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1t UHRyKGlubGluZUNhbGxGcmFtZSkpOwogICAgICAgICAgICAgaml0Lm1vdmUoCiAgICAgICAgICAg ICAgICAgQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1tUHRyKAotICAgICAgICAgICAgICAgICAg ICBiaXR3aXNlX2Nhc3Q8dm9pZCo+KG9wZXJhdGlvbkNyZWF0ZUlubGluZWRBcmd1bWVudHMpKSwK KyAgICAgICAgICAgICAgICAgICAgYml0d2lzZV9jYXN0PHZvaWQqPihvcGVyYXRpb25DcmVhdGVJ bmxpbmVkQXJndW1lbnRzRHVyaW5nT1NSRXhpdCkpLAogICAgICAgICAgICAgICAgIEdQUkluZm86 Om5vbkFyZ0dQUjApOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgaml0LnNldHVwQXJn dW1lbnRzRXhlY1N0YXRlKCk7CiAgICAgICAgICAgICBqaXQubW92ZSgKICAgICAgICAgICAgICAg ICBBc3NlbWJseUhlbHBlcnM6OlRydXN0ZWRJbW1QdHIoCi0gICAgICAgICAgICAgICAgICAgIGJp dHdpc2VfY2FzdDx2b2lkKj4ob3BlcmF0aW9uQ3JlYXRlQXJndW1lbnRzKSksCisgICAgICAgICAg ICAgICAgICAgIGJpdHdpc2VfY2FzdDx2b2lkKj4ob3BlcmF0aW9uQ3JlYXRlQXJndW1lbnRzRHVy aW5nT1NSRXhpdCkpLAogICAgICAgICAgICAgICAgIEdQUkluZm86Om5vbkFyZ0dQUjApOwogICAg ICAgICB9CiAgICAgICAgIGppdC5jYWxsKEdQUkluZm86Om5vbkFyZ0dQUjApOwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCShyZXZpc2lvbiAxNjk5 NzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC03NjksNiArNzY5LDEyIEBAIEpTQ2VsbCogSklUX09QRVJBVElPTiBvcGVy YXRpb25DcmVhdGVJbmwKICAgICByZXR1cm4gcmVzdWx0OwogfQogCitKU0NlbGwqIEpJVF9PUEVS QVRJT04gb3BlcmF0aW9uQ3JlYXRlSW5saW5lZEFyZ3VtZW50c0R1cmluZ09TUkV4aXQoRXhlY1N0 YXRlKiBleGVjLCBJbmxpbmVDYWxsRnJhbWUqIGlubGluZUNhbGxGcmFtZSkKK3sKKyAgICBEZWZl ckdDRm9yQVdoaWxlKGV4ZWMtPnZtKCkuaGVhcCk7CisgICAgcmV0dXJuIG9wZXJhdGlvbkNyZWF0 ZUlubGluZWRBcmd1bWVudHMoZXhlYywgaW5saW5lQ2FsbEZyYW1lKTsKK30KKwogdm9pZCBKSVRf T1BFUkFUSU9OIG9wZXJhdGlvblRlYXJPZmZJbmxpbmVkQXJndW1lbnRzKAogICAgIEV4ZWNTdGF0 ZSogZXhlYywgSlNDZWxsKiBhcmd1bWVudHNDZWxsLCBKU0NlbGwqIGFjdGl2YXRpb25DZWxsLCBJ bmxpbmVDYWxsRnJhbWUqIGlubGluZUNhbGxGcmFtZSkKIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5oCShyZXZpc2lvbiAxNjk5NzApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtOTcs NiArOTcsNyBAQCBzaXplX3QgSklUX09QRVJBVElPTiBvcGVyYXRpb25SZWdFeHBUZXN0CiBzaXpl X3QgSklUX09QRVJBVElPTiBvcGVyYXRpb25Db21wYXJlU3RyaWN0RXFDZWxsKEV4ZWNTdGF0ZSos IEVuY29kZWRKU1ZhbHVlIGVuY29kZWRPcDEsIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRPcDIpIFdU Rl9JTlRFUk5BTDsKIHNpemVfdCBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkNvbXBhcmVTdHJpY3RF cShFeGVjU3RhdGUqLCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVkT3AxLCBFbmNvZGVkSlNWYWx1ZSBl bmNvZGVkT3AyKSBXVEZfSU5URVJOQUw7CiBKU0NlbGwqIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9u Q3JlYXRlSW5saW5lZEFyZ3VtZW50cyhFeGVjU3RhdGUqLCBJbmxpbmVDYWxsRnJhbWUqKSBXVEZf SU5URVJOQUw7CitKU0NlbGwqIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uQ3JlYXRlSW5saW5lZEFy Z3VtZW50c0R1cmluZ09TUkV4aXQoRXhlY1N0YXRlKiwgSW5saW5lQ2FsbEZyYW1lKikgV1RGX0lO VEVSTkFMOwogdm9pZCBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblRlYXJPZmZJbmxpbmVkQXJndW1l bnRzKEV4ZWNTdGF0ZSosIEpTQ2VsbCosIEpTQ2VsbCosIElubGluZUNhbGxGcmFtZSopIFdURl9J TlRFUk5BTDsKIEVuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uR2V0SW5saW5l ZEFyZ3VtZW50QnlWYWwoRXhlY1N0YXRlKiwgaW50MzJfdCwgSW5saW5lQ2FsbEZyYW1lKiwgaW50 MzJfdCkgV1RGX0lOVEVSTkFMOwogRW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRp b25HZXRBcmd1bWVudEJ5VmFsKEV4ZWNTdGF0ZSosIGludDMyX3QsIGludDMyX3QpIFdURl9JTlRF Uk5BTDsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNw cAkocmV2aXNpb24gMTY5OTcwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVy YXRpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM5MSw2ICsxMzkxLDEyIEBAIEpTQ2VsbCog SklUX09QRVJBVElPTiBvcGVyYXRpb25DcmVhdGVBcmcKICAgICByZXR1cm4gcmVzdWx0OwogfQog CitKU0NlbGwqIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uQ3JlYXRlQXJndW1lbnRzRHVyaW5nT1NS RXhpdChFeGVjU3RhdGUqIGV4ZWMpCit7CisgICAgRGVmZXJHQ0ZvckFXaGlsZShleGVjLT52bSgp LmhlYXApOworICAgIHJldHVybiBvcGVyYXRpb25DcmVhdGVBcmd1bWVudHMoZXhlYyk7Cit9CisK IEVuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uR2V0QXJndW1lbnRzTGVuZ3Ro KEV4ZWNTdGF0ZSogZXhlYywgaW50MzJfdCBhcmd1bWVudHNSZWdpc3RlcikKIHsKICAgICBWTSYg dm0gPSBleGVjLT52bSgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVy YXRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVy YXRpb25zLmgJKHJldmlzaW9uIDE2OTk3MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUT3BlcmF0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNjksNiArMjY5LDcgQEAgdm9pZCBK SVRfT1BFUkFUSU9OIG9wZXJhdGlvblByb2ZpbGVXaWxsQwogRW5jb2RlZEpTVmFsdWUgSklUX09Q RVJBVElPTiBvcGVyYXRpb25DaGVja0hhc0luc3RhbmNlKEV4ZWNTdGF0ZSosIEVuY29kZWRKU1Zh bHVlLCBFbmNvZGVkSlNWYWx1ZSBiYXNlVmFsKSBXVEZfSU5URVJOQUw7CiBKU0NlbGwqIEpJVF9P UEVSQVRJT04gb3BlcmF0aW9uQ3JlYXRlQWN0aXZhdGlvbihFeGVjU3RhdGUqLCBpbnQzMl90IG9m ZnNldCkgV1RGX0lOVEVSTkFMOwogSlNDZWxsKiBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkNyZWF0 ZUFyZ3VtZW50cyhFeGVjU3RhdGUqKSBXVEZfSU5URVJOQUw7CitKU0NlbGwqIEpJVF9PUEVSQVRJ T04gb3BlcmF0aW9uQ3JlYXRlQXJndW1lbnRzRHVyaW5nT1NSRXhpdChFeGVjU3RhdGUqKSBXVEZf SU5URVJOQUw7CiBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkdldEFyZ3Vt ZW50c0xlbmd0aChFeGVjU3RhdGUqLCBpbnQzMl90KSBXVEZfSU5URVJOQUw7CiBFbmNvZGVkSlNW YWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkdldEJ5VmFsRGVmYXVsdChFeGVjU3RhdGUqLCBF bmNvZGVkSlNWYWx1ZSBlbmNvZGVkQmFzZSwgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZFN1YnNjcmlw dCkgV1RGX0lOVEVSTkFMOwogRW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25H ZXRCeVZhbEdlbmVyaWMoRXhlY1N0YXRlKiwgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZEJhc2UsIEVu Y29kZWRKU1ZhbHVlIGVuY29kZWRTdWJzY3JpcHQpIFdURl9JTlRFUk5BTDsK