133904 2014-06-14 09:38:06 -0700 convertToUTF8String converts null string to empty string 2014-12-09 09:10:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 Hamish.K.Mackenzie webkit-unassigned berto cgarcia mrobinson zan oldest_to_newest 1015662 0 Hamish.K.Mackenzie 2014-06-14 09:38:06 -0700 This means it is not possible to use functions like webkit_dom_css_style_declaration_get_property_value to tell if a property has no value (or is just set to the empty string). I think it could be fixed with... gchar* convertToUTF8String(WTF::String const& s) { + if (!s) return 0; return g_strdup(s.utf8().data()); } 1028738 1 cgarcia 2014-08-12 23:48:48 -0700 I agree, and it's consistent with the rest of the API that uses NULL instead of "". My only concern is that it might break existing applications relying on DOM functions returning always valid pointers. We have just broken the API/ABI so maybe it's a good momento for a change like this one, though. 1053441 2 berto 2014-12-08 10:58:52 -0800 I guess if we really want to do this and it's not too late already, then it's now or never. 1053678 3 cgarcia 2014-12-09 00:12:28 -0800 I had forgotten this, we should have changed it before the 2.6 release, but people are still migrating, s we can probably change it now. 1053718 4 242899 berto 2014-12-09 02:24:45 -0800 Created attachment 242899 Patch 1053806 5 242928 berto 2014-12-09 09:02:54 -0800 Created attachment 242928 Patch I added a test 1053809 6 242928 cgarcia 2014-12-09 09:06:53 -0800 Comment on attachment 242928 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242928&action=review Thanks! > Source/WebCore/bindings/gobject/ConvertToUTF8String.cpp:33 > + return 0; nullptr > Source/WebCore/bindings/gobject/ConvertToUTF8String.cpp:35 > return g_strdup(s.utf8().data()); We could probably do something like return s.isNull() ? nullptr : g_strdup(s.utf8().data()); 1053810 7 cgarcia 2014-12-09 09:07:19 -0800 We should merge this in the stable branch too. 1053812 8 berto 2014-12-09 09:10:48 -0800 Committed r177019: <http://trac.webkit.org/changeset/177019> 242899 2014-12-09 02:24:45 -0800 2014-12-09 09:02:54 -0800 Patch 133904.diff text/plain 1293 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMDRiYzk4Li5lZTgwMTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTQtMTItMDkgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KIAorICAg ICAgICBjb252ZXJ0VG9VVEY4U3RyaW5nIGNvbnZlcnRzIG51bGwgc3RyaW5nIHRvIGVtcHR5IHN0 cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMz OTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0 dXJuIE5VTEwgaWYgdGhlIHN0cmluZyBpcyBOVUxMLgorCisgICAgICAgICogYmluZGluZ3MvZ29i amVjdC9Db252ZXJ0VG9VVEY4U3RyaW5nLmNwcDoKKyAgICAgICAgKGNvbnZlcnRUb1VURjhTdHJp bmcpOgorCisyMDE0LTEyLTA5ICBBbGJlcnRvIEdhcmNpYSAgPGJlcnRvQGlnYWxpYS5jb20+CisK ICAgICAgICAgW01lZGlhXVtHVEtdW0VGTF0gUmVkdWNlIHN0eWxlIHVwZGF0ZXMgKHBhaW50aW5n KSBpbiBjb250cm9scwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM3NzczCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmpl Y3QvQ29udmVydFRvVVRGOFN0cmluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2Jq ZWN0L0NvbnZlcnRUb1VURjhTdHJpbmcuY3BwCmluZGV4IDE0ZGYzYTYuLjdhNGYxMTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvQ29udmVydFRvVVRGOFN0cmlu Zy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9Db252ZXJ0VG9VVEY4 U3RyaW5nLmNwcApAQCAtMjksMTEgKzI5LDE0IEBACiAKIGdjaGFyKiBjb252ZXJ0VG9VVEY4U3Ry aW5nKFdURjo6U3RyaW5nIGNvbnN0JiBzKQogeworICAgIGlmIChzLmlzTnVsbCgpKQorICAgICAg ICByZXR1cm4gMDsKKwogICAgIHJldHVybiBnX3N0cmR1cChzLnV0ZjgoKS5kYXRhKCkpOwogfQog CiBnY2hhciogY29udmVydFRvVVRGOFN0cmluZyhXZWJDb3JlOjpVUkwgY29uc3QmIHMpCiB7Ci0g ICAgcmV0dXJuIGdfc3RyZHVwKHMuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CisgICAgcmV0dXJu IGNvbnZlcnRUb1VURjhTdHJpbmcocy5zdHJpbmcoKSk7CiB9CiAK 242928 2014-12-09 09:02:54 -0800 2014-12-09 09:06:53 -0800 Patch 133904.diff text/plain 2867 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMDRiYzk4Li5iODczMGFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTQtMTItMDkgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KIAorICAg ICAgICBjb252ZXJ0VG9VVEY4U3RyaW5nIGNvbnZlcnRzIG51bGwgc3RyaW5nIHRvIGVtcHR5IHN0 cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMz OTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVz dCBhZGRlZCB0byBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvRE9NTm9kZVRl c3QuY3BwCisKKyAgICAgICAgUmV0dXJuIDAgaWYgdGhlIHN0cmluZyBpcyBudWxsLgorCisgICAg ICAgICogYmluZGluZ3MvZ29iamVjdC9Db252ZXJ0VG9VVEY4U3RyaW5nLmNwcDoKKyAgICAgICAg KGNvbnZlcnRUb1VURjhTdHJpbmcpOgorCisyMDE0LTEyLTA5ICBBbGJlcnRvIEdhcmNpYSAgPGJl cnRvQGlnYWxpYS5jb20+CisKICAgICAgICAgW01lZGlhXVtHVEtdW0VGTF0gUmVkdWNlIHN0eWxl IHVwZGF0ZXMgKHBhaW50aW5nKSBpbiBjb250cm9scwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3NzczCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2dvYmplY3QvQ29udmVydFRvVVRGOFN0cmluZy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9nb2JqZWN0L0NvbnZlcnRUb1VURjhTdHJpbmcuY3BwCmluZGV4IDE0ZGYz YTYuLjdhNGYxMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3Qv Q29udmVydFRvVVRGOFN0cmluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i amVjdC9Db252ZXJ0VG9VVEY4U3RyaW5nLmNwcApAQCAtMjksMTEgKzI5LDE0IEBACiAKIGdjaGFy KiBjb252ZXJ0VG9VVEY4U3RyaW5nKFdURjo6U3RyaW5nIGNvbnN0JiBzKQogeworICAgIGlmIChz LmlzTnVsbCgpKQorICAgICAgICByZXR1cm4gMDsKKwogICAgIHJldHVybiBnX3N0cmR1cChzLnV0 ZjgoKS5kYXRhKCkpOwogfQogCiBnY2hhciogY29udmVydFRvVVRGOFN0cmluZyhXZWJDb3JlOjpV UkwgY29uc3QmIHMpCiB7Ci0gICAgcmV0dXJuIGdfc3RyZHVwKHMuc3RyaW5nKCkudXRmOCgpLmRh dGEoKSk7CisgICAgcmV0dXJuIGNvbnZlcnRUb1VURjhTdHJpbmcocy5zdHJpbmcoKSk7CiB9CiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3MmE1 NWNhLi42NjI4OWY3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMTItMDkgIEFsYmVydG8gR2FyY2lhICA8YmVy dG9AaWdhbGlhLmNvbT4KKworICAgICAgICBjb252ZXJ0VG9VVEY4U3RyaW5nIGNvbnZlcnRzIG51 bGwgc3RyaW5nIHRvIGVtcHR5IHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMzOTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGVzdCB0aGF0IHRyeWluZyB0byBnZXQgdGhlIHZhbHVlIG9mIGEg bm9uLWV4aXN0ZW50IGF0dHJpYnV0ZQorICAgICAgICByZXR1cm5zIDAgaW5zdGVhZCBvZiBhbiBl bXB0eSBzdHJpbmcuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsv RE9NTm9kZVRlc3QuY3BwOgorICAgICAgICAoV2ViS2l0RE9NTm9kZVRlc3Q6OnRlc3RJbnNlcnRp b24pOgorCiAyMDE0LTEyLTA5ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1RLXSBCdW1wIG1pbmltdW0gdmVyc2lvbiBvZiBBVEsgdXNlZCBieSBqaGJ1 aWxkIHRvIGF0IGxlYXN0IDIuMTUuMgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXQyR3RrL0RPTU5vZGVUZXN0LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0Mkd0ay9ET01Ob2RlVGVzdC5jcHAKaW5kZXggNWY2MmU1NC4uZGRlYTkyYyAxMDA2 NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL0RPTU5vZGVUZXN0 LmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvRE9NTm9kZVRl c3QuY3BwCkBAIC04OCw2ICs4OCw5IEBAIHByaXZhdGU6CiAgICAgICAgIC8vIEJvZHkgc2hvdWxk bid0IGhhdmUgYW55IGNoaWxkcmVuIGF0IHRoaXMgcG9pbnQuCiAgICAgICAgIGdfYXNzZXJ0KCF3 ZWJraXRfZG9tX25vZGVfaGFzX2NoaWxkX25vZGVzKFdFQktJVF9ET01fTk9ERShib2R5KSkpOwog CisgICAgICAgIC8vIFRoZSB2YWx1ZSBvZiBhIG5vbi1leGlzdGVudCBhdHRyaWJ1dGUgc2hvdWxk IGJlIG51bGwsIG5vdCBhbiBlbXB0eSBzdHJpbmcKKyAgICAgICAgZ19hc3NlcnQoIXdlYmtpdF9k b21faHRtbF9ib2R5X2VsZW1lbnRfZ2V0X2JhY2tncm91bmQoV0VCS0lUX0RPTV9IVE1MX0JPRFlf RUxFTUVOVChib2R5KSkpOworCiAgICAgICAgIC8vIEluc2VydCBvbmUgUCBlbGVtZW50LgogICAg ICAgICBXZWJLaXRET01FbGVtZW50KiBwID0gd2Via2l0X2RvbV9kb2N1bWVudF9jcmVhdGVfZWxl bWVudChkb2N1bWVudCwgIlAiLCAwKTsKICAgICAgICAgZ19hc3NlcnQoV0VCS0lUX0RPTV9JU19I VE1MX0VMRU1FTlQocCkpOwo=