133891 2014-06-13 17:24:49 -0700 [iOS][wk2] Swipe snapshots are removed too quickly if there is no saved render tree size 2014-06-23 03:01:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca benjamin simon.fraser webkit-bug-importer oldest_to_newest 1015589 0 thorton 2014-06-13 17:24:49 -0700 If we don't have a render tree size (because the UI process has restarted), we should keep the blank white snapshot view up until either the first layer tree commit from the Web process or the watchdog fires. We should *not* remove the snapshot immediately upon ending the gesture, because that will instantly reveal the previous page's tiles. 1015590 1 233096 thorton 2014-06-13 17:25:28 -0700 Created attachment 233096 patch 1015591 2 thorton 2014-06-13 17:33:27 -0700 This is built on top of https://bugs.webkit.org/show_bug.cgi?id=133885 1016016 3 thorton 2014-06-16 16:48:57 -0700 http://trac.webkit.org/changeset/170036 1017514 4 webkit-bug-importer 2014-06-23 03:01:29 -0700 <rdar://problem/17416500> 233096 2014-06-13 17:25:28 -0700 2014-06-16 14:32:07 -0700 patch swipe2.diff text/plain 2244 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ODBkYzZlLi44YjhhZDE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTQtMDYtMTMgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCisgICAgICAgIFtpT1NdW3drMl0gU3dpcGUgc25hcHNob3RzIGFyZSByZW1vdmVkIHRvbyBx dWlja2x5IGlmIHRoZXJlIGlzIG5vIHNhdmVkIHJlbmRlciB0cmVlIHNpemUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzg5MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9WaWV3 R2VzdHVyZUNvbnRyb2xsZXJJT1MubW06CisgICAgICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29u dHJvbGxlcjo6ZW5kU3dpcGVHZXN0dXJlKToKKyAgICAgICAgKFdlYktpdDo6Vmlld0dlc3R1cmVD b250cm9sbGVyOjpzZXRSZW5kZXJUcmVlU2l6ZSk6CisgICAgICAgIElmIHdlIGRvbid0IGtub3cg dGhlIHRhcmdldCByZW5kZXIgdHJlZSBzaXplLCB3YWl0IHVudGlsIHRoZSBmaXJzdCBsYXllciB0 cmVlIGNvbW1pdAorICAgICAgICB0aGF0IGNvbWVzIGluLCBpbnN0ZWFkIG9mIHJlbW92aW5nIHRo ZSBzbmFwc2hvdCB3aGVuIHRoZSBnZXN0dXJlIGVuZHMuCisKKzIwMTQtMDYtMTMgIFRpbW90aHkg SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCiAgICAgICAgIFtpT1NdW3drMl0g U3dpcGluZyBiYWNrIGJyaWVmbHkgc2hvd3MgdGhlIHByZXZpb3VzIHBhZ2UgYmVmb3JlIGxvYWRp bmcgdGhlIG5ldyBvbmUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzMzg4NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9z L1ZpZXdHZXN0dXJlQ29udHJvbGxlcklPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9p b3MvVmlld0dlc3R1cmVDb250cm9sbGVySU9TLm1tCmluZGV4IDY0MzdlMDUuLjIyZjYyNmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvVmlld0dlc3R1cmVDb250cm9s bGVySU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvVmlld0dlc3R1cmVD b250cm9sbGVySU9TLm1tCkBAIC0yMzYsMTEgKzIzNiw2IEBAIHZvaWQgVmlld0dlc3R1cmVDb250 cm9sbGVyOjplbmRTd2lwZUdlc3R1cmUoV2ViQmFja0ZvcndhcmRMaXN0SXRlbSogdGFyZ2V0SXRl bSwKICAgICBWaWV3U25hcHNob3RTdG9yZTo6c2hhcmVkKCkuZGlzYWJsZVNuYXBzaG90dGluZygp OwogICAgIG1fd2ViUGFnZVByb3h5LmdvVG9CYWNrRm9yd2FyZEl0ZW0odGFyZ2V0SXRlbSk7CiAg ICAgVmlld1NuYXBzaG90U3RvcmU6OnNoYXJlZCgpLmVuYWJsZVNuYXBzaG90dGluZygpOwotICAg IAotICAgIGlmICghbV90YXJnZXRSZW5kZXJUcmVlU2l6ZSkgewotICAgICAgICByZW1vdmVTd2lw ZVNuYXBzaG90KCk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9CiAKICAgICBtX3N3aXBlV2F0Y2hk b2dUaW1lci5zdGFydE9uZVNob3Qoc3dpcGVTbmFwc2hvdFJlbW92YWxXYXRjaGRvZ0R1cmF0aW9u LmNvdW50KCkpOwogfQpAQCAtMjUwLDcgKzI0NSw3IEBAIHZvaWQgVmlld0dlc3R1cmVDb250cm9s bGVyOjpzZXRSZW5kZXJUcmVlU2l6ZSh1aW50NjRfdCByZW5kZXJUcmVlU2l6ZSkKICAgICBpZiAo bV9hY3RpdmVHZXN0dXJlVHlwZSAhPSBWaWV3R2VzdHVyZVR5cGU6OlN3aXBlKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBpZiAobV90YXJnZXRSZW5kZXJUcmVlU2l6ZSAmJiByZW5kZXJUcmVlU2l6 ZSA+IG1fdGFyZ2V0UmVuZGVyVHJlZVNpemUgJiYgbV93ZWJQYWdlUHJveHkuZHJhd2luZ0FyZWEo KS0+Y3VycmVudFRyYW5zYWN0aW9uSUQoKSA+PSBtX3RhcmdldFRyYW5zYWN0aW9uSUQpCisgICAg aWYgKCghbV90YXJnZXRSZW5kZXJUcmVlU2l6ZSB8fCByZW5kZXJUcmVlU2l6ZSA+IG1fdGFyZ2V0 UmVuZGVyVHJlZVNpemUpICYmIG1fd2ViUGFnZVByb3h5LmRyYXdpbmdBcmVhKCktPmN1cnJlbnRU cmFuc2FjdGlvbklEKCkgPj0gbV90YXJnZXRUcmFuc2FjdGlvbklEKQogICAgICAgICByZW1vdmVT d2lwZVNuYXBzaG90KCk7CiB9CiAK