133889 2014-06-13 16:25:25 -0700 implement modulo for non-armv7s arm_thumb 2014-06-13 16:38:11 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Enhancement --- 1 achristensen achristensen benjamin oldest_to_newest 1015571 0 achristensen 2014-06-13 16:25:25 -0700 The current implementation of modulo for armv7 requires the sdiv operation, which is only available on armv7s. For non-armv7s cpus, lets just do a function call for now to get it enabled. 1015574 1 233090 achristensen 2014-06-13 16:31:16 -0700 Created attachment 233090 Patch 1015575 2 achristensen 2014-06-13 16:38:11 -0700 http://trac.webkit.org/changeset/169956 233090 2014-06-13 16:31:16 -0700 2014-06-13 16:35:31 -0700 Patch bug-133889-20140613163059.patch text/plain 2540 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTk1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA2LTEzICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFrZSBjc3Mg aml0IGNvbXBpbGUgb24gYXJtdjcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzM4ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGNzc2ppdC9TZWxlY3RvckNvbXBpbGVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNlbGVjdG9yQ29tcGlsZXI6Om1vZHVsb0hlbHBlcik6CisgICAgICAgIChXZWJDb3Jl OjpTZWxlY3RvckNvbXBpbGVyOjpTZWxlY3RvckNvZGVHZW5lcmF0b3I6Om1vZHVsbyk6CisgICAg ICAgIEltcGxlbWVudCBtb2R1bG8gdXNpbmcgYSBmdW5jdGlvbiBjYWxsIGZvciBub3cuCisKIDIw MTQtMDYtMTMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAg ICBVc2UgdGhlIGNhbGxPbk1haW5UaHJlYWQgdmVyc2lvbiB0aGF0IHRha2VzIGFuIHN0ZDo6ZnVu Y3Rpb24gaW4gQmxvYlJlc291cmNlSGFuZGxlOjpzdGFydCgpCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9jc3NqaXQvU2VsZWN0b3JDb21waWxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvY3Nzaml0L1NlbGVjdG9yQ29tcGlsZXIuY3BwCShyZXZpc2lvbiAxNjk5NTUpCisrKyBTb3Vy Y2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21waWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE0NTcsNiArMTQ1NywxNCBAQCB2b2lkIFNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2VuZXJhdGVT cGVjCiAgICAgfQogfQogCisjaWYgQ1BVKEFSTV9USFVNQjIpICYmICFDUFUoQVBQTEVfQVJNVjdT KQorLy8gRklYTUU6IFRoaXMgY291bGQgYmUgaW1wbGVtZW50ZWQgaW4gYXNzZW1ibHkgdG8gYXZv aWQgYSBmdW5jdGlvbiBjYWxsLCBhbmQgd2Uga25vdyB0aGUgZGl2aXNvciBhdCBqaXQtY29tcGls ZSB0aW1lLgorc3RhdGljIGludCBtb2R1bG9IZWxwZXIoaW50IGRpdmlkZW5kLCBpbnQgZGl2aXNv cikKK3sKKyAgICByZXR1cm4gZGl2aWRlbmQgJSBkaXZpc29yOworfQorI2VuZGlmCisKIC8vIFRo ZSB2YWx1ZSBpbiBpbnB1dERpdmlkZW5kIGlzIGRlc3Ryb3llZCBieSB0aGUgbW9kdWxvIG9wZXJh dGlvbi4KIEFzc2VtYmxlcjo6SnVtcCBTZWxlY3RvckNvZGVHZW5lcmF0b3I6Om1vZHVsbyhBc3Nl bWJsZXI6OlJlc3VsdENvbmRpdGlvbiBjb25kaXRpb24sIEFzc2VtYmxlcjo6UmVnaXN0ZXJJRCBp bnB1dERpdmlkZW5kLCBpbnQgZGl2aXNvcikKIHsKQEAgLTE0NzMsNiArMTQ4MSwxMyBAQCBBc3Nl bWJsZXI6Okp1bXAgU2VsZWN0b3JDb2RlR2VuZXJhdG9yOjptCiAjZW5kaWYKICAgICBtX2Fzc2Vt Ymxlci5tdWwzMihkaXZpc29yUmVnaXN0ZXIsIHJlc3VsdFJlZ2lzdGVyKTsKICAgICByZXR1cm4g bV9hc3NlbWJsZXIuYnJhbmNoU3ViMzIoY29uZGl0aW9uLCBpbnB1dERpdmlkZW5kLCByZXN1bHRS ZWdpc3RlciwgcmVzdWx0UmVnaXN0ZXIpOworI2VsaWYgQ1BVKEFSTV9USFVNQjIpICYmICFDUFUo QVBQTEVfQVJNVjdTKQorICAgIExvY2FsUmVnaXN0ZXJXaXRoUHJlZmVyZW5jZSBkaXZpc29yUmVn aXN0ZXIobV9yZWdpc3RlckFsbG9jYXRvciwgLCBKU0M6OkdQUkluZm86OmFyZ3VtZW50R1BSMSk7 CisgICAgbV9hc3NlbWJsZXIubW92ZShBc3NlbWJsZXI6OlRydXN0ZWRJbW0zMihkaXZpc29yKSwg ZGl2aXNvclJlZ2lzdGVyKTsKKyAgICBGdW5jdGlvbkNhbGwgZnVuY3Rpb25DYWxsKG1fYXNzZW1i bGVyLCBtX3JlZ2lzdGVyQWxsb2NhdG9yLCBtX3N0YWNrQWxsb2NhdG9yLCBtX2Z1bmN0aW9uQ2Fs bHMpOworICAgIGZ1bmN0aW9uQ2FsbC5zZXRGdW5jdGlvbkFkZHJlc3MobW9kdWxvSGVscGVyKTsK KyAgICBmdW5jdGlvbkNhbGwuc2V0VHdvQXJndW1lbnRzKGlucHV0RGl2aWRlbmQsIGRpdmlzb3JS ZWdpc3Rlcik7CisgICAgcmV0dXJuIGZ1bmN0aW9uQ2FsbC5jYWxsQW5kQnJhbmNoT25Cb29sZWFu UmV0dXJuVmFsdWUoY29uZGl0aW9uKTsKICNlbGlmIENQVShYODZfNjQpCiAgICAgLy8gaWRpdiB0 YWtlcyBSQVggKyBhbiBhcmJpdHJhcnkgcmVnaXN0ZXIsIGFuZCByZXR1cm4gUkFYICsgUkRYLiBN b3N0IG9mIHRoaXMgY29kZSBpcyBhYm91dCBkb2luZwogICAgIC8vIGFuIGVmZmljaWVudCBhbGxv Y2F0aW9uIG9mIHRob3NlIHJlZ2lzdGVycy4gSWYgYSByZWdpc3RlciBpcyBhbHJlYWR5IGluIHVz ZSBhbmQgaXMgbm90IHRoZSBpbnB1dERpdmlkZW5kLAo=