133880 2014-06-13 13:57:47 -0700 OSR exit should barrier the Executables for all InlineCallFrames, not just those on the stack at the time of exit 2014-06-16 15:44:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg benjamin cmarcelo commit-queue ggaren oldest_to_newest 1015521 0 mhahnenberg 2014-06-13 13:57:47 -0700 We could have exited due to a value received from an inlined block that's no longer on the stack, so we should just barrier all InlineCallFrames. 1015523 1 233073 mhahnenberg 2014-06-13 13:59:39 -0700 Created attachment 233073 Patch 1015548 2 233073 commit-queue 2014-06-13 15:19:22 -0700 Comment on attachment 233073 Patch Clearing flags on attachment: 233073 Committed r169951: <http://trac.webkit.org/changeset/169951> 1015549 3 commit-queue 2014-06-13 15:19:24 -0700 All reviewed patches have been landed. Closing bug. 1015994 4 ggaren 2014-06-16 15:44:21 -0700 <rdar://problem/17276579> 233073 2014-06-13 13:59:39 -0700 2014-06-13 15:19:21 -0700 Patch bug-133880-20140613135915.patch text/plain 3775 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY5OTQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTA2LTEzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgT1NSIGV4aXQgc2hvdWxkIGJhcnJpZXIgdGhlIEV4ZWN1dGFibGVzIGZvciBhbGwg SW5saW5lQ2FsbEZyYW1lcywgbm90IGp1c3QgdGhvc2Ugb24gdGhlIHN0YWNrIGF0IHRoZSB0aW1l IG9mIGV4aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzMzg4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlIGNvdWxkIGhhdmUgZXhpdGVkIGR1ZSB0byBhIHZhbHVlIHJlY2VpdmVkIGZyb20gYW4gaW5s aW5lZCBibG9jayB0aGF0J3Mgbm8gbG9uZ2VyIG9uIAorICAgICAgICB0aGUgc3RhY2ssIHNvIHdl IHNob3VsZCBqdXN0IGJhcnJpZXIgYWxsIElubGluZUNhbGxGcmFtZXMuCisKKyAgICAgICAgKiBk ZmcvREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjphZGp1 c3RBbmRKdW1wVG9UYXJnZXQpOgorCiAyMDE0LTA2LTEzICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFrZSBjc3Mgaml0IGNvbXBpbGUgZm9y IGFybXY3LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0Q29tcGls ZXJDb21tb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH T1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcAkocmV2aXNpb24gMTY5OTQ0KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0Q29tcGlsZXJDb21tb24uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xOTksMTMgKzE5OSwxNiBAQCBzdGF0aWMgdm9pZCBvc3JXcml0ZUJhcnJpZXIoQ0Nh bGxIZWxwZXJzCiB2b2lkIGFkanVzdEFuZEp1bXBUb1RhcmdldChDQ2FsbEhlbHBlcnMmIGppdCwg Y29uc3QgT1NSRXhpdEJhc2UmIGV4aXQpCiB7CiAjaWYgRU5BQkxFKEdHQykgCi0gICAgLy8gMTEp IFdyaXRlIGJhcnJpZXIgdGhlIG93bmVyIGV4ZWN1dGFibGUgYmVjYXVzZSB3ZSdyZSBqdW1waW5n IGludG8gYSBkaWZmZXJlbnQgYmxvY2suCi0gICAgZm9yIChDb2RlT3JpZ2luIGNvZGVPcmlnaW4g PSBleGl0Lm1fY29kZU9yaWdpbjsgOyBjb2RlT3JpZ2luID0gY29kZU9yaWdpbi5pbmxpbmVDYWxs RnJhbWUtPmNhbGxlcikgewotICAgICAgICBDb2RlQmxvY2sqIGJhc2VsaW5lQ29kZUJsb2NrID0g aml0LmJhc2VsaW5lQ29kZUJsb2NrRm9yKGNvZGVPcmlnaW4pOwotICAgICAgICBqaXQubW92ZShB c3NlbWJseUhlbHBlcnM6OlRydXN0ZWRJbW1QdHIoYmFzZWxpbmVDb2RlQmxvY2stPm93bmVyRXhl Y3V0YWJsZSgpKSwgR1BSSW5mbzo6bm9uQXJnR1BSMCk7IAotICAgICAgICBvc3JXcml0ZUJhcnJp ZXIoaml0LCBHUFJJbmZvOjpub25BcmdHUFIwLCBHUFJJbmZvOjpub25BcmdHUFIxKTsKLSAgICAg ICAgaWYgKCFjb2RlT3JpZ2luLmlubGluZUNhbGxGcmFtZSkKLSAgICAgICAgICAgIGJyZWFrOwor ICAgIC8vIDExKSBXcml0ZSBiYXJyaWVyIHRoZSBvd25lciBleGVjdXRhYmxlcyBiZWNhdXNlIHdl J3JlIGp1bXBpbmcgaW50byBhIGRpZmZlcmVudCBibG9jay4KKyAgICBqaXQubW92ZShBc3NlbWJs eUhlbHBlcnM6OlRydXN0ZWRJbW1QdHIoaml0LmNvZGVCbG9jaygpLT5vd25lckV4ZWN1dGFibGUo KSksIEdQUkluZm86Om5vbkFyZ0dQUjApOworICAgIG9zcldyaXRlQmFycmllcihqaXQsIEdQUklu Zm86Om5vbkFyZ0dQUjAsIEdQUkluZm86Om5vbkFyZ0dQUjEpOworICAgIElubGluZUNhbGxGcmFt ZVNldCogaW5saW5lQ2FsbEZyYW1lcyA9IGppdC5jb2RlQmxvY2soKS0+aml0Q29kZSgpLT5kZmdD b21tb24oKS0+aW5saW5lQ2FsbEZyYW1lcy5nZXQoKTsKKyAgICBpZiAoaW5saW5lQ2FsbEZyYW1l cykgeworICAgICAgICBmb3IgKElubGluZUNhbGxGcmFtZSogaW5saW5lQ2FsbEZyYW1lIDogKmlu bGluZUNhbGxGcmFtZXMpIHsKKyAgICAgICAgICAgIFNjcmlwdEV4ZWN1dGFibGUqIG93bmVyRXhl Y3V0YWJsZSA9IGlubGluZUNhbGxGcmFtZS0+ZXhlY3V0YWJsZS5nZXQoKTsKKyAgICAgICAgICAg IGppdC5tb3ZlKEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbVB0cihvd25lckV4ZWN1dGFibGUp LCBHUFJJbmZvOjpub25BcmdHUFIwKTsgCisgICAgICAgICAgICBvc3JXcml0ZUJhcnJpZXIoaml0 LCBHUFJJbmZvOjpub25BcmdHUFIwLCBHUFJJbmZvOjpub25BcmdHUFIxKTsKKyAgICAgICAgfQog ICAgIH0KICNlbmRpZgogCkluZGV4OiBTb3VyY2UvV1RGL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNpb24gMTY5OTQ3KQorKysgU291cmNlL1dURi9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wNi0xMyAgTWFy ayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgorCisgICAgICAgIE9TUiBleGl0 IHNob3VsZCBiYXJyaWVyIHRoZSBFeGVjdXRhYmxlcyBmb3IgYWxsIElubGluZUNhbGxGcmFtZXMs IG5vdCBqdXN0IHRob3NlIG9uIHRoZSBzdGFjayBhdCB0aGUgdGltZSBvZiBleGl0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM4ODAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9CYWcuaDoKKyAg ICAgICAgKFdURjo6QmFnOjppdGVyYXRvcjo6b3BlcmF0b3IhPSk6IEFkZCAhPSB0byB0aGUgQmFn IGl0ZXJhdG9yIHNvIHdlIGNhbiB1c2UgaXQgaW4gcmFuZ2UtYmFzZWQgaXRlcmF0aW9uLgorCiAy MDE0LTA2LTEyICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGQgc3VwcG9ydCBmb3IgdGhyZWFkL1dvcmtRdWV1ZSBRb1MKSW5kZXg6IFNvdXJj ZS9XVEYvd3RmL0JhZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0JhZy5oCShyZXZp c2lvbiAxNjk5NDQpCisrKyBTb3VyY2UvV1RGL3d0Zi9CYWcuaAkod29ya2luZyBjb3B5KQpAQCAt ODMsNiArODMsMTIgQEAgcHVibGljOgogICAgICAgICB7CiAgICAgICAgICAgICByZXR1cm4gbV9u b2RlID09IG90aGVyLm1fbm9kZTsKICAgICAgICAgfQorCisgICAgICAgIGJvb2wgb3BlcmF0b3Ih PShjb25zdCBpdGVyYXRvciYgb3RoZXIpIGNvbnN0CisgICAgICAgIHsKKyAgICAgICAgICAgIHJl dHVybiAhKCp0aGlzID09IG90aGVyKTsKKyAgICAgICAgfQorCiAgICAgcHJpdmF0ZToKICAgICAg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gZnJpZW5kIGNsYXNzIFdURjo6QmFnOwogICAgICAgICBO b2RlKiBtX25vZGU7Cg==