133874 2014-06-13 12:16:04 -0700 Add a HTTPHeaderMap::set overload that takes a HTTPHeaderName 2014-06-14 02:08:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca ossy oldest_to_newest 1015494 0 andersca 2014-06-13 12:16:04 -0700 Add a HTTPHeaderMap::set overload that takes a HTTPHeaderName 1015495 1 233067 andersca 2014-06-13 12:17:02 -0700 Created attachment 233067 Patch 1015496 2 andersca 2014-06-13 12:35:34 -0700 Committed r169943: <http://trac.webkit.org/changeset/169943> 1015541 3 ossy 2014-06-13 15:01:52 -0700 (In reply to comment #2) > Committed r169943: <http://trac.webkit.org/changeset/169943> It broke the EFL and GTK build. :( 1015638 4 ossy 2014-06-14 02:07:02 -0700 Buildfix landed in https://trac.webkit.org/changeset/169966 . Otherwise breaking the build and then going home wasn't a fairplay game ... 1015640 5 233067 ossy 2014-06-14 02:08:40 -0700 Comment on attachment 233067 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233067&action=review > Source/WebCore/platform/network/HTTPHeaderMap.h:74 > + template<size_t length> void add(const char (&)[length], const String&) = delete; I think it was an accidental change, because it is the only one implementaion of add, and the bug title is about only chaning set. So I removed this deletion in the buildfix. 233067 2014-06-13 12:17:02 -0700 2014-06-14 02:08:40 -0700 Patch bug-133874-20140613121638.patch text/plain 6684 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5OTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIyOGM4NmZiMjlmZjVl OWZkYjU1NjBlODAzMDc0Mzc3YjgwNzhmOS4uYmFjZWYzYzg1NGE4MmI1ZDMxMTYxNDU1OTBjNzQw MWJkYTM3MDM1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTA2LTEzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIGEgSFRUUEhl YWRlck1hcDo6c2V0IG92ZXJsb2FkIHRoYXQgdGFrZXMgYSBIVFRQSGVhZGVyTmFtZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzODc0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL0hUVFBIZWFkZXJNYXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRUUEhlYWRlck1hcDo6 c2V0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVxdWVzdENGTmV0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdDo6ZG9VcGRhdGVQbGF0Zm9ybUhUVFBCb2R5KToK KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlcXVlc3RNYWMubW06Cisg ICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OmRvVXBkYXRlUGxhdGZvcm1IVFRQQm9k eSk6CisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlhNTEh0dHBSZXF1ZXN0OjpzZW5kKToKKworMjAxNC0wNi0xMyAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCBhIEhUVFBIZWFkZXJNYXA6OmZpbmQg b3ZlcmxvYWQgdGhhdCB0YWtlcyBhIEhUVFBIZWFkZXJOYW1lCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM4NzIKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTWFwLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck1hcC5jcHAKaW5kZXggMjUyNDY3YzVkNmU3 NThjOTAxZjA4MzlkZjE4OGMyOWQ1MjM4MWYwYi4uZmQxNWMzM2JlNjM4MzA5OWMwNzk2ZDU0NmZm NmJjN2U5OTdkMTljNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9IVFRQSGVhZGVyTWFwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L0hUVFBIZWFkZXJNYXAuY3BwCkBAIC05OSw2ICs5OSwxMSBAQCBzdHJ1Y3QgQ2FzZUZvbGRpbmdD U3RyaW5nVHJhbnNsYXRvciB7CiAgICAgfQogfTsKIAordm9pZCBIVFRQSGVhZGVyTWFwOjpzZXQo SFRUUEhlYWRlck5hbWUgbmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSkKK3sKKyAgICBtX2hlYWRl cnMuc2V0KGh0dHBIZWFkZXJOYW1lU3RyaW5nKG5hbWUpLnRvU3RyaW5nV2l0aG91dENvcHlpbmco KSwgdmFsdWUpOworfQorCiBib29sIEhUVFBIZWFkZXJNYXA6OmNvbnRhaW5zKEhUVFBIZWFkZXJO YW1lIG5hbWUpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1faGVhZGVycy5jb250YWlucyhodHRwSGVh ZGVyTmFtZVN0cmluZyhuYW1lKS50b1N0cmluZ1dpdGhvdXRDb3B5aW5nKCkpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQSGVhZGVyTWFwLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuaAppbmRleCBjMzBmNTk0 NTZiZDhmZjM3NWQ4ZDE4OTY1YjI5ZjNmOTJhNjU4OWVkLi45NjY2ODJlMzY0YTc3Mjc4ZDdkOTdj NDViNzljN2Q2NzBiMDZiMDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL0hUVFBIZWFkZXJNYXAuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL0hUVFBIZWFkZXJNYXAuaApAQCAtNjMsMTIgKzYzLDE1IEBAIHB1YmxpYzoKICAgICB2b2lk IHNldChjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmFsdWUpOwogICAg IHZvaWQgYWRkKGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSk7 CiAKKyAgICB2b2lkIHNldChIVFRQSGVhZGVyTmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSk7CiAg ICAgYm9vbCBjb250YWlucyhIVFRQSGVhZGVyTmFtZSkgY29uc3Q7CiAgICAgU3RyaW5nIGdldChj b25zdCBjaGFyKikgY29uc3Q7CiAgICAgY29uc3RfaXRlcmF0b3IgZmluZChIVFRQSGVhZGVyTmFt ZSkgY29uc3Q7CiAgICAgYm9vbCByZW1vdmUoSFRUUEhlYWRlck5hbWUpOwogCiAgICAgLy8gSW5z dGVhZCBvZiBwYXNzaW5nIGEgc3RyaW5nIGxpdGVyYWwgdG8gYW55IG9mIHRoZXNlIGZ1bmN0aW9u cywganVzdCB1c2UgYSBIVFRQSGVhZGVyTmFtZSBpbnN0ZWFkLgorICAgIHRlbXBsYXRlPHNpemVf dCBsZW5ndGg+IHZvaWQgc2V0KGNvbnN0IGNoYXIgKCYpW2xlbmd0aF0sIGNvbnN0IFN0cmluZyYp ID0gZGVsZXRlOworICAgIHRlbXBsYXRlPHNpemVfdCBsZW5ndGg+IHZvaWQgYWRkKGNvbnN0IGNo YXIgKCYpW2xlbmd0aF0sIGNvbnN0IFN0cmluZyYpID0gZGVsZXRlOwogICAgIHRlbXBsYXRlPHNp emVfdCBsZW5ndGg+IGJvb2wgY29udGFpbnMoY29uc3QgY2hhciAoJilbbGVuZ3RoXSkgPSBkZWxl dGU7CiAgICAgdGVtcGxhdGU8c2l6ZV90IGxlbmd0aD4gY29uc3RfaXRlcmF0b3IgZmluZChjb25z dCBjaGFyKCYpW2xlbmd0aF0pID0gZGVsZXRlOwogICAgIHRlbXBsYXRlPHNpemVfdCBsZW5ndGg+ IGJvb2wgcmVtb3ZlKGNvbnN0IGNoYXIgKCYpW2xlbmd0aF0pID0gZGVsZXRlOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZVJlcXVlc3RDRk5l dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVxdWVz dENGTmV0LmNwcAppbmRleCAxZjdiNGMyZWE3NDdmNjJiY2E5NzhiOWNmN2YwZmYxOGNiZTAwZjU2 Li4zYjE4NzdjYjAyNmExMWY1NGIxOWIxZDM4NjE4Njc3NTQyOTMzMzA4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVxdWVzdENGTmV0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVxdWVz dENGTmV0LmNwcApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1 ZGUgIlJlc291cmNlUmVxdWVzdENGTmV0LmgiCiAKKyNpbmNsdWRlICJIVFRQSGVhZGVyTmFtZXMu aCIKICNpbmNsdWRlICJSZXNvdXJjZVJlcXVlc3QuaCIKICNpbmNsdWRlIDx3dGYvUGFzc093blB0 ci5oPgogCkBAIC0yMTksMTIgKzIyMCwxMSBAQCB2b2lkIFJlc291cmNlUmVxdWVzdDo6ZG9VcGRh dGVQbGF0Zm9ybUhUVFBCb2R5KCkKIAogICAgIGlmIChSZXRhaW5QdHI8Q0ZSZWFkU3RyZWFtUmVm PiBib2R5U3RyZWFtID0gYWRvcHRDRihDRlVSTFJlcXVlc3RDb3B5SFRUUFJlcXVlc3RCb2R5U3Ry ZWFtKGNmUmVxdWVzdCkpKSB7CiAgICAgICAgIC8vIEZvciBzdHJlYW1zLCBwcm92aWRlIGEgQ29u dGVudC1MZW5ndGggdG8gYXZvaWQgdXNpbmcgY2h1bmtlZCBlbmNvZGluZywgYW5kIHRvIGdldCBh Y2N1cmF0ZSB0b3RhbCBsZW5ndGggaW4gY2FsbGJhY2tzLgotICAgICAgICBSZXRhaW5QdHI8Q0ZT dHJpbmdSZWY+IGxlbmd0aFN0cmluZyA9IGFkb3B0Q0Yoc3RhdGljX2Nhc3Q8Q0ZTdHJpbmdSZWY+ KENGUmVhZFN0cmVhbUNvcHlQcm9wZXJ0eShib2R5U3RyZWFtLmdldCgpLCBmb3JtRGF0YVN0cmVh bUxlbmd0aFByb3BlcnR5TmFtZSgpKSkpOwotICAgICAgICBpZiAobGVuZ3RoU3RyaW5nKSB7Cisg ICAgICAgIGlmIChSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGxlbmd0aFN0cmluZyA9IGFkb3B0Q0Yo c3RhdGljX2Nhc3Q8Q0ZTdHJpbmdSZWY+KENGUmVhZFN0cmVhbUNvcHlQcm9wZXJ0eShib2R5U3Ry ZWFtLmdldCgpLCBmb3JtRGF0YVN0cmVhbUxlbmd0aFByb3BlcnR5TmFtZSgpKSkpKSB7CiAgICAg ICAgICAgICBDRlVSTFJlcXVlc3RTZXRIVFRQSGVhZGVyRmllbGRWYWx1ZShjZlJlcXVlc3QsIENG U1RSKCJDb250ZW50LUxlbmd0aCIpLCBsZW5ndGhTdHJpbmcuZ2V0KCkpOwogICAgICAgICAgICAg Ly8gU2luY2UgcmVzb3VyY2UgcmVxdWVzdCBpcyBhbHJlYWR5IG1hcmtlZCB1cGRhdGVkLCB3ZSBu ZWVkIHRvIGtlZXAgaXQgdXAgdG8gZGF0ZSB0b28uCiAgICAgICAgICAgICBBU1NFUlQobV9yZXNv dXJjZVJlcXVlc3RVcGRhdGVkKTsKLSAgICAgICAgICAgIG1faHR0cEhlYWRlckZpZWxkcy5zZXQo IkNvbnRlbnQtTGVuZ3RoIiwgbGVuZ3RoU3RyaW5nLmdldCgpKTsKKyAgICAgICAgICAgIG1faHR0 cEhlYWRlckZpZWxkcy5zZXQoSFRUUEhlYWRlck5hbWU6OkNvbnRlbnRMZW5ndGgsIGxlbmd0aFN0 cmluZy5nZXQoKSk7CiAgICAgICAgIH0KICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVxdWVzdE1hYy5tbSBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVxdWVzdE1hYy5tbQppbmRleCAw NzlhOGYxMmFkNDE2NzU5ZDdlYThjNDY0YWRmY2I3YmNmMTY4Mzk3Li4yOTE0ZjcyYTJlN2U5ZWI0 ZDU2Zjc5OWE5YzUyYTQ1NTI4ODU4YTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlcXVlc3RNYWMubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VSZXF1ZXN0TWFjLm1tCkBAIC0yNyw2ICsy Nyw3IEBACiAjaW1wb3J0ICJSZXNvdXJjZVJlcXVlc3QuaCIKIAogI2ltcG9ydCAiRm9ybURhdGFT dHJlYW1NYWMuaCIKKyNpbXBvcnQgIkhUVFBIZWFkZXJOYW1lcy5oIgogI2ltcG9ydCAiUmVzb3Vy Y2VSZXF1ZXN0Q0ZOZXQuaCIKICNpbXBvcnQgIlJ1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oIgog I2ltcG9ydCAiV2ViQ29yZVN5c3RlbUludGVyZmFjZS5oIgpAQCAtMjM1LDcgKzIzNiw3IEBAIHZv aWQgUmVzb3VyY2VSZXF1ZXN0Ojpkb1VwZGF0ZVBsYXRmb3JtSFRUUEJvZHkoKQogICAgICAgICAg ICAgW25zUmVxdWVzdCBzZXRWYWx1ZTpsZW5ndGhTdHJpbmcgZm9ySFRUUEhlYWRlckZpZWxkOkAi Q29udGVudC1MZW5ndGgiXTsKICAgICAgICAgICAgIC8vIFNpbmNlIHJlc291cmNlIHJlcXVlc3Qg aXMgYWxyZWFkeSBtYXJrZWQgdXBkYXRlZCwgd2UgbmVlZCB0byBrZWVwIGl0IHVwIHRvIGRhdGUg dG9vLgogICAgICAgICAgICAgQVNTRVJUKG1fcmVzb3VyY2VSZXF1ZXN0VXBkYXRlZCk7Ci0gICAg ICAgICAgICBtX2h0dHBIZWFkZXJGaWVsZHMuc2V0KCJDb250ZW50LUxlbmd0aCIsIGxlbmd0aFN0 cmluZyk7CisgICAgICAgICAgICBtX2h0dHBIZWFkZXJGaWVsZHMuc2V0KEhUVFBIZWFkZXJOYW1l OjpDb250ZW50TGVuZ3RoLCBsZW5ndGhTdHJpbmcpOwogICAgICAgICB9CiAgICAgfQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwIGIvU291cmNlL1dl YkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCA2MTJkNTNjZTAxYzg5YmJkMDM5YmE5 MjI1MTg2NjA2YjQ3ZDAyYzQ4Li5hNGUwZTVhZmMyOGI4MDhmOGYwNmRhMDQ0OTgyOGM5ZjYyOTBi ZDAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAgLTMzLDYgKzMzLDcg QEAKICNpbmNsdWRlICJFeGNlcHRpb25Db2RlLmgiCiAjaW5jbHVkZSAiRmlsZS5oIgogI2luY2x1 ZGUgIkhUTUxEb2N1bWVudC5oIgorI2luY2x1ZGUgIkhUVFBIZWFkZXJOYW1lcy5oIgogI2luY2x1 ZGUgIkhUVFBQYXJzZXJzLmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmgi CiAjaW5jbHVkZSAiSlNET01CaW5kaW5nLmgiCkBAIC02MzIsNyArNjMzLDcgQEAgdm9pZCBYTUxI dHRwUmVxdWVzdDo6c2VuZChjb25zdCBTdHJpbmcmIGJvZHksIEV4Y2VwdGlvbkNvZGUmIGVjKQog ICAgICAgICAgICAgICAgIHNldFJlcXVlc3RIZWFkZXJJbnRlcm5hbCgiQ29udGVudC1UeXBlIiwg ImFwcGxpY2F0aW9uL3htbCIpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgcmVwbGFj ZUNoYXJzZXRJbk1lZGlhVHlwZShjb250ZW50VHlwZSwgIlVURi04Iik7Ci0gICAgICAgICAgICBt X3JlcXVlc3RIZWFkZXJzLnNldCgiQ29udGVudC1UeXBlIiwgY29udGVudFR5cGUpOworICAgICAg ICAgICAgbV9yZXF1ZXN0SGVhZGVycy5zZXQoSFRUUEhlYWRlck5hbWU6OkNvbnRlbnRUeXBlLCBj b250ZW50VHlwZSk7CiAgICAgICAgIH0KIAogICAgICAgICBtX3JlcXVlc3RFbnRpdHlCb2R5ID0g Rm9ybURhdGE6OmNyZWF0ZShVVEY4RW5jb2RpbmcoKS5lbmNvZGUoYm9keSwgRW50aXRpZXNGb3JV bmVuY29kYWJsZXMpKTsK