133855 2014-06-13 07:30:27 -0700 [Gtk] [Stable] Fix the "Safari" part of the UA 2014-06-16 09:21:53 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 133403 1 svillar webkit-unassigned cgarcia gustavo mrobinson oldest_to_newest 1015415 0 svillar 2014-06-13 07:30:27 -0700 The part of our UA where we claim to be Safari is plainly wrong. Since version 3.0 the Safari user agent has the following structure: Version/X Safari/Y while in WebKitGtk that part looks like Safari/Y Version/6.0 This is causing problems with lots of websites, some of them very important like live.com (hotmail.com) our www.icloud.com, that report "unsupported browser" problems. This is basically a port of https://bugs.webkit.org/show_bug.cgi?id=133403 1015417 1 233049 svillar 2014-06-13 07:37:55 -0700 Created attachment 233049 Patch 1015425 2 233049 mrobinson 2014-06-13 08:10:08 -0700 Comment on attachment 233049 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233049&action=review > Tools/TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c:108 > settings = webkit_web_view_get_settings(WEBKIT_WEB_VIEW(webView)); > defaultUserAgent = g_strdup(webkit_web_settings_get_user_agent(settings)); > > + g_assert(g_strstr_len(defaultUserAgent, -1, "Version/8.0 Safari/")); > + g_assert(g_strstr_len(defaultUserAgent, -1, "Version/8.0") < g_strstr_len(defaultUserAgent, -1, "Safari/")); > + > test_non_quirky_user_agents(settings, defaultUserAgent); > > /* Test quirky google domains */ This file doesn't exist any longer. :) 1015428 3 233049 svillar 2014-06-13 08:14:27 -0700 Comment on attachment 233049 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233049&action=review >> Tools/TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c:108 >> /* Test quirky google domains */ > > This file doesn't exist any longer. :) It does in the stable branch. This is for stable only 1015431 4 233049 mrobinson 2014-06-13 08:19:43 -0700 Comment on attachment 233049 Patch Doh! Sorry. 1015874 5 svillar 2014-06-16 09:21:30 -0700 Committed finally in r170009 1015875 6 233049 svillar 2014-06-16 09:21:53 -0700 Comment on attachment 233049 Patch Clearing the flag now that landed 233049 2014-06-13 07:37:55 -0700 2014-06-16 09:21:53 -0700 Patch 133855.patch text/plain 4878 svillar ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZTY1YjU5Li41MDljMWEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTQtMDYtMTMgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0d0a10gW1N0YWJsZV0gRml4IHRoZSAiU2FmYXJpIiBwYXJ0IG9mIHRoZSBV QQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzODU1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY2xh aW0gdG8gYmUgU2FmYXJpIChhbW9uZyBvdGhlcnMpIHRvIGVuc3VyZSBtYXhpbXVtCisgICAgICAg IGNvbXBhdGliaWxpdHkgd2l0aCBleGlzdGluZyB3ZWIgc2l0ZXMuIFNpbmNlIFNhZmFyaSAzLjAg dmFsaWQKKyAgICAgICAgU2FmYXJpIFVBIHN0cmluZ3MgbG9vayBsaWtlIHRoaXMgIlZlcnNpb24v WCBTYWZhcmkvWSIgd2hpbGUgaW4gb3VyCisgICAgICAgIFVBIGl0J3MgIlNhZmFyaS9ZIFZlcnNp b24vNi4wIi4KKworICAgICAgICBUaGlzIGlzIHdyb25nIGFuZCBpcyBjYXVzaW5nICJ1bnN1cHBv cnRlZCBicm93c2VyIiBpc3N1ZXMgaW4KKyAgICAgICAgbWFueSBpbXBvcnRhbnQgc2l0ZXMgYXMg bGl2ZS5jb20gb3VyIGljbG91ZC5jb20uCisKKyAgICAgICAgQXBhcnQgZnJvbSB0aGF0IEknbSBi dW1waW5nIHRoZSBTYWZhcmkgVmVyc2lvbiBpbiB0aGUgVUEgdG8gOC4wIGFzCisgICAgICAgIHdl J3JlIGFscmVhZHkgY2xhaW1pbmcgdG8gYmUgIlNhZmFyaS81MzguMTUiIHdoaWNoIHNob3VsZCBi ZQorICAgICAgICBwcmV0dHkgZXF1aXZhbGVudCB0byBTYWZhcmkgOCBpbiB0ZXJtcyBvZiBmZWF0 dXJlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6c3RhbmRhcmRVc2VyQWdlbnQpOgorCiAyMDE0LTA1LTI1ICBNaWxhbiBDcmhh ICA8bWNyaGFAcmVkaGF0LmNvbT4KIAogICAgICAgICBbU3RhYmxlXSBbR1RLXSBHZGlPYmplY3Qu aCBtaXNzaW5nIGluIFdlYktpdEdUSyAyLjQuMSB0YXJiYWxsCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCmluZGV4IDg1NTdiNTUuLjMzMTk1NWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCkBAIC03MCw3ICs3 MCw3IEBAIFN0cmluZyBzdGFuZGFyZFVzZXJBZ2VudChjb25zdCBTdHJpbmcmIGFwcGxpY2F0aW9u TmFtZSwgY29uc3QgU3RyaW5nJiBhcHBsaWNhdGlvCiAgICAgLy8gd3JvbmcgY2FuIGNhdXNlIHNp dGVzIHRvIGxvYWQgdGhlIHdyb25nIEphdmFTY3JpcHQsIENTUywgb3IgY3VzdG9tIGZvbnRzLiBJ biBzb21lIGNhc2VzCiAgICAgLy8gc2l0ZXMgd29uJ3QgbG9hZCByZXNvdXJjZXMgYXQgYWxsLgog ICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgQ1N0cmluZywgdWFWZXJzaW9uLCAoU3RyaW5n Ojpmb3JtYXQoIiVpLiVpIiwgVVNFUl9BR0VOVF9HVEtfTUFKT1JfVkVSU0lPTiwgVVNFUl9BR0VO VF9HVEtfTUlOT1JfVkVSU0lPTikudXRmOCgpKSk7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChj b25zdCBTdHJpbmcsIHN0YXRpY1VBLCAoU3RyaW5nOjpmb3JtYXQoIk1vemlsbGEvNS4wIChNYWNp bnRvc2g7ICVzKSBBcHBsZVdlYktpdC8lcyAoS0hUTUwsIGxpa2UgR2Vja28pIFNhZmFyaS8lcyBW ZXJzaW9uLzYuMCIsCisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHN0YXRp Y1VBLCAoU3RyaW5nOjpmb3JtYXQoIk1vemlsbGEvNS4wIChNYWNpbnRvc2g7ICVzKSBBcHBsZVdl YktpdC8lcyAoS0hUTUwsIGxpa2UgR2Vja28pIFZlcnNpb24vOC4wIFNhZmFyaS8lcyIsCiAgICAg ICAgIHBsYXRmb3JtVmVyc2lvbkZvclVBU3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgdWFWZXJzaW9u LmRhdGEoKSwgdWFWZXJzaW9uLmRhdGEoKSkpKTsKIAogICAgIGlmIChhcHBsaWNhdGlvbk5hbWUu aXNFbXB0eSgpKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n CmluZGV4IDFlODYxZTEuLjk2YWFjYmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNC0wNi0xMyAgU2VyZ2lvIFZp bGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR3RrXSBbU3RhYmxl XSBGaXggdGhlICJTYWZhcmkiIHBhcnQgb2YgdGhlIFVBCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM4NTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIGNvdXBsZSBvZiB0ZXN0cyB0byB2ZXJp ZnkgdGhhdCB0aGUgU2FmYXJpIHBhcnQgb2Ygb3VyIFVBCisgICAgICAgIGxvb2tzIGxpa2UgIlZl cnNpb24vWCBTYWZhcmkvWSIgaW5zdGVhZCBvZiAiU2FmYXJpL1kgVmVyc2lvbi9YIgorICAgICAg ICB3aGljaCBpcyBjYXVzaW5nICJ1bnN1cHBvcnRlZCBicm93c2VyIiBpc3N1ZXMuCisKKyAgICAg ICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdFdlYktpdFNldHRpbmdzLmNw cDoKKyAgICAgICAgKHRlc3RXZWJLaXRTZXR0aW5nc1VzZXJBZ2VudCk6CisgICAgICAgICogVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvdGVzdHdlYnNldHRpbmdzLmM6CisgICAgICAgICh0 ZXN0X3dlYmtpdF93ZWJfc2V0dGluZ3NfdXNlcl9hZ2VudCk6CisKIDIwMTQtMDUtMjYgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdl YlByb2Nlc3MgbGVha2VkIHdoZW4gY2xvc2luZyBwYWdlcyB3aXRoIG5ldHdvcmsgcHJvY2VzcyBl bmFibGVkCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsv VGVzdFdlYktpdFNldHRpbmdzLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Mkd0ay9UZXN0V2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IDYwZjk2NGUuLmE1ZjMwNjQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2ViS2l0U2V0 dGluZ3MuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0 V2ViS2l0U2V0dGluZ3MuY3BwCkBAIC0zMzYsNiArMzM2LDkgQEAgc3RhdGljIHZvaWQgdGVzdFdl YktpdFNldHRpbmdzVXNlckFnZW50KFdlYlZpZXdUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQog ICAgIGNvbnN0IGNoYXIqIG5ld1VzZXJBZ2VudCA9IHdlYmtpdF9zZXR0aW5nc19nZXRfdXNlcl9h Z2VudChzZXR0aW5ncy5nZXQoKSk7CiAgICAgZ19hc3NlcnQoZ19zdHJzdHJfbGVuKG5ld1VzZXJB Z2VudCwgLTEsICIzLjQuNSIpKTsKICAgICBnX2Fzc2VydChnX3N0cnN0cl9sZW4obmV3VXNlckFn ZW50LCAtMSwgIldlYkNhdEdUSysiKSk7CisKKyAgICBHVW5pcXVlUHRyPGNoYXI+IGFwcGxpY2F0 aW9uVXNlckFnZW50KGdfc3RyZHVwX3ByaW50ZigiJXMgJXMiLCBkZWZhdWx0VXNlckFnZW50LmRh dGEoKSwgIldlYkNhdEdUSysvMy40LjUiKSk7CisgICAgZ19hc3NlcnRfY21wc3RyKGFwcGxpY2F0 aW9uVXNlckFnZW50LmdldCgpLCA9PSwgd2Via2l0X3NldHRpbmdzX2dldF91c2VyX2FnZW50KHNl dHRpbmdzLmdldCgpKSk7CiB9CiAKIHN0YXRpYyB2b2lkIHNlcnZlckNhbGxiYWNrKFNvdXBTZXJ2 ZXIqIHNlcnZlciwgU291cE1lc3NhZ2UqIG1lc3NhZ2UsIGNvbnN0IGNoYXIqIHBhdGgsIEdIYXNo VGFibGUqLCBTb3VwQ2xpZW50Q29udGV4dCosIGdwb2ludGVyKQpkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvdGVzdHdlYnNldHRpbmdzLmMgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEd0ay90ZXN0d2Vic2V0dGluZ3MuYwppbmRleCAzNTQ4 OWNkLi44MDMyMjVhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dEd0ay90ZXN0d2Vic2V0dGluZ3MuYworKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdEd0ay90ZXN0d2Vic2V0dGluZ3MuYwpAQCAtMTAwLDYgKzEwMCw5IEBAIHN0YXRpYyB2b2lk IHRlc3Rfd2Via2l0X3dlYl9zZXR0aW5nc191c2VyX2FnZW50KHZvaWQpCiAgICAgc2V0dGluZ3Mg PSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3NldHRpbmdzKFdFQktJVF9XRUJfVklFVyh3ZWJWaWV3KSk7 CiAgICAgZGVmYXVsdFVzZXJBZ2VudCA9IGdfc3RyZHVwKHdlYmtpdF93ZWJfc2V0dGluZ3NfZ2V0 X3VzZXJfYWdlbnQoc2V0dGluZ3MpKTsKIAorICAgIGdfYXNzZXJ0KGdfc3Ryc3RyX2xlbihkZWZh dWx0VXNlckFnZW50LCAtMSwgIlZlcnNpb24vOC4wIFNhZmFyaS8iKSk7CisgICAgZ19hc3NlcnQo Z19zdHJzdHJfbGVuKGRlZmF1bHRVc2VyQWdlbnQsIC0xLCAiVmVyc2lvbi84LjAiKSA8IGdfc3Ry c3RyX2xlbihkZWZhdWx0VXNlckFnZW50LCAtMSwgIlNhZmFyaS8iKSk7CisKICAgICB0ZXN0X25v bl9xdWlya3lfdXNlcl9hZ2VudHMoc2V0dGluZ3MsIGRlZmF1bHRVc2VyQWdlbnQpOwogCiAgICAg LyogVGVzdCBxdWlya3kgZ29vZ2xlIGRvbWFpbnMgKi8K