133847 2014-06-13 06:06:39 -0700 [GTK] Implement HTML5 Gamepad API 2020-10-20 04:53:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98937 133848 133849 133850 133851 133853 133854 212236 212453 213094 217226 217493 217494 217651 1 m.debski changseok annulen aperez bugs-noreply cgarcia changseok darin ews-watchlist gyuyoung.kim jinwoo7.song mcatanzaro ryuan.choi sam sergio syoichi zan oldest_to_newest 1015394 0 m.debski 2014-06-13 06:06:39 -0700 This series of patches add support for HTML5 Gamepad API. This sould be conforming to spec: http://www.w3.org/TR/gamepad/ It will consists of required changes in WebCore, layout tests for new implementation and events and Gamepad support in EFL and GTK port. There will be total of 5 patches - first 2 will introduce changes which can affect other features, next there will be common Gamepad implementation and in the end per port code. More information about each change in relevant bug description. 1017521 1 m.debski 2014-06-23 03:25:34 -0700 Relevant bugs were updated with patches. Please take a look if you are interested. 1630618 2 changseok 2020-03-16 20:42:31 -0700 Gamepad API was implemented by mac port. This ticket may aim to implement the spec for non-mac ports. But patches look very old and outdated. Michal, are you still working on this? If not, I'd like to take this over. 1634790 3 changseok 2020-03-27 04:39:22 -0700 My rough sketch is here, https://github.com/shivamidow/webkit/commits/gamepad-api. 1699400 4 411785 aperez 2020-10-19 13:24:05 -0700 Created attachment 411785 Patch 1699417 5 411785 darin 2020-10-19 13:54:54 -0700 Comment on attachment 411785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411785&action=review > ChangeLog:9 > + because libmanette is not availble in the current Debian "old stable" (Buster), which typo: available 1699616 6 aperez 2020-10-19 23:29:23 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 411785 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411785&action=review > > > ChangeLog:9 > > + because libmanette is not availble in the current Debian "old stable" (Buster), which > > typo: available Thanks, I will fix this before landing. 1699653 7 aperez 2020-10-20 02:37:06 -0700 This changes the public build options, so I will need an approval from a second reviewer, ideally working closely with the GTK port =) 1699663 8 411785 cgarcia 2020-10-20 03:28:44 -0700 Comment on attachment 411785 Patch LGTM 1699668 9 aperez 2020-10-20 03:55:17 -0700 (In reply to Carlos Garcia Campos from comment #8) > Comment on attachment 411785 [details] > Patch > > LGTM Thanks! 1699673 10 411852 aperez 2020-10-20 04:26:18 -0700 Created attachment 411852 Patch for landing 1699675 11 ews-feeder 2020-10-20 04:53:16 -0700 Committed r268725: <https://trac.webkit.org/changeset/268725> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411852. 411785 2020-10-19 13:24:05 -0700 2020-10-20 04:26:14 -0700 Patch bug-133847-20201019232403.patch text/plain 2233 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGZjZTQ5 MDM0OWUzODBlMjE4Y2ZlYTMzOTdiN2FlYTAwODEwZDU0YjkuLjg1NmEzNGE2YWVlNGE1ZGY2OWRi OTdmYmU1MTFhZDgyYzM2YjVhZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNDksNiArMTQ5 LDcgQEAgZW5kaWYgKCkKICMgY2hhbmdpbmcgdGhlIHZhbHVlIG9mIHRoZSBvcHRpb24uCiBXRUJL SVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQVNZTkNfU0NST0xMSU5HIFBSSVZB VEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRFJBR19TVVBQ T1JUIFBVQkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9H QU1FUEFEIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9TUEVMTENIRUNLIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9UT1VDSF9FVkVOVFMgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX1dFQl9DUllQVE8gUFVCTElDIE9OKQpAQCAtMTY5LDcgKzE3MCw2IEBA IFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9ET1dOTE9BRF9BVFRSSUJV VEUgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9F TkNSWVBURURfTUVESUEgUFJJVkFURSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQog V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0ZJTFRFUlNfTEVWRUxfMiBQ UklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0ZUUERJ UiBQUklWQVRFIE9GRikKLVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9H QU1FUEFEIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKIFdFQktJVF9P UFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9HUFVfUFJPQ0VTUyBQUklWQVRFICR7RU5B QkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFU30pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfSU5QVVRfVFlQRV9DT0xPUiBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0xBWU9VVF9GT1JNQVRUSU5HX0NPTlRFWFQgUFJJVkFU RSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IGE0YWVmMzlkYWQ2NTgxMzgwNGVkYzE2Yzc0NTQxMGQzNjQ0Mzgw Y2QuLjhhNzMzZjg5ZDUxMjY0M2VkZTY3MTdhZWE2N2U3MGQ2Zjc1MDc4YzggMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0xMC0xOSAg QWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEtdIEltcGxlbWVudCBIVE1MNSBHYW1lcGFkIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzODQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIHRoZSBnYW1lcGFkIHN1cHBvcnQgYnkgZGVm YXVsdCBmb3IgdGhlIEdUSyBwb3J0LiBUaGUgb3B0aW9uIGlzIG1hcmtlZCBQVUJMSUMKKyAgICAg ICAgYmVjYXVzZSBsaWJtYW5ldHRlIGlzIG5vdCBhdmFpbGJsZSBpbiB0aGUgY3VycmVudCBEZWJp YW4gIm9sZCBzdGFibGUiIChCdXN0ZXIpLCB3aGljaAorICAgICAgICB3ZSBuZWVkIHRvIHN1cHBv cnQgdW50aWwgU2VwdGVtYmVyIDIwMjEuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u c0dUSy5jbWFrZTogU2V0IEVOQUJMRV9HQU1FUEFEIHRvIFBVQkxJQyBhbmQgT04gYnkgZGVmYXVs dC4KKwogMjAyMC0xMC0xNCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUmVtb3ZlIEFDQ0VMRVJBVEVEXzJEX0NBTlZBUyBidWlsZCBmbGFncyBhbmQgZ3Vh cmRlZCBjb2RlCg== 411852 2020-10-20 04:26:18 -0700 2020-10-20 04:53:17 -0700 Patch for landing bug-133847-20201020142617.patch text/plain 2268 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGZjZTQ5 MDM0OWUzODBlMjE4Y2ZlYTMzOTdiN2FlYTAwODEwZDU0YjkuLjg1NmEzNGE2YWVlNGE1ZGY2OWRi OTdmYmU1MTFhZDgyYzM2YjVhZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNDksNiArMTQ5 LDcgQEAgZW5kaWYgKCkKICMgY2hhbmdpbmcgdGhlIHZhbHVlIG9mIHRoZSBvcHRpb24uCiBXRUJL SVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQVNZTkNfU0NST0xMSU5HIFBSSVZB VEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRFJBR19TVVBQ T1JUIFBVQkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9H QU1FUEFEIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9TUEVMTENIRUNLIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9UT1VDSF9FVkVOVFMgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX1dFQl9DUllQVE8gUFVCTElDIE9OKQpAQCAtMTY5LDcgKzE3MCw2IEBA IFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9ET1dOTE9BRF9BVFRSSUJV VEUgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9F TkNSWVBURURfTUVESUEgUFJJVkFURSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQog V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0ZJTFRFUlNfTEVWRUxfMiBQ UklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0ZUUERJ UiBQUklWQVRFIE9GRikKLVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9H QU1FUEFEIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKIFdFQktJVF9P UFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9HUFVfUFJPQ0VTUyBQUklWQVRFICR7RU5B QkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFU30pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfSU5QVVRfVFlQRV9DT0xPUiBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0xBWU9VVF9GT1JNQVRUSU5HX0NPTlRFWFQgUFJJVkFU RSAke0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IDA2ZmNlYTljZWY1YzY4YWE2NGJiZGQ0MDhlMDk2MDYwY2I2Njk5 ZWEuLjcxNmZkOTMwMWU1NDlhMjcyY2U5MGM4ODdkZTVhODg3ZTEzNDA3YjIgMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0xMC0yMCAg QWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEtdIEltcGxlbWVudCBIVE1MNSBHYW1lcGFkIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzODQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWlj aGFlbCBDYXRhbnphcm8uCisKKyAgICAgICAgRW5hYmxlIHRoZSBnYW1lcGFkIHN1cHBvcnQgYnkg ZGVmYXVsdCBmb3IgdGhlIEdUSyBwb3J0LiBUaGUgb3B0aW9uIGlzIG1hcmtlZCBQVUJMSUMKKyAg ICAgICAgYmVjYXVzZSBsaWJtYW5ldHRlIGlzIG5vdCBhdmFpbGFibGUgaW4gdGhlIGN1cnJlbnQg RGViaWFuICJvbGQgc3RhYmxlIiAoQnVzdGVyKSwgd2hpY2gKKyAgICAgICAgd2UgbmVlZCB0byBz dXBwb3J0IHVudGlsIFNlcHRlbWJlciAyMDIxLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09w dGlvbnNHVEsuY21ha2U6IFNldCBFTkFCTEVfR0FNRVBBRCB0byBQVUJMSUMgYW5kIE9OIGJ5IGRl ZmF1bHQuCisKIDIwMjAtMTAtMTkgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTihyMjY4MTE1KSBbR1RLXSBCdWlsZCBmYWlsdXJlcyB3aXRoIEdD QyA3IChVYnVudHUgMTguMDQpIGFuZCBHQ0MgOCAoRGViaWFuIEJ1c3RlcikK