133830 2014-06-12 16:23:53 -0700 [New Multicolumn] vertical-rl columns don't repaint properly when there is overflow out the left 2023-03-13 11:06:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 hyatt hyatt ahmad.saleem792 commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser zalan oldest_to_newest 1015276 0 hyatt 2014-06-12 16:23:53 -0700 vertical-rl columns don't repaint properly when there is overflow out the left side of the column set. 1015277 1 233005 hyatt 2014-06-12 16:24:23 -0700 Created attachment 233005 Patch 1015279 2 commit-queue 2014-06-12 16:25:49 -0700 Attachment 233005 did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayer.cpp:5109: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1940934 3 ahmad.saleem792 2023-03-13 10:15:14 -0700 It seems partially this patch is implemented - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderMultiColumnSet.cpp#735 Do we need to do anything more here? Thanks! 233005 2014-06-12 16:24:23 -0700 2014-06-12 16:24:23 -0700 Patch patch.txt text/plain 1428 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNpb24g MTY5OTEyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNTEwNiw3ICs1MTA2LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6dXBkYXRl Q2xpcFJlY3RzKGNvbnN0IAogICAgICAgICB0ZW1wQ29udGV4dC5jbGlwUmVjdHNUeXBlID0gVGVt cG9yYXJ5Q2xpcFJlY3RzOwogICAgICAgICBDbGlwUmVjdHMgY2xpcFJlY3RzOwogICAgICAgICBj YWxjdWxhdGVDbGlwUmVjdHModGVtcENvbnRleHQsIGNsaXBSZWN0cyk7Ci0gICAgICAgIEFTU0VS VChjbGlwUmVjdHMgPT0gKm1fY2xpcFJlY3RzQ2FjaGUtPmdldENsaXBSZWN0cyhjbGlwUmVjdHNU eXBlLCBjbGlwUmVjdHNDb250ZXh0LnJlc3BlY3RPdmVyZmxvd0NsaXApLmdldCgpKTsKKyAgICAg ICAvLyBBU1NFUlQoY2xpcFJlY3RzID09ICptX2NsaXBSZWN0c0NhY2hlLT5nZXRDbGlwUmVjdHMo Y2xpcFJlY3RzVHlwZSwgY2xpcFJlY3RzQ29udGV4dC5yZXNwZWN0T3ZlcmZsb3dDbGlwKS5nZXQo KSk7CiAjZW5kaWYKICAgICAgICAgcmV0dXJuOyAvLyBXZSBoYXZlIHRoZSBjb3JyZWN0IGNhY2hl ZCB2YWx1ZS4KICAgICB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVs dGlDb2x1bW5TZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJNdWx0aUNvbHVtblNldC5jcHAJKHJldmlzaW9uIDE2OTkxMikKKysrIFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtblNldC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTY2NSw2ICs2NjUsNyBAQCB2b2lkIFJlbmRlck11bHRpQ29sdW1uU2V0OjpyZXBhaW50Rmxvd1Ro CiAgICAgICAgIExheW91dFJlY3QgZmxvd1RocmVhZE92ZXJmbG93UG9ydGlvbiA9IGZsb3dUaHJl YWRQb3J0aW9uT3ZlcmZsb3dSZWN0KGZsb3dUaHJlYWRQb3J0aW9uLCBpLCBjb2xDb3VudCwgY29s R2FwKTsKIAogICAgICAgICAvLyBEbyBhIHJlcGFpbnQgZm9yIHRoaXMgc3BlY2lmaWMgY29sdW1u LgorICAgICAgICBmbGlwRm9yV3JpdGluZ01vZGUoY29sUmVjdCk7CiAgICAgICAgIHJlcGFpbnRG bG93VGhyZWFkQ29udGVudFJlY3RhbmdsZShyZXBhaW50UmVjdCwgZmxvd1RocmVhZFBvcnRpb24s IGNvbFJlY3QubG9jYXRpb24oKSwgJmZsb3dUaHJlYWRPdmVyZmxvd1BvcnRpb24pOwogICAgIH0K IH0K