133828 2014-06-12 16:00:50 -0700 Remove some dead / unused code 2014-06-12 16:33:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam oldest_to_newest 1015267 0 mark.lam 2014-06-12 16:00:50 -0700 Patch coming. 1015268 1 233002 mark.lam 2014-06-12 16:05:19 -0700 Created attachment 233002 the patch. 1015280 2 mark.lam 2014-06-12 16:32:21 -0700 Thanks for the review. Landed in r169920: <http://trac.webkit.org/r169920>. 1015281 3 mark.lam 2014-06-12 16:33:42 -0700 FYI, the efl-wk2 bot failure is due to a tool chain issue and is unrelated to this patch: [ 17%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSAudioStreamTrack.cpp.o c++: internal compiler error: Killed (program cc1plus) Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions. make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/dom/Document.cpp.o] Error 4 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 make: *** [all] Error 2 233002 2014-06-12 16:05:19 -0700 2014-06-12 16:26:23 -0700 the patch. bug-133828.patch text/plain 7540 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY5OTE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE0LTA2LTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgc29tZSBkZWFkIC8gdW51c2VkIGNvZGUuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xMzM4Mjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBidWlsdGlucy9CdWlsdGluRXhlY3V0YWJsZXMuY3BwOgorICAgICAgICAoSlNDOjpC dWlsdGluRXhlY3V0YWJsZXM6OmNyZWF0ZUJ1aWx0aW5FeGVjdXRhYmxlKToKKyAgICAgICAgKiBi eXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6OlVubGlua2VkRnVu Y3Rpb25FeGVjdXRhYmxlOjpVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZSk6CisgICAgICAgICog Ynl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaDoKKyAgICAgICAgKEpTQzo6VW5saW5rZWRGdW5j dGlvbkV4ZWN1dGFibGU6OmNyZWF0ZSk6CisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2Rl R2VuZXJhdG9yLmg6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlR2VuZXJhdG9yOjptYWtlRnVuY3Rp b24pOgorICAgICAgICAqIHBhcnNlci9QYXJzZXIuaDoKKyAgICAgICAgKEpTQzo6RGVwdGhNYW5h Z2VyOjpEZXB0aE1hbmFnZXIpOiBEZWxldGVkLgorICAgICAgICAoSlNDOjpEZXB0aE1hbmFnZXI6 On5EZXB0aE1hbmFnZXIpOiBEZWxldGVkLgorICAgICAgICAqIHJ1bnRpbWUvQ29kZUNhY2hlLmNw cDoKKyAgICAgICAgKEpTQzo6Q29kZUNhY2hlOjpnZXRGdW5jdGlvbkV4ZWN1dGFibGVGcm9tR2xv YmFsQ29kZSk6CisKIDIwMTQtMDYtMTIgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFw cGxlLmNvbT4KIAogICAgICAgICBNb3ZlIHN0cnVjdHVyZUhhc1JhcmVEYXRhIG91dCBvZiBUeXBl SW5mbwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL0J1aWx0aW5FeGVjdXRh Ymxlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL0J1 aWx0aW5FeGVjdXRhYmxlcy5jcHAJKHJldmlzaW9uIDE2OTkxOCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9idWlsdGlucy9CdWlsdGluRXhlY3V0YWJsZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC03OCw3ICs3OCw3IEBAIFVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlKiBCdWlsdGluRXhlY3UK ICAgICAgICAgUkVMRUFTRV9BU1NFUlQoY2xvc2VkVmFyaWFibGUtPmlzRW1wdHlVbmlxdWUoKSk7 CiAgICAgfQogICAgIGJvZHktPm92ZXJyaWRlTmFtZShuYW1lKTsKLSAgICBVbmxpbmtlZEZ1bmN0 aW9uRXhlY3V0YWJsZSogZnVuY3Rpb25FeGVjdXRhYmxlID0gVW5saW5rZWRGdW5jdGlvbkV4ZWN1 dGFibGU6OmNyZWF0ZSgmbV92bSwgc291cmNlLCBib2R5LCB0cnVlLCBVbmxpbmtlZEJ1aWx0aW5G dW5jdGlvbik7CisgICAgVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUqIGZ1bmN0aW9uRXhlY3V0 YWJsZSA9IFVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlOjpjcmVhdGUoJm1fdm0sIHNvdXJjZSwg Ym9keSwgVW5saW5rZWRCdWlsdGluRnVuY3Rpb24pOwogICAgIGZ1bmN0aW9uRXhlY3V0YWJsZS0+ bV9uYW1lVmFsdWUuc2V0KG1fdm0sIGZ1bmN0aW9uRXhlY3V0YWJsZSwganNTdHJpbmcoJm1fdm0s IG5hbWUuc3RyaW5nKCkpKTsKICAgICByZXR1cm4gZnVuY3Rpb25FeGVjdXRhYmxlOwogfQpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2Rl QmxvY2suY3BwCShyZXZpc2lvbiAxNjk5MTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MiwxMyArODIs MTIgQEAgdW5zaWduZWQgVW5saW5rZWRDb2RlQmxvY2s6OmFkZE9yRmluZENvbgogICAgIHJldHVy biBhZGRDb25zdGFudCh2KTsKIH0KIAotVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGU6OlVubGlu a2VkRnVuY3Rpb25FeGVjdXRhYmxlKFZNKiB2bSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIGNvbnN0 IFNvdXJjZUNvZGUmIHNvdXJjZSwgRnVuY3Rpb25Cb2R5Tm9kZSogbm9kZSwgYm9vbCBpc0Zyb21H bG9iYWxDb2RlLCBVbmxpbmtlZEZ1bmN0aW9uS2luZCBraW5kKQorVW5saW5rZWRGdW5jdGlvbkV4 ZWN1dGFibGU6OlVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlKFZNKiB2bSwgU3RydWN0dXJlKiBz dHJ1Y3R1cmUsIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSwgRnVuY3Rpb25Cb2R5Tm9kZSogbm9k ZSwgVW5saW5rZWRGdW5jdGlvbktpbmQga2luZCkKICAgICA6IEJhc2UoKnZtLCBzdHJ1Y3R1cmUp CiAgICAgLCBtX251bUNhcHR1cmVkVmFyaWFibGVzKG5vZGUtPmNhcHR1cmVkVmFyaWFibGVDb3Vu dCgpKQogICAgICwgbV9mb3JjZVVzZXNBcmd1bWVudHMobm9kZS0+dXNlc0FyZ3VtZW50cygpKQog ICAgICwgbV9pc0luU3RyaWN0Q29udGV4dChub2RlLT5pc1N0cmljdE1vZGUoKSkKICAgICAsIG1f aGFzQ2FwdHVyZWRWYXJpYWJsZXMobm9kZS0+aGFzQ2FwdHVyZWRWYXJpYWJsZXMoKSkKLSAgICAs IG1faXNGcm9tR2xvYmFsQ29kZShpc0Zyb21HbG9iYWxDb2RlKQogICAgICwgbV9pc0J1aWx0aW5G dW5jdGlvbihraW5kID09IFVubGlua2VkQnVpbHRpbkZ1bmN0aW9uKQogICAgICwgbV9uYW1lKG5v ZGUtPmlkZW50KCkpCiAgICAgLCBtX2luZmVycmVkTmFtZShub2RlLT5pbmZlcnJlZE5hbWUoKSkK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZENv ZGVCbG9jay5oCShyZXZpc2lvbiAxNjk5MTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAtOTIsOSArOTIsOSBA QCBwdWJsaWM6CiAgICAgZnJpZW5kIGNsYXNzIENvZGVDYWNoZTsKICAgICBmcmllbmQgY2xhc3Mg Vk07CiAgICAgdHlwZWRlZiBKU0NlbGwgQmFzZTsKLSAgICBzdGF0aWMgVW5saW5rZWRGdW5jdGlv bkV4ZWN1dGFibGUqIGNyZWF0ZShWTSogdm0sIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSwgRnVu Y3Rpb25Cb2R5Tm9kZSogbm9kZSwgYm9vbCBpc0Zyb21HbG9iYWxDb2RlLCBVbmxpbmtlZEZ1bmN0 aW9uS2luZCB1bmxpbmtlZEZ1bmN0aW9uS2luZCkKKyAgICBzdGF0aWMgVW5saW5rZWRGdW5jdGlv bkV4ZWN1dGFibGUqIGNyZWF0ZShWTSogdm0sIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSwgRnVu Y3Rpb25Cb2R5Tm9kZSogbm9kZSwgVW5saW5rZWRGdW5jdGlvbktpbmQgdW5saW5rZWRGdW5jdGlv bktpbmQpCiAgICAgewotICAgICAgICBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZSogaW5zdGFu Y2UgPSBuZXcgKE5vdE51bGwsIGFsbG9jYXRlQ2VsbDxVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJs ZT4odm0tPmhlYXApKSBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZSh2bSwgdm0tPnVubGlua2Vk RnVuY3Rpb25FeGVjdXRhYmxlU3RydWN0dXJlLmdldCgpLCBzb3VyY2UsIG5vZGUsIGlzRnJvbUds b2JhbENvZGUsIHVubGlua2VkRnVuY3Rpb25LaW5kKTsKKyAgICAgICAgVW5saW5rZWRGdW5jdGlv bkV4ZWN1dGFibGUqIGluc3RhbmNlID0gbmV3IChOb3ROdWxsLCBhbGxvY2F0ZUNlbGw8VW5saW5r ZWRGdW5jdGlvbkV4ZWN1dGFibGU+KHZtLT5oZWFwKSkgVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFi bGUodm0sIHZtLT51bmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZVN0cnVjdHVyZS5nZXQoKSwgc291 cmNlLCBub2RlLCB1bmxpbmtlZEZ1bmN0aW9uS2luZCk7CiAgICAgICAgIGluc3RhbmNlLT5maW5p c2hDcmVhdGlvbigqdm0pOwogICAgICAgICByZXR1cm4gaW5zdGFuY2U7CiAgICAgfQpAQCAtMTYy LDcgKzE2Miw3IEBAIHB1YmxpYzoKICAgICBib29sIGlzQnVpbHRpbkZ1bmN0aW9uKCkgY29uc3Qg eyByZXR1cm4gbV9pc0J1aWx0aW5GdW5jdGlvbjsgfQogCiBwcml2YXRlOgotICAgIFVubGlua2Vk RnVuY3Rpb25FeGVjdXRhYmxlKFZNKiwgU3RydWN0dXJlKiwgY29uc3QgU291cmNlQ29kZSYsIEZ1 bmN0aW9uQm9keU5vZGUqLCBib29sIGlzRnJvbUdsb2JhbENvZGUsIFVubGlua2VkRnVuY3Rpb25L aW5kKTsKKyAgICBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZShWTSosIFN0cnVjdHVyZSosIGNv bnN0IFNvdXJjZUNvZGUmLCBGdW5jdGlvbkJvZHlOb2RlKiwgVW5saW5rZWRGdW5jdGlvbktpbmQp OwogICAgIFdyaXRlQmFycmllcjxVbmxpbmtlZEZ1bmN0aW9uQ29kZUJsb2NrPiBtX2NvZGVCbG9j a0ZvckNhbGw7CiAgICAgV3JpdGVCYXJyaWVyPFVubGlua2VkRnVuY3Rpb25Db2RlQmxvY2s+IG1f Y29kZUJsb2NrRm9yQ29uc3RydWN0OwogCkBAIC0xNzAsNyArMTcwLDYgQEAgcHJpdmF0ZToKICAg ICBib29sIG1fZm9yY2VVc2VzQXJndW1lbnRzIDogMTsKICAgICBib29sIG1faXNJblN0cmljdENv bnRleHQgOiAxOwogICAgIGJvb2wgbV9oYXNDYXB0dXJlZFZhcmlhYmxlcyA6IDE7Ci0gICAgYm9v bCBtX2lzRnJvbUdsb2JhbENvZGUgOiAxOwogICAgIGJvb2wgbV9pc0J1aWx0aW5GdW5jdGlvbiA6 IDE7CiAKICAgICBJZGVudGlmaWVyIG1fbmFtZTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgJKHJldmlzaW9u IDE2OTkxOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVH ZW5lcmF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtNTQ3LDcgKzU0Nyw3IEBAIG5hbWVzcGFjZSBK U0MgewogICAgICAgICAKICAgICAgICAgVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUqIG1ha2VG dW5jdGlvbihGdW5jdGlvbkJvZHlOb2RlKiBib2R5KQogICAgICAgICB7Ci0gICAgICAgICAgICBy ZXR1cm4gVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGU6OmNyZWF0ZShtX3ZtLCBtX3Njb3BlTm9k ZS0+c291cmNlKCksIGJvZHksIGZhbHNlLCBpc0J1aWx0aW5GdW5jdGlvbigpID8gVW5saW5rZWRC dWlsdGluRnVuY3Rpb24gOiBVbmxpbmtlZE5vcm1hbEZ1bmN0aW9uKTsKKyAgICAgICAgICAgIHJl dHVybiBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZTo6Y3JlYXRlKG1fdm0sIG1fc2NvcGVOb2Rl LT5zb3VyY2UoKSwgYm9keSwgaXNCdWlsdGluRnVuY3Rpb24oKSA/IFVubGlua2VkQnVpbHRpbkZ1 bmN0aW9uIDogVW5saW5rZWROb3JtYWxGdW5jdGlvbik7CiAgICAgICAgIH0KIAogICAgICAgICBS ZWdpc3RlcklEKiBlbWl0SW5pdExhenlSZWdpc3RlcihSZWdpc3RlcklEKik7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmgJKHJldmlzaW9uIDE2OTkxOCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTg4LDIz ICs4OCw2IEBAIGVudW0gRGVjb25zdHJ1Y3Rpb25LaW5kIHsKIHRlbXBsYXRlIDx0eXBlbmFtZSBU PiBpbmxpbmUgYm9vbCBpc0V2YWxOb2RlKCkgeyByZXR1cm4gZmFsc2U7IH0KIHRlbXBsYXRlIDw+ IGlubGluZSBib29sIGlzRXZhbE5vZGU8RXZhbE5vZGU+KCkgeyByZXR1cm4gdHJ1ZTsgfQogCi1z dHJ1Y3QgRGVwdGhNYW5hZ2VyIHsKLSAgICBEZXB0aE1hbmFnZXIoaW50KiBkZXB0aCkKLSAgICAg ICAgOiBtX29yaWdpbmFsRGVwdGgoKmRlcHRoKQotICAgICAgICAsIG1fZGVwdGgoZGVwdGgpCi0g ICAgewotICAgIH0KLQotICAgIH5EZXB0aE1hbmFnZXIoKQotICAgIHsKLSAgICAgICAgKm1fZGVw dGggPSBtX29yaWdpbmFsRGVwdGg7Ci0gICAgfQotCi1wcml2YXRlOgotICAgIGludCBtX29yaWdp bmFsRGVwdGg7Ci0gICAgaW50KiBtX2RlcHRoOwotfTsKLQogc3RydWN0IFNjb3BlTGFiZWxJbmZv IHsKICAgICBTY29wZUxhYmVsSW5mbyhTdHJpbmdJbXBsKiBpZGVudCwgYm9vbCBpc0xvb3ApCiAg ICAgICAgIDogbV9pZGVudChpZGVudCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvZGVDYWNoZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvQ29kZUNhY2hlLmNwcAkocmV2aXNpb24gMTY5OTE4KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYzLDcgKzE2 Myw3IEBAIFVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlKiBDb2RlQ2FjaGU6OmcKICAgICBSRUxF QVNFX0FTU0VSVChib2R5KTsKICAgICBSRUxFQVNFX0FTU0VSVChib2R5LT5pZGVudCgpLmlzTnVs bCgpKTsKIAotICAgIFVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlKiBmdW5jdGlvbkV4ZWN1dGFi bGUgPSBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZTo6Y3JlYXRlKCZ2bSwgc291cmNlLCBib2R5 LCB0cnVlLCBVbmxpbmtlZE5vcm1hbEZ1bmN0aW9uKTsKKyAgICBVbmxpbmtlZEZ1bmN0aW9uRXhl Y3V0YWJsZSogZnVuY3Rpb25FeGVjdXRhYmxlID0gVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGU6 OmNyZWF0ZSgmdm0sIHNvdXJjZSwgYm9keSwgVW5saW5rZWROb3JtYWxGdW5jdGlvbik7CiAgICAg ZnVuY3Rpb25FeGVjdXRhYmxlLT5tX25hbWVWYWx1ZS5zZXQodm0sIGZ1bmN0aW9uRXhlY3V0YWJs ZSwganNTdHJpbmcoJnZtLCBuYW1lLnN0cmluZygpKSk7CiAKICAgICBhZGRSZXN1bHQuaXRlcmF0 b3ItPnZhbHVlID0gU291cmNlQ29kZVZhbHVlKHZtLCBmdW5jdGlvbkV4ZWN1dGFibGUsIG1fc291 cmNlQ29kZS5hZ2UoKSk7Cg==