133827 2014-06-12 15:17:35 -0700 C++ style comment was preventing compile if CPU(ARM_NEON) 2015-01-14 08:11:08 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Minor --- 1 juul webkit-unassigned ossy oldest_to_newest 1015257 0 232998 juul 2014-06-12 15:17:35 -0700 Created attachment 232998 NEON-specific buildfix for WTF C++ style comment was preventing compile if CPU(ARM_NEON). Changed to C style comment. Unreviewed buildfix. Patch included. 1015344 1 232998 ossy 2014-06-13 00:19:36 -0700 Comment on attachment 232998 NEON-specific buildfix for WTF View in context: https://bugs.webkit.org/attachment.cgi?id=232998&action=review LGTM, r=me. But please fix the style issue. > Source/WTF/ChangeLog:8 > + C++ style comment was preventing compile if CPU(ARM_NEON). > + Changed to C style comment. > + > + Unreviewed buildfix. > + > + * wtf/Platform.h: Please fix the indentation and leave the reviewed by nobody oops line unchanged. 1061177 2 ossy 2015-01-14 08:10:55 -0800 Landed in https://trac.webkit.org/changeset/178419 with fixed changelog. 232998 2014-06-12 15:17:35 -0700 2015-01-14 08:11:08 -0800 NEON-specific buildfix for WTF neon_cpp_comment_buildfix.patch text/plain 894 juul SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjk5MTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA2LTEyICBNYXJjIEp1dWwgIDxqdXVsQHN1 ZG9tZXNoLm9yZz4KKworCUMrKyBzdHlsZSBjb21tZW50IHdhcyBwcmV2ZW50aW5nIGNvbXBpbGUg aWYgQ1BVKEFSTV9ORU9OKS4KKwlDaGFuZ2VkIHRvIEMgc3R5bGUgY29tbWVudC4KKworICAgICAg ICBVbnJldmlld2VkIGJ1aWxkZml4LgorCQorICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAy MDE0LTA2LTEyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAg IEZpeCBNYWMgYWZ0ZXIgcjE2OTg4MC4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gMTY5OTEw KQorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMzAxLDcg KzMwMSw3IEBACiAjZW5kaWYKIAogI2lmIENQVShBUk1fTkVPTikKLS8vIEFsbCBORU9OIGludHJp bnNpY3MgdXNhZ2UgY2FuIGJlIGRpc2FibGVkIGJ5IHRoaXMgbWFjcm8uCisvKiBBbGwgTkVPTiBp bnRyaW5zaWNzIHVzYWdlIGNhbiBiZSBkaXNhYmxlZCBieSB0aGlzIG1hY3JvLiAqLwogI2RlZmlu ZSBIQVZFX0FSTV9ORU9OX0lOVFJJTlNJQ1MgMQogI2VuZGlmCiAK