133826 2014-06-12 15:13:29 -0700 [iOS WK2] Fix crash on back/foward swipe 2014-06-12 15:25:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser andersca cmarcelo commit-queue jamesr japhet luiz simon.fraser tonikitoo oldest_to_newest 1015252 0 simon.fraser 2014-06-12 15:13:29 -0700 [iOS WK2] Fix crash on back/foward swipe 1015255 1 232997 simon.fraser 2014-06-12 15:15:16 -0700 Created attachment 232997 Patch 1015256 2 simon.fraser 2014-06-12 15:15:42 -0700 <rdar://problem/17032752> 1015260 3 simon.fraser 2014-06-12 15:25:07 -0700 https://trac.webkit.org/r169913 232997 2014-06-12 15:15:16 -0700 2014-06-12 15:19:24 -0700 Patch bug-133826-20140612151453.patch text/plain 4910 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5OTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzU3ZjA1ZTk0ZWYyZjg2 NTYyZjQ4NTZlNzIxODUwNmYzZjhjMDExOC4uNzIwMWIxZjhiNzMzZjFhNDE2NWY3NGRhNjFjZDcy ZTNlMmIyNzAyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA2LTEyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBG aXggY3Jhc2ggb24gYmFjay9mb3dhcmQgc3dpcGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzgyNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTcw MzI3NTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6ZnJhbWVWaWV3Rm9yU2Nyb2xsaW5nTm9kZSgpIHdv dWxkIGNyYXNoIHdpdGggYSBudWxsIHJvb3QKKyAgICAgICAgc3RhdGUgbm9kZSwgYmVjYXVzZSBI aXN0b3J5Q29udHJvbGxlcjo6cmVzdG9yZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlKCkgdHJp ZWQKKyAgICAgICAgdG8gcmVzdG9yZSBzY3JvbGwgcG9zaXRpb24gKHZpYSByZXN0b3JlVmlld1N0 YXRlKCkpIGJlZm9yZSBob29raW5nIHVwIHRoZSBzY3JvbGxpbmcKKyAgICAgICAgY29vcmRpbmF0 b3IuCisgICAgICAgIAorICAgICAgICBGaXggYnkgZG9pbmcgdGhlIHNjcm9sbGluZ0Nvb3JkaW5h dG9yLT5mcmFtZVZpZXdSb290TGF5ZXJEaWRDaGFuZ2UoKSBiZWZvcmUKKyAgICAgICAgY2FsbGlu ZyByZXN0b3JlVmlld1N0YXRlKCkuCisgICAgICAgIAorICAgICAgICBBbHNvIGFkZCBhIGRlZmVu c2l2ZSBudWxsLWNoZWNrIG9uIHRoZSByb290IHN0YXRlIG5vZGUgaW4gdXBkYXRlU2Nyb2xsUG9z aXRpb25BZnRlckFzeW5jU2Nyb2xsVGltZXJGaXJlZCgpLgorCisgICAgICAgICogbG9hZGVyL0hp c3RvcnlDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okhpc3RvcnlDb250cm9sbGVy OjpyZXN0b3JlU2Nyb2xsUG9zaXRpb25BbmRWaWV3U3RhdGUpOgorICAgICAgICAqIHBhZ2Uvc2Ny b2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6ZnJhbWVWaWV3Rm9yU2Nyb2xsaW5nTm9kZSk6CisK IDIwMTQtMDYtMTIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBT dWJwaXhlbCByZW5kZXJpbmc6IE1ha2UgPHNlbGVjdD4gZWxlbWVudCdzIGRlY29yYXRpb24gc3Vi cGl4ZWwgYXdhcmUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNv bnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNw cAppbmRleCBlODJlN2QxZWZjYzc2YTZmODlhYWI0YjkzOTNjMDc1NzdiNDJjNDM3Li5lYjM4MGQ0 MGI2MTNiOGQxMDM0ZWQxY2NjNjA4ODdiNDg3MTdiNTZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAKQEAgLTEyNCwzMyArMTI0LDM1IEBAIHZvaWQgSGlz dG9yeUNvbnRyb2xsZXI6OnJlc3RvcmVTY3JvbGxQb3NpdGlvbkFuZFZpZXdTdGF0ZSgpCiAgICAg Ly8gc28gdGhlcmUgKmlzKiBubyBzY3JvbGwgb3IgdmlldyBzdGF0ZSB0byByZXN0b3JlIQogICAg IGlmICghbV9jdXJyZW50SXRlbSkKICAgICAgICAgcmV0dXJuOwotICAgIAotICAgIC8vIEZJWE1F OiBJdCB3b3VsZCBiZSBncmVhdCB0byB3b3JrIG91dCBhIHdheSB0byBwdXQgdGhpcyBjb2RlIGlu IFdlYkNvcmUgaW5zdGVhZCBvZiBjYWxsaW5nCi0gICAgLy8gdGhyb3VnaCB0byB0aGUgY2xpZW50 LiBJdCdzIGN1cnJlbnRseSB1c2VkIG9ubHkgZm9yIHRoZSBQREYgdmlldyBvbiBNYWMuCi0gICAg bV9mcmFtZS5sb2FkZXIoKS5jbGllbnQoKS5yZXN0b3JlVmlld1N0YXRlKCk7CisKKyAgICBGcmFt ZVZpZXcqIHZpZXcgPSBtX2ZyYW1lLnZpZXcoKTsKIAogICAgIC8vIEZJWE1FOiBUaGVyZSBpcyBz b21lIHNjcm9sbGluZyByZWxhdGVkIHdvcmsgdGhhdCBuZWVkcyB0byBoYXBwZW4gd2hlbmV2ZXIg YSBwYWdlIGdvZXMgaW50byB0aGUKICAgICAvLyBwYWdlIGNhY2hlIGFuZCBzaW1pbGFyIHdvcmsg dGhhdCBuZWVkcyB0byBvY2N1ciB3aGVuIGl0IGNvbWVzIG91dC4gVGhpcyBpcyB3aGVyZSB3ZSBk byB0aGUgd29yawogICAgIC8vIHRoYXQgbmVlZHMgdG8gaGFwcGVuIHdoZW4gd2UgZXhpdCwgYW5k IHRoZSB3b3JrIHRoYXQgbmVlZHMgdG8gaGFwcGVuIHdoZW4gd2UgZW50ZXIgaXMgaW4KICAgICAv LyBEb2N1bWVudDo6c2V0SXNJblBhZ2VDYWNoZShib29sKS4gSXQgd291bGQgYmUgbmljZSBpZiB0 aGVyZSB3YXMgbW9yZSBzeW1tZXRyeSBpbiB0aGVzZSBzcG90cy4KICAgICAvLyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg2OTgKLSAgICBpZiAoRnJhbWVWaWV3KiB2 aWV3ID0gbV9mcmFtZS52aWV3KCkpIHsKKyAgICBpZiAodmlldykgewogICAgICAgICBQYWdlKiBw YWdlID0gbV9mcmFtZS5wYWdlKCk7CiAgICAgICAgIGlmIChwYWdlICYmIG1fZnJhbWUuaXNNYWlu RnJhbWUoKSkgewogICAgICAgICAgICAgaWYgKFNjcm9sbGluZ0Nvb3JkaW5hdG9yKiBzY3JvbGxp bmdDb29yZGluYXRvciA9IHBhZ2UtPnNjcm9sbGluZ0Nvb3JkaW5hdG9yKCkpCiAgICAgICAgICAg ICAgICAgc2Nyb2xsaW5nQ29vcmRpbmF0b3ItPmZyYW1lVmlld1Jvb3RMYXllckRpZENoYW5nZSh2 aWV3KTsKICAgICAgICAgfQorICAgIH0KKworICAgIC8vIEZJWE1FOiBJdCB3b3VsZCBiZSBncmVh dCB0byB3b3JrIG91dCBhIHdheSB0byBwdXQgdGhpcyBjb2RlIGluIFdlYkNvcmUgaW5zdGVhZCBv ZiBjYWxsaW5nCisgICAgLy8gdGhyb3VnaCB0byB0aGUgY2xpZW50LgorICAgIG1fZnJhbWUubG9h ZGVyKCkuY2xpZW50KCkucmVzdG9yZVZpZXdTdGF0ZSgpOwogCiAjaWYgIVBMQVRGT1JNKElPUykK LSAgICAgICAgLy8gRG9uJ3QgcmVzdG9yZSBzY3JvbGwgcG9pbnQgb24gaU9TIGFzIEZyYW1lTG9h ZGVyQ2xpZW50OjpyZXN0b3JlVmlld1N0YXRlKCkgZG9lcyB0aGF0LgotICAgICAgICBpZiAoIXZp ZXctPndhc1Njcm9sbGVkQnlVc2VyKCkpIHsKLSAgICAgICAgICAgIGlmIChwYWdlICYmIG1fZnJh bWUuaXNNYWluRnJhbWUoKSAmJiBtX2N1cnJlbnRJdGVtLT5wYWdlU2NhbGVGYWN0b3IoKSkKLSAg ICAgICAgICAgICAgICBwYWdlLT5zZXRQYWdlU2NhbGVGYWN0b3IobV9jdXJyZW50SXRlbS0+cGFn ZVNjYWxlRmFjdG9yKCksIG1fY3VycmVudEl0ZW0tPnNjcm9sbFBvaW50KCkpOwotICAgICAgICAg ICAgZWxzZQotICAgICAgICAgICAgICAgIHZpZXctPnNldFNjcm9sbFBvc2l0aW9uKG1fY3VycmVu dEl0ZW0tPnNjcm9sbFBvaW50KCkpOwotICAgICAgICB9Ci0jZW5kaWYKKyAgICAvLyBEb24ndCBy ZXN0b3JlIHNjcm9sbCBwb2ludCBvbiBpT1MgYXMgRnJhbWVMb2FkZXJDbGllbnQ6OnJlc3RvcmVW aWV3U3RhdGUoKSBkb2VzIHRoYXQuCisgICAgaWYgKHZpZXcgJiYgIXZpZXctPndhc1Njcm9sbGVk QnlVc2VyKCkpIHsKKyAgICAgICAgaWYgKHBhZ2UgJiYgbV9mcmFtZS5pc01haW5GcmFtZSgpICYm IG1fY3VycmVudEl0ZW0tPnBhZ2VTY2FsZUZhY3RvcigpKQorICAgICAgICAgICAgcGFnZS0+c2V0 UGFnZVNjYWxlRmFjdG9yKG1fY3VycmVudEl0ZW0tPnBhZ2VTY2FsZUZhY3RvcigpLCBtX2N1cnJl bnRJdGVtLT5zY3JvbGxQb2ludCgpKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgdmlldy0+ c2V0U2Nyb2xsUG9zaXRpb24obV9jdXJyZW50SXRlbS0+c2Nyb2xsUG9pbnQoKSk7CiAgICAgfQor I2VuZGlmCiB9CiAKIHZvaWQgSGlzdG9yeUNvbnRyb2xsZXI6OnVwZGF0ZUJhY2tGb3J3YXJkTGlz dEZvckZyYWdtZW50U2Nyb2xsKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Ny b2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5jcHAKaW5kZXggMzFmMGRiOTQ4 MTkwNGRhYjZjMmFkNjE3M2MyOGE5MGI3OTVjNTE5Ny4uNWFjMTA0ZjdjOTk4ZTcyNzU3YjU1NzNm NTJlYzBlYzYxMjkxOTliNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxp bmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5jcHAKQEAgLTE5Nyw2ICsxOTcs OSBAQCB2b2lkIEFzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnVwZGF0ZVNjcm9sbFBvc2l0aW9u QWZ0ZXJBc3luY1Njcm9sbFRpbWVyRmlyZWQoVAogCiBGcmFtZVZpZXcqIEFzeW5jU2Nyb2xsaW5n Q29vcmRpbmF0b3I6OmZyYW1lVmlld0ZvclNjcm9sbGluZ05vZGUoU2Nyb2xsaW5nTm9kZUlEIHNj cm9sbGluZ05vZGVJRCkgY29uc3QKIHsKKyAgICBpZiAoIW1fc2Nyb2xsaW5nU3RhdGVUcmVlLT5y b290U3RhdGVOb2RlKCkpCisgICAgICAgIHJldHVybiBudWxscHRyOworICAgIAogICAgIGlmIChz Y3JvbGxpbmdOb2RlSUQgPT0gbV9zY3JvbGxpbmdTdGF0ZVRyZWUtPnJvb3RTdGF0ZU5vZGUoKS0+ c2Nyb2xsaW5nTm9kZUlEKCkpCiAgICAgICAgIHJldHVybiBtX3BhZ2UtPm1haW5GcmFtZSgpLnZp ZXcoKTsKIAo=