133803 2014-06-12 10:01:25 -0700 REGRESSION(169799): [GTK] several layout tests on editing/ fail 2024-05-28 23:30:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clopez webkit-unassigned bugs-noreply cgarcia dpino ltilve svillar webkit-bug-importer oldest_to_newest 1015144 0 clopez 2014-06-12 10:01:25 -0700 The following layout test are failing on GTK+ since r169799 <http://trac.webkit.org/changeset/169799> editing/deleting/delete-by-word-001.html [ Failure ] editing/deleting/delete-by-word-002.html [ Failure ] editing/input/option-page-up-down.html [ Failure ] editing/input/scroll-viewport-page-up-down.html [ Failure ] editing/undo/undo-deleteWord.html [ Failure ] The diffs are the following: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r169799%20%28745%29/editing/deleting/delete-by-word-001-pretty-diff.html http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r169799%20%28745%29/editing/deleting/delete-by-word-002-pretty-diff.html http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r169799%20%28745%29/editing/input/option-page-up-down-pretty-diff.html http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r169799%20%28745%29/editing/input/scroll-viewport-page-up-down-pretty-diff.html http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r169799%20%28745%29/editing/undo/undo-deleteWord-pretty-diff.html 1015173 1 clopez 2014-06-12 11:40:16 -0700 I added this tests to the GTK TestExpectations on http://webkit.org/b/133811 1015357 2 cgarcia 2014-06-13 01:30:47 -0700 I'm not sure this is a regression, are you sure our own expectation files are correct? The actual result I see for editing/deleting/delete-by-word-001 looks the same than cross-platform expected results. Note that the test does: if (navigator.userAgent.search(/\bMac OS X\b/) != -1) deleteWordModifiers = ["altKey"]; else deleteWordModifiers = ["ctrlKey"]; So, before r169799 we were using the alt key instead of the control key, which I think was wrong. 1015378 3 clopez 2014-06-13 04:25:20 -0700 (In reply to comment #2) > I'm not sure this is a regression, are you sure our own expectation files are correct? The actual result I see for editing/deleting/delete-by-word-001 looks the same than cross-platform expected results. Note that the test does: > > if (navigator.userAgent.search(/\bMac OS X\b/) != -1) > deleteWordModifiers = ["altKey"]; > else > deleteWordModifiers = ["ctrlKey"]; > > So, before r169799 we were using the alt key instead of the control key, which I think was wrong. It may be be that the test expectations for this tests before r169799 were wrong. Lorenzo commented that r169799 made a bunch of tests to pass, so maybe this ones that started to fail just need to be rebaselined. Compare the results: 169798 -> layout-test 16 failures 13 new passes 23 flakes 1 missing results http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/744 169799 -> layout-test 20 failures 21 new passes 15 flakes 1 missing results http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/745 1015427 4 svillar 2014-06-13 08:12:28 -0700 (In reply to comment #3) > It may be be that the test expectations for this tests before r169799 were wrong. > > Lorenzo commented that r169799 made a bunch of tests to pass, so maybe this ones that started to fail just need to be rebaselined. Let's rebaseline them and remove as many platform specific results as possible. 2038374 5 dpino 2024-05-28 23:29:18 -0700 The test(s) filed under this bug are consistenly passing since 275882@main (updated baselines for these tests). https://results.webkit.org/?platform=GTK&platform=WPE&suite=layout-tests&test=editing%2Fdeleting%2Fdelete-by-word-001.html After updating test expectations in 279290@main, there are no more tests referring to this bug. Closing bug. 2038375 6 webkit-bug-importer 2024-05-28 23:30:15 -0700 <rdar://problem/128921894>